152947 2016-01-09 11:26:13 -0800 [mips] Implemented emitFunctionPrologue/Epilogue 2016-01-15 10:53:56 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1154157 0 annulen 2016-01-09 11:26:13 -0800 Implemented AssemblyHelpers::emitFunctionPrologue and AssemblyHelpers::emitFunctionEpilogue for MIPS. 1154158 1 268625 annulen 2016-01-09 11:27:57 -0800 Created attachment 268625 Patch 1155741 2 jbriance 2016-01-15 05:10:43 -0800 LGTM 1155747 3 269046 annulen 2016-01-15 06:18:23 -0800 Created attachment 269046 Patch 1155751 4 annulen 2016-01-15 06:26:02 -0800 New version of patch introduces ARM-style pushPair/popPair helpers to reduce number of stack pointer changes. 1155768 5 jbriance 2016-01-15 08:07:43 -0800 Even better, LGTM 1155813 6 269046 msaboff 2016-01-15 10:07:33 -0800 Comment on attachment 269046 Patch r=me 1155837 7 269046 commit-queue 2016-01-15 10:53:53 -0800 Comment on attachment 269046 Patch Clearing flags on attachment: 269046 Committed r195134: <http://trac.webkit.org/changeset/195134> 1155838 8 commit-queue 2016-01-15 10:53:56 -0800 All reviewed patches have been landed. Closing bug. 268625 2016-01-09 11:27:57 -0800 2016-01-15 06:18:17 -0800 Patch bug-152947-20160109222725.patch text/plain 1633 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MmI5ZDk3YjA1ZTE4NTM2ODk0ZGNlNzk5OTJlZGQ2YmJhNjJhYzcxLi5kNTBmNzkxZmY0YWI3NDQz YTlhNDU5MjU4OGRlMDg3MDVmNWI5ZDUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wMS0wOSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEltcGxlbWVudGVkIGVtaXRGdW5jdGlvblByb2xvZ3Vl L0VwaWxvZ3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTI5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGppdC9Bc3NlbWJseUhlbHBlcnMuaDoKKyAgICAgICAgKEpTQzo6QXNzZW1ibHlIZWxwZXJz OjplbWl0RnVuY3Rpb25Qcm9sb2d1ZSk6CisgICAgICAgIChKU0M6OkFzc2VtYmx5SGVscGVyczo6 ZW1pdEZ1bmN0aW9uRXBpbG9ndWUpOgorCiAyMDE2LTAxLTA5ICBNYXJrIExhbSAgPG1hcmsubGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBUaGUgRlRMIGFsbG9jYXRlZCBzcGlsbCBzbG90cyBmb3Ig QmluYXJ5T3BzIGlzIHNvbWV0aW1lcyBpbmFjY3VyYXRlLgpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmgKaW5kZXggOThlODFmZjU2Zjg2Y2E2NGJmOWMzYzdiMzZj MWUxMDE4YjIyNmU1NC4uYmI4MzFkMzFmMmVmNzdiYjUzNWJhN2I5YmM5MDVlMDg1MzE1NDA1NSAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2VtYmx5SGVscGVycy5oCkBAIC00NDcs NiArNDQ3LDIwIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIDIgKiBzaXplb2Yodm9pZCopOwog ICAgIH0KIAorICAgIHZvaWQgZW1pdEZ1bmN0aW9uUHJvbG9ndWUoKQorICAgIHsKKyAgICAgICAg cHVzaChyZXR1cm5BZGRyZXNzUmVnaXN0ZXIpOworICAgICAgICBwdXNoKGZyYW1lUG9pbnRlclJl Z2lzdGVyKTsKKyAgICAgICAgbW92ZShzdGFja1BvaW50ZXJSZWdpc3RlciwgZnJhbWVQb2ludGVy UmVnaXN0ZXIpOworICAgIH0KKworICAgIHZvaWQgZW1pdEZ1bmN0aW9uRXBpbG9ndWUoKQorICAg IHsKKyAgICAgICAgbW92ZShmcmFtZVBvaW50ZXJSZWdpc3Rlciwgc3RhY2tQb2ludGVyUmVnaXN0 ZXIpOworICAgICAgICBwb3AoZnJhbWVQb2ludGVyUmVnaXN0ZXIpOworICAgICAgICBwb3AocmV0 dXJuQWRkcmVzc1JlZ2lzdGVyKTsKKyAgICB9CisKICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgcHJl c2VydmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKFJlZ2lzdGVySUQgcmVnKQogICAgIHsKICAgICAg ICAgbW92ZShyZXR1cm5BZGRyZXNzUmVnaXN0ZXIsIHJlZyk7Cg== 269046 2016-01-15 06:18:23 -0800 2016-01-15 10:53:53 -0800 Patch bug-152947-20160115171753.patch text/plain 3114 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ODIzNjU4MGUzNGY2YmRkN2FlOWMxYTYyMGQwZmJlNzgwYjZmZjg2Li4xNWRiNTYwMDk5OWRmOGQ5 NTc1NzQ1Zjk4OTM1NTRiMWE5YWFjY2RmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNi0wMS0xNSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEltcGxlbWVudGVkIGVtaXRGdW5jdGlvblByb2xvZ3Vl L0VwaWxvZ3VlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTI5NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9B c3NlbWJsZXJNSVBTOjpwb3BQYWlyKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBT OjpwdXNoUGFpcik6CisgICAgICAgICogaml0L0Fzc2VtYmx5SGVscGVycy5oOgorICAgICAgICAo SlNDOjpBc3NlbWJseUhlbHBlcnM6OmVtaXRGdW5jdGlvblByb2xvZ3VlKToKKyAgICAgICAgKEpT Qzo6QXNzZW1ibHlIZWxwZXJzOjplbWl0RnVuY3Rpb25FcGlsb2d1ZVdpdGhFbXB0eUZyYW1lKToK KyAgICAgICAgKEpTQzo6QXNzZW1ibHlIZWxwZXJzOjplbWl0RnVuY3Rpb25FcGlsb2d1ZSk6CisK IDIwMTYtMDEtMDcgIEtvbnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgogCiAg ICAgICAgIFttaXBzXSBSZXBsYWNlZCBzdWJpIHdpdGggYWRkaSBpbiBnZXRIb3N0Q2FsbFJldHVy blZhbHVlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyTUlQUy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlck1JUFMuaAppbmRleCA3MjM5ODkyMmI3NTA3OTVlNjkzN2QxM2Y4ZDdhMjk3NDExY2M1 MDFhLi5jZWViMTM5YmQyMThiYWNiOGJhMmRkNTI3M2NkOTk1YjdkMmU4OTI3IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgK QEAgLTEyNzAsNiArMTI3MCwxMyBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLmFkZGl1 KE1JUFNSZWdpc3RlcnM6OnNwLCBNSVBTUmVnaXN0ZXJzOjpzcCwgNCk7CiAgICAgfQogCisgICAg dm9pZCBwb3BQYWlyKFJlZ2lzdGVySUQgZGVzdDEsIFJlZ2lzdGVySUQgZGVzdDIpCisgICAgewor ICAgICAgICBtX2Fzc2VtYmxlci5sdyhkZXN0MSwgTUlQU1JlZ2lzdGVyczo6c3AsIDApOworICAg ICAgICBtX2Fzc2VtYmxlci5sdyhkZXN0MiwgTUlQU1JlZ2lzdGVyczo6c3AsIDQpOworICAgICAg ICBtX2Fzc2VtYmxlci5hZGRpdShNSVBTUmVnaXN0ZXJzOjpzcCwgTUlQU1JlZ2lzdGVyczo6c3As IDgpOworICAgIH0KKwogICAgIHZvaWQgcHVzaChSZWdpc3RlcklEIHNyYykKICAgICB7CiAgICAg ICAgIG1fYXNzZW1ibGVyLmFkZGl1KE1JUFNSZWdpc3RlcnM6OnNwLCBNSVBTUmVnaXN0ZXJzOjpz cCwgLTQpOwpAQCAtMTI4OCw2ICsxMjk1LDEzIEBAIHB1YmxpYzoKICAgICAgICAgcHVzaChpbW1U ZW1wUmVnaXN0ZXIpOwogICAgIH0KIAorICAgIHZvaWQgcHVzaFBhaXIoUmVnaXN0ZXJJRCBzcmMx LCBSZWdpc3RlcklEIHNyYzIpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5hZGRpdShNSVBT UmVnaXN0ZXJzOjpzcCwgTUlQU1JlZ2lzdGVyczo6c3AsIC04KTsKKyAgICAgICAgbV9hc3NlbWJs ZXIuc3coc3JjMiwgTUlQU1JlZ2lzdGVyczo6c3AsIDQpOworICAgICAgICBtX2Fzc2VtYmxlci5z dyhzcmMxLCBNSVBTUmVnaXN0ZXJzOjpzcCwgMCk7CisgICAgfQorCiAgICAgLy8gUmVnaXN0ZXIg bW92ZSBvcGVyYXRpb25zOgogICAgIC8vCiAgICAgLy8gTW92ZSB2YWx1ZXMgaW4gcmVnaXN0ZXJz LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmgKaW5kZXggOThl ODFmZjU2Zjg2Y2E2NGJmOWMzYzdiMzZjMWUxMDE4YjIyNmU1NC4uNTRjOWFkYzhkN2QzMTczMmJh MWI2NGZkNGZiMWVhODUxZmZiYjE1ZiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2ppdC9Bc3NlbWJseUhlbHBlcnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fz c2VtYmx5SGVscGVycy5oCkBAIC00NDcsNiArNDQ3LDIzIEBAIHB1YmxpYzoKICAgICAgICAgcmV0 dXJuIDIgKiBzaXplb2Yodm9pZCopOwogICAgIH0KIAorICAgIHZvaWQgZW1pdEZ1bmN0aW9uUHJv bG9ndWUoKQorICAgIHsKKyAgICAgICAgcHVzaFBhaXIoZnJhbWVQb2ludGVyUmVnaXN0ZXIsIHJl dHVybkFkZHJlc3NSZWdpc3Rlcik7CisgICAgICAgIG1vdmUoc3RhY2tQb2ludGVyUmVnaXN0ZXIs IGZyYW1lUG9pbnRlclJlZ2lzdGVyKTsKKyAgICB9CisKKyAgICB2b2lkIGVtaXRGdW5jdGlvbkVw aWxvZ3VlV2l0aEVtcHR5RnJhbWUoKQorICAgIHsKKyAgICAgICAgcG9wUGFpcihmcmFtZVBvaW50 ZXJSZWdpc3RlciwgcmV0dXJuQWRkcmVzc1JlZ2lzdGVyKTsKKyAgICB9CisKKyAgICB2b2lkIGVt aXRGdW5jdGlvbkVwaWxvZ3VlKCkKKyAgICB7CisgICAgICAgIG1vdmUoZnJhbWVQb2ludGVyUmVn aXN0ZXIsIHN0YWNrUG9pbnRlclJlZ2lzdGVyKTsKKyAgICAgICAgZW1pdEZ1bmN0aW9uRXBpbG9n dWVXaXRoRW1wdHlGcmFtZSgpOworICAgIH0KKwogICAgIEFMV0FZU19JTkxJTkUgdm9pZCBwcmVz ZXJ2ZVJldHVybkFkZHJlc3NBZnRlckNhbGwoUmVnaXN0ZXJJRCByZWcpCiAgICAgewogICAgICAg ICBtb3ZlKHJldHVybkFkZHJlc3NSZWdpc3RlciwgcmVnKTsK