152945 2016-01-09 09:17:21 -0800 REGRESSION (r194426): First email field is not autofilled on amazon.com 2016-01-09 16:39:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue simon.fraser oldest_to_newest 1154148 0 zalan 2016-01-09 09:17:21 -0800 1. go to https://www.amazon.com/ap/register?_encoding=UTF8&openid.assoc_handle=usflex&openid.claimed_id=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.identity=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.mode=checkid_setup&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0&openid.ns.pape=http%3A%2F%2Fspecs.openid.net%2Fextensions%2Fpape%2F1.0&openid.pape.max_auth_age=0&openid.return_to=https%3A%2F%2Fwww.amazon.com%2Fgp%2Fyourstore%2Fhome%3Fie%3DUTF8%26ref_%3Dnav_newcust 2. cmd-shift-A or click and arrow down to select autofill options. * RESULTS First email field is not filled, second email is filled. 1154149 1 zalan 2016-01-09 09:18:05 -0800 rdar://problem/24082914 1154150 2 268622 zalan 2016-01-09 09:41:54 -0800 Created attachment 268622 Patch 1154152 3 268622 simon.fraser 2016-01-09 10:38:55 -0800 Comment on attachment 268622 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268622&action=review > Source/WebCore/ChangeLog:11 > + Unable to test. Needs Safari autofill interaction. This is a shame. Can't you simulate it with two text fields? > Source/WebCore/page/FrameView.cpp:2651 > + // We already have a pending (full) layout. Just mark the subtree for layout. I can't see how you know you have a pending layout here. 1154164 4 zalan 2016-01-09 14:05:35 -0800 (In reply to comment #3) > Comment on attachment 268622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268622&action=review > > > Source/WebCore/ChangeLog:11 > > + Unable to test. Needs Safari autofill interaction. > > This is a shame. Can't you simulate it with two text fields? I might. > > > Source/WebCore/page/FrameView.cpp:2651 > > + // We already have a pending (full) layout. Just mark the subtree for layout. > > I can't see how you know you have a pending layout here. We early return from this function when layout is pending. 1154168 5 268629 zalan 2016-01-09 15:05:54 -0800 Created attachment 268629 Patch 1154176 6 268629 commit-queue 2016-01-09 16:39:12 -0800 Comment on attachment 268629 Patch Clearing flags on attachment: 268629 Committed r194823: <http://trac.webkit.org/changeset/194823> 1154177 7 commit-queue 2016-01-09 16:39:16 -0800 All reviewed patches have been landed. Closing bug. 268622 2016-01-09 09:41:54 -0800 2016-01-09 15:05:51 -0800 Patch bug-152945-20160109094123.patch text/plain 2169 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Nzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRhYWFlM2VhODhhZWZj YTkyNzUzMTQxYTY3NWMwZmYyNzIzYTJiMi4uMTBmZjhmYTAwYWM0ZDg4YmUzMzIyZTg3YWVmYmU5 MDEyMzdhMzc4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE5NDQy Nik6IEZpcnN0IGVtYWlsIGZpZWxkIGlzIG5vdCBhdXRvZmlsbGVkIG9uIGFtYXpvbi5jb20KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjk0NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjQwODI5MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjE5NDQyNiBtaXNzZWQgbWFya2luZyB0aGUgbV9sYXlv dXRSb290IGZvciBsYXlvdXQgd2hpbGUgY29udmVydGluZyB0byBmdWxsIGxheW91dCAoaXQgb25s eSBtYXJrZWQgdGhlIG5ldyBsYXlvdXQgcm9vdCkuCisKKyAgICAgICAgVW5hYmxlIHRvIHRlc3Qu IE5lZWRzIFNhZmFyaSBhdXRvZmlsbCBpbnRlcmFjdGlvbi4KKworICAgICAgICAqIHBhZ2UvRnJh bWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2NoZWR1bGVSZWxheW91 dE9mU3VidHJlZSk6CisKIDIwMTYtMDEtMDggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBIb3ZlcmluZyBsaW5rIG9uIGh0dHA6Ly9oZWxwLmFwcGxlLmNvbS9hcHBs ZXR2LyMvIGRvZXMgbm90IHNob3cgdGV4dCB1bmRlcmxpbmUuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAKaW5kZXggMWY3OWY4MGFiNWU0ZGMyMGE1ZGNhMTQzYWQ3YjVhMTA2M2MyN2IwZS4uNDY2 NzFmNzVlNDQ0NjIwNjhjNDg0N2FiZTdmYzk5ZGI4YzUxMDM2NSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJh bWVWaWV3LmNwcApAQCAtMjY0OCw3ICsyNjQ4LDcgQEAgdm9pZCBGcmFtZVZpZXc6OnNjaGVkdWxl UmVsYXlvdXRPZlN1YnRyZWUoUmVuZGVyRWxlbWVudCYgbmV3UmVsYXlvdXRSb290KQogICAgICAg ICByZXR1cm47CiAKICAgICBpZiAoIW1fbGF5b3V0Um9vdCkgewotICAgICAgICAvLyBKdXN0IHJl bGF5b3V0IHRoZSBzdWJ0cmVlLgorICAgICAgICAvLyBXZSBhbHJlYWR5IGhhdmUgYSBwZW5kaW5n IChmdWxsKSBsYXlvdXQuIEp1c3QgbWFyayB0aGUgc3VidHJlZSBmb3IgbGF5b3V0LgogICAgICAg ICBuZXdSZWxheW91dFJvb3QubWFya0NvbnRhaW5pbmdCbG9ja3NGb3JMYXlvdXQoU2NoZWR1bGVS ZWxheW91dDo6Tm8pOwogICAgICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEludmFs aWRhdGVMYXlvdXQoZnJhbWUoKSk7CiAgICAgICAgIHJldHVybjsKQEAgLTI2NjksMTAgKzI2Njks OSBAQCB2b2lkIEZyYW1lVmlldzo6c2NoZWR1bGVSZWxheW91dE9mU3VidHJlZShSZW5kZXJFbGVt ZW50JiBuZXdSZWxheW91dFJvb3QpCiAgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6 ZGlkSW52YWxpZGF0ZUxheW91dChmcmFtZSgpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLQot ICAgIC8vIEp1c3QgZG8gYSBmdWxsIHJlbGF5b3V0LgotICAgIG1fbGF5b3V0Um9vdCA9ICZuZXdS ZWxheW91dFJvb3Q7CisgICAgLy8gVHdvIGRpc2pvaW50IHN1YnRyZWVzIG5lZWQgbGF5b3V0LiBN YXJrIGJvdGggb2YgdGhlbSBhbmQgaXNzdWUgYSBmdWxsIGxheW91dCBpbnN0ZWFkLgogICAgIGNv bnZlcnRTdWJ0cmVlTGF5b3V0VG9GdWxsTGF5b3V0KCk7CisgICAgbmV3UmVsYXlvdXRSb290Lm1h cmtDb250YWluaW5nQmxvY2tzRm9yTGF5b3V0KFNjaGVkdWxlUmVsYXlvdXQ6Ok5vKTsKICAgICBJ bnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEludmFsaWRhdGVMYXlvdXQoZnJhbWUoKSk7CiB9 CiAK 268629 2016-01-09 15:05:54 -0800 2016-01-09 16:39:12 -0800 Patch bug-152945-20160109150522.patch text/plain 4559 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Nzc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjRhYWFlM2VhODhhZWZj YTkyNzUzMTQxYTY3NWMwZmYyNzIzYTJiMi4uMDc2ZTljNDk3ODdlNGZmODc0NTFhYzgxMjM0Yzk1 MDRkODdmYzY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjE5NDQy Nik6IEZpcnN0IGVtYWlsIGZpZWxkIGlzIG5vdCBhdXRvZmlsbGVkIG9uIGFtYXpvbi5jb20KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjk0NQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjQwODI5MTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjE5NDQyNiBtaXNzZWQgbWFya2luZyB0aGUgbV9sYXlv dXRSb290IGZvciBsYXlvdXQgd2hpbGUgY29udmVydGluZyB0byBmdWxsIGxheW91dCAoaXQgb25s eSBtYXJrZWQgdGhlIG5ldyBsYXlvdXQgcm9vdCkuCisKKyAgICAgICAgVGVzdDogZmFzdC9mb3Jt cy9tdWx0aXBsZS1zdWJ0cmVlLWxheW91dC1mYWlsdXJlLmh0bWwKKworICAgICAgICAqIHBhZ2Uv RnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6c2NoZWR1bGVSZWxh eW91dE9mU3VidHJlZSk6CisKIDIwMTYtMDEtMDggIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBIb3ZlcmluZyBsaW5rIG9uIGh0dHA6Ly9oZWxwLmFwcGxlLmNvbS9h cHBsZXR2LyMvIGRvZXMgbm90IHNob3cgdGV4dCB1bmRlcmxpbmUuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAKaW5kZXggMWY3OWY4MGFiNWU0ZGMyMGE1ZGNhMTQzYWQ3YjVhMTA2M2MyN2IwZS4u NDY2NzFmNzVlNDQ0NjIwNjhjNDg0N2FiZTdmYzk5ZGI4YzUxMDM2NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcApAQCAtMjY0OCw3ICsyNjQ4LDcgQEAgdm9pZCBGcmFtZVZpZXc6OnNjaGVk dWxlUmVsYXlvdXRPZlN1YnRyZWUoUmVuZGVyRWxlbWVudCYgbmV3UmVsYXlvdXRSb290KQogICAg ICAgICByZXR1cm47CiAKICAgICBpZiAoIW1fbGF5b3V0Um9vdCkgewotICAgICAgICAvLyBKdXN0 IHJlbGF5b3V0IHRoZSBzdWJ0cmVlLgorICAgICAgICAvLyBXZSBhbHJlYWR5IGhhdmUgYSBwZW5k aW5nIChmdWxsKSBsYXlvdXQuIEp1c3QgbWFyayB0aGUgc3VidHJlZSBmb3IgbGF5b3V0LgogICAg ICAgICBuZXdSZWxheW91dFJvb3QubWFya0NvbnRhaW5pbmdCbG9ja3NGb3JMYXlvdXQoU2NoZWR1 bGVSZWxheW91dDo6Tm8pOwogICAgICAgICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZElu dmFsaWRhdGVMYXlvdXQoZnJhbWUoKSk7CiAgICAgICAgIHJldHVybjsKQEAgLTI2NjksMTAgKzI2 NjksOSBAQCB2b2lkIEZyYW1lVmlldzo6c2NoZWR1bGVSZWxheW91dE9mU3VidHJlZShSZW5kZXJF bGVtZW50JiBuZXdSZWxheW91dFJvb3QpCiAgICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRhdGlv bjo6ZGlkSW52YWxpZGF0ZUxheW91dChmcmFtZSgpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0K LQotICAgIC8vIEp1c3QgZG8gYSBmdWxsIHJlbGF5b3V0LgotICAgIG1fbGF5b3V0Um9vdCA9ICZu ZXdSZWxheW91dFJvb3Q7CisgICAgLy8gVHdvIGRpc2pvaW50IHN1YnRyZWVzIG5lZWQgbGF5b3V0 LiBNYXJrIGJvdGggb2YgdGhlbSBhbmQgaXNzdWUgYSBmdWxsIGxheW91dCBpbnN0ZWFkLgogICAg IGNvbnZlcnRTdWJ0cmVlTGF5b3V0VG9GdWxsTGF5b3V0KCk7CisgICAgbmV3UmVsYXlvdXRSb290 Lm1hcmtDb250YWluaW5nQmxvY2tzRm9yTGF5b3V0KFNjaGVkdWxlUmVsYXlvdXQ6Ok5vKTsKICAg ICBJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEludmFsaWRhdGVMYXlvdXQoZnJhbWUoKSk7 CiB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCAwYTM0OTNiZmUxZGI1ZmZmNDNhMjllNWM4ZDBhNDJmMTkwMGZlZWQzLi4w YWI2YzI1YjU0YzY1NTYwZDVjZjg2ODc0NGM5ZjgxMTViMTExNjQ2IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTYtMDEtMDkgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OIChyMTk0NDI2KTogRmlyc3QgZW1haWwgZmllbGQgaXMgbm90IGF1dG9m aWxsZWQgb24gYW1hem9uLmNvbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyOTQ1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDA4MjkxND4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMTk0NDI2IG1p c3NlZCBtYXJraW5nIHRoZSBtX2xheW91dFJvb3QgZm9yIGxheW91dCB3aGlsZSBjb252ZXJ0aW5n IHRvIGZ1bGwgbGF5b3V0IChpdCBvbmx5IG1hcmtlZCB0aGUgbmV3IGxheW91dCByb290KS4KKwor ICAgICAgICAqIGZhc3QvZm9ybXMvbXVsdGlwbGUtc3VidHJlZS1sYXlvdXQtZmFpbHVyZS1leHBl Y3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Zvcm1zL211bHRpcGxlLXN1YnRyZWUt bGF5b3V0LWZhaWx1cmUuaHRtbDogQWRkZWQuCisKIDIwMTYtMDEtMDggIFphbGFuIEJ1anRhcyAg PHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBIb3ZlcmluZyBsaW5rIG9uIGh0dHA6Ly9oZWxw LmFwcGxlLmNvbS9hcHBsZXR2LyMvIGRvZXMgbm90IHNob3cgdGV4dCB1bmRlcmxpbmUuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL211bHRpcGxlLXN1YnRyZWUtbGF5b3V0LWZh aWx1cmUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbXVsdGlwbGUtc3Vi dHJlZS1sYXlvdXQtZmFpbHVyZS1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjExMzYwNGIzNDQ4 MzJlNzVkMjY2MTI0ODE1M2ZjMjc2MGE5ZjlkM2UKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL211bHRpcGxlLXN1YnRyZWUtbGF5b3V0LWZhaWx1cmUtZXhwZWN0ZWQu aHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8 dGl0bGU+VGhpcyB0ZXN0cyB3aGVuIHdlIGlzc3VlIHN1YnRyZWUgbGF5b3V0IG9uIG11bHRpcGxl IHN1YnRyZWVzLCB0aGV5IGFsbCBnZXQgbGFpZCBvdXQgcHJvcGVybHkuPC90aXRsZT4KKzwvaGVh ZD4KKzxib2R5PgorPGRpdj48aW5wdXQgdmFsdWU9ImZvb2JhciI+PC9kaXY+Cis8ZGl2PjxpbnB1 dCB2YWx1ZT0iZm9vYmFyIj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvbXVsdGlwbGUtc3VidHJlZS1sYXlvdXQtZmFpbHVyZS5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9tdWx0aXBsZS1zdWJ0cmVlLWxheW91dC1mYWlsdXJl Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uOTRjZDFjYzYzZmExZTE4MTQyOWQ0MmY0NDk5NjY3ZDU0Mzc5YjVm MQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvbXVsdGlwbGUtc3Vi dHJlZS1sYXlvdXQtZmFpbHVyZS5odG1sCkBAIC0wLDAgKzEsMjAgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzx0aXRsZT5UaGlzIHRlc3RzIHdoZW4gd2UgaXNzdWUgc3VidHJl ZSBsYXlvdXQgb24gbXVsdGlwbGUgc3VidHJlZXMsIHRoZXkgYWxsIGdldCBsYWlkIG91dCBwcm9w ZXJseS48L3RpdGxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2PjxpbnB1dCBpZD0idGVzdCI+PC9k aXY+Cis8ZGl2PjxpbnB1dCBpZD0idGVzdDEiPjwvZGl2PgorPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK3NldFRpbWVvdXQo ZnVuY3Rpb24oKSB7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3QiKS52YWx1ZSA9 ICJmb29iYXIiOworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0ZXN0MSIpLnZhbHVlID0g ImZvb2JhciI7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVy Lm5vdGlmeURvbmUoKTsKKyAgICB9LCAwKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=