152934 2016-01-08 16:16:09 -0800 FTL B3 should do varargs tail calls and stack overflows 2016-01-08 16:38:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1154050 0 fpizlo 2016-01-08 16:16:09 -0800 Patch forthcoming. 1154051 1 268597 fpizlo 2016-01-08 16:18:42 -0800 Created attachment 268597 the patch 1154052 2 commit-queue 2016-01-08 16:20:59 -0800 Attachment 268597 did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:344: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:352: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1154053 3 268597 fpizlo 2016-01-08 16:21:44 -0800 Comment on attachment 268597 the patch Hold on, this isn't working right. 1154054 4 268597 fpizlo 2016-01-08 16:24:01 -0800 Comment on attachment 268597 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268597&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:345 > + jit.copyCalleeSavesToVMCalleeSavesBuffer(); I have to add AllowMacroScratchRegisterUsage above here. 1154055 5 268597 saam 2016-01-08 16:33:21 -0800 Comment on attachment 268597 the patch r=me 1154058 6 fpizlo 2016-01-08 16:38:39 -0800 Landed in http://trac.webkit.org/changeset/194805 268597 2016-01-08 16:18:42 -0800 2016-01-08 16:33:21 -0800 the patch blah.patch text/plain 3512 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0ODAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTAxLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEIzIHNob3VsZCBkbyB2YXJhcmdzIHRhaWwgY2FsbHMgYW5kIHN0YWNrIG92ZXJmbG93cwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyOTM0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSB3YXMgdHJ5 aW5nIHRvIGdldCB0YWlsLWNhbGwtdmFyYXJncy1uby1zdGFjay1vdmVyZmxvdy5qcy5mdGwtbm8t Y2ppdC12YWxpZGF0ZSB0byB3b3JrIGFuZAorICAgICAgICBhdCBmaXJzdCBJIGhpdCB0aGUgc3Rh Y2sgb3ZlcmZsb3cgaXNzdWUgYW5kIHRoZW4gSSBoaXQgdGhlIHZhcmFyZ3MgdGFpbCBjYWxsIGlz c3VlLiBUaGF0J3MKKyAgICAgICAgd2h5IEkgaGF2ZSB0d28gZml4ZXMgaW4gb25lIGNoYW5nZS4g Tm93IHRoZSB0ZXN0IHBhc3Nlcy4KKworICAgICAgICAqIGZ0bC9GVExMb3dlckRGR1RvTExWTS5j cHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvTExWTTo6bG93ZXIpOiBJbXBs ZW1lbnQgc3RhY2sgb3ZlcmZsb3cgaGFuZGxpbmcuCisgICAgICAgIChKU0M6OkZUTDo6REZHOjpM b3dlckRGR1RvTExWTTo6Y29tcGlsZUNhbGxPckNvbnN0cnVjdFZhcmFyZ3MpOiBWYXJhcmdzIHRh aWwgY2FsbHMgbmVlZCB0bworICAgICAgICBhcHBlbmQgYW4gT29wcyAoaS5lLiAidW5yZWFjaGFi bGUiKS4KKwogMjAxNi0wMS0wOCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAg ICAgICAgIEIzIG5lZWRzIE5lZygpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTk0Nzc0KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTMzOSwxOSArMzM5LDMyIEBAIHB1YmxpYzoKICAgICAgICAgbV9vdXQuYXBwZW5kVG8oc3RhY2tP dmVyZmxvdywgbV9oYW5kbGVFeGNlcHRpb25zKTsKICAgICAgICAgbV9vdXQuY2FsbChtX291dC52 b2lkVHlwZSwgbV9vdXQub3BlcmF0aW9uKG9wZXJhdGlvblRocm93U3RhY2tPdmVyZmxvd0Vycm9y KSwgbV9jYWxsRnJhbWUsIG1fb3V0LmNvbnN0SW50UHRyKGNvZGVCbG9jaygpKSk7CiAjaWYgRlRM X1VTRVNfQjMKLSAgICAgICAgLy8gRklYTUUKLSNlbHNlCisgICAgICAgIFBhdGNocG9pbnRWYWx1 ZSogcGF0Y2hwb2ludCA9IG1fb3V0LnBhdGNocG9pbnQoVm9pZCk7CisgICAgICAgIHBhdGNocG9p bnQtPnNldEdlbmVyYXRvcigKKyAgICAgICAgICAgIFs9XSAoQ0NhbGxIZWxwZXJzJiBqaXQsIGNv bnN0IFN0YWNrbWFwR2VuZXJhdGlvblBhcmFtcyYpIHsKKyAgICAgICAgICAgICAgICBqaXQuY29w eUNhbGxlZVNhdmVzVG9WTUNhbGxlZVNhdmVzQnVmZmVyKCk7CisgICAgICAgICAgICAgICAgaml0 Lm1vdmUoQ0NhbGxIZWxwZXJzOjpUcnVzdGVkSW1tUHRyKGppdC52bSgpKSwgR1BSSW5mbzo6YXJn dW1lbnRHUFIwKTsKKyAgICAgICAgICAgICAgICBqaXQubW92ZShHUFJJbmZvOjpjYWxsRnJhbWVS ZWdpc3RlciwgR1BSSW5mbzo6YXJndW1lbnRHUFIxKTsKKyAgICAgICAgICAgICAgICBDQ2FsbEhl bHBlcnM6OkNhbGwgY2FsbCA9IGppdC5jYWxsKCk7CisgICAgICAgICAgICAgICAgaml0Lmp1bXBU b0V4Y2VwdGlvbkhhbmRsZXIoKTsKKworICAgICAgICAgICAgICAgIGppdC5hZGRMaW5rVGFzaygK KyAgICAgICAgICAgICAgICAgICAgWz1dIChMaW5rQnVmZmVyJiBsaW5rQnVmZmVyKSB7CisgICAg ICAgICAgICAgICAgICAgICAgICBsaW5rQnVmZmVyLmxpbmsoY2FsbCwgRnVuY3Rpb25QdHIobG9v a3VwRXhjZXB0aW9uSGFuZGxlckZyb21DYWxsZXJGcmFtZSkpOworICAgICAgICAgICAgICAgICAg ICB9KTsKKyAgICAgICAgICAgIH0pOworI2Vsc2UgLy8gRlRMX1VTRVNfQjMKICAgICAgICAgc3Rh dGUtPmhhbmRsZVN0YWNrT3ZlcmZsb3dFeGNlcHRpb25TdGFja21hcElEID0gbV9zdGFja21hcElE cysrOwogICAgICAgICBtX291dC5jYWxsKAogICAgICAgICAgICAgbV9vdXQudm9pZFR5cGUsIG1f b3V0LnN0YWNrbWFwSW50cmluc2ljKCksCiAgICAgICAgICAgICBtX291dC5jb25zdEludDY0KHN0 YXRlLT5oYW5kbGVTdGFja092ZXJmbG93RXhjZXB0aW9uU3RhY2ttYXBJRCksCiAgICAgICAgICAg ICBtX291dC5jb25zdEludDMyKE1hY3JvQXNzZW1ibGVyOjptYXhKdW1wUmVwbGFjZW1lbnRTaXpl KCkpKTsKLSNlbmRpZgorI2VuZGlmIC8vIEZUTF9VU0VTX0IzCiAgICAgICAgIG1fb3V0LnVucmVh Y2hhYmxlKCk7CiAgICAgICAgIAogICAgICAgICBtX291dC5hcHBlbmRUbyhtX2hhbmRsZUV4Y2Vw dGlvbnMsIGNoZWNrQXJndW1lbnRzKTsKICNpZiBGVExfVVNFU19CMwotICAgICAgICBQYXRjaHBv aW50VmFsdWUqIHBhdGNocG9pbnQgPSBtX291dC5wYXRjaHBvaW50KFZvaWQpOworICAgICAgICBw YXRjaHBvaW50ID0gbV9vdXQucGF0Y2hwb2ludChWb2lkKTsKICAgICAgICAgQm94PENDYWxsSGVs cGVyczo6TGFiZWw+IGV4Y2VwdGlvbkhhbmRsZXIgPSBzdGF0ZS0+ZXhjZXB0aW9uSGFuZGxlcjsK ICAgICAgICAgcGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAogICAgICAgICAgICAgWz1dIChDQ2Fs bEhlbHBlcnMmIGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJikgewpAQCAtNTUx MCw3ICs1NTIzLDE2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgIH0pOwogICAgICAg ICAgICAgfSk7CiAKLSAgICAgICAgc2V0SlNWYWx1ZShwYXRjaHBvaW50KTsKKyAgICAgICAgc3dp dGNoIChub2RlLT5vcCgpKSB7CisgICAgICAgIGNhc2UgVGFpbENhbGxWYXJhcmdzOgorICAgICAg ICBjYXNlIFRhaWxDYWxsRm9yd2FyZFZhcmFyZ3M6CisgICAgICAgICAgICBtX291dC51bnJlYWNo YWJsZSgpOworICAgICAgICAgICAgYnJlYWs7CisKKyAgICAgICAgZGVmYXVsdDoKKyAgICAgICAg ICAgIHNldEpTVmFsdWUocGF0Y2hwb2ludCk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAg fQogI2Vsc2UKICAgICAgICAgVU5VU0VEX1BBUkFNKGZvcndhcmRpbmcpOwogICAgICAgICB1bnNp Z25lZCBzdGFja21hcElEID0gbV9zdGFja21hcElEcysrOwo=