15293 2007-09-26 23:00:14 -0700 eBay item "SuperSize" popup image viewer does not display images 2020-10-23 13:35:04 -0700 1 1 1 Unclassified WebKit Evangelism 523.x (Safari 3) All All RESOLVED CONFIGURATION CHANGED http://cgi.ebay.com/Titan-Missile-Base-Central-Washington_W0QQcmdZViewItemQQcategoryZ1607QQihZ009QQitemZ190132455924QQrdZ1 HasReduction P2 Normal --- 1 cameowood webkit-unassigned aroben jensimmons mrowe vicki webkit-bug-importer oldest_to_newest 57144 0 cameowood 2007-09-26 23:00:14 -0700 On an eBay item page, there is an option to view item photos in a "supersized" format that opens a new popup window and displays the enlarged images there. This seems to be a cross-platform bug that doesn't display this image. This site works in FF and IE. Go to the above ebay item. Click on the "Supersize" link under the thumbnail image on the left side of the page. A new window pops up but no image is displayed. 57147 1 mrowe 2007-09-27 03:41:14 -0700 I see the following JS exception when following the instructions: Undefined value http://include.ebaystatic.com/js/v/us/features/viewitem/viPopupBody.js:503 That line of code looks like the following: if(client.safari){var ifhack=(typeof(ebay)!="undefined")?ebay.oDocument.createElement("iframe"):document.createElement("iframe");ifhack.style.width='1px';ifhack.style.height='1px';ifhack.style.visibility='hidden';document.body.appendChild(ifhack);with(ifhack.document){open();write('<body> </body>');close();} To pretty it up a bit: if (client.safari) { var ifhack = (typeof(ebay) != "undefined") ? ebay.oDocument.createElement("iframe") : document.createElement("iframe"); ifhack.style.width = '1px'; ifhack.style.height = '1px'; ifhack.style.visibility = 'hidden'; document.body.appendChild(ifhack); with(ifhack.document) { open(); write('<body> </body>'); close(); } this.iframeHack = ifhack; } It is the clause with (ifhack.document) { that is triggering the issue. I found this by judicious experimentation with javascript entry in the address bar. 57178 2 ddkilzer 2007-09-27 10:31:31 -0700 (In reply to comment #1) > It is the clause > with (ifhack.document) { iframe.document was changed to iframe.contentDocument in r21651, ironically to fix eBay layout! (See also Bug 14054.) http://trac.webkit.org/projects/webkit/changeset/21651 eBay should be feature-testing for iframe.contentDocument instead of using user agent detection. I'm guessing this should be an evangelism bug. 63367 3 cameowood 2007-12-05 11:13:47 -0800 This bug still is a problem- anything I can do to help? 63455 4 ddkilzer 2007-12-06 07:10:30 -0800 (In reply to comment #2) > eBay should be feature-testing for iframe.contentDocument instead of using user > agent detection. > > I'm guessing this should be an evangelism bug. Clearly an evangelism bug. For more information about using "object detection" (not "feature detection") to detect iframe.contentDocument, see: http://developer.apple.com/internet/webcontent/objectdetection.html 66600 5 mjs 2008-01-08 17:57:18 -0800 I think eBay should be able to remove this Safari-specific code path entirely, at least for Safari 3.