152923 2016-01-08 13:26:51 -0800 Fixed compilation of JavaScriptCore with GCC 4.8 on 32-bit platforms 2016-01-11 13:04:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned achristensen commit-queue jbriance keith_miller mark.lam mcatanzaro msaboff ossy saam oldest_to_newest 1153978 0 annulen 2016-01-08 13:26:51 -0800 This small patch restores compilation of JSC with GCC 4.8 on 32-bit platforms. 1153981 1 268578 annulen 2016-01-08 13:28:20 -0800 Created attachment 268578 Patch 1154000 2 msaboff 2016-01-08 14:01:25 -0800 What is the error that GCC 4.8 reports? Aggregate initialization is a c++11 feature and should be in GCC 4.8. 1154015 3 annulen 2016-01-08 14:28:26 -0800 I hit this GCC bug which is fixed in 4.9.0: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=50025 Exact message is: In file included from ../../Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:33:0: ../../Source/JavaScriptCore/jit/CallFrameShuffler.h: In member function ‘void JSC::CallFrameShuffler::assumeCalleeIsCell()’: ../../Source/JavaScriptCore/jit/CallFrameShuffler.h:144:90: error: invalid initialization of non-const reference of type ‘JSC::CachedRecovery&’ from an rvalue of type ‘<brace-enclosed initializer list>’ CachedRecovery& calleeCachedRecovery { *getNew(VirtualRegister(JSStack::Callee)) }; 1154077 4 achristensen 2016-01-08 17:24:42 -0800 This seems like it is completely unrelated to whether it is being compiled on a 32-bit platform. 1154127 5 ossy 2016-01-08 23:41:16 -0800 (In reply to comment #4) > This seems like it is completely unrelated to whether it is being compiled > on a 32-bit platform. It is in JSVALUE32_64 block. 1154153 6 mcatanzaro 2016-01-09 10:45:55 -0800 Frankly, if a one-line change is all that's needed to support a particular compiler, I would just take it. For openSUSE I got the latest stable WebKitGTK+ building and running fine with GCC 4.8 using -DENABLE_INDEXED_DATABASE=OFF and -DENABLE_DATABASE_PROCESS=OFF, in order to provide them the option of upgrading. (It built fine without running into this issue.) We will need to be more conservative with increasing our GCC requirement in the future. 1154154 7 annulen 2016-01-09 10:49:44 -0800 Many vendor-supplied cross-toolchains don't have GCC 4.9 yet, but provide 4.8.x. And many other Linux distributions, e.g. Ubuntu 14.04 LTS, provide GCC 4.8 in their repos, but not newer versions. 1154357 8 ossy 2016-01-11 05:41:05 -0800 Just a note, once we would like to use B3 as FTL JIT backend, GCC 5.2 will be the minimum required version. See bug151624 for details. 1154358 9 annulen 2016-01-11 05:46:29 -0800 That's sad, I hoped I will be able to fix FTL compilation with 4.8 in local branch. However, right now I'm mostly interested in supporting GCC 4.8 for targeting MIPS with vendor-supplied toolchain, and it has no B3 yet. 1154436 10 achristensen 2016-01-11 12:14:46 -0800 (In reply to comment #5) > (In reply to comment #4) > > This seems like it is completely unrelated to whether it is being compiled > > on a 32-bit platform. > > It is in JSVALUE32_64 block. Oh, duh. (In reply to comment #6) > Frankly, if a one-line change is all that's needed to support a particular compiler, I would just take it. I agree. I see no harm in accepting this change right now. 1154458 11 268578 commit-queue 2016-01-11 13:04:36 -0800 Comment on attachment 268578 Patch Clearing flags on attachment: 268578 Committed r194861: <http://trac.webkit.org/changeset/194861> 1154459 12 commit-queue 2016-01-11 13:04:39 -0800 All reviewed patches have been landed. Closing bug. 268578 2016-01-08 13:28:20 -0800 2016-01-11 13:04:36 -0800 Patch bug-152923-20160109002747.patch text/plain 1455 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx YTNiODZlYmE1MzgwNTg1NjEyOTk2YmFlZjQyNjIzZDhiMDkxYmFmLi5lNDVmYTUxOWI2YWEzYjA3 MzY4M2E0ZTY0M2M0ZjM4ODg1ODliNGY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0wOCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgRml4ZWQgY29tcGlsYXRpb24gb2YgSmF2YVNjcmlwdENvcmUgd2l0 aCBHQ0MgNC44IG9uIDMyLWJpdCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjkyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogaml0L0NhbGxGcmFtZVNodWZmbGVyLmg6CisgICAgICAg IChKU0M6OkNhbGxGcmFtZVNodWZmbGVyOjphc3N1bWVDYWxsZWVJc0NlbGwpOgorCiAyMDE2LTAx LTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQjMgaW5jb3Jy ZWN0bHkgdHVybnMgTm90RXF1YWwoYm9vbCwgMSkgaW50byBFcXVhbChib29sLCAxKSBpbnN0ZWFk IG9mIEVxdWFsKGJvb2wsIDApCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0NhbGxGcmFtZVNodWZmbGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NhbGxGcmFt ZVNodWZmbGVyLmgKaW5kZXggNDVhNzczMDk5ZDJhMjdjZmY3YWI0NTg3ZDdmMTQ2NWUyMWViNDA4 OC4uMzkyN2NiNmM5MWY5ODI2OWRjNDg1MTM5M2QwM2UyYjU0OWY3NWIyMCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DYWxsRnJhbWVTaHVmZmxlci5oCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvQ2FsbEZyYW1lU2h1ZmZsZXIuaApAQCAtMTQxLDcgKzE0MSw3 IEBAIHB1YmxpYzoKICAgICB2b2lkIGFzc3VtZUNhbGxlZUlzQ2VsbCgpCiAgICAgewogI2lmIFVT RShKU1ZBTFVFMzJfNjQpCi0gICAgICAgIENhY2hlZFJlY292ZXJ5JiBjYWxsZWVDYWNoZWRSZWNv dmVyeSB7ICpnZXROZXcoVmlydHVhbFJlZ2lzdGVyKEpTU3RhY2s6OkNhbGxlZSkpIH07CisgICAg ICAgIENhY2hlZFJlY292ZXJ5JiBjYWxsZWVDYWNoZWRSZWNvdmVyeSA9ICpnZXROZXcoVmlydHVh bFJlZ2lzdGVyKEpTU3RhY2s6OkNhbGxlZSkpOwogICAgICAgICBzd2l0Y2ggKGNhbGxlZUNhY2hl ZFJlY292ZXJ5LnJlY292ZXJ5KCkudGVjaG5pcXVlKCkpIHsKICAgICAgICAgY2FzZSBJblBhaXI6 CiAgICAgICAgICAgICB1cGRhdGVSZWNvdmVyeSgK