152922 2016-01-08 13:24:34 -0800 FTL B3 compile() doesn't clear exception handlers before we add FTL-specific ones 2016-01-08 13:43:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1153977 0 fpizlo 2016-01-08 13:24:34 -0800 This causes amusing things to happen when the callsite index overlaps with the bytecode index of some handler. 1153980 1 268577 fpizlo 2016-01-08 13:27:20 -0800 Created attachment 268577 the patch 1153983 2 268577 saam 2016-01-08 13:28:38 -0800 Comment on attachment 268577 the patch lol, sounds amusing, indeed r=me 1153990 3 fpizlo 2016-01-08 13:43:17 -0800 Landed in http://trac.webkit.org/changeset/194786 Now the test failure list is: ** The following JSC stress test failures have been introduced: regress/script-tests/call-spread-apply.js.ftl-no-cjit-no-inline-validate regress/script-tests/call-spread-call.js.ftl-no-cjit-no-inline-validate regress/script-tests/varargs-strict-mode.js.ftl-no-cjit-no-inline-validate stress/load-varargs-then-inlined-call-and-exit-strict.js.ftl-no-cjit-no-inline-validate stress/op_negate.js.ftl-no-cjit stress/reflect-apply.js.ftl-eager-no-cjit stress/tail-call-varargs-no-stack-overflow.js.ftl-eager stress/tail-call-varargs-no-stack-overflow.js.ftl-eager-no-cjit stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-inline-validate stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-put-stack-validate stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-small-pool stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-validate stress/varargs-varargs-inlined-exit-strict-mode.js.ftl-no-cjit-no-inline-validate 268577 2016-01-08 13:27:20 -0800 2016-01-08 13:28:38 -0800 the patch blah.patch text/plain 4279 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NzgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE2LTAxLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEIzIGNvbXBpbGUoKSBkb2Vzbid0IGNsZWFyIGV4Y2VwdGlvbiBoYW5kbGVycyBiZWZvcmUg d2UgYWRkIEZUTC1zcGVjaWZpYyBvbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTI5MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGVEwgQjMgd2FzIGdlbmVyYXRpbmcgYSBoYW5kbGVyIHRhYmxlIHRo YXQgZmlyc3QgY29udGFpbmVkIHRoZSBvbGQgYmFzZWxpbmUgaGFuZGxlcnMga2V5ZWQKKyAgICAg ICAgYnkgYmFzZWxpbmUncyBieXRlY29kZSBpbmRpY2VzIGFuZCB0aGVuIHRoZSBGVEwgaGFuZGxl cnMga2V5ZWQgYnkgRlRMIGNhbGxzaXRlIGluZGV4LiBUaGF0J3MKKyAgICAgICAgd3JvbmcsIHNp bmNlIHRoZSBGVEwgY29kZSBibG9jayBzaG91bGQgbm90IGNvbnRhaW4gYW55IGJhc2VsaW5lIGhh bmRsZXJzLiBUaGUgZml4IGlzIHRvCisgICAgICAgIGNsZWFyIHRoZSBoYW5kbGVycyBiZWZvcmUg Z2VuZXJhdGlvbiwgc29ydCBvZiBsaWtlIEZUTCBMTFZNIGRvZXMuCisKKyAgICAgICAgQWxzbyBh ZGRlZCBzb21lIHN0dWZmIHRvIG1ha2UgaXQgZWFzaWVyIHRvIGluc3BlY3QgdGhlIGhhbmRsZXIg dGFibGUuCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlND OjpDb2RlQmxvY2s6OmR1bXBCeXRlY29kZSk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6ZHVt cEV4Y2VwdGlvbkhhbmRsZXJzKToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpiZWdpbkR1bXBQ cm9maWxpbmcpOgorICAgICAgICAqIGJ5dGVjb2RlL0NvZGVCbG9jay5oOgorICAgICAgICAqIGZ0 bC9GVExCM0NvbXBpbGUuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNvbXBpbGUpOgorCiAyMDE2 LTAxLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgQjMgaW5j b3JyZWN0bHkgdHVybnMgTm90RXF1YWwoYm9vbCwgMSkgaW50byBFcXVhbChib29sLCAxKSBpbnN0 ZWFkIG9mIEVxdWFsKGJvb2wsIDApCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNv ZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2aXNpb24gMTk0NzczKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYzOSwxNiAr NjM5LDcgQEAgdm9pZCBDb2RlQmxvY2s6OmR1bXBCeXRlY29kZShQcmludFN0cmVhbQogICAgICAg ICB9IHdoaWxlIChpIDwgY291bnQpOwogICAgIH0KIAotICAgIGlmIChtX3JhcmVEYXRhICYmICFt X3JhcmVEYXRhLT5tX2V4Y2VwdGlvbkhhbmRsZXJzLmlzRW1wdHkoKSkgewotICAgICAgICBvdXQu cHJpbnRmKCJcbkV4Y2VwdGlvbiBIYW5kbGVyczpcbiIpOwotICAgICAgICB1bnNpZ25lZCBpID0g MDsKLSAgICAgICAgZG8gewotICAgICAgICAgICAgSGFuZGxlckluZm8mIGhhbmRsZXIgPSBtX3Jh cmVEYXRhLT5tX2V4Y2VwdGlvbkhhbmRsZXJzW2ldOwotICAgICAgICAgICAgb3V0LnByaW50Zigi XHQgJWQ6IHsgc3RhcnQ6IFslNGRdIGVuZDogWyU0ZF0gdGFyZ2V0OiBbJTRkXSB9ICVzXG4iLAot ICAgICAgICAgICAgICAgIGkgKyAxLCBoYW5kbGVyLnN0YXJ0LCBoYW5kbGVyLmVuZCwgaGFuZGxl ci50YXJnZXQsIGhhbmRsZXIudHlwZU5hbWUoKSk7Ci0gICAgICAgICAgICArK2k7Ci0gICAgICAg IH0gd2hpbGUgKGkgPCBtX3JhcmVEYXRhLT5tX2V4Y2VwdGlvbkhhbmRsZXJzLnNpemUoKSk7Ci0g ICAgfQorICAgIGR1bXBFeGNlcHRpb25IYW5kbGVycyhvdXQpOwogICAgIAogICAgIGlmIChtX3Jh cmVEYXRhICYmICFtX3JhcmVEYXRhLT5tX3N3aXRjaEp1bXBUYWJsZXMuaXNFbXB0eSgpKSB7CiAg ICAgICAgIG91dC5wcmludGYoIlN3aXRjaCBKdW1wIFRhYmxlczpcbiIpOwpAQCAtNjk1LDYgKzY4 NiwyMCBAQCB2b2lkIENvZGVCbG9jazo6ZHVtcEJ5dGVjb2RlKFByaW50U3RyZWFtCiAgICAgb3V0 LnByaW50ZigiXG4iKTsKIH0KIAordm9pZCBDb2RlQmxvY2s6OmR1bXBFeGNlcHRpb25IYW5kbGVy cyhQcmludFN0cmVhbSYgb3V0KQoreworICAgIGlmIChtX3JhcmVEYXRhICYmICFtX3JhcmVEYXRh LT5tX2V4Y2VwdGlvbkhhbmRsZXJzLmlzRW1wdHkoKSkgeworICAgICAgICBvdXQucHJpbnRmKCJc bkV4Y2VwdGlvbiBIYW5kbGVyczpcbiIpOworICAgICAgICB1bnNpZ25lZCBpID0gMDsKKyAgICAg ICAgZG8geworICAgICAgICAgICAgSGFuZGxlckluZm8mIGhhbmRsZXIgPSBtX3JhcmVEYXRhLT5t X2V4Y2VwdGlvbkhhbmRsZXJzW2ldOworICAgICAgICAgICAgb3V0LnByaW50ZigiXHQgJWQ6IHsg c3RhcnQ6IFslNGRdIGVuZDogWyU0ZF0gdGFyZ2V0OiBbJTRkXSB9ICVzXG4iLAorICAgICAgICAg ICAgICAgIGkgKyAxLCBoYW5kbGVyLnN0YXJ0LCBoYW5kbGVyLmVuZCwgaGFuZGxlci50YXJnZXQs IGhhbmRsZXIudHlwZU5hbWUoKSk7CisgICAgICAgICAgICArK2k7CisgICAgICAgIH0gd2hpbGUg KGkgPCBtX3JhcmVEYXRhLT5tX2V4Y2VwdGlvbkhhbmRsZXJzLnNpemUoKSk7CisgICAgfQorfQor CiB2b2lkIENvZGVCbG9jazo6YmVnaW5EdW1wUHJvZmlsaW5nKFByaW50U3RyZWFtJiBvdXQsIGJv b2wmIGhhc1ByaW50ZWRQcm9maWxpbmcpCiB7CiAgICAgaWYgKGhhc1ByaW50ZWRQcm9maWxpbmcp IHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJKHJl dmlzaW9uIDE5NDc3MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxv Y2suaAkod29ya2luZyBjb3B5KQpAQCAtMTkyLDYgKzE5Miw3IEBAIHB1YmxpYzoKICAgICB2b2lk IGR1bXBCeXRlY29kZSgKICAgICAgICAgUHJpbnRTdHJlYW0mLCB1bnNpZ25lZCBieXRlY29kZU9m ZnNldCwKICAgICAgICAgY29uc3QgU3R1YkluZm9NYXAmID0gU3R1YkluZm9NYXAoKSwgY29uc3Qg Q2FsbExpbmtJbmZvTWFwJiA9IENhbGxMaW5rSW5mb01hcCgpKTsKKyAgICB2b2lkIGR1bXBFeGNl cHRpb25IYW5kbGVycyhQcmludFN0cmVhbSYpOwogICAgIHZvaWQgcHJpbnRTdHJ1Y3R1cmVzKFBy aW50U3RyZWFtJiwgY29uc3QgSW5zdHJ1Y3Rpb24qKTsKICAgICB2b2lkIHByaW50U3RydWN0dXJl KFByaW50U3RyZWFtJiwgY29uc3QgY2hhciogbmFtZSwgY29uc3QgSW5zdHJ1Y3Rpb24qLCBpbnQg b3BlcmFuZCk7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQjNDb21waWxl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzQ29tcGls ZS5jcHAJKHJldmlzaW9uIDE5NDc3MykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRM QjNDb21waWxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDYgKzEwOSw5IEBAIHZvaWQgY29t cGlsZShTdGF0ZSYgc3RhdGUsIFNhZmVwb2ludDo6UmUKICAgICAgICAgICAgIG1hdGVyaWFsaXph dGlvbi0+YWNjb3VudEZvckxvY2Fsc09mZnNldChsb2NhbHNPZmZzZXQpOwogICAgIH0KIAorICAg IC8vIFdlIHdpbGwgYWRkIGV4Y2VwdGlvbiBoYW5kbGVycyB3aGlsZSBnZW5lcmF0aW5nLgorICAg IGNvZGVCbG9jay0+Y2xlYXJFeGNlcHRpb25IYW5kbGVycygpOworCiAgICAgQ0NhbGxIZWxwZXJz IGppdCgmdm0sIGNvZGVCbG9jayk7CiAgICAgQjM6OmdlbmVyYXRlKCpzdGF0ZS5wcm9jLCBqaXQp OwogCg==