152915 2016-01-08 11:48:57 -0800 Nullopt and InPlace should be structs, not enum values 2016-01-08 13:33:08 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cdumez cmarcelo commit-queue oldest_to_newest 1153924 0 andersca 2016-01-08 11:48:57 -0800 Nullopt and InPlace should be structs, not enum values 1153927 1 268566 andersca 2016-01-08 11:57:23 -0800 Created attachment 268566 Patch 1153929 2 commit-queue 2016-01-08 11:59:07 -0800 Attachment 268566 did not pass style-queue: ERROR: Source/WTF/wtf/StdLibExtras.h:362: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1153968 3 268566 kling 2016-01-08 13:10:12 -0800 Comment on attachment 268566 Patch igp;r=me 1153986 4 andersca 2016-01-08 13:33:08 -0800 Committed r194784: <http://trac.webkit.org/changeset/194784> 268566 2016-01-08 11:57:23 -0800 2016-01-08 13:10:12 -0800 Patch bug-152915-20160108115656.patch text/plain 5830 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhhYTY1ZjY2ODk3NDNlOGMzMDEyYjA1 MmNjMDRiODViMTdhOGJmYmMuLjg3NDE0NWIyNjlhODBiMGNiZDBmMTM1ODIyMGE2M2UyZTA1YjFh MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMTYtMDEtMDggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxsb3B0IGFuZCBJblBsYWNlIHNob3VsZCBi ZSBzdHJ1Y3RzLCBub3QgZW51bSB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MjkxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdpdGhvdXQgdGhpcywgCisKKyAgICAgICAgT3B0aW9uYWw8aW50 PiBvID0gZmxhZyA/IDEgOiBOdWxsb3B0OworCisgICAgICAgIHdvdWxkIGNhdXNlIE51bGxvcHQg dG8gYmUgdHJlYXRlZCBhcyBhbiBpbnRlZ2VyLCBjYXVzaW5nIG8gdG8gYmUgaW5pdGlhbGl6ZWQg dG8gMCwKKyAgICAgICAgaW5zdGVhZCBvZiBOdWxsb3B0LiBXaXRoIHRoaXMgY2hhbmdlLCB0aGUg YWJvdmUgY29kZSBub3cgY2F1c2VzIGEgY29tcGlsZSBlcnJvci4KKworICAgICAgICBBbHNvLCBn ZXQgcmlkIG9mIHRoZSBDT05TVEVYUFIgbWFjcm8gc2luY2UgYWxsIGNvbXBpbGVycyBzdXBwb3J0 IGNvbnN0ZXhwciBwcm9wZXJseSwKKyAgICAgICAgYW5kIGFkZCBhIFdURjo6bWFrZU9wdGlvbmFs IHRvIG1hdGNoIHRoZSBjdXJyZW50IGl0ZXJhdGlvbiBvZiBzdGQ6OmV4cGVyaW1lbnRhbDo6b3B0 aW9uYWwuCisKKyAgICAgICAgKiB3dGYvQ29tcGlsZXIuaDoKKyAgICAgICAgKiB3dGYvRm9yd2Fy ZC5oOgorICAgICAgICAqIHd0Zi9PcHRpb25hbC5oOgorICAgICAgICAoV1RGOjpOdWxsb3B0VGFn OjpOdWxsb3B0VGFnKToKKyAgICAgICAgKFdURjo6bWFrZU9wdGlvbmFsKToKKyAgICAgICAgKiB3 dGYvU3RkTGliRXh0cmFzLmg6CisgICAgICAgIChzdGQ6OmxpdGVyYWxzOjpjaHJvbm9fbGl0ZXJh bHM6Om9wZXJhdG9yIF9zKToKKyAgICAgICAgKHN0ZDo6bGl0ZXJhbHM6OmNocm9ub19saXRlcmFs czo6b3BlcmF0b3IgX21zKToKKyAgICAgICAgKHN0ZDo6bW92ZSk6CisKIDIwMTYtMDEtMDYgIEFu ZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgYSBzbWFy dCBibG9jayBwb2ludGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oIGIv U291cmNlL1dURi93dGYvQ29tcGlsZXIuaAppbmRleCA2OWQ2ZjhhNDg3ZmNjODEyMWNhZjkwMWY0 ZTU3ZWViYmVjNmE4YjdkLi43YjljOTJiODU2MjEwNTgzOGM5ZWJjMjMyYzg1ZWJmNzA5OWU2Mjc4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Db21waWxlci5oCisrKyBiL1NvdXJjZS9XVEYv d3RmL0NvbXBpbGVyLmgKQEAgLTUwLDcgKzUwLDYgQEAKICNkZWZpbmUgV1RGX0NPTVBJTEVSX0NM QU5HIDEKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0JMT0NLUyBfX2hhc19mZWF0dXJl KGJsb2NrcykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0NfU1RBVElDX0FTU0VSVCBf X2hhc19mZWF0dXJlKGNfc3RhdGljX2Fzc2VydCkKLSNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBP UlRTX0NYWF9DT05TVEVYUFIgX19oYXNfZmVhdHVyZShjeHhfY29uc3RleHByKQogI2RlZmluZSBX VEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX1JFRkVSRU5DRV9RVUFMSUZJRURfRlVOQ1RJT05TIF9f aGFzX2ZlYXR1cmUoY3h4X3JlZmVyZW5jZV9xdWFsaWZpZWRfZnVuY3Rpb25zKQogI2RlZmluZSBX VEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX1VTRVJfTElURVJBTFMgX19oYXNfZmVhdHVyZShjeHhf dXNlcl9saXRlcmFscykKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1NVUFBPUlRTX0ZBTExUSFJPVUdI X1dBUk5JTkdTIF9faGFzX2ZlYXR1cmUoY3h4X2F0dHJpYnV0ZXMpICYmIF9faGFzX3dhcm5pbmco Ii1XaW1wbGljaXQtZmFsbHRocm91Z2giKQpAQCAtNjUsNyArNjQsNiBAQAogLyogTm90ZTogVGhp cyBzZWN0aW9uIG11c3QgY29tZSBhZnRlciB0aGUgQ2xhbmcgc2VjdGlvbiBzaW5jZSB3ZSBjaGVj ayAhQ09NUElMRVIoQ0xBTkcpIGhlcmUuICovCiAjaWYgQ09NUElMRVIoR0NDX09SX0NMQU5HKSAm JiAhQ09NUElMRVIoQ0xBTkcpCiAjZGVmaW5lIFdURl9DT01QSUxFUl9HQ0MgMQotI2RlZmluZSBX VEZfQ09NUElMRVJfU1VQUE9SVFNfQ1hYX0NPTlNURVhQUiAxCiAjZGVmaW5lIFdURl9DT01QSUxF Ul9TVVBQT1JUU19DWFhfVVNFUl9MSVRFUkFMUyAxCiAjZGVmaW5lIFdURl9DT01QSUxFUl9TVVBQ T1JUU19DWFhfUkVGRVJFTkNFX1FVQUxJRklFRF9GVU5DVElPTlMgMQogCkBAIC0xNTUsMTYgKzE1 Myw2IEBACiAjZGVmaW5lIEFMV0FZU19JTkxJTkUgaW5saW5lCiAjZW5kaWYKIAotLyogQ09OU1RF WFBSICovCi0KLSNpZiAhZGVmaW5lZChDT05TVEVYUFIpICYmIENPTVBJTEVSX1NVUFBPUlRTKENY WF9DT05TVEVYUFIpCi0jZGVmaW5lIENPTlNURVhQUiBjb25zdGV4cHIKLSNlbmRpZgotCi0jaWYg IWRlZmluZWQoQ09OU1RFWFBSKQotI2RlZmluZSBDT05TVEVYUFIKLSNlbmRpZgotCiAvKiBXVEZf RVhURVJOX0Nfe0JFR0lOLCBFTkR9ICovCiAKICNpZmRlZiBfX2NwbHVzcGx1cwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvRm9yd2FyZC5oIGIvU291cmNlL1dURi93dGYvRm9yd2FyZC5oCmlu ZGV4IGViNWU0OTAyMWMyNDRlNmM2MDkyOWFjOGZhYWFmNGJmMDFjYTQ3MDQuLjU0MzQyODQxOGVm YjI4YjA5M2I2NjNmZjE0ZTExZjEzOGM5ZmEwZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L0ZvcndhcmQuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Gb3J3YXJkLmgKQEAgLTI4LDYgKzI4LDcg QEAgbmFtZXNwYWNlIFdURiB7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBGdW5jdGlvbjsK IHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIExhenlOZXZlckRlc3Ryb3llZDsKIHRlbXBsYXRl PHR5cGVuYW1lIFQ+IGNsYXNzIE5ldmVyRGVzdHJveWVkOwordGVtcGxhdGU8dHlwZW5hbWUgVD4g Y2xhc3MgT3B0aW9uYWw7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBQYXNzUmVmUHRyOwog dGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgUmVmUHRyOwogdGVtcGxhdGU8dHlwZW5hbWUgVD4g Y2xhc3MgUmVmOwpAQCAtNjIsNiArNjMsNyBAQCB1c2luZyBXVEY6OkZ1bmN0aW9uOwogdXNpbmcg V1RGOjpGdW5jdGlvbkRpc3BhdGNoZXI7CiB1c2luZyBXVEY6OkxhenlOZXZlckRlc3Ryb3llZDsK IHVzaW5nIFdURjo6TmV2ZXJEZXN0cm95ZWQ7Cit1c2luZyBXVEY6Ok9wdGlvbmFsOwogdXNpbmcg V1RGOjpPcmRpbmFsTnVtYmVyOwogdXNpbmcgV1RGOjpQYXNzUmVmUHRyOwogdXNpbmcgV1RGOjpQ cmludFN0cmVhbTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9PcHRpb25hbC5oCmluZGV4IDk3OWYwOTcwZTAwMjhiN2NkZGFkNGVhZTA2Nzk4 ZTdiOGI3YjMyYzMuLmZhMGVkZjdkZjMyODAyMjgzYTM1NzM4MmFlMWM2NmFhYzQyYTZmZmYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL09wdGlvbmFsLmgKKysrIGIvU291cmNlL1dURi93dGYv T3B0aW9uYWwuaApAQCAtMzYsOCArMzYsMTEgQEAKIAogbmFtZXNwYWNlIFdURiB7CiAKLWVudW0g SW5QbGFjZVRhZyB7IEluUGxhY2UgfTsKLWVudW0gTnVsbG9wdFRhZyB7IE51bGxvcHQgfTsKK3N0 cnVjdCBJblBsYWNlVGFnIHsgfTsKK2NvbnN0ZXhwciBJblBsYWNlVGFnIEluUGxhY2UgeyB9Owor CitzdHJ1Y3QgTnVsbG9wdFRhZyB7IGV4cGxpY2l0IGNvbnN0ZXhwciBOdWxsb3B0VGFnKGludCkg eyB9IH07Citjb25zdGV4cHIgTnVsbG9wdFRhZyBOdWxsb3B0IHsgMCB9OwogCiB0ZW1wbGF0ZTx0 eXBlbmFtZSBUPgogY2xhc3MgT3B0aW9uYWwgewpAQCAtMTkzLDEwICsxOTYsMTggQEAgcHJpdmF0 ZToKICAgICB0eXBlbmFtZSBzdGQ6OmFsaWduZWRfc3RvcmFnZTxzaXplb2YoVCksIHN0ZDo6YWxp Z25tZW50X29mPFQ+Ojp2YWx1ZT46OnR5cGUgbV92YWx1ZTsKIH07CiAKK3RlbXBsYXRlPHR5cGVu YW1lIFQ+CitPcHRpb25hbDx0eXBlbmFtZSBzdGQ6OmRlY2F5PFQ+Ojp0eXBlPgorbWFrZU9wdGlv bmFsKFQmJiB2YWx1ZSkKK3sKKyAgICByZXR1cm4gT3B0aW9uYWw8dHlwZW5hbWUgc3RkOjpkZWNh eTxUPjo6dHlwZT4oc3RkOjpmb3J3YXJkPFQ+KHZhbHVlKSk7Cit9CisKIH0gLy8gbmFtZXNwYWNl IFdURgogCiB1c2luZyBXVEY6OkluUGxhY2U7CiB1c2luZyBXVEY6Ok51bGxvcHQ7CiB1c2luZyBX VEY6Ok9wdGlvbmFsOwordXNpbmcgV1RGOjptYWtlT3B0aW9uYWw7CiAKICNlbmRpZiAvLyBPcHRp b25hbF9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdGRMaWJFeHRyYXMuaCBiL1NvdXJj ZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCmluZGV4IGU4NWVlMWI3MGM2NmNhMjliMTRhNjkwM2Jm YmU1YjRiNDdjNzhjMGEuLmQ4NzIwOTcxZGIwZTg0NzAwM2Q1OGZmYjg0ODA2MjE5OGI2NTc3ZWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCisrKyBiL1NvdXJjZS9X VEYvd3RmL1N0ZExpYkV4dHJhcy5oCkBAIC0zNTksMTIgKzM1OSwxMiBAQCBUIGV4Y2hhbmdlKFQm IHQsIFUmJiBuZXdWYWx1ZSkKIC8vIChVc2VyLWxpdGVyYWxzIG5lZWQgdG8gaGF2ZSBhIGxlYWRp bmcgdW5kZXJzY29yZSBzbyB3ZSBhZGQgaXQgaGVyZSAtIHRoZSAicmVhbCIgbGl0ZXJhbHMgZG9u J3QgaGF2ZSB1bmRlcnNjb3JlcykuCiBuYW1lc3BhY2UgbGl0ZXJhbHMgewogbmFtZXNwYWNlIGNo cm9ub19saXRlcmFscyB7Ci0gICAgQ09OU1RFWFBSIGlubGluZSBjaHJvbm86OnNlY29uZHMgb3Bl cmF0b3IiIiBfcyh1bnNpZ25lZCBsb25nIGxvbmcgcykKKyAgICBjb25zdGV4cHIgaW5saW5lIGNo cm9ubzo6c2Vjb25kcyBvcGVyYXRvciIiIF9zKHVuc2lnbmVkIGxvbmcgbG9uZyBzKQogICAgIHsK ICAgICAgICAgcmV0dXJuIGNocm9ubzo6c2Vjb25kcyhzdGF0aWNfY2FzdDxjaHJvbm86OnNlY29u ZHM6OnJlcD4ocykpOwogICAgIH0KIAotICAgIENPTlNURVhQUiBjaHJvbm86Om1pbGxpc2Vjb25k cyBvcGVyYXRvciIiIF9tcyh1bnNpZ25lZCBsb25nIGxvbmcgbXMpCisgICAgY29uc3RleHByIGNo cm9ubzo6bWlsbGlzZWNvbmRzIG9wZXJhdG9yIiIgX21zKHVuc2lnbmVkIGxvbmcgbG9uZyBtcykK ICAgICB7CiAgICAgICAgIHJldHVybiBjaHJvbm86Om1pbGxpc2Vjb25kcyhzdGF0aWNfY2FzdDxj aHJvbm86Om1pbGxpc2Vjb25kczo6cmVwPihtcykpOwogICAgIH0KQEAgLTM3Myw3ICszNzMsNyBA QCBuYW1lc3BhY2UgY2hyb25vX2xpdGVyYWxzIHsKICNlbmRpZgogCiB0ZW1wbGF0ZTxXVEY6OkNo ZWNrTW92ZVBhcmFtZXRlclRhZywgdHlwZW5hbWUgVD4KLUFMV0FZU19JTkxJTkUgQ09OU1RFWFBS IHR5cGVuYW1lIHJlbW92ZV9yZWZlcmVuY2U8VD46OnR5cGUmJiBtb3ZlKFQmJiB2YWx1ZSkKK0FM V0FZU19JTkxJTkUgY29uc3RleHByIHR5cGVuYW1lIHJlbW92ZV9yZWZlcmVuY2U8VD46OnR5cGUm JiBtb3ZlKFQmJiB2YWx1ZSkKIHsKICAgICBzdGF0aWNfYXNzZXJ0KGlzX2x2YWx1ZV9yZWZlcmVu Y2U8VD46OnZhbHVlLCAiVCBpcyBub3QgYW4gbHZhbHVlIHJlZmVyZW5jZTsgbW92ZSgpIGlzIHVu bmVjZXNzYXJ5LiIpOwogCg==