152909 2016-01-08 11:23:56 -0800 FTL B3 allocateCell() should not crash 2016-01-08 11:38:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150279 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1153903 0 fpizlo 2016-01-08 11:23:56 -0800 And it shouldn't use undef, that's dumb. 1153907 1 268559 fpizlo 2016-01-08 11:25:54 -0800 Created attachment 268559 the patch 1153908 2 268559 mark.lam 2016-01-08 11:28:50 -0800 Comment on attachment 268559 the patch r=me 1153913 3 fpizlo 2016-01-08 11:38:31 -0800 Here's the new list of failures after this change: ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/dfg-constant-fold-misprediction.js.layout-ftl-eager-no-cjit regress/script-tests/call-spread-apply.js.ftl-no-cjit-no-inline-validate regress/script-tests/call-spread-call.js.ftl-no-cjit-no-inline-validate regress/script-tests/getter-richards-try-catch.js.default-ftl regress/script-tests/getter-richards-try-catch.js.ftl-no-cjit-validate regress/script-tests/richards-try-catch.js.default-ftl regress/script-tests/richards-try-catch.js.ftl-eager regress/script-tests/richards-try-catch.js.ftl-eager-no-cjit regress/script-tests/richards-try-catch.js.ftl-no-cjit-no-put-stack-validate regress/script-tests/richards-try-catch.js.ftl-no-cjit-validate regress/script-tests/varargs-strict-mode.js.ftl-no-cjit-no-inline-validate stress/ftl-try-catch-patchpoint-with-volatile-registers.js.default-ftl stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-eager-no-cjit stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-no-inline-validate stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-no-put-stack-validate stress/ftl-try-catch-patchpoint-with-volatile-registers.js.ftl-no-cjit-validate stress/load-varargs-then-inlined-call-and-exit-strict.js.ftl-no-cjit-no-inline-validate stress/op_negate.js.ftl-no-cjit stress/reflect-apply.js.ftl-eager-no-cjit stress/tail-call-varargs-no-stack-overflow.js.default-ftl stress/tail-call-varargs-no-stack-overflow.js.ftl-eager stress/tail-call-varargs-no-stack-overflow.js.ftl-eager-no-cjit stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-inline-validate stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-no-put-stack-validate stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-small-pool stress/tail-call-varargs-no-stack-overflow.js.ftl-no-cjit-validate stress/varargs-varargs-inlined-exit-strict-mode.js.ftl-no-cjit-no-inline-validate 1153914 4 fpizlo 2016-01-08 11:38:43 -0800 Landed in http://trac.webkit.org/changeset/194774 268559 2016-01-08 11:25:54 -0800 2016-01-08 11:28:50 -0800 the patch blah.patch text/plain 1699 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NzczKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE2LTAxLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEIzIGFsbG9jYXRlQ2VsbCgpIHNob3VsZCBub3QgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjkwOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY29kZSB3YXMgY3Jhc2hpbmcgaW4g c29tZSB0ZXN0cyB0aGF0IGZvcmNlZCBHQyBzbG93IHBhdGhzIGJlY2F1c2UgaXQgd2FzIHN0dWJi ZWQgb3V0CisgICAgICAgIGR1ZSB0byB0aGUgdXNlIG9mIHVuZGVmLiBCMyBkb2Vzbid0IGhhdmUg dW5kZWYuIEluIHRoaXMgY2FzZSwgdGhlcmUncyBubyBnb29kIHJlYXNvbiB0byB1c2UKKyAgICAg ICAgdW5kZWYuIFdlIGNhbiBqdXN0IHVzZSB6ZXJvLiBTaW5jZSB0aGUgcGF0aCBpcyBkZWFkIGFu eXdheSBpbiB0aGF0IGNhc2UsIHdlIHdlcmVuJ3QgZ2FpbmluZworICAgICAgICBhbnkgTExWTSBv cHRpbWl6YXRpb25zIGJ5IHVzaW5nIHVuZGVmLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZH VG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjphbGxv Y2F0ZUNlbGwpOgorCiAyMDE2LTAxLTA4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+ CiAKICAgICAgICAgRlRMIEIzIGZhaWxzIHRvIHJlYWxpemUgdGhhdCBiaW5hcnkgc25pcHBldHMg bWlnaHQgY2hvb3NlIHRvIG9taXQgdGhlaXIgZmFzdCBwYXRoCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTk0Nzcz KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTc3MzMsMTIgKzc3MzMsOCBAQCBwcml2YXRlOgogICAgICAgICBMVmFs dWUgcmVzdWx0OwogICAgICAgICBMVmFsdWUgY29uZGl0aW9uOwogICAgICAgICBpZiAoT3B0aW9u czo6Zm9yY2VHQ1Nsb3dQYXRocygpKSB7Ci0jaWYgRlRMX1VTRVNfQjMKLSAgICAgICAgICAgIENS QVNIKCk7Ci0jZWxzZQotICAgICAgICAgICAgcmVzdWx0ID0gZ2V0VW5kZWYobV9vdXQuaW50NjQp OworICAgICAgICAgICAgcmVzdWx0ID0gbV9vdXQuaW50UHRyWmVybzsKICAgICAgICAgICAgIGNv bmRpdGlvbiA9IG1fb3V0LmJvb2xlYW5GYWxzZTsKLSNlbmRpZgogICAgICAgICB9IGVsc2Ugewog ICAgICAgICAgICAgcmVzdWx0ID0gbV9vdXQubG9hZFB0cigKICAgICAgICAgICAgICAgICBhbGxv Y2F0b3IsIG1faGVhcHMuTWFya2VkQWxsb2NhdG9yX2ZyZWVMaXN0SGVhZCk7Cg==