152900 2016-01-08 10:48:23 -0800 [ANGLE] Correct UNREACHABLE runtime assertion for void constructors 2016-01-08 13:01:45 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham commit-queue dino kondapallykalyan roger_fong webkit-bug-importer oldest_to_newest 1153869 0 bfulgham 2016-01-08 10:48:23 -0800 The fix is just to remove the UNREACHABLE call in this name mangler. Several expected values pass through here and should not contribute to the mangled name. The ‘UNREACHBLE()’ call was not appropriate: chromium / angle / angle / 01971113492d9aca386f2bca021b1f4b134fc277^! / . commit 01971113492d9aca386f2bca021b1f4b134fc277 [log] [tgz] author Dmitry Skiba <dskiba@google.com> Fri Jul 10 18:54:00 2015 committer Jamie Madill <jmadill@chromium.org> Fri Jul 10 19:03:34 2015 tree 47e42eac00f7d64cddb14b3cc21a4e605c189d20 parent 53b76107ece2f5b4dfc831f2b571f9db04d65c73 [diff] diff --git a/src/compiler/translator/Types.cpp b/src/compiler/translator/Types.cpp index 0b60eb1..62bcd8e 100644 --- a/src/compiler/translator/Types.cpp +++ b/src/compiler/translator/Types.cpp @@ -142,7 +142,8 @@ mangledName += interfaceBlock->mangledName(); break; default: - UNREACHABLE(); + // EbtVoid, EbtAddress and non types + break; } if (isMatrix()) 1153870 1 bfulgham 2016-01-08 10:49:05 -0800 Side note: We need to update ANGLE, and should try to keep more in sync with the upstream work. The patch that had this (small) fix also added some useful caching that would be nice to have in our code. 1153875 2 268551 bfulgham 2016-01-08 10:55:39 -0800 Created attachment 268551 Patch 1153878 3 bfulgham 2016-01-08 10:56:22 -0800 <rdar://problem/24107501> 1153880 4 commit-queue 2016-01-08 10:56:55 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1153958 5 268551 commit-queue 2016-01-08 13:01:43 -0800 Comment on attachment 268551 Patch Clearing flags on attachment: 268551 Committed r194780: <http://trac.webkit.org/changeset/194780> 1153959 6 commit-queue 2016-01-08 13:01:45 -0800 All reviewed patches have been landed. Closing bug. 268551 2016-01-08 10:55:39 -0800 2016-01-08 13:01:43 -0800 Patch bug-152900-20160108105507.patch text/plain 1915 bfulgham SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDc3MCkKKysrIFNv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDI1IEBACisyMDE2LTAxLTA4ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgor CisgICAgICAgIFtBTkdMRV0gQ29ycmVjdCBVTlJFQUNIQUJMRSBydW50aW1lIGFzc2VydGlvbiBm b3Igdm9pZCBjb25zdHJ1Y3RvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1MjkwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQxMDc1MDE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdGVkIGJ5 IEtocm9ub3MgV2ViR0wgMS4wLjQgc3VpdGUuCisKKyAgICAgICAgTWVyZ2UgYSBzbWFsbCBwYXJ0 IG9mIEFOR0xFIHVwc3RyZWFtIGNvbW1pdCByMjg0NzM1OgorICAgICAgICAKKyAgICAgICAgICAg IGNvbW1pdCAgICAwMTk3MTExMzQ5MmQ5YWNhMzg2ZjJiY2EwMjFiMWY0YjEzNGZjMjc3CisgICAg ICAgICAgICBhdXRob3IgICAgRG1pdHJ5IFNraWJhIDxkc2tpYmFAZ29vZ2xlLmNvbT4gIEZyaSBK dWwgMTAgMTg6NTQ6MDAgMjAxNQorICAgICAgICAgICAgY29tbWl0dGVyIEphbWllIE1hZGlsbCA8 am1hZGlsbEBjaHJvbWl1bS5vcmc+ICBGcmkgSnVsIDEwIDE5OjAzOjM0IDIwMTUKKyAgICAgICAg ICAgIHRyZWUgICAgICA0N2U0MmVhYzAwZjdkNjRjZGRiMTRiM2NjMjFhNGU2MDVjMTg5ZDIwCisK KyAgICAgICAgVGhpcyBpc3N1ZSB3YXMgZm91bmQgYnkgPGh0dHBzOi8vd3d3Lmtocm9ub3Mub3Jn L3JlZ2lzdHJ5L3dlYmdsL3Nkay90ZXN0cy9jb25mb3JtYW5jZS9nbHNsL2J1Z3MvYW5nbGUtY29u c3RydWN0b3ItaW52YWxpZC1wYXJhbWV0ZXJzLmh0bWw/d2ViZ2xWZXJzaW9uPTEmcXVpZXQ9MD4K KworICAgICAgICAqIHNyYy9jb21waWxlci90cmFuc2xhdG9yL1R5cGVzLmNwcDoKKyAgICAgICAg KFRUeXBlOjpidWlsZE1hbmdsZWROYW1lKTogRG9uJ3QgYXNzZXJ0IHdpdGggVU5SRUFDSEFCTEUg aGVyZS4KKwogMjAxNS0xMi0yOCAgSm9vbmdodW4gUGFyayAgPGpoNzE4LnBhcmtAc2Ftc3VuZy5j b20+CiAKICAgICAgICAgW0FOR0xFXVtFRkxdW0dUS10gUmVtb3ZlICd0ZW1wbGF0ZTxjbGFzcz4g Y2xhc3Mgc3RkOjphdXRvX3B0ciBpcyBkZXByZWNhdGVkJyBjb21waWxlIHdhcm5pbmcKSW5kZXg6 IFNvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xhdG9yL1R5cGVzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvY29tcGlsZXIvdHJh bnNsYXRvci9UeXBlcy5jcHAJKHJldmlzaW9uIDE5NDc2NykKKysrIFNvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL3NyYy9jb21waWxlci90cmFuc2xhdG9yL1R5cGVzLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTQyLDcgKzE0Miw4IEBAIFRTdHJpbmcgVFR5cGU6OmJ1aWxkTWFuZ2xlZE5hbWUoKSBjb25z dAogICAgICAgICBtYW5nbGVkTmFtZSArPSBpbnRlcmZhY2VCbG9jay0+bWFuZ2xlZE5hbWUoKTsK ICAgICAgICAgYnJlYWs7CiAgICAgICBkZWZhdWx0OgotICAgICAgICBVTlJFQUNIQUJMRSgpOwor ICAgICAgICAvLyBFYnRWb2lkLCBFYnRBZGRyZXNzIGFuZCBub24gdHlwZXMKKyAgICAgICAgYnJl YWs7CiAgICAgfQogCiAgICAgaWYgKGlzTWF0cml4KCkpCg==