152895 2016-01-08 09:18:21 -0800 [JSC] B3 is unable to do function calls on ARM64 2016-01-10 17:00:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1153838 0 benjamin 2016-01-08 09:18:21 -0800 [JSC] B3 is unable to do function calls on ARM64 1153839 1 268546 benjamin 2016-01-08 09:20:09 -0800 Created attachment 268546 Patch 1153841 2 268546 mark.lam 2016-01-08 09:30:19 -0800 Comment on attachment 268546 Patch r=me 1154262 3 268546 commit-queue 2016-01-10 13:43:04 -0800 Comment on attachment 268546 Patch Clearing flags on attachment: 268546 Committed r194831: <http://trac.webkit.org/changeset/194831> 1154263 4 commit-queue 2016-01-10 13:43:08 -0800 All reviewed patches have been landed. Closing bug. 1154292 5 268546 fpizlo 2016-01-10 17:00:54 -0800 Comment on attachment 268546 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268546&action=review > Source/JavaScriptCore/b3/B3LowerToAir.cpp:1554 > +#if CPU(ARM64) && PLATFORM(IOS) We usually use "if (isARM64())" instead of "#if CPU(ARM64)" in the compiler, since that would be just as correct and a whole lot more clear. I think it would make sense to add an "isIOS()" function and turn this code into normal control flow. 268546 2016-01-08 09:20:09 -0800 2016-01-10 13:43:04 -0800 Patch bug-152895-20160108181934.patch text/plain 3980 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NWY1MDIwYjIxZTRiMWUzM2I4ZjRlNThkMmQwMzhmMTAyYjgwNTMyLi5kZjEzN2ZhMzgwMDczNDFi OTIxNjZhNzk3MjA2OTNlYTRkNjgxODdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMiBAQAogMjAxNi0wMS0wOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KIAorICAgICAgICBbSlNDXSBCMyBpcyB1bmFibGUgdG8gZG8gZnVuY3Rpb24gY2FsbHMg b24gQVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1Mjg5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFwcGFyZW50bHkgaU9TIGRvZXMgbm90IGZvbGxvdyB0aGUgQVJNNjQgQUJJIGZvciBmdW5jdGlv biBjYWxscy4KKyAgICAgICAgSW5zdGVhZCBvZiBnaXZpbmcgZWFjaCB2YWx1ZSBhIDggYnl0ZXMg c2xvdCwgaXQgbXVzdCBiZSBwYWNrZWQKKyAgICAgICAgd2hpbGUgcHJlc2VydmluZyBhbGlnbm1l bnQuCisKKyAgICAgICAgVGhpcyBwYXRjaCBhZGRzIGEgI2lmZGVmIHRvIG1ha2UgZnVuY3Rpb24g Y2FsbHMgZnVuY3Rpb25hbC4KKworICAgICAgICAqIGIzL0IzTG93ZXJUb0Fpci5jcHA6CisgICAg ICAgIChKU0M6OkIzOjpBaXI6Okxvd2VyVG9BaXI6Om1hcnNoYWxsQ0NhbGxBcmd1bWVudCk6Cisg ICAgICAgIChKU0M6OkIzOjpBaXI6Okxvd2VyVG9BaXI6Omxvd2VyKToKKworMjAxNi0wMS0wOCAg QmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KKwogICAgICAgICBbSlNDXSBN YWtlIGJyYW5jaE11bCBmdW5jdGlvbmFsIGluIEFSTSBCMyBhbmQgbWlub3IgZml4ZXMKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjg4OQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyVG9BaXIuY3BwCmluZGV4IGFlMjE2MmU4YWYwYjJk YjE2MzdiOTU4YjAyMTcwYzA5NzM5OTI4N2MuLjQ0NThiZWM3YTBkZWM2MTU5MzA0ZDIwYzQ2ZTA0 M2JhZThiNjNmYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2Vy VG9BaXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyVG9BaXIuY3Bw CkBAIC0xNTQyLDcgKzE1NDIsNyBAQCBwcml2YXRlOgogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5 cGVuYW1lIEJhbmtJbmZvPgotICAgIEFyZyBtYXJzaGFsbENDYWxsQXJndW1lbnQodW5zaWduZWQm IGFyZ3VtZW50Q291bnQsIHVuc2lnbmVkJiBzdGFja0NvdW50LCBWYWx1ZSogY2hpbGQpCisgICAg QXJnIG1hcnNoYWxsQ0NhbGxBcmd1bWVudCh1bnNpZ25lZCYgYXJndW1lbnRDb3VudCwgdW5zaWdu ZWQmIHN0YWNrT2Zmc2V0LCBWYWx1ZSogY2hpbGQpCiAgICAgewogICAgICAgICB1bnNpZ25lZCBh cmd1bWVudEluZGV4ID0gYXJndW1lbnRDb3VudCsrOwogICAgICAgICBpZiAoYXJndW1lbnRJbmRl eCA8IEJhbmtJbmZvOjpudW1iZXJPZkFyZ3VtZW50UmVnaXN0ZXJzKSB7CkBAIC0xNTUxLDEzICsx NTUxLDE2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICByZXR1cm4gcmVzdWx0OwogICAgICAgICB9 CiAKLSAgICAgICAgLy8gQ29tcHV0ZSB0aGUgcGxhY2UgdGhhdCB0aGlzIGdvZXMgb250byB0aGUg c3RhY2suIE9uIFg4Nl82NCBhbmQgcHJvYmFibHkgb3RoZXIgY2FsbGluZwotICAgICAgICAvLyBj b252ZW50aW9ucyB0aGF0IGRvbid0IGludm9sdmUgb2Jzb2xldGUgY29tcHV0ZXJzIGFuZCBvcGVy YXRpbmcgc3lzdGVtcywgc3ViLXBvaW50ZXItc2l6ZQotICAgICAgICAvLyBhcmd1bWVudHMgYXJl IHN0aWxsIGdpdmVuIGEgZnVsbCBwb2ludGVyLXNpemVkIHN0YWNrIHNsb3QuIEhlbmNlIHdlIGRv bid0IGhhdmUgdG8gY29uc2lkZXIKLSAgICAgICAgLy8gdGhlIHR5cGUgb2YgdGhlIGFyZ3VtZW50 IHdoZW4gZGVkdWNpbmcgdGhlIHN0YWNrIGluZGV4LgotICAgICAgICB1bnNpZ25lZCBzdGFja0lu ZGV4ID0gc3RhY2tDb3VudCsrOwotCi0gICAgICAgIEFyZyByZXN1bHQgPSBBcmc6OmNhbGxBcmco c3RhY2tJbmRleCAqIHNpemVvZih2b2lkKikpOworI2lmIENQVShBUk02NCkgJiYgUExBVEZPUk0o SU9TKQorICAgICAgICAvLyBpT1MgZG9lcyBub3QgZm9sbG93IHRoZSBBUk02NCBBQkkgcmVnYXJk aW5nIGZ1bmN0aW9uIGNhbGxzLgorICAgICAgICAvLyBBcmd1bWVudHMgbXVzdCBiZSBwYWNrZWQu CisgICAgICAgIHVuc2lnbmVkIHNsb3RTaXplID0gc2l6ZW9mVHlwZShjaGlsZC0+dHlwZSgpKTsK KyAgICAgICAgc3RhY2tPZmZzZXQgPSBXVEY6OnJvdW5kVXBUb011bHRpcGxlT2Yoc2xvdFNpemUs IHN0YWNrT2Zmc2V0KTsKKyNlbHNlCisgICAgICAgIHVuc2lnbmVkIHNsb3RTaXplID0gc2l6ZW9m KHZvaWQqKTsKKyNlbmRpZgorICAgICAgICBBcmcgcmVzdWx0ID0gQXJnOjpjYWxsQXJnKHN0YWNr T2Zmc2V0KTsKKyAgICAgICAgc3RhY2tPZmZzZXQgKz0gc2xvdFNpemU7CiAgICAgICAgIAogICAg ICAgICAvLyBQdXQgdGhlIGNvZGUgZm9yIHN0b3JpbmcgdGhlIGFyZ3VtZW50IGJlZm9yZSBhbnl0 aGluZyBlbHNlLiBUaGlzIHNpZ25pZmljYW50bHkgZWFzZXMgdGhlCiAgICAgICAgIC8vIGJ1cmRl biBvbiB0aGUgcmVnaXN0ZXIgYWxsb2NhdG9yLiBJZiB3ZSBjb3VsZCwgd2UnZCBob2lzdCB0aGVz ZSBzdG9yZXMgYXMgZmFyIGFzCkBAIC0xOTQzLDE4ICsxOTQ2LDE4IEBAIHByaXZhdGU6CiAgICAg ICAgICAgICAvLyB0aGlzLCBBaXIgZG9lcyBub3Qga25vdyB3aGF0IHRoZSBjb252ZW50aW9uIGlz OyBpdCBqdXN0IHRha2VzIG91ciB3b3JkIGZvciBpdC4KICAgICAgICAgICAgIHVuc2lnbmVkIGdw QXJndW1lbnRDb3VudCA9IDA7CiAgICAgICAgICAgICB1bnNpZ25lZCBmcEFyZ3VtZW50Q291bnQg PSAwOwotICAgICAgICAgICAgdW5zaWduZWQgc3RhY2tDb3VudCA9IDA7CisgICAgICAgICAgICB1 bnNpZ25lZCBzdGFja09mZnNldCA9IDA7CiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAx OyBpIDwgY0NhbGwtPm51bUNoaWxkcmVuKCk7ICsraSkgewogICAgICAgICAgICAgICAgIFZhbHVl KiBhcmdDaGlsZCA9IGNDYWxsLT5jaGlsZChpKTsKICAgICAgICAgICAgICAgICBBcmcgYXJnOwog ICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgIHN3aXRjaCAoQXJnOjp0eXBlRm9yQjNU eXBlKGFyZ0NoaWxkLT50eXBlKCkpKSB7CiAgICAgICAgICAgICAgICAgY2FzZSBBcmc6OkdQOgot ICAgICAgICAgICAgICAgICAgICBhcmcgPSBtYXJzaGFsbENDYWxsQXJndW1lbnQ8R1BSSW5mbz4o Z3BBcmd1bWVudENvdW50LCBzdGFja0NvdW50LCBhcmdDaGlsZCk7CisgICAgICAgICAgICAgICAg ICAgIGFyZyA9IG1hcnNoYWxsQ0NhbGxBcmd1bWVudDxHUFJJbmZvPihncEFyZ3VtZW50Q291bnQs IHN0YWNrT2Zmc2V0LCBhcmdDaGlsZCk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogCiAg ICAgICAgICAgICAgICAgY2FzZSBBcmc6OkZQOgotICAgICAgICAgICAgICAgICAgICBhcmcgPSBt YXJzaGFsbENDYWxsQXJndW1lbnQ8RlBSSW5mbz4oZnBBcmd1bWVudENvdW50LCBzdGFja0NvdW50 LCBhcmdDaGlsZCk7CisgICAgICAgICAgICAgICAgICAgIGFyZyA9IG1hcnNoYWxsQ0NhbGxBcmd1 bWVudDxGUFJJbmZvPihmcEFyZ3VtZW50Q291bnQsIHN0YWNrT2Zmc2V0LCBhcmdDaGlsZCk7CiAg ICAgICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgICAgIH0KIAo=