152894 2016-01-08 09:07:43 -0800 run-webkit-tests mis-counts totals when there are other crashes 2017-03-15 17:16:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue glenn lforschler oldest_to_newest 1153837 0 aakash_jain 2016-01-08 09:07:43 -0800 see <rdar://problem/24098697> When there are "other" crashes, the "didn't run" in run-webkit-tests output are wrong. e.g.: 8 tests ran as expected, 2 didn't (-2 didn't run): And: 15:34:07.115 52921 10 slowest tests that are not marked as SLOW and did not timeout/crash: 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html took 2.7 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html took 0.5 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html took 0.4 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html took 0.3 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html took 0.3 seconds 15:34:07.115 52921 http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html took 0.3 seconds 15:34:07.115 52921 suggestd-53291 took 0.0 seconds 15:34:07.115 52921 suggestd-53097 took 0.0 seconds 15:34:07.115 52921 15:34:07.115 52921 Tests marked as SLOW: 15:34:07.115 52921 15:34:07.115 52921 Tests that timed out or crashed: 15:34:07.115 52921 15:34:07.115 52921 Time to process slowest subdirectories: 15:34:07.115 52921 took 0.0 seconds to run 2 tests. 15:34:07.115 52921 all_tests took 5.9 seconds to run 8 tests. 15:34:07.115 52921 15:34:07.115 52921 15:34:07.115 52921 15:34:07.115 52921 8 tests ran as expected, 2 didn't (-2 didn't run) 1153840 1 268547 aakash_jain 2016-01-08 09:21:04 -0800 Created attachment 268547 Proposed patch 1153842 2 ap 2016-01-08 09:31:08 -0800 It would be good to add a regression test for this. 1153843 3 aakash_jain 2016-01-08 09:34:23 -0800 ok, will add. 1153855 4 268547 commit-queue 2016-01-08 10:20:44 -0800 Comment on attachment 268547 Proposed patch Clearing flags on attachment: 268547 Committed r194768: <http://trac.webkit.org/changeset/194768> 1153856 5 commit-queue 2016-01-08 10:20:47 -0800 All reviewed patches have been landed. Closing bug. 268547 2016-01-08 09:21:04 -0800 2016-01-08 10:20:44 -0800 Proposed patch patch_count_test1 text/plain 1485 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDc2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE2LTAxLTA4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzIG1pcy1jb3VudHMgdG90YWxzIHdoZW4gdGhl cmUgYXJlIG90aGVyIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1Mjg5NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQwOTg2OTc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9ydW5fcmVzdWx0cy5weToKKyAgICAg ICAgKFRlc3RSdW5SZXN1bHRzLmFkZCk6IERvIG5vdCB1cGRhdGUgcmVzdWx0IGNvdW50ZXJzIGZv ciBvdGhlciBjcmFzaGVzLgorCiAyMDE2LTAxLTA4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZh YmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgd2Via2l0LXBhdGNoIGJ1aWxkLWFuZC10ZXN0 IHNob3VsZCBoYXZlIGFuIG9wdGlvbiB0byBpdGVyYXRlIG92ZXIgbmV3IHRlc3RzCkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMvdGVzdF9ydW5fcmVzdWx0 cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9ydW5fcmVzdWx0cy5weQkocmV2aXNpb24gMTk0NzY2KQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfcnVuX3Jlc3VsdHMucHkJKHdv cmtpbmcgY29weSkKQEAgLTY3LDYgKzY3LDggQEAgY2xhc3MgVGVzdFJ1blJlc3VsdHMob2JqZWN0 KToKICAgICBkZWYgYWRkKHNlbGYsIHRlc3RfcmVzdWx0LCBleHBlY3RlZCwgdGVzdF9pc19zbG93 KToKICAgICAgICAgc2VsZi50ZXN0c19ieV9leHBlY3RhdGlvblt0ZXN0X3Jlc3VsdC50eXBlXS5h ZGQodGVzdF9yZXN1bHQudGVzdF9uYW1lKQogICAgICAgICBzZWxmLnJlc3VsdHNfYnlfbmFtZVt0 ZXN0X3Jlc3VsdC50ZXN0X25hbWVdID0gdGVzdF9yZXN1bHQKKyAgICAgICAgaWYgdGVzdF9yZXN1 bHQuaXNfb3RoZXJfY3Jhc2g6CisgICAgICAgICAgICByZXR1cm4KICAgICAgICAgaWYgdGVzdF9y ZXN1bHQudHlwZSAhPSB0ZXN0X2V4cGVjdGF0aW9ucy5TS0lQOgogICAgICAgICAgICAgc2VsZi5h bGxfcmVzdWx0cy5hcHBlbmQodGVzdF9yZXN1bHQpCiAgICAgICAgIHNlbGYucmVtYWluaW5nIC09 IDEK