152885 2016-01-08 03:44:53 -0800 [mips] Fixed unused parameter warnings 2016-01-08 08:55:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1153792 0 annulen 2016-01-08 03:44:53 -0800 Fixed unused parameter warnings 1153793 1 268535 annulen 2016-01-08 03:48:28 -0800 Created attachment 268535 Patch 1153808 2 268535 mark.lam 2016-01-08 06:20:20 -0800 Comment on attachment 268535 Patch This looks like a bug. Applying this patch would cover up the bug. We should find out who is using these setupArgumentsWithExecState that is ignoring the TrustedImm32. 1153813 3 annulen 2016-01-08 06:31:07 -0800 Mark, it looked as bug for me too, but Julien Brianceau explained me that this is the dummy argument used to pass 64-bit arguments. Source/JavaScriptCore/jit/JITInlines.h:583 defines EABI_32BIT_DUMMY_ARG which is then used in setupArgumentsWithExecState invocations. 1153819 4 jbriance 2016-01-08 06:44:09 -0800 I see two solutions here: 1) We actually setup the dummy argument, which is not a big deal (one move opcode) 2) We add somethink like this instead to check that this is actually the expected EABI_32BIT_DUMMY_ARG. RELEASE_ASSERT(arg1.m_value == 0); 1153821 5 annulen 2016-01-08 07:00:27 -0800 Better option for (2) would be ASSERT_UNUSED(arg1, arg1.m_value == 0); 1153826 6 mark.lam 2016-01-08 08:04:10 -0800 (In reply to comment #5) > Better option for (2) would be ASSERT_UNUSED(arg1, arg1.m_value == 0); I've looked at the code some more and see that this is the current accepted practice for dealing with EABI_32BIT_DUMMY_ARG. I think there are better ways to do this, but the current patch is adequate. I will r+ the patch. 1153835 7 268535 commit-queue 2016-01-08 08:55:24 -0800 Comment on attachment 268535 Patch Clearing flags on attachment: 268535 Committed r194766: <http://trac.webkit.org/changeset/194766> 1153836 8 commit-queue 2016-01-08 08:55:27 -0800 All reviewed patches have been landed. Closing bug. 268535 2016-01-08 03:48:28 -0800 2016-01-08 08:55:24 -0800 Patch bug-152885-20160108144755.patch text/plain 1580 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzgxZGI4MzRjNDE5MjJjMzY2MjU3OTgwNGZhNzJlNTgwMmVmYzg3Li5iYmVkOWM1MjUwNDc3MjMw YzM5MzIwNDk1NWRhZWIzYTNkMWMwYmY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0wOCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEZpeGVkIHVudXNlZCBwYXJhbWV0ZXIgd2FybmluZ3MK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjg4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaml0L0ND YWxsSGVscGVycy5oOgorICAgICAgICAoSlNDOjpDQ2FsbEhlbHBlcnM6OnNldHVwQXJndW1lbnRz V2l0aEV4ZWNTdGF0ZSk6CisKIDIwMTYtMDEtMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBGVEwgQjMgbGF6eSBzbG93IHBhdGhzIHNob3VsZCBkbyBleGNlcHRp b25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0NDYWxsSGVscGVycy5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9DQ2FsbEhlbHBlcnMuaAppbmRleCA0YWY5YTYx ZTM2MWEyNTgxMWNlNWNhNmI1MjVhMzQ3NDgxYWJiODliLi44MjQzNDMwMjMwYmE4MTQ0Y2Y4Y2Q2 ZmY5MjFlMDBlMzhmZmEzZTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0 L0NDYWxsSGVscGVycy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQ0NhbGxIZWxw ZXJzLmgKQEAgLTEwOTgsMTIgKzEwOTgsMTIgQEAgcHVibGljOgogICAgICAgICBwb2tlKGFyZzMs IDQpOwogICAgIH0KIAotICAgIEFMV0FZU19JTkxJTkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhF eGVjU3RhdGUoVHJ1c3RlZEltbTMyIGFyZzEsIEZQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMykKKyAg ICBBTFdBWVNfSU5MSU5FIHZvaWQgc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKFRydXN0ZWRJ bW0zMiwgRlBSUmVnIGFyZzIsIEdQUlJlZyBhcmczKQogICAgIHsKICAgICAgICAgc2V0dXBBcmd1 bWVudHNXaXRoRXhlY1N0YXRlKGFyZzIsIGFyZzMpOwogICAgIH0KIAotICAgIEFMV0FZU19JTkxJ TkUgdm9pZCBzZXR1cEFyZ3VtZW50c1dpdGhFeGVjU3RhdGUoR1BSUmVnIGFyZzEsIEdQUlJlZyBh cmcyLCBUcnVzdGVkSW1tMzIgYXJnMywgRlBSUmVnIGFyZzQpCisgICAgQUxXQVlTX0lOTElORSB2 b2lkIHNldHVwQXJndW1lbnRzV2l0aEV4ZWNTdGF0ZShHUFJSZWcgYXJnMSwgR1BSUmVnIGFyZzIs IFRydXN0ZWRJbW0zMiwgRlBSUmVnIGFyZzQpCiAgICAgewogICAgICAgICBzZXR1cEFyZ3VtZW50 c1dpdGhFeGVjU3RhdGUoYXJnMSwgYXJnMiwgYXJnNCk7CiAgICAgfQo=