152884 2016-01-08 03:37:49 -0800 [mips] Max value of immediate arg of logical ops is 0xffff 2016-01-08 08:37:58 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1153790 0 annulen 2016-01-08 03:37:49 -0800 Replaced imm.m_value < 65535 checks with imm.m_value <= 65535 1153791 1 268534 annulen 2016-01-08 03:39:48 -0800 Created attachment 268534 Patch 1153794 2 268536 annulen 2016-01-08 03:50:27 -0800 Created attachment 268536 Patch 1153798 3 jbriance 2016-01-08 04:29:49 -0800 LGTM 1153823 4 268536 msaboff 2016-01-08 07:48:49 -0800 Comment on attachment 268536 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268536&action=review r=me > Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:292 > - else if (imm.m_value > 0 && imm.m_value < 65535 && !m_fixedWidth) > + else if (imm.m_value > 0 && imm.m_value <= 65535 && !m_fixedWidth) This is fine, but you could also write: else if ((imm.m_value & 0xffff) == imm.m_value) && !m_fixedWidth) 1153832 5 268536 commit-queue 2016-01-08 08:37:53 -0800 Comment on attachment 268536 Patch Clearing flags on attachment: 268536 Committed r194764: <http://trac.webkit.org/changeset/194764> 1153833 6 commit-queue 2016-01-08 08:37:58 -0800 All reviewed patches have been landed. Closing bug. 268534 2016-01-08 03:39:48 -0800 2016-01-08 03:50:20 -0800 Patch bug-152884-20160108143915.patch text/plain 2435 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzgxZGI4MzRjNDE5MjJjMzY2MjU3OTgwNGZhNzJlNTgwMmVmYzg3Li42MTZjMDM1YWY2MDk0YWM5 ZWQ0NmQ1OGZhMmUyOTVlOTgxNjQ4NTdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNi0wMS0wOCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIE1heCB2YWx1ZSBvZiBpbW1lZGlhdGUgYXJnIG9mIGxv Z2ljYWwgb3BzIGlzIDB4ZmZmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChK U0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YW5kMzIpOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt Ymxlck1JUFM6Om9yMzIpOgorCiAyMDE2LTAxLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBs ZS5jb20+CiAKICAgICAgICAgRlRMIEIzIGxhenkgc2xvdyBwYXRocyBzaG91bGQgZG8gZXhjZXB0 aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlck1JUFMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJNSVBTLmgKaW5kZXggOGY4M2E3OTc4Y2Q2MGViNTVhOTc2ZWRkZDU3ZDhhNmE4NDZmOTMw My4uMmRjNDIzZjA0YjdhOTBlYWZmM2MzNmY3OTkzM2IwNTU5OTY2Y2QyZCAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBA IC0yODksNyArMjg5LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgaWYgKCFpbW0ubV92YWx1 ZSAmJiAhbV9maXhlZFdpZHRoKQogICAgICAgICAgICAgbW92ZShNSVBTUmVnaXN0ZXJzOjp6ZXJv LCBkZXN0KTsKLSAgICAgICAgZWxzZSBpZiAoaW1tLm1fdmFsdWUgPiAwICYmIGltbS5tX3ZhbHVl IDwgNjU1MzUgJiYgIW1fZml4ZWRXaWR0aCkKKyAgICAgICAgZWxzZSBpZiAoaW1tLm1fdmFsdWUg PiAwICYmIGltbS5tX3ZhbHVlIDw9IDY1NTM1ICYmICFtX2ZpeGVkV2lkdGgpCiAgICAgICAgICAg ICBtX2Fzc2VtYmxlci5hbmRpKGRlc3QsIGRlc3QsIGltbS5tX3ZhbHVlKTsKICAgICAgICAgZWxz ZSB7CiAgICAgICAgICAgICAvKgpAQCAtMzA1LDcgKzMwNSw3IEBAIHB1YmxpYzoKICAgICB7CiAg ICAgICAgIGlmICghaW1tLm1fdmFsdWUgJiYgIW1fZml4ZWRXaWR0aCkKICAgICAgICAgICAgIG1v dmUoTUlQU1JlZ2lzdGVyczo6emVybywgZGVzdCk7Ci0gICAgICAgIGVsc2UgaWYgKGltbS5tX3Zh bHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8IDY1NTM1ICYmICFtX2ZpeGVkV2lkdGgpCisgICAgICAg IGVsc2UgaWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8PSA2NTUzNSAmJiAhbV9m aXhlZFdpZHRoKQogICAgICAgICAgICAgbV9hc3NlbWJsZXIuYW5kaShkZXN0LCBzcmMsIGltbS5t X3ZhbHVlKTsKICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICBtb3ZlKGltbSwgaW1tVGVtcFJl Z2lzdGVyKTsKQEAgLTM4MSw3ICszODEsNyBAQCBwdWJsaWM6CiAgICAgICAgIGlmICghaW1tLm1f dmFsdWUgJiYgIW1fZml4ZWRXaWR0aCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBp ZiAoaW1tLm1fdmFsdWUgPiAwICYmIGltbS5tX3ZhbHVlIDwgNjU1MzUKKyAgICAgICAgaWYgKGlt bS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8PSA2NTUzNQogICAgICAgICAgICAgJiYgIW1f Zml4ZWRXaWR0aCkgewogICAgICAgICAgICAgbV9hc3NlbWJsZXIub3JpKGRlc3QsIGRlc3QsIGlt bS5tX3ZhbHVlKTsKICAgICAgICAgICAgIHJldHVybjsKQEAgLTQwMiw3ICs0MDIsNyBAQCBwdWJs aWM6CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBpZiAoaW1tLm1f dmFsdWUgPiAwICYmIGltbS5tX3ZhbHVlIDwgNjU1MzUgJiYgIW1fZml4ZWRXaWR0aCkgeworICAg ICAgICBpZiAoaW1tLm1fdmFsdWUgPiAwICYmIGltbS5tX3ZhbHVlIDw9IDY1NTM1ICYmICFtX2Zp eGVkV2lkdGgpIHsKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLm9yaShkZXN0LCBzcmMsIGltbS5t X3ZhbHVlKTsKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQo= 268536 2016-01-08 03:50:27 -0800 2016-01-08 08:37:53 -0800 Patch bug-152884-20160108144955.patch text/plain 2508 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 MzgxZGI4MzRjNDE5MjJjMzY2MjU3OTgwNGZhNzJlNTgwMmVmYzg3Li40MjRjMTMxYWFlOTgyMDk3 OTVlZWRkYmViMzJiZjVkYmNhOTUyOTMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wMS0wOCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIE1heCB2YWx1ZSBvZiBpbW1lZGlhdGUgYXJnIG9mIGxv Z2ljYWwgb3BzIGlzIDB4ZmZmZgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyODg0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUmVwbGFjZWQgaW1tLm1fdmFsdWUgPCA2NTUzNSBjaGVja3Mgd2l0aCBpbW0u bV92YWx1ZSA8PSA2NTUzNQorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQ Uy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6OmFuZDMyKToKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjpvcjMyKToKKwogMjAxNi0wMS0wNyAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTCBCMyBsYXp5IHNsb3cgcGF0aHMg c2hvdWxkIGRvIGV4Y2VwdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCmluZGV4IDhmODNhNzk3OGNkNjBlYjU1YTk3NmVk ZGQ1N2Q4YTZhODQ2ZjkzMDMuLjJkYzQyM2YwNGI3YTkwZWFmZjNjMzZmNzk5MzNiMDU1OTk2NmNk MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJNSVBTLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fz c2VtYmxlck1JUFMuaApAQCAtMjg5LDcgKzI4OSw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgICAg IGlmICghaW1tLm1fdmFsdWUgJiYgIW1fZml4ZWRXaWR0aCkKICAgICAgICAgICAgIG1vdmUoTUlQ U1JlZ2lzdGVyczo6emVybywgZGVzdCk7Ci0gICAgICAgIGVsc2UgaWYgKGltbS5tX3ZhbHVlID4g MCAmJiBpbW0ubV92YWx1ZSA8IDY1NTM1ICYmICFtX2ZpeGVkV2lkdGgpCisgICAgICAgIGVsc2Ug aWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8PSA2NTUzNSAmJiAhbV9maXhlZFdp ZHRoKQogICAgICAgICAgICAgbV9hc3NlbWJsZXIuYW5kaShkZXN0LCBkZXN0LCBpbW0ubV92YWx1 ZSk7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgLyoKQEAgLTMwNSw3ICszMDUsNyBAQCBw dWJsaWM6CiAgICAgewogICAgICAgICBpZiAoIWltbS5tX3ZhbHVlICYmICFtX2ZpeGVkV2lkdGgp CiAgICAgICAgICAgICBtb3ZlKE1JUFNSZWdpc3RlcnM6Onplcm8sIGRlc3QpOwotICAgICAgICBl bHNlIGlmIChpbW0ubV92YWx1ZSA+IDAgJiYgaW1tLm1fdmFsdWUgPCA2NTUzNSAmJiAhbV9maXhl ZFdpZHRoKQorICAgICAgICBlbHNlIGlmIChpbW0ubV92YWx1ZSA+IDAgJiYgaW1tLm1fdmFsdWUg PD0gNjU1MzUgJiYgIW1fZml4ZWRXaWR0aCkKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmFuZGko ZGVzdCwgc3JjLCBpbW0ubV92YWx1ZSk7CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgbW92 ZShpbW0sIGltbVRlbXBSZWdpc3Rlcik7CkBAIC0zODEsNyArMzgxLDcgQEAgcHVibGljOgogICAg ICAgICBpZiAoIWltbS5tX3ZhbHVlICYmICFtX2ZpeGVkV2lkdGgpCiAgICAgICAgICAgICByZXR1 cm47CiAKLSAgICAgICAgaWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8IDY1NTM1 CisgICAgICAgIGlmIChpbW0ubV92YWx1ZSA+IDAgJiYgaW1tLm1fdmFsdWUgPD0gNjU1MzUKICAg ICAgICAgICAgICYmICFtX2ZpeGVkV2lkdGgpIHsKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLm9y aShkZXN0LCBkZXN0LCBpbW0ubV92YWx1ZSk7CiAgICAgICAgICAgICByZXR1cm47CkBAIC00MDIs NyArNDAyLDcgQEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAKLSAg ICAgICAgaWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8IDY1NTM1ICYmICFtX2Zp eGVkV2lkdGgpIHsKKyAgICAgICAgaWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1ZSA8 PSA2NTUzNSAmJiAhbV9maXhlZFdpZHRoKSB7CiAgICAgICAgICAgICBtX2Fzc2VtYmxlci5vcmko ZGVzdCwgc3JjLCBpbW0ubV92YWx1ZSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K