152879 2016-01-07 18:00:32 -0800 restoreCalleeSavesFromVMCalleeSavesBuffer should use the scratch register 2016-01-08 10:50:10 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam commit-queue keith_miller mark.lam msaboff oldest_to_newest 1153712 0 saam 2016-01-07 18:00:32 -0800 ... 1153716 1 268519 saam 2016-01-07 18:04:56 -0800 Created attachment 268519 patch 1153719 2 268519 mark.lam 2016-01-07 18:09:42 -0800 Comment on attachment 268519 patch View in context: https://bugs.webkit.org/attachment.cgi?id=268519&action=review > Source/JavaScriptCore/jit/AssemblyHelpers.cpp:539 > +#else > + UNUSED_PARAM(usedRegisters); Please remove. 1153872 3 saam 2016-01-08 10:50:10 -0800 landed in: http://trac.webkit.org/changeset/194772 268519 2016-01-07 18:04:56 -0800 2016-01-07 18:07:17 -0800 patch c-backup.diff text/plain 5309 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NzQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE2LTAxLTA3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHJlc3RvcmVDYWxsZWVTYXZlc0Zyb21WTUNhbGxlZVNhdmVzQnVmZmVyIHNob3VsZCB1c2UgdGhl IHNjcmF0Y2ggcmVnaXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1Mjg3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIHdlcmUgY2xvYmJlcmluZyBhIHJlZ2lzdGVyIHdlIG5lZWRlZCB3aGVuIHBp Y2tpbmcKKyAgICAgICAgYSBzY3JhdGNoIHJlZ2lzdGVyIGluc2lkZSBhbiBGVEwgT1NSIEV4aXQu CisKKyAgICAgICAgKiBkZmcvREZHVGh1bmtzLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpvc3JF bnRyeVRodW5rR2VuZXJhdG9yKToKKyAgICAgICAgKiBqaXQvQXNzZW1ibHlIZWxwZXJzLmNwcDoK KyAgICAgICAgKEpTQzo6QXNzZW1ibHlIZWxwZXJzOjplbWl0UmFuZG9tVGh1bmspOgorICAgICAg ICAoSlNDOjpBc3NlbWJseUhlbHBlcnM6OnJlc3RvcmVDYWxsZWVTYXZlc0Zyb21WTUNhbGxlZVNh dmVzQnVmZmVyKToKKyAgICAgICAgKiBqaXQvQXNzZW1ibHlIZWxwZXJzLmg6CisgICAgICAgIChK U0M6OkFzc2VtYmx5SGVscGVyczo6Y29weUNhbGxlZVNhdmVzRnJvbUZyYW1lT3JSZWdpc3RlclRv Vk1DYWxsZWVTYXZlc0J1ZmZlcik6CisgICAgICAgIChKU0M6OkFzc2VtYmx5SGVscGVyczo6cmVz dG9yZUNhbGxlZVNhdmVzRnJvbVZNQ2FsbGVlU2F2ZXNCdWZmZXIpOiBEZWxldGVkLgorICAgICAg ICAqIHRlc3RzL3N0cmVzcy9mdGwtcHV0LWJ5LWlkLXNldHRlci1leGNlcHRpb24taW50ZXJlc3Rp bmctbGl2ZS1zdGF0ZS5qczoKKyAgICAgICAgKGZvbyk6CisKIDIwMTYtMDEtMDcgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBGVEwgQjMgbGF6eSBzbG93IHBhdGhz IHNob3VsZCBkbyBleGNlcHRpb25zCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1RodW5rcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdU aHVua3MuY3BwCShyZXZpc2lvbiAxOTQ3NDcpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1RodW5rcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzNSw4ICsxMzUsNyBAQCBNYWNyb0Fz c2VtYmxlckNvZGVSZWYgb3NyRW50cnlUaHVua0dlbmVyCiAgICAgaml0LmFib3J0V2l0aFJlYXNv bihERkdVbnJlYXNvbmFibGVPU1JFbnRyeUp1bXBEZXN0aW5hdGlvbik7CiAKICAgICBvay5saW5r KCZqaXQpOwotICAgIFJlZ2lzdGVyU2V0IHVzZWRSZWdpc3RlcnMoUmVnaXN0ZXJTZXQ6OnN0dWJV bmF2YWlsYWJsZVJlZ2lzdGVycygpLCBHUFJJbmZvOjpyZWdUMSk7Ci0gICAgaml0LnJlc3RvcmVD YWxsZWVTYXZlc0Zyb21WTUNhbGxlZVNhdmVzQnVmZmVyKHVzZWRSZWdpc3RlcnMpOworICAgIGpp dC5yZXN0b3JlQ2FsbGVlU2F2ZXNGcm9tVk1DYWxsZWVTYXZlc0J1ZmZlcigpOwogICAgIGppdC5l bWl0TWF0ZXJpYWxpemVUYWdDaGVja1JlZ2lzdGVycygpOwogCiAgICAgaml0Lmp1bXAoR1BSSW5m bzo6cmVnVDEpOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBl cnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlI ZWxwZXJzLmNwcAkocmV2aXNpb24gMTk0NzQ3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2pp dC9Bc3NlbWJseUhlbHBlcnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MTcsNiArNTE3LDI5IEBA IHZvaWQgQXNzZW1ibHlIZWxwZXJzOjplbWl0UmFuZG9tVGh1bmsoR1AKIH0KICNlbmRpZgogCit2 b2lkIEFzc2VtYmx5SGVscGVyczo6cmVzdG9yZUNhbGxlZVNhdmVzRnJvbVZNQ2FsbGVlU2F2ZXNC dWZmZXIoKQoreworI2lmIE5VTUJFUl9PRl9DQUxMRUVfU0FWRVNfUkVHSVNURVJTID4gMAorICAg IGNoYXIqIHNvdXJjZUJ1ZmZlciA9IGJpdHdpc2VfY2FzdDxjaGFyKj4obV92bS0+Y2FsbGVlU2F2 ZVJlZ2lzdGVyc0J1ZmZlcik7CisKKyAgICBSZWdpc3RlckF0T2Zmc2V0TGlzdCogYWxsQ2FsbGVl U2F2ZXMgPSBtX3ZtLT5nZXRBbGxDYWxsZWVTYXZlUmVnaXN0ZXJPZmZzZXRzKCk7CisgICAgUmVn aXN0ZXJTZXQgZG9udFJlc3RvcmVSZWdpc3RlcnMgPSBSZWdpc3RlclNldDo6c3RhY2tSZWdpc3Rl cnMoKTsKKyAgICB1bnNpZ25lZCByZWdpc3RlckNvdW50ID0gYWxsQ2FsbGVlU2F2ZXMtPnNpemUo KTsKKyAgICAKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcmVnaXN0ZXJDb3VudDsgaSsr KSB7CisgICAgICAgIFJlZ2lzdGVyQXRPZmZzZXQgZW50cnkgPSBhbGxDYWxsZWVTYXZlcy0+YXQo aSk7CisgICAgICAgIGlmIChkb250UmVzdG9yZVJlZ2lzdGVycy5nZXQoZW50cnkucmVnKCkpKQor ICAgICAgICAgICAgY29udGludWU7CisgICAgICAgIGlmIChlbnRyeS5yZWcoKS5pc0dQUigpKQor ICAgICAgICAgICAgbG9hZFB0cihzdGF0aWNfY2FzdDx2b2lkKj4oc291cmNlQnVmZmVyICsgZW50 cnkub2Zmc2V0KCkpLCBlbnRyeS5yZWcoKS5ncHIoKSk7CisgICAgICAgIGVsc2UKKyAgICAgICAg ICAgIGxvYWREb3VibGUoVHJ1c3RlZEltbVB0cihzb3VyY2VCdWZmZXIgKyBlbnRyeS5vZmZzZXQo KSksIGVudHJ5LnJlZygpLmZwcigpKTsKKyAgICB9CisjZWxzZQorICAgIFVOVVNFRF9QQVJBTSh1 c2VkUmVnaXN0ZXJzKTsKKyNlbmRpZgorfQorCiB9IC8vIG5hbWVzcGFjZSBKU0MKIAogI2VuZGlm IC8vIEVOQUJMRShKSVQpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0Fzc2VtYmx5 SGVscGVycy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1i bHlIZWxwZXJzLmgJKHJldmlzaW9uIDE5NDc0NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvQXNzZW1ibHlIZWxwZXJzLmgJKHdvcmtpbmcgY29weSkKQEAgLTI5NywzMSArMjk3LDggQEAg cHVibGljOgogI2VuZGlmCiAgICAgfQogCi0gICAgdm9pZCByZXN0b3JlQ2FsbGVlU2F2ZXNGcm9t Vk1DYWxsZWVTYXZlc0J1ZmZlcihjb25zdCBUZW1wUmVnaXN0ZXJTZXQmIHVzZWRSZWdpc3RlcnMg PSB7IFJlZ2lzdGVyU2V0OjpzdHViVW5hdmFpbGFibGVSZWdpc3RlcnMoKSB9KQotICAgIHsKLSNp ZiBOVU1CRVJfT0ZfQ0FMTEVFX1NBVkVTX1JFR0lTVEVSUyA+IDAKLSAgICAgICAgR1BSUmVnIHRl bXAxID0gdXNlZFJlZ2lzdGVycy5nZXRGcmVlR1BSKDApOwotICAgICAgICAKLSAgICAgICAgbW92 ZShUcnVzdGVkSW1tUHRyKG1fdm0tPmNhbGxlZVNhdmVSZWdpc3RlcnNCdWZmZXIpLCB0ZW1wMSk7 CisgICAgdm9pZCByZXN0b3JlQ2FsbGVlU2F2ZXNGcm9tVk1DYWxsZWVTYXZlc0J1ZmZlcigpOwog Ci0gICAgICAgIFJlZ2lzdGVyQXRPZmZzZXRMaXN0KiBhbGxDYWxsZWVTYXZlcyA9IG1fdm0tPmdl dEFsbENhbGxlZVNhdmVSZWdpc3Rlck9mZnNldHMoKTsKLSAgICAgICAgUmVnaXN0ZXJTZXQgZG9u dFJlc3RvcmVSZWdpc3RlcnMgPSBSZWdpc3RlclNldDo6c3RhY2tSZWdpc3RlcnMoKTsKLSAgICAg ICAgdW5zaWduZWQgcmVnaXN0ZXJDb3VudCA9IGFsbENhbGxlZVNhdmVzLT5zaXplKCk7Ci0gICAg ICAgIAotICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgcmVnaXN0ZXJDb3VudDsgaSsr KSB7Ci0gICAgICAgICAgICBSZWdpc3RlckF0T2Zmc2V0IGVudHJ5ID0gYWxsQ2FsbGVlU2F2ZXMt PmF0KGkpOwotICAgICAgICAgICAgaWYgKGRvbnRSZXN0b3JlUmVnaXN0ZXJzLmdldChlbnRyeS5y ZWcoKSkpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICBpZiAoZW50cnku cmVnKCkuaXNHUFIoKSkKLSAgICAgICAgICAgICAgICBsb2FkUHRyKEFkZHJlc3ModGVtcDEsIGVu dHJ5Lm9mZnNldCgpKSwgZW50cnkucmVnKCkuZ3ByKCkpOwotICAgICAgICAgICAgZWxzZQotICAg ICAgICAgICAgICAgIGxvYWREb3VibGUoQWRkcmVzcyh0ZW1wMSwgZW50cnkub2Zmc2V0KCkpLCBl bnRyeS5yZWcoKS5mcHIoKSk7Ci0gICAgICAgIH0KLSNlbHNlCi0gICAgICAgIFVOVVNFRF9QQVJB TSh1c2VkUmVnaXN0ZXJzKTsKLSNlbmRpZgotICAgIH0KLSAgICAKICAgICB2b2lkIGNvcHlDYWxs ZWVTYXZlc0Zyb21GcmFtZU9yUmVnaXN0ZXJUb1ZNQ2FsbGVlU2F2ZXNCdWZmZXIoY29uc3QgVGVt cFJlZ2lzdGVyU2V0JiB1c2VkUmVnaXN0ZXJzID0geyBSZWdpc3RlclNldDo6c3R1YlVuYXZhaWxh YmxlUmVnaXN0ZXJzKCkgfSkKICAgICB7CiAjaWYgTlVNQkVSX09GX0NBTExFRV9TQVZFU19SRUdJ U1RFUlMgPiAwCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2Z0bC1w dXQtYnktaWQtc2V0dGVyLWV4Y2VwdGlvbi1pbnRlcmVzdGluZy1saXZlLXN0YXRlLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZnRsLXB1dC1ieS1p ZC1zZXR0ZXItZXhjZXB0aW9uLWludGVyZXN0aW5nLWxpdmUtc3RhdGUuanMJKHJldmlzaW9uIDE5 NDc0NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvZnRsLXB1dC1ieS1p ZC1zZXR0ZXItZXhjZXB0aW9uLWludGVyZXN0aW5nLWxpdmUtc3RhdGUuanMJKHdvcmtpbmcgY29w eSkKQEAgLTEsNiArMSwzIEBACi0vLyBUaGlzIGZhaWx1cmUgd2lsbCBiZSByZXNvbHZlZCBieSBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMjc5LgotLy9AIHNraXAK LQogZnVuY3Rpb24gZm9vKG8sIHApIHsKICAgICB2YXIgeCA9IDEwMDsKICAgICB2YXIgcmVzdWx0 ID0gMTAxOwo=