152876 2016-01-07 17:52:11 -0800 Correct missing EXT_sRGB Format Handling 2016-01-07 18:52:06 -0800 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build All All RESOLVED FIXED https://www.khronos.org/registry/webgl/sdk/tests/conformance/extensions/ext-sRGB.html?webglVersion=1&quiet=0) InRadar P2 Normal --- 109332 1 bfulgham bfulgham achristensen bfulgham commit-queue ddkilzer dino kondapallykalyan noam roger_fong webkit-bug-importer oldest_to_newest 1153705 0 bfulgham 2016-01-07 17:52:11 -0800 When we added EXT_sRGB support to WebGL in Bug 109332, a couple of places were missed for the case of using SRGB as a texture source. This was identified by the WebGL 1.0.4 test suite. 1153707 1 bfulgham 2016-01-07 17:53:12 -0800 <rdar://problem/23284389> 1153714 2 268518 bfulgham 2016-01-07 18:02:12 -0800 Created attachment 268518 Patch 1153715 3 commit-queue 2016-01-07 18:04:13 -0800 Attachment 268518 did not pass style-queue: ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1153723 4 ddkilzer 2016-01-07 18:18:21 -0800 (In reply to comment #3) > Attachment 268518 [details] did not pass style-queue: > > > ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507: enum > members should use InterCaps with an initial capital letter or initial 'k' > for C-style enums. [readability/enum_casing] [4] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Didn't I fix this? Maybe my check-style change wasn't broad enough. 1153725 5 ddkilzer 2016-01-07 18:21:03 -0800 (In reply to comment #4) > (In reply to comment #3) > > Attachment 268518 [details] did not pass style-queue: > > > > > > ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507: enum > > members should use InterCaps with an initial capital letter or initial 'k' > > for C-style enums. [readability/enum_casing] [4] > > Total errors found: 1 in 4 files > > > > > > If any of these errors are false positives, please file a bug against > > check-webkit-style. > > Didn't I fix this? Maybe my check-style change wasn't broad enough. Oh, not a 'k' constant. Different issue. 1153733 6 268518 commit-queue 2016-01-07 18:52:00 -0800 Comment on attachment 268518 Patch Clearing flags on attachment: 268518 Committed r194751: <http://trac.webkit.org/changeset/194751> 1153734 7 commit-queue 2016-01-07 18:52:06 -0800 All reviewed patches have been landed. Closing bug. 268518 2016-01-07 18:02:12 -0800 2016-01-07 18:52:00 -0800 Patch bug-152876-20160107180139.patch text/plain 3964 bfulgham SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDc0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTA3ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgbWlzc2luZyBF WFRfc1JHQiBGb3JtYXQgSGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1Mjg3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjMyODQzODk+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdGVk IGJ5IFdlYkdMIDEuMC40IHN1aXRlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NDb250ZXh0M0QuY3BwOgorICAgICAgICAoZ2V0RGF0YUZvcm1hdCk6IEhhbmRsZSBtaXNz aW5nIFNSR0IgYW5kIFNSR0JfQUxQSEEgY2FzZXMuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NDb250ZXh0M0QuaDogQWRkIG1pc3NpbmcgU1JHQl9BTFBIQSB2YWx1ZSBmcm9t IHRoZSBLaHJvbm9zIHN0YW5kYXJkLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW5n bC9HcmFwaGljc0NvbnRleHQzRE9wZW5HTC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQzRDo6dGV4SW1hZ2UyRCk6IEFkZCBhbiBhc3NlcnRpb24gdGhhdCB3ZSBhcmUgbm90 IGJlaW5nIGhhbmRlZAorICAgICAgICBhbiBpbnRlcm5hbCBmb3JtYXQgdG8gYSBtZXRob2QgdGhh dCB3b3JrcyB3aXRoIG5vcm1hbCBmb3JtYXRzLgorCiAyMDE2LTAxLTA3ICBKZXIgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtFTUVdIFNlY3VyZSBzdG9wIGluZm9ybWF0 aW9uIG5vdCB3cml0dGVuIHRvIGRpc2sKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5jcHAJKHJldmlzaW9uIDE5NDY5 OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjIsNiArNjIsMTIgQEAgR3JhcGhpY3NDb250ZXh0M0Q6 OkRhdGFGb3JtYXQgZ2V0RGF0YUZvcgogICAgICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpM VU1JTkFOQ0VfQUxQSEE6CiAgICAgICAgICAgICBkc3RGb3JtYXQgPSBHcmFwaGljc0NvbnRleHQz RDo6RGF0YUZvcm1hdFJBODsKICAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEdyYXBo aWNzQ29udGV4dDNEOjpTUkdCOgorICAgICAgICAgICAgZHN0Rm9ybWF0ID0gR3JhcGhpY3NDb250 ZXh0M0Q6OkRhdGFGb3JtYXRSR0I4OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2Ug R3JhcGhpY3NDb250ZXh0M0Q6OlNSR0JfQUxQSEE6CisgICAgICAgICAgICBkc3RGb3JtYXQgPSBH cmFwaGljc0NvbnRleHQzRDo6RGF0YUZvcm1hdFJHQkE4OworICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAg ICAgfQpAQCAtOTIsNiArOTgsMTIgQEAgR3JhcGhpY3NDb250ZXh0M0Q6OkRhdGFGb3JtYXQgZ2V0 RGF0YUZvcgogICAgICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpMVU1JTkFOQ0VfQUxQSEE6 CiAgICAgICAgICAgICBkc3RGb3JtYXQgPSBHcmFwaGljc0NvbnRleHQzRDo6RGF0YUZvcm1hdFJB MTZGOwogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6 OlNSR0I6CisgICAgICAgICAgICBkc3RGb3JtYXQgPSBHcmFwaGljc0NvbnRleHQzRDo6RGF0YUZv cm1hdFJHQjE2RjsKKyAgICAgICAgICAgIGJyZWFrOworICAgICAgICBjYXNlIEdyYXBoaWNzQ29u dGV4dDNEOjpTUkdCX0FMUEhBOgorICAgICAgICAgICAgZHN0Rm9ybWF0ID0gR3JhcGhpY3NDb250 ZXh0M0Q6OkRhdGFGb3JtYXRSR0JBMTZGOworICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGRl ZmF1bHQ6CiAgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgfQpAQCAt MTEzLDYgKzEyNSwxMiBAQCBHcmFwaGljc0NvbnRleHQzRDo6RGF0YUZvcm1hdCBnZXREYXRhRm9y CiAgICAgICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OkxVTUlOQU5DRV9BTFBIQToKICAgICAg ICAgICAgIGRzdEZvcm1hdCA9IEdyYXBoaWNzQ29udGV4dDNEOjpEYXRhRm9ybWF0UkEzMkY7CiAg ICAgICAgICAgICBicmVhazsKKyAgICAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6U1JHQjoK KyAgICAgICAgICAgIGRzdEZvcm1hdCA9IEdyYXBoaWNzQ29udGV4dDNEOjpEYXRhRm9ybWF0UkdC MzJGOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6 OlNSR0JfQUxQSEE6CisgICAgICAgICAgICBkc3RGb3JtYXQgPSBHcmFwaGljc0NvbnRleHQzRDo6 RGF0YUZvcm1hdFJHQkEzMkY7CisgICAgICAgICAgICBicmVhazsKICAgICAgICAgZGVmYXVsdDoK ICAgICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgICAgICB9CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE LmgJKHJldmlzaW9uIDE5NDY5OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkKQEAgLTUwNCw2ICs1MDQsNyBAQCBw dWJsaWM6CiAgICAgICAgIEZMT0FUX01BVDR4MyA9IDB4OEI2QSwKICAgICAgICAgU1JHQiA9IDB4 OEM0MCwKICAgICAgICAgU1JHQjggPSAweDhDNDEsCisgICAgICAgIFNSR0JfQUxQSEEgPSAweDhD NDIsCiAgICAgICAgIFNSR0I4X0FMUEhBOCA9IDB4OEM0MywKICAgICAgICAgQ09NUEFSRV9SRUZf VE9fVEVYVFVSRSA9IDB4ODg0RSwKICAgICAgICAgUkdCQTMyRiA9IDB4ODgxNCwKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9HcmFwaGljc0NvbnRleHQzRE9w ZW5HTC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbmdsL0dyYXBoaWNzQ29udGV4dDNET3BlbkdMLmNwcAkocmV2aXNpb24gMTk0Njk5KQorKysg U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL0dyYXBoaWNzQ29udGV4dDNE T3BlbkdMLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzU1LDYgKzM1NSw3IEBAIGJvb2wgR3JhcGhp Y3NDb250ZXh0M0Q6OnRleEltYWdlMkQoR0MzRGUKICAgICAgICAgdHlwZSA9IEdMX0hBTEZfRkxP QVRfQVJCOwogICAgIH0KIAorICAgIEFTU0VSVChmb3JtYXQgIT0gRXh0ZW5zaW9uczNEOjpTUkdC OF9BTFBIQThfRVhUKTsKICAgICBpZiAoZm9ybWF0ID09IEV4dGVuc2lvbnMzRDo6U1JHQl9BTFBI QV9FWFQpCiAgICAgICAgIG9wZW5HTEZvcm1hdCA9IEdMX1JHQkE7CiAgICAgZWxzZSBpZiAoZm9y bWF0ID09IEV4dGVuc2lvbnMzRDo6U1JHQl9FWFQpCg==