152862 2016-01-07 14:30:10 -0800 Add a waitUntilReady() step 2016-01-07 16:11:08 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jonlee jonlee cdumez commit-queue dino rniwa sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1153605 0 jonlee 2016-01-07 14:30:10 -0800 Allow benchmarks an opportunity to setup before running. 1153606 1 webkit-bug-importer 2016-01-07 14:30:20 -0800 <rdar://problem/24097315> 1153637 2 268498 jonlee 2016-01-07 15:13:23 -0800 Created attachment 268498 Patch 1153648 3 268498 sabouhallawa 2016-01-07 15:36:29 -0800 Comment on attachment 268498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review > PerformanceTests/Animometer/tests/resources/main.js:357 > + function resolveWhenFinished() { Just for consistency, can't we get rid of 'var self = this' and use something like var resolveWhenFinished = function() { .... }.bind(this); .... resolveWhenFinished(); 1153664 4 268498 jonlee 2016-01-07 15:55:03 -0800 Comment on attachment 268498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review >> PerformanceTests/Animometer/tests/resources/main.js:357 >> + function resolveWhenFinished() { > > Just for consistency, can't we get rid of 'var self = this' and use something like > > var resolveWhenFinished = function() { .... }.bind(this); > .... > > resolveWhenFinished(); Sure. 1153668 5 jonlee 2016-01-07 16:11:08 -0800 Committed r194743: <http://trac.webkit.org/changeset/194743> 268498 2016-01-07 15:13:23 -0800 2016-01-07 15:16:12 -0800 Patch bug-152862-20160107151251.patch text/plain 3910 jonlee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NzI3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0FuaW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMKaW5kZXggOTgzN2M1NzU0NjkzMWMzOTEw YzAxZGI5MjMwZDVkZGM0YWFkYzhkZC4uODc0YTExMThlOGFiYzRmNzljNDk3MGU5YzJhNmY3ODZh MzAyODRjMyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL3Jl c291cmNlcy9tYWluLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9y ZXNvdXJjZXMvbWFpbi5qcwpAQCAtMzUwLDE3ICszNTAsMjUgQEAgQmVuY2htYXJrLnByb3RvdHlw ZSA9CiAKICAgICBydW46IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHRoaXMuc3RhcnQoKTsK KyAgICAgICAgcmV0dXJuIHRoaXMud2FpdFVudGlsUmVhZHkoKS50aGVuKGZ1bmN0aW9uKCkgewor ICAgICAgICAgICAgdGhpcy5zdGFydCgpOworICAgICAgICAgICAgdmFyIHByb21pc2UgPSBuZXcg U2ltcGxlUHJvbWlzZTsKKyAgICAgICAgICAgIHZhciBzZWxmID0gdGhpczsKKyAgICAgICAgICAg IGZ1bmN0aW9uIHJlc29sdmVXaGVuRmluaXNoZWQoKSB7CisgICAgICAgICAgICAgICAgaWYgKHR5 cGVvZiBzZWxmLl9zdGF0ZSAhPSAidW5kZWZpbmVkIiAmJiAoc2VsZi5fc3RhdGUuY3VycmVudFN0 YWdlKCkgPT0gQmVuY2htYXJrU3RhdGUuc3RhZ2VzLkZJTklTSEVEKSkKKyAgICAgICAgICAgICAg ICAgICAgcmV0dXJuIHByb21pc2UucmVzb2x2ZShzZWxmLl9zYW1wbGVyKTsKKyAgICAgICAgICAg ICAgICBzZXRUaW1lb3V0KHJlc29sdmVXaGVuRmluaXNoZWQuYmluZChzZWxmKSwgNTApOworICAg ICAgICAgICAgfQogCi0gICAgICAgIHZhciBwcm9taXNlID0gbmV3IFNpbXBsZVByb21pc2U7Ci0g ICAgICAgIHZhciBzZWxmID0gdGhpczsKLSAgICAgICAgZnVuY3Rpb24gcmVzb2x2ZVdoZW5GaW5p c2hlZCgpIHsKLSAgICAgICAgICAgIGlmICh0eXBlb2Ygc2VsZi5fc3RhdGUgIT0gInVuZGVmaW5l ZCIgJiYgKHNlbGYuX3N0YXRlLmN1cnJlbnRTdGFnZSgpID09IEJlbmNobWFya1N0YXRlLnN0YWdl cy5GSU5JU0hFRCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuIHByb21pc2UucmVzb2x2ZShzZWxm Ll9zYW1wbGVyKTsKLSAgICAgICAgICAgIHNldFRpbWVvdXQocmVzb2x2ZVdoZW5GaW5pc2hlZC5i aW5kKHNlbGYpLCA1MCk7Ci0gICAgICAgIH0KKyAgICAgICAgICAgIHJlc29sdmVXaGVuRmluaXNo ZWQoKTsKKyAgICAgICAgICAgIHJldHVybiBwcm9taXNlOworICAgICAgICB9LmJpbmQodGhpcykp OworICAgIH0sCiAKLSAgICAgICAgcmVzb2x2ZVdoZW5GaW5pc2hlZCgpOworICAgIHdhaXRVbnRp bFJlYWR5OiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB2YXIgcHJvbWlzZSA9IG5ldyBTaW1w bGVQcm9taXNlOworICAgICAgICBwcm9taXNlLnJlc29sdmUoKTsKICAgICAgICAgcmV0dXJuIHBy b21pc2U7CiAgICAgfSwKIApkaWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVy L3Rlc3RzL3RlbXBsYXRlL3Jlc291cmNlcy90ZW1wbGF0ZS1jYW52YXMuanMgYi9QZXJmb3JtYW5j ZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvdGVtcGxhdGUvcmVzb3VyY2VzL3RlbXBsYXRlLWNhbnZh cy5qcwppbmRleCA0MjUwZTM5ODUyYzEyMzM4OTE1ODNlM2YxYjUxY2FjMTE3YmIxMWRlLi5kMzY4 NmYxNGE2NTEyMDgwODMwZWRlZmIxOGExODI1NTJmMjY0YWU0IDEwMDY0NAotLS0gYS9QZXJmb3Jt YW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvdGVtcGxhdGUvcmVzb3VyY2VzL3RlbXBsYXRlLWNh bnZhcy5qcworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0FuaW1vbWV0ZXIvdGVzdHMvdGVtcGxhdGUv cmVzb3VyY2VzL3RlbXBsYXRlLWNhbnZhcy5qcwpAQCAtNzIsOCArNzIsMjMgQEAgVGVtcGxhdGVD YW52YXNCZW5jaG1hcmsgPSBVdGlsaXRpZXMuY3JlYXRlU3ViY2xhc3MoQmVuY2htYXJrLAogICAg IGZ1bmN0aW9uKG9wdGlvbnMpCiAgICAgewogICAgICAgICBCZW5jaG1hcmsuY2FsbCh0aGlzLCBu ZXcgVGVtcGxhdGVDYW52YXNTdGFnZSgpLCBvcHRpb25zKTsKKyAgICB9LCB7CisKKyAgICAvLyBP dmVycmlkZSB0aGlzIGZ1bmN0aW9uIGlmIHRoZSBiZW5jaG1hcmsgbmVlZHMgdG8gd2FpdCBmb3Ig cmVzb3VyY2VzIHRvIGJlCisgICAgLy8gbG9hZGVkLgorICAgIC8vCisgICAgLy8gRGVmYXVsdCBp bXBsZW1lbnRhdGlvbiByZXR1cm5zIGEgcmVzb2x2ZWQgcHJvbWlzZSwgc28gdGhhdCB0aGUgYmVu Y2htYXJrCisgICAgLy8gYmVuY2htYXJrIHN0YXJ0cyByaWdodCBhd2F5LiBIZXJlJ3MgYW4gZXhh bXBsZSB3aGVyZSB3ZSdyZSB3YWl0aW5nIDUKKyAgICAvLyBzZWNvbmRzIGJlZm9yZSBzdGFydGlu ZyB0aGUgYmVuY2htYXJrLgorICAgIHdhaXRVbnRpbFJlYWR5OiBmdW5jdGlvbigpCisgICAgewor ICAgICAgICB2YXIgcHJvbWlzZSA9IG5ldyBTaW1wbGVQcm9taXNlOworICAgICAgICB3aW5kb3cu c2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIHByb21pc2UucmVzb2x2ZSgpOwor ICAgICAgICB9LCA1MDAwKTsKKyAgICAgICAgcmV0dXJuIHByb21pc2U7CiAgICAgfQotKTsKK30p OwogCiB3aW5kb3cuYmVuY2htYXJrQ2xhc3MgPSBUZW1wbGF0ZUNhbnZhc0JlbmNobWFyazsKIApk aWZmIC0tZ2l0IGEvUGVyZm9ybWFuY2VUZXN0cy9DaGFuZ2VMb2cgYi9QZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwppbmRleCA5NTY4Y2JlODU5ZDQwZDY0ODU0MDZkNzA5ODllZmRhNGJjZDU0MGEx Li42NTU4MWE0NDZkNjlkYWMzYzA1MGU0NTRlZmI2M2ZmMDIwNjQxMDMxIDEwMDY0NAotLS0gYS9Q ZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxvZworKysgYi9QZXJmb3JtYW5jZVRlc3RzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTAxLTA3ICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNv bT4KKworICAgICAgICBBZGQgYSB3YWl0VW50aWxSZWFkeSgpIHN0ZXAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjg2MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHdhaXRVbnRpbFJlYWR5KCkg Y2FsbGJhY2sgdGhhdCBsZXRzIHRoZSBiZW5jaG1hcmsgY29tcGxldGUKKyAgICAgICAgaXRzIHNl dHVwIGJlZm9yZSBydW5uaW5nIHRoZSBiZW5jaG1hcmsuCisKKyAgICAgICAgKiBBbmltb21ldGVy L3Rlc3RzL3Jlc291cmNlcy9tYWluLmpzOgorICAgICAgICAoQmVuY2htYXJrLnByb3RvdHlwZS5y dW4pOiBGaXJzdCBjYWxsIHdhaXRVbnRpbFJlYWR5LCB3aGljaCByZXR1cm5zCisgICAgICAgIGEg cHJvbWlzZS4gV2hlbiB0aGUgcHJvbWlzZSByZXNvbHZlcywgcnVuIGV2ZXJ5dGhpbmcgdGhhdCB3 YXMgaW4gdGhpcworICAgICAgICBmdW5jdGlvbi4KKyAgICAgICAgKEJlbmNobWFyay5wcm90b3R5 cGUud2FpdFVudGlsUmVhZHkpOiBEZWZhdWx0IGltcGxlbWVudGF0aW9uIHJldHVybnMKKyAgICAg ICAgYSByZXNvbHZlZCBwcm9taXNlLgorICAgICAgICAoQmVuY2htYXJrLnByb3RvdHlwZS5yZXNv bHZlV2hlbkZpbmlzaGVkKTogRGVsZXRlZC4KKyAgICAgICAgKiBBbmltb21ldGVyL3Rlc3RzL3Rl bXBsYXRlL3Jlc291cmNlcy90ZW1wbGF0ZS1jYW52YXMuanM6CisgICAgICAgIChuZXcuVGVtcGxh dGVDYW52YXNTdGFnZS53YWl0VW50aWxSZWFkeSk6IEV4YW1wbGUgb24gaG93IHRvIG92ZXJyaWRl LgorCiAyMDE2LTAxLTAzICBKb24gTGVlICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBV cGRhdGUgZGF0YSByZXBvcnRpbmcgYW5kIGFuYWx5c2lzCg==