152859 2016-01-07 14:16:44 -0800 Remove unused shouldAntialias parameter from GraphicsContext::computeLineBoundsAndAntialiasingModeForText() 2016-01-07 15:16:10 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zalan zalan commit-queue simon.fraser oldest_to_newest 1153588 0 zalan 2016-01-07 14:16:44 -0800 SSIA. 1153591 1 268488 zalan 2016-01-07 14:17:50 -0800 Created attachment 268488 Patch 1153594 2 268488 simon.fraser 2016-01-07 14:23:13 -0800 Comment on attachment 268488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268488&action=review > Source/WebCore/platform/graphics/GraphicsContext.h:553 > + FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&, float width, bool printing, Color&); Is Color an out param? 1153595 3 zalan 2016-01-07 14:24:23 -0800 (In reply to comment #2) > Comment on attachment 268488 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268488&action=review > > > Source/WebCore/platform/graphics/GraphicsContext.h:553 > > + FloatRect computeLineBoundsAndAntialiasingModeForText(const FloatPoint&, float width, bool printing, Color&); > > Is Color an out param? It is. 1153639 4 268488 commit-queue 2016-01-07 15:16:07 -0800 Comment on attachment 268488 Patch Clearing flags on attachment: 268488 Committed r194731: <http://trac.webkit.org/changeset/194731> 1153640 5 commit-queue 2016-01-07 15:16:10 -0800 All reviewed patches have been landed. Closing bug. 268488 2016-01-07 14:17:50 -0800 2016-01-07 15:16:07 -0800 Patch bug-152859-20160107141717.patch text/plain 6242 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2RkZWM0OGQ2M2U0MjIx YjA0OTU1MzU4YjI3ZWU0ZDU2NjUxZmU5NS4uNTIxNDRiZmEwZWJlYTk4OTFmNzcwMTQxOTUzNDdj MDQ2ZGVhN2E2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAxLTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBzaG91 bGRBbnRpYWxpYXMgcGFyYW1ldGVyIGZyb20gR3JhcGhpY3NDb250ZXh0Ojpjb21wdXRlTGluZUJv dW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JUZXh0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjg1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y29tcHV0ZUxpbmVCb3VuZHNBbmRBbnRpYWxpYXNp bmdNb2RlRm9yVGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250 ZXh0Lmg6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0Ojpjb21wdXRlTGlu ZUJvdW5kc0ZvclRleHQpOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3 TGluZXNGb3JUZXh0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0Nv bnRleHRDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmNvbXB1dGVM aW5lQm91bmRzRm9yVGV4dCk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmRy YXdMaW5lc0ZvclRleHQpOgorCiAyMDE2LTAxLTA2ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRmxvYXQgd2l0aCBtZWRpYSBxdWVyeSBwb3NpdGlvbmVkIGluY29y cmVjdGx5IGFmdGVyIHdpbmRvdyByZXNpemUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcAppbmRleCAwZDZiMzAwZTc1Mjg1YzE4 NWVkMmQ1MjliODY0MmExZmFmZGQ3YjcwLi4yZjkzYzMyMTMwMTM5ZjQ1ZWVhMmY0N2U4OTAwYWU2 MTg1Yzg5MDcxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dC5jcHAKQEAgLTcyMywxNyArNzIzLDEzIEBAIHZvaWQgR3JhcGhpY3ND b250ZXh0OjpwbGF0Zm9ybVN0cm9rZUVsbGlwc2UoY29uc3QgRmxvYXRSZWN0JiBlbGxpcHNlKQog fQogI2VuZGlmCiAKLUZsb2F0UmVjdCBHcmFwaGljc0NvbnRleHQ6OmNvbXB1dGVMaW5lQm91bmRz QW5kQW50aWFsaWFzaW5nTW9kZUZvclRleHQoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQsIGZsb2F0 IHdpZHRoLCBib29sIHByaW50aW5nLCBib29sJiBzaG91bGRBbnRpYWxpYXMsIENvbG9yJiBjb2xv cikKK0Zsb2F0UmVjdCBHcmFwaGljc0NvbnRleHQ6OmNvbXB1dGVMaW5lQm91bmRzQW5kQW50aWFs aWFzaW5nTW9kZUZvclRleHQoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQsIGZsb2F0IHdpZHRoLCBi b29sIHByaW50aW5nLCBDb2xvciYgY29sb3IpCiB7CiAgICAgRmxvYXRQb2ludCBvcmlnaW4gPSBw b2ludDsKICAgICBmbG9hdCB0aGlja25lc3MgPSBzdGQ6Om1heChzdHJva2VUaGlja25lc3MoKSwg MC41Zik7CiAKLSAgICBzaG91bGRBbnRpYWxpYXMgPSB0cnVlOwogICAgIGlmICghcHJpbnRpbmcp IHsKICAgICAgICAgQWZmaW5lVHJhbnNmb3JtIHRyYW5zZm9ybSA9IGdldENUTShHcmFwaGljc0Nv bnRleHQ6OkRlZmluaXRlbHlJbmNsdWRlRGV2aWNlU2NhbGUpOwotICAgICAgICBpZiAodHJhbnNm b3JtLnByZXNlcnZlc0F4aXNBbGlnbm1lbnQoKSkKLSAgICAgICAgICAgIHNob3VsZEFudGlhbGlh cyA9IGZhbHNlOwotCiAgICAgICAgIC8vIFRoaXMgY29kZSBhbHdheXMgZHJhd3MgYSBsaW5lIHRo YXQgaXMgYXQgbGVhc3Qgb25lLXBpeGVsIGxpbmUgaGlnaCwKICAgICAgICAgLy8gd2hpY2ggdGVu ZHMgdG8gdmlzdWFsbHkgb3ZlcndoZWxtIHRleHQgYXQgc21hbGwgc2NhbGVzLiBUbyBjb3VudGVy IHRoaXMKICAgICAgICAgLy8gZWZmZWN0LCBhbiBhbHBoYSBpcyBhcHBsaWVkIHRvIHRoZSB1bmRl cmxpbmUgY29sb3Igd2hlbiB0ZXh0IGlzIGF0IHNtYWxsIHNjYWxlcy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKaW5kZXggNTJiMWFk ODJiMmY4YTU4NzA4ZTk5ZTM2NmE3NmUyNTYyMGIyM2RlMC4uMGZkYTcyNWFiMjNiZjE2MjBhMDQ5 MDJjY2Q2YWQxZWQyYWRkZDJmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgKQEAgLTU1MCw3ICs1NTAsNyBAQCBwcml2YXRlOgog CiAgICAgdm9pZCBwbGF0Zm9ybUZpbGxSb3VuZGVkUmVjdChjb25zdCBGbG9hdFJvdW5kZWRSZWN0 JiwgY29uc3QgQ29sb3ImKTsKIAotICAgIEZsb2F0UmVjdCBjb21wdXRlTGluZUJvdW5kc0FuZEFu dGlhbGlhc2luZ01vZGVGb3JUZXh0KGNvbnN0IEZsb2F0UG9pbnQmLCBmbG9hdCB3aWR0aCwgYm9v bCBwcmludGluZywgYm9vbCYgc2hvdWxkQW50aWFsaWFzLCBDb2xvciYpOworICAgIEZsb2F0UmVj dCBjb21wdXRlTGluZUJvdW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JUZXh0KGNvbnN0IEZsb2F0 UG9pbnQmLCBmbG9hdCB3aWR0aCwgYm9vbCBwcmludGluZywgIENvbG9yJik7CiAKICAgICBHcmFw aGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGUqIG1fZGF0YTsKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fpcm8uY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0 Q2Fpcm8uY3BwCmluZGV4IDQ1YjE2NGM5MWYwZTIzODgyYjQ2NmViM2Y0MDdhNWU5ZTdhMmUxOTUu LjdiMTRkNjE4ZDUzZTNkMGIyOTYzYzZlMDI0NGFmZTNjZGNlNDEwZTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dENhaXJv LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGlj c0NvbnRleHRDYWlyby5jcHAKQEAgLTY0OCw5ICs2NDgsOCBAQCB2b2lkIEdyYXBoaWNzQ29udGV4 dDo6ZHJhd0ZvY3VzUmluZyhjb25zdCBWZWN0b3I8SW50UmVjdD4mIHJlY3RzLCBmbG9hdCB3aWR0 aCwgZgogCiBGbG9hdFJlY3QgR3JhcGhpY3NDb250ZXh0Ojpjb21wdXRlTGluZUJvdW5kc0ZvclRl eHQoY29uc3QgRmxvYXRQb2ludCYgb3JpZ2luLCBmbG9hdCB3aWR0aCwgYm9vbCBwcmludGluZykK IHsKLSAgICBib29sIGR1bW15Qm9vbDsKICAgICBDb2xvciBkdW1teUNvbG9yOwotICAgIHJldHVy biBjb21wdXRlTGluZUJvdW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JUZXh0KG9yaWdpbiwgd2lk dGgsIHByaW50aW5nLCBkdW1teUJvb2wsIGR1bW15Q29sb3IpOworICAgIHJldHVybiBjb21wdXRl TGluZUJvdW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JUZXh0KG9yaWdpbiwgd2lkdGgsIHByaW50 aW5nLCBkdW1teUNvbG9yKTsKIH0KIAogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdMaW5lRm9y VGV4dChjb25zdCBGbG9hdFBvaW50JiBvcmlnaW4sIGZsb2F0IHdpZHRoLCBib29sIHByaW50aW5n LCBib29sIGRvdWJsZVVuZGVybGluZXMpCkBAIC02NzEsOCArNjcwLDcgQEAgdm9pZCBHcmFwaGlj c0NvbnRleHQ6OmRyYXdMaW5lc0ZvclRleHQoY29uc3QgRmxvYXRQb2ludCYgcG9pbnQsIGNvbnN0 IERhc2hBcnJheSYKIAogICAgIENvbG9yIGxvY2FsU3Ryb2tlQ29sb3Ioc3Ryb2tlQ29sb3IoKSk7 CiAKLSAgICBib29sIHNob3VsZEFudGlhbGlhc0xpbmU7Ci0gICAgRmxvYXRSZWN0IGJvdW5kcyA9 IGNvbXB1dGVMaW5lQm91bmRzQW5kQW50aWFsaWFzaW5nTW9kZUZvclRleHQocG9pbnQsIHdpZHRo cy5sYXN0KCksIHByaW50aW5nLCBzaG91bGRBbnRpYWxpYXNMaW5lLCBsb2NhbFN0cm9rZUNvbG9y KTsKKyAgICBGbG9hdFJlY3QgYm91bmRzID0gY29tcHV0ZUxpbmVCb3VuZHNBbmRBbnRpYWxpYXNp bmdNb2RlRm9yVGV4dChwb2ludCwgd2lkdGhzLmxhc3QoKSwgcHJpbnRpbmcsIGxvY2FsU3Ryb2tl Q29sb3IpOwogCiAgICAgVmVjdG9yPEZsb2F0UmVjdCwgND4gZGFzaEJvdW5kczsKICAgICBBU1NF UlQoISh3aWR0aHMuc2l6ZSgpICUgMikpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCmluZGV4IDVhMzE3Y2Ez ZDIzNDA5OWRkZDRjZmNkMDQ2NmE2Y2ZlNzgzMjVmMjguLmU0OTA4NWEwOWI4ZTljNWE1NjkzNGFi ZTMxMjljNmUxYjJhZTM5MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHAKQEAgLTEzMjEsOSArMTMyMSw4 IEBAIEZsb2F0UmVjdCBHcmFwaGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhlbHMoY29uc3Qg RmxvYXRSZWN0JiByZWN0LCBSb3VuZGluZ01vCiAKIEZsb2F0UmVjdCBHcmFwaGljc0NvbnRleHQ6 OmNvbXB1dGVMaW5lQm91bmRzRm9yVGV4dChjb25zdCBGbG9hdFBvaW50JiBwb2ludCwgZmxvYXQg d2lkdGgsIGJvb2wgcHJpbnRpbmcpCiB7Ci0gICAgYm9vbCBkdW1teUJvb2w7CiAgICAgQ29sb3Ig ZHVtbXlDb2xvcjsKLSAgICByZXR1cm4gY29tcHV0ZUxpbmVCb3VuZHNBbmRBbnRpYWxpYXNpbmdN b2RlRm9yVGV4dChwb2ludCwgd2lkdGgsIHByaW50aW5nLCBkdW1teUJvb2wsIGR1bW15Q29sb3Ip OworICAgIHJldHVybiBjb21wdXRlTGluZUJvdW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JUZXh0 KHBvaW50LCB3aWR0aCwgcHJpbnRpbmcsIGR1bW15Q29sb3IpOwogfQogCiB2b2lkIEdyYXBoaWNz Q29udGV4dDo6ZHJhd0xpbmVGb3JUZXh0KGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBmbG9hdCB3 aWR0aCwgYm9vbCBwcmludGluZywgYm9vbCBkb3VibGVMaW5lcykKQEAgLTEzNDQsOCArMTM0Myw3 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3TGluZXNGb3JUZXh0KGNvbnN0IEZsb2F0UG9p bnQmIHBvaW50LCBjb25zdCBEYXNoQXJyYXkmCiAKICAgICBDb2xvciBsb2NhbFN0cm9rZUNvbG9y KHN0cm9rZUNvbG9yKCkpOwogCi0gICAgYm9vbCBzaG91bGRBbnRpYWxpYXNMaW5lOwotICAgIEZs b2F0UmVjdCBib3VuZHMgPSBjb21wdXRlTGluZUJvdW5kc0FuZEFudGlhbGlhc2luZ01vZGVGb3JU ZXh0KHBvaW50LCB3aWR0aHMubGFzdCgpLCBwcmludGluZywgc2hvdWxkQW50aWFsaWFzTGluZSwg bG9jYWxTdHJva2VDb2xvcik7CisgICAgRmxvYXRSZWN0IGJvdW5kcyA9IGNvbXB1dGVMaW5lQm91 bmRzQW5kQW50aWFsaWFzaW5nTW9kZUZvclRleHQocG9pbnQsIHdpZHRocy5sYXN0KCksIHByaW50 aW5nLCBsb2NhbFN0cm9rZUNvbG9yKTsKICAgICBib29sIGZpbGxDb2xvcklzTm90RXF1YWxUb1N0 cm9rZUNvbG9yID0gZmlsbENvbG9yKCkgIT0gbG9jYWxTdHJva2VDb2xvcjsKICAgICAKICAgICBW ZWN0b3I8Q0dSZWN0LCA0PiBkYXNoQm91bmRzOwo=