152858 2016-01-07 14:13:21 -0800 Web Inspector: Cannot undo in breakpoint editor 2016-09-06 12:58:39 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1153583 0 hi 2016-01-07 14:13:21 -0800 * STEPS TO REPRODUCE: 1. Create a breakpoint 2. Edit the breakpoint 3. Type some text 4. Press Cmd-Z * Expected Regular Undo functionality * Actual Crash... ------- Auto-generated details: Inspected URL: file:///Users/dcrousso/Documents/Projects/WebKit/WebKitBuild/Release/WebInspectorUI.framework/Resources/Main.html Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/602.1.15+ (KHTML, like Gecko) Uncaught exceptions: - TypeError: change.update is not a function. (In 'change.update(change.from, change.to, [newText])', 'change.update' is undefined) (at BreakpointPopoverController.js:242:22) ------- 1153584 1 webkit-bug-importer 2016-01-07 14:13:35 -0800 <rdar://problem/24096972> 1226586 2 287996 hi 2016-09-05 22:45:32 -0700 Created attachment 287996 Patch 1226789 3 287996 bburg 2016-09-06 12:36:27 -0700 Comment on attachment 287996 Patch r=me 1226796 4 287996 commit-queue 2016-09-06 12:58:35 -0700 Comment on attachment 287996 Patch Clearing flags on attachment: 287996 Committed r205499: <http://trac.webkit.org/changeset/205499> 1226797 5 commit-queue 2016-09-06 12:58:39 -0700 All reviewed patches have been landed. Closing bug. 287996 2016-09-05 22:45:32 -0700 2016-09-06 12:58:35 -0700 Patch bug-152858-20160905224310.patch text/plain 1900 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdhMDZmMDcxYTk5YjM1N2M0NjY0NGRjMWRhYWQx YWM5Y2IxN2EwYTYuLjdjNDUxOTM5MTBhZjBjZDIzMzVkYjhhYzA2ODU2MGIzOTliNGMzNzMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTA1ICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IENhbm5vdCB1bmRvIGluIGJyZWFrcG9pbnQgZWRpdG9yCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI4NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkJyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlci5wcm90b3R5cGUuX2NvbmRpdGlvbkNvZGVNaXJy b3JCZWZvcmVDaGFuZ2UpOgorICAgICAgICBTaW5jZSB0aGUgYnJlYWtwb2ludCBlZGl0b3Igb25s eSBhbGxvd3MgYSBzaW5nbGUgbGluZSBvZiBKYXZhU2NyaXB0LCBpdCBhdHRlbXB0cyB0byByZW1v dmUKKyAgICAgICAgYWxsICJcbiIgY2hhcmFjdGVycy4gIER1cmluZyBhbiAidW5kbyIgYWN0aW9u LCB0aGlzIGlzIG5vdCBwb3NzaWJsZS4KKwogMjAxNi0wOS0wNCAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVuYWJsZSBhbmQg ZW5mb3JjZSBzb21lIHJlY29tbWVuZGVkIGFuZCBzdHlsaXN0aWMgRVNMaW50IHJ1bGVzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9C cmVha3BvaW50UG9wb3ZlckNvbnRyb2xsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9Db250cm9sbGVycy9CcmVha3BvaW50UG9wb3ZlckNvbnRyb2xsZXIuanMKaW5k ZXggYWRhNTA1NDEyMDQ1NzM1ZjM2N2FkMjcyYmYyZTE2ZmViYTZkNzNjYy4uMWIzMGZjOThjMGJj YTc2YjBkZDc2YzY0ZmQyYzFkNmFlOTYzMGFmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQnJlYWtwb2ludFBvcG92ZXJDb250cm9s bGVyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0JyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlci5qcwpAQCAtMjM5LDggKzIzOSwxMSBAQCBX ZWJJbnNwZWN0b3IuQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyID0gY2xhc3MgQnJlYWtwb2lu dFBvcG92ZXJDb250cm9sbGVyIGV4dAogCiAgICAgX2NvbmRpdGlvbkNvZGVNaXJyb3JCZWZvcmVD aGFuZ2UoY29kZU1pcnJvciwgY2hhbmdlKQogICAgIHsKLSAgICAgICAgbGV0IG5ld1RleHQgPSBj aGFuZ2UudGV4dC5qb2luKCIiKS5yZXBsYWNlKC9cbi9nLCAiIik7Ci0gICAgICAgIGNoYW5nZS51 cGRhdGUoY2hhbmdlLmZyb20sIGNoYW5nZS50bywgW25ld1RleHRdKTsKKyAgICAgICAgaWYgKGNo YW5nZS51cGRhdGUpIHsKKyAgICAgICAgICAgIGxldCBuZXdUZXh0ID0gY2hhbmdlLnRleHQuam9p bigiIikucmVwbGFjZSgvXG4vZywgIiIpOworICAgICAgICAgICAgY2hhbmdlLnVwZGF0ZShjaGFu Z2UuZnJvbSwgY2hhbmdlLnRvLCBbbmV3VGV4dF0pOworICAgICAgICB9CisKICAgICAgICAgcmV0 dXJuIHRydWU7CiAgICAgfQogCg==