152838 2016-01-07 10:43:27 -0800 [mips] GPRInfo::toArgumentRegister missing 2016-01-07 12:00:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1153452 0 annulen 2016-01-07 10:43:27 -0800 Added missing GPRInfo::toArgumentRegister implementation for MIPS 1153455 1 268467 annulen 2016-01-07 10:46:02 -0800 Created attachment 268467 Patch 1153458 2 268467 msaboff 2016-01-07 10:51:49 -0800 Comment on attachment 268467 Patch We do not have plans to implement passing arguments in registers for 32 bit platforms. Therefore this is not needed. 1153469 3 annulen 2016-01-07 11:10:09 -0800 GPRInfo::toArgumentRegister is used at Source/JavaScriptCore/jit/CCallHelpers.h:58 which currently breaks compilation on MIPS BTW, MIPS32 has 32 GPRs so it would be the right thing to pass arguments via registers. 1153471 4 268467 msaboff 2016-01-07 11:17:47 -0800 Comment on attachment 268467 Patch r=me. Forgot that this is used in other areas. 1153473 5 msaboff 2016-01-07 11:21:10 -0800 (In reply to comment #3) > GPRInfo::toArgumentRegister is used at > Source/JavaScriptCore/jit/CCallHelpers.h:58 which currently breaks > compilation on MIPS > > BTW, MIPS32 has 32 GPRs so it would be the right thing to pass arguments via > registers. With only 4 argument registers, it still doesn't make sense to pass arguments in registers. Effectively this would only allow for "this" to be passed. a0 would have the callee, a1 would have the arg count, and a2/a3 would have the tag and payload for this. Even if we didn't pass the callee and arg count in registers, that would only give this and arg1. 1153493 6 268467 commit-queue 2016-01-07 12:00:25 -0800 Comment on attachment 268467 Patch Clearing flags on attachment: 268467 Committed r194709: <http://trac.webkit.org/changeset/194709> 1153494 7 commit-queue 2016-01-07 12:00:30 -0800 All reviewed patches have been landed. Closing bug. 268467 2016-01-07 10:46:02 -0800 2016-01-07 12:00:25 -0800 Patch bug-152838-20160107214529.patch text/plain 1422 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Njk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 MjIyZTk2OTZmZTcwYjUyYjgwYjIwMWE4NTQ3YTRkYWU3MzVkZTY3Li5jNmIwZTMzZTZmYTA3MTE3 NTQ2Y2EzZDk3ODZmZmZhNjdhZmQ1MjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0wNyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIEdQUkluZm86OnRvQXJndW1lbnRSZWdpc3RlciBtaXNz aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI4 MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpp dC9HUFJJbmZvLmg6CisgICAgICAgIChKU0M6OkdQUkluZm86OnRvQXJndW1lbnRSZWdpc3Rlcik6 CisKIDIwMTYtMDEtMDcgIEp1bGllbiBCcmlhbmNlYXUgIDxqYnJpYW5jZUBjaXNjby5jb20+CiAK ICAgICAgICAgW21pcHNdIEFkZCB0d28gbWlzc2luZyBhYm9ydFdpdGhSZWFzb24gaW1wbGVtZW50 YXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0dQUkluZm8uaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR1BSSW5mby5oCmluZGV4IDlmNjNkMmIxMGQwZWRm Y2Y5Y2NlNTg4NDAwZTE4YWExOTE0NjNlZWUuLmNkNmY2NzBjZmYwODY4MDRhMzU2NTFkODFmNmVm NzQ0ODBhZTcyZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR1BSSW5m by5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvR1BSSW5mby5oCkBAIC03NzAsNiAr NzcwLDEzIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIHJlZ2lzdGVyRm9ySW5kZXhbaW5kZXhd OwogICAgIH0KIAorICAgIHN0YXRpYyBHUFJSZWcgdG9Bcmd1bWVudFJlZ2lzdGVyKHVuc2lnbmVk IGluZGV4KQorICAgIHsKKyAgICAgICAgQVNTRVJUKGluZGV4IDwgbnVtYmVyT2ZBcmd1bWVudFJl Z2lzdGVycyk7CisgICAgICAgIHN0YXRpYyBjb25zdCBHUFJSZWcgcmVnaXN0ZXJGb3JJbmRleFtu dW1iZXJPZkFyZ3VtZW50UmVnaXN0ZXJzXSA9IHsgYXJndW1lbnRHUFIwLCBhcmd1bWVudEdQUjEs IGFyZ3VtZW50R1BSMiwgYXJndW1lbnRHUFIzIH07CisgICAgICAgIHJldHVybiByZWdpc3RlckZv ckluZGV4W2luZGV4XTsKKyAgICB9CisKICAgICBzdGF0aWMgdW5zaWduZWQgdG9JbmRleChHUFJS ZWcgcmVnKQogICAgIHsKICAgICAgICAgQVNTRVJUKHJlZyAhPSBJbnZhbGlkR1BSUmVnKTsK