152813 2016-01-06 16:25:14 -0800 Perf dashboard should auto-generate manifest file when one is missing 2016-02-16 13:53:47 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dewei_zhu jond kling koivisto rniwa slewis timothy oldest_to_newest 1153265 0 rniwa 2016-01-06 16:25:14 -0800 It's super annoying that one has to remember to open /admin/regenerate-manifest.php when cloning a database. The front-end code should do this automatically. 1153267 1 268421 rniwa 2016-01-06 16:27:57 -0800 Created attachment 268421 Fixes the bug 1153273 2 268421 cdumez 2016-01-06 16:56:13 -0800 Comment on attachment 268421 Fixes the bug r=me 1153275 3 rniwa 2016-01-06 16:57:23 -0800 Committed r194679: <http://trac.webkit.org/changeset/194679> 1153276 4 268421 rniwa 2016-01-06 16:57:55 -0800 Comment on attachment 268421 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=268421&action=review > Websites/perf.webkit.org/public/api/manifest.php:18 > + exit_with_success($generator->manifest()); Apparently I forgot to include the change to add Manifest::manifest. Landed the patch with that. 268421 2016-01-06 16:27:57 -0800 2016-01-06 16:56:13 -0800 Fixes the bug bug-152813-20160106162724.patch text/plain 6212 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0Njc4KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE2LTAxLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkIHNob3VsZCBhdXRvLWdlbmVyYXRlIG1hbmlmZXN0IGZp bGUgd2hlbiBvbmUgaXMgbWlzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUyODEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiAvZGF0YS9tYW5pZmVzdC5qc29uIGlzIG1pc3NpbmcsIGZhbGwg YmFjayB0byBuZXdseSBhZGRlZCAvYXBpL21hbmlmZXN0IGluc3RlYWQgb2YKKyAgICAgICAgc2ls ZW50bHkgZmFpbGluZyB0byBzaG93IHRoZSBVSS4gVGhpcyB3aWxsIG1ha2UgdGhlIGluaXRpYWwg c2V0dXAgZWFzaWVyLgorCisgICAgICAgICogcHVibGljL2FwaS9tYW5pZmVzdC5waHA6IEFkZGVk LgorICAgICAgICAobWFpbik6CisgICAgICAgICogcHVibGljL3YzL21haW4uanM6CisgICAgICAg IChmZXRjaE1hbmlmZXN0KToKKyAgICAgICAgKGRpZEZldGNoTWFuaWZlc3QpOiBFeHRyYWN0ZWQg ZnJvbSBmZXRjaE1hbmlmZXN0LgorCiAyMDE2LTAxLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3 ZWJraXQub3JnPgogCiAgICAgICAgIENvbW1pdCBhbm90aGVyIGZvcmdvdHRlbiBjaGFuZ2UsIHRo aXMgdGltZSwgZm9yIHIxOTQ2NTMuCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVi bGljL2FwaS9tYW5pZmVzdC5waHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQu b3JnL3B1YmxpYy9hcGkvbWFuaWZlc3QucGhwCShyZXZpc2lvbiAwKQorKysgV2Vic2l0ZXMvcGVy Zi53ZWJraXQub3JnL3B1YmxpYy9hcGkvbWFuaWZlc3QucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0w LDAgKzEsMjMgQEAKKzw/cGhwCisKK3JlcXVpcmVfb25jZSgnLi4vaW5jbHVkZS9qc29uLWhlYWRl ci5waHAnKTsKK3JlcXVpcmVfb25jZSgnLi4vaW5jbHVkZS9tYW5pZmVzdC5waHAnKTsKKworZnVu Y3Rpb24gbWFpbigpIHsKKyAgICAkZGIgPSBuZXcgRGF0YWJhc2U7CisgICAgaWYgKCEkZGItPmNv bm5lY3QoKSkKKyAgICAgICAgZXhpdF93aXRoX2Vycm9yKCdEYXRhYmFzZUNvbm5lY3Rpb25GYWls dXJlJyk7CisKKyAgICAkZ2VuZXJhdG9yID0gbmV3IE1hbmlmZXN0R2VuZXJhdG9yKCRkYik7Cisg ICAgaWYgKCEkZ2VuZXJhdG9yLT5nZW5lcmF0ZSgpKQorICAgICAgICBleGl0X3dpdGhfZXJyb3Io J0ZhaWxlZFRvR2VuZXJhdGVNYW5pZmVzdCcpOworCisgICAgaWYgKCEkZ2VuZXJhdG9yLT5zdG9y ZSgpKQorICAgICAgICBleGl0X3dpdGhfZXJyb3IoJ0ZhaWxlZFRvU3RvcmVNYW5pZmVzdCcpOwor CisgICAgZXhpdF93aXRoX3N1Y2Nlc3MoJGdlbmVyYXRvci0+bWFuaWZlc3QoKSk7Cit9CisKK21h aW4oKTsKKworPz4KSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbWFp bi5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21h aW4uanMJKHJldmlzaW9uIDE5NDY2MykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvbWFpbi5qcwkod29ya2luZyBjb3B5KQpAQCAtNTYsNTQgKzU2LDU5IEBAIGZ1bmN0aW9u IG1haW4oKSB7CiAKIGZ1bmN0aW9uIGZldGNoTWFuaWZlc3QoKQogewotICAgIHZhciBtYW5pZmVz dFVSTCA9ICcuLi9kYXRhL21hbmlmZXN0Lmpzb24nOwotCi0gICAgcmV0dXJuIGdldEpTT04obWFu aWZlc3RVUkwpLnRoZW4oZnVuY3Rpb24gKHJhd1Jlc3BvbnNlKSB7Ci0gICAgICAgIEluc3RydW1l bnRhdGlvbi5zdGFydE1lYXN1cmluZ1RpbWUoJ01hbmlmZXN0JywgJ2NvbnN0cnVjdG9yJyk7Cisg ICAgcmV0dXJuIGdldEpTT04oJy4uL2RhdGEvbWFuaWZlc3QuanNvbicpLnRoZW4oZGlkRmV0Y2hN YW5pZmVzdCwgZnVuY3Rpb24gKCkgeworICAgICAgICByZXR1cm4gZ2V0SlNPTignLi4vYXBpL21h bmlmZXN0LycpLnRoZW4oZGlkRmV0Y2hNYW5pZmVzdCwgZnVuY3Rpb24gKGVycm9yKSB7CisgICAg ICAgICAgICBhbGVydCgnRmFpbGVkIHRvIGxvYWQgdGhlIHNpdGUgbWFuaWZlc3Q6ICcgKyBlcnJv cik7CisgICAgICAgIH0pOworICAgIH0pOworfQogCi0gICAgICAgIHZhciB0ZXN0cyA9IFtdOwot ICAgICAgICB2YXIgdGVzdFBhcmVudE1hcCA9IHt9OwotICAgICAgICBmb3IgKHZhciB0ZXN0SWQg aW4gcmF3UmVzcG9uc2UudGVzdHMpIHsKLSAgICAgICAgICAgIHZhciB0ZXN0ID0gcmF3UmVzcG9u c2UudGVzdHNbdGVzdElkXTsKLSAgICAgICAgICAgIHZhciB0b3BMZXZlbCA9ICF0ZXN0LnBhcmVu dElkOwotICAgICAgICAgICAgaWYgKHRlc3QucGFyZW50SWQpCi0gICAgICAgICAgICAgICAgdGVz dFBhcmVudE1hcFt0ZXN0SWRdID0gcGFyc2VJbnQodGVzdC5wYXJlbnRJZCk7Ci0gICAgICAgICAg ICB0ZXN0cy5wdXNoKG5ldyBUZXN0KHRlc3RJZCwgdGVzdCwgdG9wTGV2ZWwpKTsKLSAgICAgICAg fQotICAgICAgICBmb3IgKHZhciB0ZXN0SWQgaW4gdGVzdFBhcmVudE1hcCkKLSAgICAgICAgICAg IFRlc3QuZmluZEJ5SWQodGVzdElkKS5zZXRQYXJlbnRUZXN0KFRlc3QuZmluZEJ5SWQodGVzdFBh cmVudE1hcFt0ZXN0SWRdKSk7CitmdW5jdGlvbiBkaWRGZXRjaE1hbmlmZXN0KHJhd1Jlc3BvbnNl KQoreworICAgIEluc3RydW1lbnRhdGlvbi5zdGFydE1lYXN1cmluZ1RpbWUoJ01haW4nLCAnZGlk RmV0Y2hNYW5pZmVzdCcpOwogCi0gICAgICAgIGZ1bmN0aW9uIGJ1aWxkT2JqZWN0c0Zyb21JZE1h cChpZE1hcCwgY29uc3RydWN0b3IsIHJlc29sdmVyKSB7Ci0gICAgICAgICAgICBmb3IgKHZhciBp ZCBpbiBpZE1hcCkgewotICAgICAgICAgICAgICAgIGlmIChyZXNvbHZlcikKLSAgICAgICAgICAg ICAgICAgICAgcmVzb2x2ZXIoaWRNYXBbaWRdKTsKLSAgICAgICAgICAgICAgICBuZXcgY29uc3Ry dWN0b3IoaWQsIGlkTWFwW2lkXSk7Ci0gICAgICAgICAgICB9CisgICAgdmFyIHRlc3RzID0gW107 CisgICAgdmFyIHRlc3RQYXJlbnRNYXAgPSB7fTsKKyAgICBmb3IgKHZhciB0ZXN0SWQgaW4gcmF3 UmVzcG9uc2UudGVzdHMpIHsKKyAgICAgICAgdmFyIHRlc3QgPSByYXdSZXNwb25zZS50ZXN0c1t0 ZXN0SWRdOworICAgICAgICB2YXIgdG9wTGV2ZWwgPSAhdGVzdC5wYXJlbnRJZDsKKyAgICAgICAg aWYgKHRlc3QucGFyZW50SWQpCisgICAgICAgICAgICB0ZXN0UGFyZW50TWFwW3Rlc3RJZF0gPSBw YXJzZUludCh0ZXN0LnBhcmVudElkKTsKKyAgICAgICAgdGVzdHMucHVzaChuZXcgVGVzdCh0ZXN0 SWQsIHRlc3QsIHRvcExldmVsKSk7CisgICAgfQorICAgIGZvciAodmFyIHRlc3RJZCBpbiB0ZXN0 UGFyZW50TWFwKQorICAgICAgICBUZXN0LmZpbmRCeUlkKHRlc3RJZCkuc2V0UGFyZW50VGVzdChU ZXN0LmZpbmRCeUlkKHRlc3RQYXJlbnRNYXBbdGVzdElkXSkpOworCisgICAgZnVuY3Rpb24gYnVp bGRPYmplY3RzRnJvbUlkTWFwKGlkTWFwLCBjb25zdHJ1Y3RvciwgcmVzb2x2ZXIpIHsKKyAgICAg ICAgZm9yICh2YXIgaWQgaW4gaWRNYXApIHsKKyAgICAgICAgICAgIGlmIChyZXNvbHZlcikKKyAg ICAgICAgICAgICAgICByZXNvbHZlcihpZE1hcFtpZF0pOworICAgICAgICAgICAgbmV3IGNvbnN0 cnVjdG9yKGlkLCBpZE1hcFtpZF0pOwogICAgICAgICB9Ci0gICAgICAgIGJ1aWxkT2JqZWN0c0Zy b21JZE1hcChyYXdSZXNwb25zZS5tZXRyaWNzLCBNZXRyaWMsIGZ1bmN0aW9uIChyYXcpIHsKLSAg ICAgICAgICAgIHJhdy50ZXN0ID0gVGVzdC5maW5kQnlJZChyYXcudGVzdCk7Ci0gICAgICAgIH0p OworICAgIH0KKyAgICBidWlsZE9iamVjdHNGcm9tSWRNYXAocmF3UmVzcG9uc2UubWV0cmljcywg TWV0cmljLCBmdW5jdGlvbiAocmF3KSB7CisgICAgICAgIHJhdy50ZXN0ID0gVGVzdC5maW5kQnlJ ZChyYXcudGVzdCk7CisgICAgfSk7CiAKLSAgICAgICAgYnVpbGRPYmplY3RzRnJvbUlkTWFwKHJh d1Jlc3BvbnNlLmFsbCwgUGxhdGZvcm0sIGZ1bmN0aW9uIChyYXcpIHsKLSAgICAgICAgICAgIHJh dy5sYXN0TW9kaWZpZWRCeU1ldHJpYyA9IHt9OwotICAgICAgICAgICAgcmF3Lmxhc3RNb2RpZmll ZC5mb3JFYWNoKGZ1bmN0aW9uIChsYXN0TW9kaWZpZWQsIGluZGV4KSB7Ci0gICAgICAgICAgICAg ICAgcmF3Lmxhc3RNb2RpZmllZEJ5TWV0cmljW3Jhdy5tZXRyaWNzW2luZGV4XV0gPSBsYXN0TW9k aWZpZWQ7Ci0gICAgICAgICAgICB9KTsKLSAgICAgICAgICAgIHJhdy5tZXRyaWNzID0gcmF3Lm1l dHJpY3MubWFwKGZ1bmN0aW9uIChpZCkgeyByZXR1cm4gTWV0cmljLmZpbmRCeUlkKGlkKTsgfSk7 Ci0gICAgICAgIH0pOwotICAgICAgICBidWlsZE9iamVjdHNGcm9tSWRNYXAocmF3UmVzcG9uc2Uu YnVpbGRlcnMsIEJ1aWxkZXIpOwotICAgICAgICBidWlsZE9iamVjdHNGcm9tSWRNYXAocmF3UmVz cG9uc2UucmVwb3NpdG9yaWVzLCBSZXBvc2l0b3J5KTsKLSAgICAgICAgYnVpbGRPYmplY3RzRnJv bUlkTWFwKHJhd1Jlc3BvbnNlLmJ1Z1RyYWNrZXJzLCBCdWdUcmFja2VyLCBmdW5jdGlvbiAocmF3 KSB7Ci0gICAgICAgICAgICByYXcucmVwb3NpdG9yaWVzID0gcmF3LnJlcG9zaXRvcmllcy5tYXAo ZnVuY3Rpb24gKGlkKSB7IHJldHVybiBSZXBvc2l0b3J5LmZpbmRCeUlkKGlkKTsgfSk7CisgICAg YnVpbGRPYmplY3RzRnJvbUlkTWFwKHJhd1Jlc3BvbnNlLmFsbCwgUGxhdGZvcm0sIGZ1bmN0aW9u IChyYXcpIHsKKyAgICAgICAgcmF3Lmxhc3RNb2RpZmllZEJ5TWV0cmljID0ge307CisgICAgICAg IHJhdy5sYXN0TW9kaWZpZWQuZm9yRWFjaChmdW5jdGlvbiAobGFzdE1vZGlmaWVkLCBpbmRleCkg eworICAgICAgICAgICAgcmF3Lmxhc3RNb2RpZmllZEJ5TWV0cmljW3Jhdy5tZXRyaWNzW2luZGV4 XV0gPSBsYXN0TW9kaWZpZWQ7CiAgICAgICAgIH0pOworICAgICAgICByYXcubWV0cmljcyA9IHJh dy5tZXRyaWNzLm1hcChmdW5jdGlvbiAoaWQpIHsgcmV0dXJuIE1ldHJpYy5maW5kQnlJZChpZCk7 IH0pOworICAgIH0pOworICAgIGJ1aWxkT2JqZWN0c0Zyb21JZE1hcChyYXdSZXNwb25zZS5idWls ZGVycywgQnVpbGRlcik7CisgICAgYnVpbGRPYmplY3RzRnJvbUlkTWFwKHJhd1Jlc3BvbnNlLnJl cG9zaXRvcmllcywgUmVwb3NpdG9yeSk7CisgICAgYnVpbGRPYmplY3RzRnJvbUlkTWFwKHJhd1Jl c3BvbnNlLmJ1Z1RyYWNrZXJzLCBCdWdUcmFja2VyLCBmdW5jdGlvbiAocmF3KSB7CisgICAgICAg IHJhdy5yZXBvc2l0b3JpZXMgPSByYXcucmVwb3NpdG9yaWVzLm1hcChmdW5jdGlvbiAoaWQpIHsg cmV0dXJuIFJlcG9zaXRvcnkuZmluZEJ5SWQoaWQpOyB9KTsKKyAgICB9KTsKIAotICAgICAgICBJ bnN0cnVtZW50YXRpb24uZW5kTWVhc3VyaW5nVGltZSgnTWFuaWZlc3QnLCAnY29uc3RydWN0b3In KTsKKyAgICBJbnN0cnVtZW50YXRpb24uZW5kTWVhc3VyaW5nVGltZSgnTWFpbicsICdkaWRGZXRj aE1hbmlmZXN0Jyk7CiAKLSAgICAgICAgcmV0dXJuIHsKLSAgICAgICAgICAgIHNpdGVUaXRsZTog cmF3UmVzcG9uc2Uuc2l0ZVRpdGxlLAotICAgICAgICAgICAgZGFzaGJvYXJkczogcmF3UmVzcG9u c2UuZGFzaGJvYXJkcywgLy8gRklYTUU6IEFkZCBhbiBhYnN0cmFjdGlvbiBhcm91bmQgZGFzaGJv YXJkcy4KLSAgICAgICAgfQotICAgIH0pOworICAgIHJldHVybiB7CisgICAgICAgIHNpdGVUaXRs ZTogcmF3UmVzcG9uc2Uuc2l0ZVRpdGxlLAorICAgICAgICBkYXNoYm9hcmRzOiByYXdSZXNwb25z ZS5kYXNoYm9hcmRzLCAvLyBGSVhNRTogQWRkIGFuIGFic3RyYWN0aW9uIGFyb3VuZCBkYXNoYm9h cmRzLgorICAgIH0KIH0KIAogaWYgKGRvY3VtZW50LnJlYWR5U3RhdGUgIT0gJ2xvYWRpbmcnKQo=