152812 2016-01-06 16:00:39 -0800 Perf dashboard JSON API should fail gracefully when postgres is down 2016-02-16 13:53:51 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu jond kling koivisto rniwa slewis timothy oldest_to_newest 1153263 0 rniwa 2016-01-06 16:00:39 -0800 Use '@' prefix so that we don't spit error messages by default. 1153264 1 268420 rniwa 2016-01-06 16:06:54 -0800 Created attachment 268420 Fixes the bug 1153277 2 268420 cdumez 2016-01-06 16:58:15 -0800 Comment on attachment 268420 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=268420&action=review r=me with nit. > Websites/perf.webkit.org/ChangeLog:3 > + Perf dashboard JSON API should gracefully when postgres is down Should gracefully what? 1153278 3 rniwa 2016-01-06 16:59:56 -0800 Thanks for the reviews. 1153279 4 rniwa 2016-01-06 17:00:41 -0800 Committed r194680: <http://trac.webkit.org/changeset/194680> 268420 2016-01-06 16:06:54 -0800 2016-01-06 16:58:15 -0800 Fixes the bug bug-152812-20160106160621.patch text/plain 1804 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0Njc4KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE2LTAxLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFBlcmYgZGFzaGJvYXJkIEpTT04gQVBJIHNob3VsZCBncmFjZWZ1bGx5IHdoZW4g cG9zdGdyZXMgaXMgZG93bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTUyODEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXZlbiB0aG91Z2ggYWxsIEpTT04gQVBJcyByZXR1cm5lZCBEYXRhYmFzZUNvbm5l Y3Rpb25GYWlsdXJlIGFzIHRoZSBzdGF0dXMgd2hlbiBEYXRhYmFzZTo6Y29ubmVjdAorICAgICAg ICByZXR1cm5lZCBhIGZhbHN5IHZhbHVlLCBQSFAgd2FzIHNwaXR0aW5nIG91dCB3YXJuaW5ncyBh bmQgcHJvZHVjaW5nIEhUVFAgcmVzcG9uc2VzIHRoYXQgY2Fubm90IGJlCisgICAgICAgIHBhcnNl ZCBhcyBhIEpTT04gd2hlbiBwZ19jb25uZWN0IGZhaWxlZC4KKworICAgICAgICBGaXhlZCB0aGUg YnVnIGJ5IHN1cHByZXNzaW5nIHdhcm5pbmcgbWVzc2FnZXMgaW4gcGdfY29ubmVjdC4KKworICAg ICAgICAqIHB1YmxpYy9pbmNsdWRlL2RiLnBocDoKKyAgICAgICAgKERhdGFiYXNlOjpjb25uZWN0 KTogVXNlICdAJyBwcmVmaXggdG8gc3VwcHJlc3Mgd2FybmluZyBtZXNzYWdlcy4KKwogMjAxNi0w MS0wNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDb21taXQg YW5vdGhlciBmb3Jnb3R0ZW4gY2hhbmdlLCB0aGlzIHRpbWUsIGZvciByMTk0NjUzLgpJbmRleDog V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL2RiLnBocAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUvZGIucGhwCShyZXZp c2lvbiAxOTQ2NjMpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUv ZGIucGhwCSh3b3JraW5nIGNvcHkpCkBAIC04Miw3ICs4Miw3IEBAIGNsYXNzIERhdGFiYXNlCiAK ICAgICBmdW5jdGlvbiBjb25uZWN0KCkgewogICAgICAgICAkZGF0YWJhc2VDb25maWcgPSBjb25m aWcoJ2RhdGFiYXNlJyk7Ci0gICAgICAgICR0aGlzLT5jb25uZWN0aW9uID0gcGdfY29ubmVjdCgn aG9zdD0nIC4gJGRhdGFiYXNlQ29uZmlnWydob3N0J10gLiAnIHBvcnQ9JyAuICRkYXRhYmFzZUNv bmZpZ1sncG9ydCddCisgICAgICAgICR0aGlzLT5jb25uZWN0aW9uID0gQHBnX2Nvbm5lY3QoJ2hv c3Q9JyAuICRkYXRhYmFzZUNvbmZpZ1snaG9zdCddIC4gJyBwb3J0PScgLiAkZGF0YWJhc2VDb25m aWdbJ3BvcnQnXQogICAgICAgICAgICAgLiAnIGRibmFtZT0nIC4gJGRhdGFiYXNlQ29uZmlnWydu YW1lJ10gLiAnIHVzZXI9JyAuICRkYXRhYmFzZUNvbmZpZ1sndXNlcm5hbWUnXSAuICcgcGFzc3dv cmQ9JyAuICRkYXRhYmFzZUNvbmZpZ1sncGFzc3dvcmQnXSk7CiAgICAgICAgIHJldHVybiAkdGhp cy0+Y29ubmVjdGlvbiA/IHRydWUgOiBmYWxzZTsKICAgICB9Cg==