152797 2016-01-06 12:23:29 -0800 REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests. 2016-02-03 02:31:41 -0800 1 1 1 Unclassified WebKit Platform Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=141835 P2 Normal --- 150800 1 clopez webkit-unassigned bugs-noreply cgarcia mcatanzaro pnormand oldest_to_newest 1153139 0 clopez 2016-01-06 12:23:29 -0800 Revision r191948 <http://trac.webkit.org/changeset/191948> has caused 4 new timeouts: Regressions: Unexpected timeouts (4) media/video-controls-no-scripting.html [ Timeout ] media/video-source-error.html [ Timeout ] media/video-source-load.html [ Timeout ] media/video-source-moved.html [ Timeout ] I have tested to build r191947 and r191948, and I can confirm that this 4 tests started to time out with r191948. Note: media/video-controls-no-scripting.html was failing before because of bug 141835 (but it was not timing out). 1158624 1 mcatanzaro 2016-01-25 17:27:07 -0800 Carlos, do you have time to look at this? 1158717 2 cgarcia 2016-01-25 23:11:21 -0800 No, but I'll find it. 1161255 3 270485 cgarcia 2016-02-02 06:00:34 -0800 Created attachment 270485 Patch This seems to be a problem in the very few cases that the gst bus sync handler is called form the main thread. We were avoiding scheduling to the main thread in that case, but for some reason the bus gets stalled or something. So always end the message to the main thread. This fixed the timeouts for me for media/video-source-load.html, media/video-source-moved.html and media/video-controls-no-scripting.html, the others timeout, but they also timeout for me reverting the patch. 1161460 4 270485 darin 2016-02-02 16:52:54 -0800 Comment on attachment 270485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270485&action=review > Source/WebCore/ChangeLog:9 > + sync hanlder was called in the main thread. It seems that typo: hanlder 1161461 5 270485 darin 2016-02-02 16:53:24 -0800 Comment on attachment 270485 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270485&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1906 > + GRefPtr<GstMessage> protectMessage(message); protectedMessage is a better name for this local variable, since it’s not just used to protect the message, but to send it across threads as well 1161623 6 cgarcia 2016-02-03 02:31:41 -0800 Committed r196060: <http://trac.webkit.org/changeset/196060> 270485 2016-02-02 06:00:34 -0800 2016-02-02 16:52:54 -0800 Patch wcore-gst-timeouts.diff text/plain 2275 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Nzk0MGM4Li43ODViNDgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMDItMDIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE5MTk0OCk6IFtHU3RyZWFtZXJdIDQgbmV3IHRpbWVv dXRzIG9uIGxheW91dCB0ZXN0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1Mjc5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFsd2F5cyBzY2hlZHVsZSBtZXNzYWdlcyB0byB0aGUgbWFpbiB0aHJlYWQs IGV2ZW4gd2hlbiB0aGUgYnVzCisgICAgICAgIHN5bmMgaGFubGRlciB3YXMgY2FsbGVkIGluIHRo ZSBtYWluIHRocmVhZC4gSXQgc2VlbXMgdGhhdAorICAgICAgICBHU3RyZWFtZXIgZXhwZWN0cyB0 aGluZ3MgdG8gaGFwcGVuIGluIHRoZSBuZXh0IG1haW4gbG9vcAorICAgICAgICBpdGVyYXRpb24u CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lcjo6Y3JlYXRlR1NUUGxheUJpbik6CisKIDIwMTYtMDItMDEgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFdlYktpdFdlYlZp ZXcgc2hvdWxkIHNlbmQgY3Jvc3NpbmcgZXZlbnRzIHRvIHRoZSBXZWJQcm9jZXNzCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5 ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGQ4ZjVkOWEu LjM3ZTU0OWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwCkBAIC0xOTAzLDE2ICsxOTAzLDEyIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjpjcmVhdGVHU1RQbGF5QmluKCkKICAgICAgICAgYXV0byYgcGxheWVyID0gKnN0YXRp Y19jYXN0PE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcio+KHVzZXJEYXRhKTsKIAogICAgICAg ICBpZiAoIXBsYXllci5oYW5kbGVTeW5jTWVzc2FnZShtZXNzYWdlKSkgewotICAgICAgICAgICAg aWYgKGlzTWFpblRocmVhZCgpKQotICAgICAgICAgICAgICAgIHBsYXllci5oYW5kbGVNZXNzYWdl KG1lc3NhZ2UpOwotICAgICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICAgICAgR1JlZlB0cjxH c3RNZXNzYWdlPiBwcm90ZWN0TWVzc2FnZShtZXNzYWdlKTsKLSAgICAgICAgICAgICAgICBhdXRv IHdlYWtUaGlzID0gcGxheWVyLmNyZWF0ZVdlYWtQdHIoKTsKLSAgICAgICAgICAgICAgICBSdW5M b29wOjptYWluKCkuZGlzcGF0Y2goW3dlYWtUaGlzLCBwcm90ZWN0TWVzc2FnZV0gewotICAgICAg ICAgICAgICAgICAgICBpZiAod2Vha1RoaXMpCi0gICAgICAgICAgICAgICAgICAgICAgICB3ZWFr VGhpcy0+aGFuZGxlTWVzc2FnZShwcm90ZWN0TWVzc2FnZS5nZXQoKSk7Ci0gICAgICAgICAgICAg ICAgfSk7Ci0gICAgICAgICAgICB9CisgICAgICAgICAgICBHUmVmUHRyPEdzdE1lc3NhZ2U+IHBy b3RlY3RNZXNzYWdlKG1lc3NhZ2UpOworICAgICAgICAgICAgYXV0byB3ZWFrVGhpcyA9IHBsYXll ci5jcmVhdGVXZWFrUHRyKCk7CisgICAgICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2go W3dlYWtUaGlzLCBwcm90ZWN0TWVzc2FnZV0geworICAgICAgICAgICAgICAgIGlmICh3ZWFrVGhp cykKKyAgICAgICAgICAgICAgICAgICAgd2Vha1RoaXMtPmhhbmRsZU1lc3NhZ2UocHJvdGVjdE1l c3NhZ2UuZ2V0KCkpOworICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KICAgICAgICAgZ3N0X21l c3NhZ2VfdW5yZWYobWVzc2FnZSk7CiAgICAgICAgIHJldHVybiBHU1RfQlVTX0RST1A7Cg==