15279 2007-09-25 11:50:04 -0700 Right clicking over text (or multiple spaces) auto selects the word (or multiple spaces) under it 2010-04-27 11:07:32 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) PC All RESOLVED FIXED InRadar P2 Normal --- 1 kuchhal webkit-unassigned aa anderson.calvin1 aroben dev+webkit eric fishd jesall lethalman88 mrowe tonikitoo oldest_to_newest 57011 0 kuchhal 2007-09-25 11:50:04 -0700 Due to changes made in WebCore/page/EventHandler.cpp at @24499 & @24561, when I right click on a page, the word under is auto selected and I don't see the correct context menu (Reload, View Source etc). Instead a selection based menu of Search with Google, Copy etc is shown. 57017 1 fishd 2007-09-25 12:59:35 -0700 At least, it seems broken that this happens when right clicking on a link. 57026 2 aroben 2007-09-25 13:44:15 -0700 As you can see in the ChangeLog comments from r24499 <http://trac.webkit.org/projects/webkit/changeset/24499>, this is actually expected behavior. If you click on something other than a block of text, no selection should be made and you should see the Reload/View Source menu as you expected. 57029 3 fishd 2007-09-25 14:12:26 -0700 Really? Even for hyperlinks? 57032 4 fishd 2007-09-25 14:23:50 -0700 This can't be wontfix. At least it is very broken behavior on Windows. Can we at least make it possible for embedders to define their own behavior here? 57035 5 mrowe 2007-09-25 14:29:39 -0700 The behaviour when ctrl-clicking on a link in WebKit differs from that in TextEdit, so I think this is worthy of some investigation. Ctrl-clicking on a link in TextEdit selects the entire URL, while in WebKit it only selects the word under the cursor. There may be issues with right-clicking on other platforms at well, but at the very least this issue exists on Mac OS as well. 57036 6 mrowe 2007-09-25 14:29:58 -0700 <rdar://problem/5450655> 57038 7 dev+webkit 2007-09-25 14:51:54 -0700 (In reply to comment #4) > At least it is very broken behavior on Windows. ToT on Windows behaves the same as ToT on Mac for me in regards to selection behavior and the contents of the context menu, etc. 73232 8 webkit 2008-03-10 13:18:58 -0700 *** Bug 17747 has been marked as a duplicate of this bug. *** 73234 9 webkit 2008-03-10 13:23:26 -0700 *** Bug 14399 has been marked as a duplicate of this bug. *** 76414 10 lethalman88 2008-04-06 02:24:41 -0700 On the GTK+ port there's the same problem. When i right-click it selects the words before the cursor. 82415 11 webkit 2008-06-06 03:24:29 -0700 *** Bug 19039 has been marked as a duplicate of this bug. *** 98525 12 25104 aa 2008-11-12 15:02:35 -0800 Created attachment 25104 Disables the word selection behavior for Chromium using an #ifdef. 98529 13 25104 aroben 2008-11-12 15:11:46 -0800 Comment on attachment 25104 Disables the word selection behavior for Chromium using an #ifdef. You should set the review flag to "r?" for new patches to indicate that your patch is ready to review. > +2008-11-12 aa <set EMAIL_ADDRESS environment variable> You should set the EMAIL_ADDRESS environment variable so that prepare-ChangeLog can fill in your email address correctly. You should also set the CHANGE_LOG_NAME environment variable to the name you want used in ChangeLogs. > + > + Reviewed by NOBODY (OOPS!). > + > + * page/EventHandler.cpp: > + (WebCore::EventHandler::sendContextMenuEvent): > + > + Disable word selection on context click for PLATFORM(CHROMIUM). Normally we reference the Bugzilla bug we're fixing in the ChangeLog. Something like this: Chromium fix for Bug 15279: Right clicking over text (or multiple spaces) auto selects the word (or multiple spaces) under it <https://bugs.webkit.org/show_bug.cgi?id=15279> > @@ -1627,8 +1627,9 @@ bool EventHandler::sendContextMenuEvent( > IntPoint viewportPos = v->windowToContents(event.pos()); > MouseEventWithHitTestResults mev = doc->prepareMouseEvent(HitTestRequest(false, true), viewportPos, event); > > - // Context menu events shouldn't select text in GTK+ applications. > -#if !PLATFORM(GTK) > + // Context menu events shouldn't select text in GTK+ applications or in Chromium. > + // TODO: This should probably be configurable by embedders. Consider making it a WebPreferences setting. We normally use FIXME instead of TODO. If you have filed the bug for WebPreferences you could reference it here with a URL. r=me -Adam 98538 14 aa 2008-11-12 15:28:51 -0800 Note: I talked about this on IRC with aroben. For now, we're going to change this using a macro, but in the future (perhaps when the Chromium mac team gets to this area), we should change it to use a WebPreferences setting. 98587 15 25117 aa 2008-11-12 22:57:31 -0800 Created attachment 25117 Disables the word selection behavior for Chromium, take 2 New patch. I believe I've addressed all your comments. 98615 16 25117 aroben 2008-11-13 07:26:45 -0800 Comment on attachment 25117 Disables the word selection behavior for Chromium, take 2 > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 38339) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,16 @@ > +2008-11-12 aa aa@chromium.org We normally use full names in ChangeLog headers, but this isn't a requirement. r=me 101048 17 eric 2008-12-02 12:38:33 -0800 Shouldn't this only be disabled for chromium on windows and linux? 105929 18 dglazkov 2009-01-15 11:31:25 -0800 Committed in https://bugs.webkit.org/show_bug.cgi?id=23351 New bug for solution with WebPreferences created: https://bugs.webkit.org/show_bug.cgi?id=23351 25104 2008-11-12 15:02:35 -0800 2008-12-02 12:38:04 -0800 Disables the word selection behavior for Chromium using an #ifdef. webkit_15279.patch text/plain 1614 aa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODMzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMTEtMTIgIGFhICA8c2V0IEVNQUlMX0FERFJFU1MgZW52aXJv bm1lbnQgdmFyaWFibGU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVu dEhhbmRsZXI6OnNlbmRDb250ZXh0TWVudUV2ZW50KToKKyAgICAgICAgCisgICAgICAgIERpc2Fi bGUgd29yZCBzZWxlY3Rpb24gb24gY29udGV4dCBjbGljayBmb3IgUExBVEZPUk0oQ0hST01JVU0p LgorCiAyMDA4LTExLTEyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQKSW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVu dEhhbmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw CShyZXZpc2lvbiAzODMxOCkKKysrIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjI3LDggKzE2MjcsOSBAQCBib29sIEV2ZW50SGFuZGxlcjo6c2VuZENv bnRleHRNZW51RXZlbnQoCiAgICAgSW50UG9pbnQgdmlld3BvcnRQb3MgPSB2LT53aW5kb3dUb0Nv bnRlbnRzKGV2ZW50LnBvcygpKTsKICAgICBNb3VzZUV2ZW50V2l0aEhpdFRlc3RSZXN1bHRzIG1l diA9IGRvYy0+cHJlcGFyZU1vdXNlRXZlbnQoSGl0VGVzdFJlcXVlc3QoZmFsc2UsIHRydWUpLCB2 aWV3cG9ydFBvcywgZXZlbnQpOwogCi0gICAgLy8gQ29udGV4dCBtZW51IGV2ZW50cyBzaG91bGRu J3Qgc2VsZWN0IHRleHQgaW4gR1RLKyBhcHBsaWNhdGlvbnMuCi0jaWYgIVBMQVRGT1JNKEdUSykK KyAgICAvLyBDb250ZXh0IG1lbnUgZXZlbnRzIHNob3VsZG4ndCBzZWxlY3QgdGV4dCBpbiBHVEsr IGFwcGxpY2F0aW9ucyBvciBpbiBDaHJvbWl1bS4KKyAgICAvLyBUT0RPOiBUaGlzIHNob3VsZCBw cm9iYWJseSBiZSBjb25maWd1cmFibGUgYnkgZW1iZWRkZXJzLiBDb25zaWRlciBtYWtpbmcgaXQg YSBXZWJQcmVmZXJlbmNlcyBzZXR0aW5nLgorI2lmICFQTEFURk9STShHVEspICYmICFQTEFURk9S TShDSFJPTUlVTSkKICAgICBpZiAoIW1fZnJhbWUtPnNlbGVjdGlvbigpLT5jb250YWlucyh2aWV3 cG9ydFBvcykgJiYgCiAgICAgICAgIC8vIEZJWE1FOiBJbiB0aGUgZWRpdGFibGUgY2FzZSwgd29y ZCBzZWxlY3Rpb24gc29tZXRpbWVzIHNlbGVjdHMgY29udGVudCB0aGF0IGlzbid0IHVuZGVybmVh dGggdGhlIG1vdXNlLgogICAgICAgICAvLyBJZiB0aGUgc2VsZWN0aW9uIGlzIG5vbi1lZGl0YWJs ZSwgd2UgZG8gd29yZCBzZWxlY3Rpb24gdG8gbWFrZSBpdCBlYXNpZXIgdG8gdXNlIHRoZSBjb250 ZXh0dWFsIG1lbnUgaXRlbXMK 25117 2008-11-12 22:57:31 -0800 2008-11-13 07:26:45 -0800 Disables the word selection behavior for Chromium, take 2 webkit_15279.patch text/plain 1834 aa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODMzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDgtMTEtMTIgIGFhICBhYUBjaHJvbWl1bS5vcmcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNzkKKworICAgICAgICBDaHJvbWl1bSBmaXggZm9y IEJ1ZyAxNTI3OTogUmlnaHQgY2xpY2tpbmcgb3ZlciB0ZXh0IChvciBtdWx0aXBsZSBzcGFjZXMp IGF1dG8KKyAgICAgICAgc2VsZWN0cyB0aGUgd29yZCAob3IgbXVsdGlwbGUgc3BhY2VzKSB1bmRl ciBpdAorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RXZlbnRIYW5kbGVyOjpzZW5kQ29udGV4dE1lbnVFdmVudCk6CisgICAgICAgIERvbid0IHNl bGVjdCB3b3JkcyBvbiByaWdodC1jbGljayBvbiBDaHJvbWl1bS4KKyAgICAgICAgCiAyMDA4LTEx LTEyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IERhdmUgSHlhdHQKSW5kZXg6IFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCShyZXZpc2lvbiAz ODMxOCkKKysrIFdlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNjI3LDggKzE2MjcsMTAgQEAgYm9vbCBFdmVudEhhbmRsZXI6OnNlbmRDb250ZXh0TWVudUV2 ZW50KAogICAgIEludFBvaW50IHZpZXdwb3J0UG9zID0gdi0+d2luZG93VG9Db250ZW50cyhldmVu dC5wb3MoKSk7CiAgICAgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyBtZXYgPSBkb2MtPnBy ZXBhcmVNb3VzZUV2ZW50KEhpdFRlc3RSZXF1ZXN0KGZhbHNlLCB0cnVlKSwgdmlld3BvcnRQb3Ms IGV2ZW50KTsKIAotICAgIC8vIENvbnRleHQgbWVudSBldmVudHMgc2hvdWxkbid0IHNlbGVjdCB0 ZXh0IGluIEdUSysgYXBwbGljYXRpb25zLgotI2lmICFQTEFURk9STShHVEspCisgICAgLy8gQ29u dGV4dCBtZW51IGV2ZW50cyBzaG91bGRuJ3Qgc2VsZWN0IHRleHQgaW4gR1RLKyBhcHBsaWNhdGlv bnMgb3IgaW4gQ2hyb21pdW0uCisgICAgLy8gRklYTUU6IFRoaXMgc2hvdWxkIHByb2JhYmx5IGJl IGNvbmZpZ3VyYWJsZSBieSBlbWJlZGRlcnMuIENvbnNpZGVyIG1ha2luZyBpdCBhIFdlYlByZWZl cmVuY2VzIHNldHRpbmcuCisgICAgLy8gU2VlOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNzkKKyNpZiAhUExBVEZPUk0oR1RLKSAmJiAhUExBVEZPUk0oQ0hST01J VU0pCiAgICAgaWYgKCFtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+Y29udGFpbnModmlld3BvcnRQb3Mp ICYmIAogICAgICAgICAvLyBGSVhNRTogSW4gdGhlIGVkaXRhYmxlIGNhc2UsIHdvcmQgc2VsZWN0 aW9uIHNvbWV0aW1lcyBzZWxlY3RzIGNvbnRlbnQgdGhhdCBpc24ndCB1bmRlcm5lYXRoIHRoZSBt b3VzZS4KICAgICAgICAgLy8gSWYgdGhlIHNlbGVjdGlvbiBpcyBub24tZWRpdGFibGUsIHdlIGRv IHdvcmQgc2VsZWN0aW9uIHRvIG1ha2UgaXQgZWFzaWVyIHRvIHVzZSB0aGUgY29udGV4dHVhbCBt ZW51IGl0ZW1zCg==