152785 2016-01-06 04:24:01 -0800 [mips] Add missing branchAdd32 implementation in macro assembler 2016-01-16 03:25:21 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance webkit-unassigned annulen commit-queue Jeffrey.li keith_miller mark.lam msaboff saam oldest_to_newest 1153027 0 jbriance 2016-01-06 04:24:01 -0800 In mips macro assembler, branchAdd32(ResultCondition cond, Address src, RegisterID dest) implementation is missing. 1153028 1 268366 jbriance 2016-01-06 04:26:33 -0800 Created attachment 268366 Add missing branchAdd32 implementation in mips macro assembler Note: already contributed in qtwekbit http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=946088cf515ec30de586392ec72e4658b86650a4 1153057 2 268366 msaboff 2016-01-06 09:44:55 -0800 Comment on attachment 268366 Add missing branchAdd32 implementation in mips macro assembler r=me 1153169 3 jbriance 2016-01-06 12:57:05 -0800 Manually committed r194639: http://trac.webkit.org/changeset/194639 1156157 4 jbriance 2016-01-16 03:25:21 -0800 *** Bug 145247 has been marked as a duplicate of this bug. *** 268366 2016-01-06 04:26:33 -0800 2016-01-06 09:44:55 -0800 Add missing branchAdd32 implementation in mips macro assembler bug-152785.patch text/plain 1369 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NjM2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE2LTAxLTA2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBBZGQgbWlzc2luZyBicmFuY2hBZGQzMiBpbXBsZW1lbnRhdGlvbiBpbiBt YWNybyBhc3NlbWJsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1Mjc4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpN YWNyb0Fzc2VtYmxlck1JUFM6OmJyYW5jaEFkZDMyKToKKwogMjAxNi0wMS0wNiAgQW5keSBWYW5X YWdvbmVyICA8dGhldGFsZWNyYWZ0ZXJAZ21haWwuY29tPgogCiAgICAgICAgIFtFUzZdIERhdGUu cHJvdG90eXBlIHNob3VsZCBiZSBhIHBsYWluIG9iamVjdApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShyZXZpc2lv biAxOTQ2MzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyTUlQUy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjY0LDYgKzE2NjQsMTIgQEAgcHVibGljOgog ICAgICAgICByZXR1cm4gYnJhbmNoQWRkMzIoY29uZCwgaW1tVGVtcFJlZ2lzdGVyLCBkZXN0KTsK ICAgICB9CiAKKyAgICBKdW1wIGJyYW5jaEFkZDMyKFJlc3VsdENvbmRpdGlvbiBjb25kLCBBZGRy ZXNzIGFkZHJlc3MsIFJlZ2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAgICAgIGxvYWQzMihhZGRy ZXNzLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICByZXR1cm4gYnJhbmNoQWRkMzIoY29uZCwg aW1tVGVtcFJlZ2lzdGVyLCBkZXN0KTsKKyAgICB9CisKICAgICBKdW1wIGJyYW5jaEFkZDMyKFJl c3VsdENvbmRpdGlvbiBjb25kLCBSZWdpc3RlcklEIHNyYywgVHJ1c3RlZEltbTMyIGltbSwgUmVn aXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAgICAgbW92ZShpbW0sIGltbVRlbXBSZWdpc3Rlcik7 Cg==