152782 2016-01-06 02:57:49 -0800 [mips] Fix bug in branchTruncateDoubleToUint32() implementation 2016-01-06 10:10:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance jbriance annulen commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1153017 0 jbriance 2016-01-06 02:57:49 -0800 In mips macro assembler, the branchTruncateDoubleToUint32(FPRegisterID, RegisterID, BranchTruncateType) implementation is incorrect. 1153018 1 268364 jbriance 2016-01-06 03:00:09 -0800 Created attachment 268364 Fix branchTruncateDoubleToUint32 mips implementation in macro assembler Note: already contributed in qtwekbit http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=2d9ed318a21f6102dddc0b91de2698908a9b8efc 1153064 2 268364 commit-queue 2016-01-06 10:10:43 -0800 Comment on attachment 268364 Fix branchTruncateDoubleToUint32 mips implementation in macro assembler Clearing flags on attachment: 268364 Committed r194641: <http://trac.webkit.org/changeset/194641> 1153065 3 commit-queue 2016-01-06 10:10:47 -0800 All reviewed patches have been landed. Closing bug. 268364 2016-01-06 03:00:09 -0800 2016-01-06 10:10:43 -0800 Fix branchTruncateDoubleToUint32 mips implementation in macro assembler bug-152782.patch text/plain 1478 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NjM1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTAxLTA2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBGaXggYnJhbmNoVHJ1bmNhdGVEb3VibGVUb1VpbnQzMiBpbXBsZW1lbnRh dGlvbiBpbiBtYWNybyBhc3NlbWJsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1Mjc4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFscmVhZHkgY292ZXJlZCBieSBMYXlvdXRUZXN0cy9qcy9kZmctdWlu dDMyYXJyYXktb3ZlcmZsb3ctdmFsdWVzIHRlc3QuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YnJh bmNoVHJ1bmNhdGVEb3VibGVUb1VpbnQzMik6CisKIDIwMTYtMDEtMDYgIEJlbmphbWluIFBvdWxh aW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gR2V0IG1vcmUgb2YgdGVz dGIzIHRvIHBhc3Mgb24gQVJNNjQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAkocmV2aXNpb24gMTk0NjM0KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAkod29y a2luZyBjb3B5KQpAQCAtMjY4Myw3ICsyNjgzLDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAg bV9hc3NlbWJsZXIudHJ1bmN3ZChmcFRlbXBSZWdpc3Rlciwgc3JjKTsKICAgICAgICAgbV9hc3Nl bWJsZXIubWZjMShkZXN0LCBmcFRlbXBSZWdpc3Rlcik7Ci0gICAgICAgIHJldHVybiBicmFuY2gz MihicmFuY2hUeXBlID09IEJyYW5jaElmVHJ1bmNhdGVGYWlsZWQgPyBFcXVhbCA6IE5vdEVxdWFs LCBkZXN0LCBUcnVzdGVkSW1tMzIoMCkpOworICAgICAgICByZXR1cm4gYnJhbmNoMzIoYnJhbmNo VHlwZSA9PSBCcmFuY2hJZlRydW5jYXRlRmFpbGVkID8gRXF1YWwgOiBOb3RFcXVhbCwgZGVzdCwg VHJ1c3RlZEltbTMyKDB4N2ZmZmZmZmYpKTsKICAgICB9CiAKICAgICAvLyBSZXN1bHQgaXMgdW5k ZWZpbmVkIGlmIHRoZSB2YWx1ZSBpcyBvdXRzaWRlIG9mIHRoZSBpbnRlZ2VyIHJhbmdlLgo=