152781 2016-01-06 02:31:14 -0800 [mips] Fix bug in or32() implementation 2016-01-06 12:58:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbriance jbriance annulen commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1153013 0 jbriance 2016-01-06 02:31:14 -0800 In mips macro assembler, the or32(TrustedImm32, RegisterID, RegisterID) implementation is buggy when used with a null immediate 1153014 1 268363 jbriance 2016-01-06 02:41:03 -0800 Created attachment 268363 Fix or32() mips implementation in macro assembler Note: already contributed in qtwekbit http://code.qt.io/cgit/qt/qtwebkit.git/commit/?id=0546c8656a3728bf4375da39027e096beba4f111 1153059 2 268363 msaboff 2016-01-06 09:47:19 -0800 Comment on attachment 268363 Fix or32() mips implementation in macro assembler r=me 1153170 3 jbriance 2016-01-06 12:58:13 -0800 Manually committed r194640: http://trac.webkit.org/changeset/194640 268363 2016-01-06 02:41:03 -0800 2016-01-06 09:47:19 -0800 Fix or32() mips implementation in macro assembler bug-152781.patch text/plain 1281 jbriance SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NjM0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE2LTAxLTA2ICBKdWxpZW4gQnJpYW5jZWF1ICA8amJyaWFuY2VAY2lzY28uY29tPgorCisg ICAgICAgIFttaXBzXSBGaXggb3IzMiBpbXBsZW1lbnRhdGlvbiBpbiBtYWNybyBhc3NlbWJsZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjc4MQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1J UFM6Om9yMzIpOgorCiAyMDE2LTAxLTA1ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlh LmNvbT4KIAogICAgICAgICBbQ01ha2VdIFJlbW92ZSBVU0VfVURJUzg2IHZhcmlhYmxlCkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJNSVBTLmgJKHJldmlzaW9uIDE5NDYzNCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkKQEAgLTM5Nyw4ICszOTcs MTAgQEAgcHVibGljOgogCiAgICAgdm9pZCBvcjMyKFRydXN0ZWRJbW0zMiBpbW0sIFJlZ2lzdGVy SUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewotICAgICAgICBpZiAoIWltbS5tX3ZhbHVl ICYmICFtX2ZpeGVkV2lkdGgpCisgICAgICAgIGlmICghaW1tLm1fdmFsdWUgJiYgIW1fZml4ZWRX aWR0aCkgeworICAgICAgICAgICAgbW92ZShzcmMsIGRlc3QpOwogICAgICAgICAgICAgcmV0dXJu OworICAgICAgICB9CiAKICAgICAgICAgaWYgKGltbS5tX3ZhbHVlID4gMCAmJiBpbW0ubV92YWx1 ZSA8IDY1NTM1ICYmICFtX2ZpeGVkV2lkdGgpIHsKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLm9y aShkZXN0LCBzcmMsIGltbS5tX3ZhbHVlKTsK