152776 2016-01-05 22:33:00 -0800 v3 UI doesn't preserve the time range when charts page is opened from a dashboard 2016-02-16 13:50:10 -0800 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dewei_zhu jond kling koivisto rniwa slewis timothy oldest_to_newest 1152991 0 rniwa 2016-01-05 22:33:00 -0800 When one month view is selected, we should open charts page with that time range. 1152992 1 268356 rniwa 2016-01-05 22:40:09 -0800 Created attachment 268356 Fixes the bug 1153051 2 268356 cdumez 2016-01-06 08:56:34 -0800 Comment on attachment 268356 Fixes the bug r=me 1153103 3 268356 commit-queue 2016-01-06 11:10:01 -0800 Comment on attachment 268356 Fixes the bug Clearing flags on attachment: 268356 Committed r194647: <http://trac.webkit.org/changeset/194647> 1153104 4 commit-queue 2016-01-06 11:10:07 -0800 All reviewed patches have been landed. Closing bug. 268356 2016-01-05 22:40:09 -0800 2016-01-06 11:10:01 -0800 Fixes the bug bug-152776-20160105223936.patch text/plain 5190 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NjMyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI2IEBACisyMDE2LTAxLTA2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIHYzIFVJIGRvZXNuJ3QgcHJlc2VydmUgdGhlIHRpbWUgcmFuZ2Ugd2hlbiBjaGFy dHMgcGFnZSBpcyBvcGVuZWQgZnJvbSBhIGRhc2hib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNzc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgdGhlIGJ1ZyBieSBtb3ZpbmcgdGhlIGNv bnN0cnVjdGlvbiBvZiBjaGFydHMgVVJMIGZyb20gRGFzaGJvYXJkUGFnZS5wcm90b3R5cGUub3Bl biB0bworICAgICAgICBEYXNoYm9hcmRQYWdlLnByb3RvdHlwZS5yZW5kZXIgYW5kIHJlLXJlbmRl cmluZyB0aGUgZW50aXJlIHBhZ2UgdXBvbiBhbiBVUkwgc3RhdGUgdHJhbnNpdGlvbi4KKworICAg ICAgICAqIHB1YmxpYy92My9wYWdlcy9jaGFydHMtcGFnZS5qczoKKyAgICAgICAgKENoYXJ0c1Bh Z2UuY3JlYXRlU3RhdGVGb3JEYXNoYm9hcmRJdGVtKTogVGFrZXMgdGhlIHN0YXJ0IHRpbWUgZm9y IHRoZSBjaGFydHMgcGFnZS4KKworICAgICAgICAqIHB1YmxpYy92My9wYWdlcy9kYXNoYm9hcmQt cGFnZS5qczoKKyAgICAgICAgKERhc2hib2FyZFBhZ2UucHJvdG90eXBlLnVwZGF0ZUZyb21TZXJp YWxpemVkU3RhdGUpOiBNZXJnZWQgX251bWJlck9mRGF5c0RpZENoYW5nZSBhbmQKKyAgICAgICAg X3VwZGF0ZUNoYXJ0c0RvbWFpbkZyb21Ub29sYmFyIGludG8gdGhpcyBmdW5jdGlvbiBzaW5jZSB0 aGV5J3JlIG5vdCB1c2VkIGVsc2V3aGVyZS4gQWxzbyByZS1yZW5kZXIKKyAgICAgICAgdGhlIGVu dGlyZSBwYWdlIHdoZW4gdHJhbnNpdGlvbiBiZXR3ZWVuIGRpZmZlcmVudCBudW1iZXIgb2YgZGF5 cyB0byBzaG93LgorICAgICAgICAoRGFzaGJvYXJkUGFnZS5wcm90b3R5cGUuX251bWJlck9mRGF5 c0RpZENoYW5nZSk6IERlbGV0ZWQuCisgICAgICAgIChEYXNoYm9hcmRQYWdlLnByb3RvdHlwZS5f dXBkYXRlQ2hhcnRzRG9tYWluRnJvbVRvb2xiYXIpOiBEZWxldGVkLgorICAgICAgICAoRGFzaGJv YXJkUGFnZS5wcm90b3R5cGUucmVuZGVyKTogQ29uc3RydWN0IFVSTCBmb3IgZWFjaCBjaGFydHMg aGVyZS4KKyAgICAgICAgKERhc2hib2FyZFBhZ2UucHJvdG90eXBlLl9jcmVhdGVDaGFydEZvckNl bGwpOiBEb24ndCBjb25zdHJ1Y3QgVVJMIGhlcmUgc2luY2UgdGhpcyBmdW5jdGlvbiBpcworICAg ICAgICBjYWxsZWQgb25jZSB3aGVuIHRoZSBkYXNoYm9hcmQgcGFnZSBpcyBvcGVuZWQsIGFuZCBu b3Qgd2hlbiB0aGUgdGltZSByYW5nZSBpcyBjaGFuZ2VkLgorCiAyMDE2LTAxLTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgYW4gb2xk IHZlcnNpb24gb2YgUEhQIGFmdGVyIHIxOTQ2MTguCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtp dC5vcmcvcHVibGljL3YzL3BhZ2VzL2NoYXJ0cy1wYWdlLmpzCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMvY2hhcnRzLXBhZ2UuanMJKHJldmlz aW9uIDE5NDYyNykKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMv Y2hhcnRzLXBhZ2UuanMJKHdvcmtpbmcgY29weSkKQEAgLTEzLDkgKzEzLDkgQEAgY2xhc3MgQ2hh cnRzUGFnZSBleHRlbmRzIFBhZ2VXaXRoQ2hhcnRzIAogCiAgICAgcm91dGVOYW1lKCkgeyByZXR1 cm4gJ2NoYXJ0cyc7IH0KIAotICAgIHN0YXRpYyBjcmVhdGVTdGF0ZUZvckRhc2hib2FyZEl0ZW0o cGxhdGZvcm1JZCwgbWV0cmljSWQpCisgICAgc3RhdGljIGNyZWF0ZVN0YXRlRm9yRGFzaGJvYXJk SXRlbShwbGF0Zm9ybUlkLCBtZXRyaWNJZCwgc3RhcnRUaW1lKQogICAgIHsKLSAgICAgICAgdmFy IHN0YXRlID0ge3BhbmVMaXN0OiBbW3BsYXRmb3JtSWQsIG1ldHJpY0lkXV19OworICAgICAgICB2 YXIgc3RhdGUgPSB7cGFuZUxpc3Q6IFtbcGxhdGZvcm1JZCwgbWV0cmljSWRdXSwgc2luY2U6IHN0 YXJ0VGltZX07CiAgICAgICAgIHJldHVybiBzdGF0ZTsKICAgICB9CiAKSW5kZXg6IFdlYnNpdGVz L3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMvZGFzaGJvYXJkLXBhZ2UuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9wYWdlcy9kYXNoYm9h cmQtcGFnZS5qcwkocmV2aXNpb24gMTk0NjI3KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3Jn L3B1YmxpYy92My9wYWdlcy9kYXNoYm9hcmQtcGFnZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMjQs MjggKzI0LDE3IEBAIGNsYXNzIERhc2hib2FyZFBhZ2UgZXh0ZW5kcyBQYWdlV2l0aENoYXIKIAog ICAgIHVwZGF0ZUZyb21TZXJpYWxpemVkU3RhdGUoc3RhdGUsIGlzT3BlbikKICAgICB7Ci0gICAg ICAgIGlmICghaXNPcGVuIHx8IHN0YXRlLm51bWJlck9mRGF5cykgeworICAgICAgICBpZiAoIWlz T3BlbiB8fCBzdGF0ZS5udW1iZXJPZkRheXMpCiAgICAgICAgICAgICB0aGlzLnRvb2xiYXIoKS5z ZXROdW1iZXJPZkRheXMoc3RhdGUubnVtYmVyT2ZEYXlzKTsKLSAgICAgICAgICAgIHRoaXMuX251 bWJlck9mRGF5c0RpZENoYW5nZShpc09wZW4pOwotICAgICAgICB9Ci0gICAgICAgIHRoaXMuX3Vw ZGF0ZUNoYXJ0c0RvbWFpbkZyb21Ub29sYmFyKCk7Ci0gICAgfQotCi0gICAgX251bWJlck9mRGF5 c0RpZENoYW5nZShpc09wZW4pCi0gICAgewotICAgICAgICBpZiAoaXNPcGVuKQotICAgICAgICAg ICAgcmV0dXJuOwogCi0gICAgICAgIHRoaXMudG9vbGJhcigpLnJlbmRlcigpOwotICAgICAgICB0 aGlzLmhlYWRpbmcoKS5yZW5kZXIoKTsgLy8gVXBkYXRlIGxpbmtzIGZvciBvdGhlciBkYXNoYm9h cmRzLgotICAgIH0KLQotICAgIF91cGRhdGVDaGFydHNEb21haW5Gcm9tVG9vbGJhcigpCi0gICAg ewogICAgICAgICB2YXIgc3RhcnRUaW1lID0gdGhpcy50b29sYmFyKCkuc3RhcnRUaW1lKCk7CiAg ICAgICAgIHZhciBlbmRUaW1lID0gdGhpcy50b29sYmFyKCkuZW5kVGltZSgpOwogICAgICAgICBm b3IgKHZhciBjaGFydCBvZiB0aGlzLl9jaGFydHMpCiAgICAgICAgICAgICBjaGFydC5zZXREb21h aW4oc3RhcnRUaW1lLCBlbmRUaW1lKTsKKworICAgICAgICB0aGlzLl9uZWVkc1RhYmxlQ29uc3Ry dWN0aW9uID0gdHJ1ZTsKKyAgICAgICAgaWYgKCFpc09wZW4pCisgICAgICAgICAgICB0aGlzLnJl bmRlcigpOwogICAgIH0KIAogICAgIG9wZW4oc3RhdGUpCkBAIC05MCw2ICs3OSw4IEBAIGNsYXNz IERhc2hib2FyZFBhZ2UgZXh0ZW5kcyBQYWdlV2l0aENoYXIKIAogICAgICAgICBpZiAodGhpcy5f bmVlZHNUYWJsZUNvbnN0cnVjdGlvbikgewogICAgICAgICAgICAgdmFyIHRyZWUgPSBbXTsKKyAg ICAgICAgICAgIHZhciByb3V0ZXIgPSB0aGlzLnJvdXRlcigpOworICAgICAgICAgICAgdmFyIHN0 YXJ0VGltZSA9IHRoaXMudG9vbGJhcigpLnN0YXJ0VGltZSgpOwogICAgICAgICAgICAgZm9yICh2 YXIgZ3JvdXAgb2YgdGhpcy5fdGFibGVHcm91cHMpIHsKICAgICAgICAgICAgICAgICB0cmVlLnB1 c2goZWxlbWVudCgndGhlYWQnLCBlbGVtZW50KCd0cicsCiAgICAgICAgICAgICAgICAgICAgIGdy b3VwWzBdLm1hcChmdW5jdGlvbiAoY2VsbCwgY2VsbEluZGV4KSB7CkBAIC0xMDYsNyArOTcsOSBA QCBjbGFzcyBEYXNoYm9hcmRQYWdlIGV4dGVuZHMgUGFnZVdpdGhDaGFyCiAgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoIWNlbGwuY2hhcnQpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGVsZW1lbnQoJ3RkJywgY2VsbCk7CiAKLSAgICAgICAgICAgICAgICAgICAgICAgIHJl dHVybiBlbGVtZW50KCd0ZCcsIFtjZWxsLnN0YXR1c1ZpZXcsIGxpbmsoY2VsbC5jaGFydC5lbGVt ZW50KCksIGNlbGwubGFiZWwsIGNlbGwudXJsKV0pOworICAgICAgICAgICAgICAgICAgICAgICAg dmFyIHVybCA9IHJvdXRlci51cmwoJ2NoYXJ0cycsIAorICAgICAgICAgICAgICAgICAgICAgICAg ICAgIENoYXJ0c1BhZ2UuY3JlYXRlU3RhdGVGb3JEYXNoYm9hcmRJdGVtKGNlbGwucGxhdGZvcm0u aWQoKSwgY2VsbC5tZXRyaWMuaWQoKSwgc3RhcnRUaW1lKSk7CisgICAgICAgICAgICAgICAgICAg ICAgICByZXR1cm4gZWxlbWVudCgndGQnLCBbY2VsbC5zdGF0dXNWaWV3LCBsaW5rKGNlbGwuY2hh cnQuZWxlbWVudCgpLCBjZWxsLmxhYmVsLCB1cmwpXSk7CiAgICAgICAgICAgICAgICAgICAgIH0p KTsKICAgICAgICAgICAgICAgICB9KSkpOwogICAgICAgICAgICAgfQpAQCAtMTQ2LDkgKzEzOSwx MCBAQCBjbGFzcyBEYXNoYm9hcmRQYWdlIGV4dGVuZHMgUGFnZVdpdGhDaGFyCiAgICAgICAgIHJl dHVybiB7CiAgICAgICAgICAgICBjaGFydDogY2hhcnQsCiAgICAgICAgICAgICBzdGF0dXNWaWV3 OiBzdGF0dXNWaWV3LAorICAgICAgICAgICAgcGxhdGZvcm06IHJlc3VsdC5wbGF0Zm9ybSwKICAg ICAgICAgICAgIG1ldHJpYzogcmVzdWx0Lm1ldHJpYywKLSAgICAgICAgICAgIGxhYmVsOiByZXN1 bHQubWV0cmljLmZ1bGxOYW1lKCkgKyAnIG9uICcgKyByZXN1bHQucGxhdGZvcm0ubGFiZWwoKSwK LSAgICAgICAgICAgIHVybDogdGhpcy5yb3V0ZXIoKS51cmwoJ2NoYXJ0cycsIENoYXJ0c1BhZ2Uu Y3JlYXRlU3RhdGVGb3JEYXNoYm9hcmRJdGVtKHBsYXRmb3JtSWQsIG1ldHJpY0lkKSl9OworICAg ICAgICAgICAgbGFiZWw6IHJlc3VsdC5tZXRyaWMuZnVsbE5hbWUoKSArICcgb24gJyArIHJlc3Vs dC5wbGF0Zm9ybS5sYWJlbCgpCisgICAgICAgIH07CiAgICAgfQogCiAgICAgX2ZldGNoZWREYXRh KCkK