152768 2016-01-05 18:10:45 -0800 Silence -Wtautological-compare 2016-01-06 13:13:54 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other PC Linux RESOLVED FIXED P2 Trivial --- 1 mcatanzaro mcatanzaro commit-queue keith_miller mark.lam mcatanzaro msaboff ossy saam oldest_to_newest 1152953 0 mcatanzaro 2016-01-05 18:10:45 -0800 [394/5657] Building CXX object Source/...vaScriptCore.dir/runtime/Options.cpp.o ../../Source/JavaScriptCore/runtime/Options.cpp:618:217: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:899: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:1584: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:2278: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:2972: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:3657: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:4448: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:5064: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:5758: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:6449: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:7146: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:7882: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:8612: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:9336: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:10033: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:10757: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:11481: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:12175: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:12854: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:13608: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:14332: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:15056: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:15789: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:16483: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:17183: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:17936: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:18549: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:19261: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:19955: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:20682: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:21370: warning: self-comparison always evaluates to true [-Wtautological-compare] ../../Source/JavaScriptCore/runtime/Options.cpp:618:22049: warning: self-comparison always evaluates to true [-Wtautological-compare] 32 warnings generated. 1152954 1 268341 mcatanzaro 2016-01-05 18:17:02 -0800 Created attachment 268341 Patch 1153003 2 268341 saam 2016-01-05 23:57:19 -0800 Comment on attachment 268341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268341&action=review r=me with build fixes > Source/JavaScriptCore/runtime/Options.cpp:627 > +#if COMPILER(CLANG) Shouldn't this be the same condition as above? 1153127 3 mcatanzaro 2016-01-06 11:50:50 -0800 (In reply to comment #2) > > Source/JavaScriptCore/runtime/Options.cpp:627 > > +#if COMPILER(CLANG) > > Shouldn't this be the same condition as above? Yup. Also this construct: #if COMPILER(CLANG) && __has_warning("-Wtautological-compare") Is breaking the GCC build, it has to be: #if COMPILER(CLANG) #if __has_warning("-Wtautological-compare") Which is a bit annoying... maybe could add some WTF macros to simplify this in a future commit. 1153128 4 268385 mcatanzaro 2016-01-06 11:53:42 -0800 Created attachment 268385 Patch 1153181 5 268385 commit-queue 2016-01-06 13:13:50 -0800 Comment on attachment 268385 Patch Clearing flags on attachment: 268385 Committed r194659: <http://trac.webkit.org/changeset/194659> 1153182 6 commit-queue 2016-01-06 13:13:54 -0800 All reviewed patches have been landed. Closing bug. 268341 2016-01-05 18:17:02 -0800 2016-01-06 11:53:37 -0800 Patch bug-152768-20160105201628.patch text/plain 1959 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NmQyYTJmNjJjMjcxNGJiZWIzZjFmZThhZjAwY2JmM2Q3MTY4ZWUyLi42ZTM4YzNmN2Y2NzA2MDI0 MDkwMzZjZWZiNWU1MDg0NWUxMGMzODZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0wNSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgU2lsZW5jZSAtV3RhdXRvbG9naWNhbC1jb21wYXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI3NjgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0 aW9ucy5jcHA6CisgICAgICAgIChKU0M6Ok9wdGlvbnM6OnNldEFsaWFzZWRPcHRpb24pOgorCiAy MDE2LTAxLTA1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LiBBIHN5bWJvbCB3YXMgYmVpbmcgZXhwb3J0ZWQgdGhh dCBzaG91bGQgbm90IGhhdmUgYmVlbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL09wdGlvbnMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0 aW9ucy5jcHAKaW5kZXggMzc2YjI0ZTE1YjRmZmQ5M2VjYzQwZmJmMTFlZWMyMzQ1ZmJjZTdlNS4u MzllMTcwNGY4YTJjZWYwYmUwMzkwOWU5NDcyMGFmMTY2YzJmYzdhZiAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKKysrIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5jcHAKQEAgLTMzLDYgKzMzLDcgQEAKICNpbmNsdWRl IDxzdGRsaWIuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvQVNDSUlDVHlw ZS5oPgorI2luY2x1ZGUgPHd0Zi9Db21waWxlci5oPgogI2luY2x1ZGUgPHd0Zi9EYXRhTG9nLmg+ CiAjaW5jbHVkZSA8d3RmL051bWJlck9mQ29yZXMuaD4KICNpbmNsdWRlIDx3dGYvU3RkTGliRXh0 cmFzLmg+CkBAIC01OTcsNiArNTk4LDExIEBAIGJvb2wgT3B0aW9uczo6c2V0QWxpYXNlZE9wdGlv bihjb25zdCBjaGFyKiBhcmcpCiAgICAgaWYgKCFlcXVhbFN0cikKICAgICAgICAgcmV0dXJuIGZh bHNlOwogCisjaWYgQ09NUElMRVIoQ0xBTkcpICYmIF9faGFzX3dhcm5pbmcoIi1XdGF1dG9sb2dp Y2FsLWNvbXBhcmUiKQorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEgY2xh bmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV3RhdXRvbG9naWNhbC1jb21wYXJlIgorI2VuZGlmCisK ICAgICAvLyBGb3IgZWFjaCBvcHRpb24sIGNoZWNrIGlmIHRoZSBzcGVjaWZ5IGFyZyBpcyBhIG1h dGNoLiBJZiBzbywgc2V0IHRoZSBhcmcKICAgICAvLyBpZiB0aGUgdmFsdWUgbWFrZXMgc2Vuc2Uu IE90aGVyd2lzZSwgbW92ZSBvbiB0byBjaGVja2luZyB0aGUgbmV4dCBvcHRpb24uCiAjZGVmaW5l IEZPUl9FQUNIX09QVElPTihhbGlhc2VkTmFtZV8sIHVuYWxpYXNlZE5hbWVfLCBlcXVpdmFsZW5j ZSkgXApAQCAtNjE4LDYgKzYyNCwxMCBAQCBib29sIE9wdGlvbnM6OnNldEFsaWFzZWRPcHRpb24o Y29uc3QgY2hhciogYXJnKQogICAgIEpTQ19BTElBU0VEX09QVElPTlMoRk9SX0VBQ0hfT1BUSU9O KQogI3VuZGVmIEZPUl9FQUNIX09QVElPTgogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjcHJhZ21h IGNsYW5nIGRpYWdub3N0aWMgcG9wCisjZW5kaWYKKwogICAgIHJldHVybiBmYWxzZTsgLy8gTm8g b3B0aW9uIG1hdGNoZWQuCiB9CiAK 268385 2016-01-06 11:53:42 -0800 2016-01-06 13:13:50 -0800 Patch bug-152768-20160106135309.patch text/plain 2012 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NjQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAw MDgzZjc3ZDBmYjhlMTc0Y2FiYmYwMDU5ZjI3ZjQzNTJkMWIzZDYxLi5lYmNmMDEzYjQ1YTkzM2Zj OWEyNmRhNzc2OGJjZWZhYTJjOTEwYmY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0wNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGln YWxpYS5jb20+CisKKyAgICAgICAgU2lsZW5jZSAtV3RhdXRvbG9naWNhbC1jb21wYXJlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI3NjgKKworICAg ICAgICBSZXZpZXdlZCBieSBTYWFtIEJhcmF0aS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9u cy5jcHA6CisgICAgICAgIChKU0M6Ok9wdGlvbnM6OnNldEFsaWFzZWRPcHRpb24pOgorCiAyMDE2 LTAxLTA2ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIFdl YktpdCBTUEkgZm9yIHJlZ2lzdGVyaW5nIGFuIGF1dG9tYXRpb24gY29udHJvbGxlciB3aXRoIFJl bW90ZUluc3BlY3RvcgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcApp bmRleCAzNzZiMjRlMTViNGZmZDkzZWNjNDBmYmYxMWVlYzIzNDVmYmNlN2U1Li5mYmZjNTUwMzZl Y2NhNmQ4Y2UxOWFmNmFkMzQ0ZTA3YTExMjE3ZWVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9PcHRpb25zLmNwcApAQCAtMzMsNiArMzMsNyBAQAogI2luY2x1ZGUgPHN0ZGxpYi5o PgogI2luY2x1ZGUgPHN0cmluZy5oPgogI2luY2x1ZGUgPHd0Zi9BU0NJSUNUeXBlLmg+CisjaW5j bHVkZSA8d3RmL0NvbXBpbGVyLmg+CiAjaW5jbHVkZSA8d3RmL0RhdGFMb2cuaD4KICNpbmNsdWRl IDx3dGYvTnVtYmVyT2ZDb3Jlcy5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KQEAg LTU5Nyw2ICs1OTgsMTMgQEAgYm9vbCBPcHRpb25zOjpzZXRBbGlhc2VkT3B0aW9uKGNvbnN0IGNo YXIqIGFyZykKICAgICBpZiAoIWVxdWFsU3RyKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyNp ZiBDT01QSUxFUihDTEFORykKKyNpZiBfX2hhc193YXJuaW5nKCItV3RhdXRvbG9naWNhbC1jb21w YXJlIikKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRpYWdu b3N0aWMgaWdub3JlZCAiLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSIKKyNlbmRpZgorI2VuZGlmCisK ICAgICAvLyBGb3IgZWFjaCBvcHRpb24sIGNoZWNrIGlmIHRoZSBzcGVjaWZ5IGFyZyBpcyBhIG1h dGNoLiBJZiBzbywgc2V0IHRoZSBhcmcKICAgICAvLyBpZiB0aGUgdmFsdWUgbWFrZXMgc2Vuc2Uu IE90aGVyd2lzZSwgbW92ZSBvbiB0byBjaGVja2luZyB0aGUgbmV4dCBvcHRpb24uCiAjZGVmaW5l IEZPUl9FQUNIX09QVElPTihhbGlhc2VkTmFtZV8sIHVuYWxpYXNlZE5hbWVfLCBlcXVpdmFsZW5j ZSkgXApAQCAtNjE4LDYgKzYyNiwxMiBAQCBib29sIE9wdGlvbnM6OnNldEFsaWFzZWRPcHRpb24o Y29uc3QgY2hhciogYXJnKQogICAgIEpTQ19BTElBU0VEX09QVElPTlMoRk9SX0VBQ0hfT1BUSU9O KQogI3VuZGVmIEZPUl9FQUNIX09QVElPTgogCisjaWYgQ09NUElMRVIoQ0xBTkcpCisjaWYgX19o YXNfd2FybmluZygiLVd0YXV0b2xvZ2ljYWwtY29tcGFyZSIpCisjcHJhZ21hIGNsYW5nIGRpYWdu b3N0aWMgcG9wCisjZW5kaWYKKyNlbmRpZgorCiAgICAgcmV0dXJuIGZhbHNlOyAvLyBObyBvcHRp b24gbWF0Y2hlZC4KIH0KIAo=