152718 2016-01-04 15:58:01 -0800 gtest should use the same SDK as other projects 2016-01-05 09:15:13 -0800 1 1 1 Unclassified WebKit Tools / Tests Safari 9 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap ddkilzer lforschler oldest_to_newest 1152555 0 ap 2016-01-04 15:58:01 -0800 gtest's xcconfig files use USE_INTERNAL_SDK, but never define it. rdar://problem/23566856 1152562 1 268245 ap 2016-01-04 16:16:24 -0800 Created attachment 268245 proposed fix 1152663 2 268245 achristensen 2016-01-04 22:58:22 -0800 Comment on attachment 268245 proposed fix Adding the definition of USE_INTERNAL_SDK looks good. r=me Why are you duplicating the use of it to DebugProject and ReleaseProject? They both include General.xcconfig. This seems unnecessary. 1152665 3 ap 2016-01-04 23:34:13 -0800 I did it to match other projects, which have this snippet in DebugRelease.xcconfig (so that it doesn't affect production builds). It is possible to avoid duplication, but at the cost of doing things differently, which seems likely to cause confusion again in the future. 1152733 4 ap 2016-01-05 09:15:13 -0800 Committed http://trac.webkit.org/r194585 268245 2016-01-04 16:16:24 -0800 2016-01-04 22:58:22 -0800 proposed fix gtest_sdk.txt text/plain 3168 ap SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv VGhpcmRQYXJ0eS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDU2MSkKKysrIFNvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAxLTA0 ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIGd0ZXN0IHNo b3VsZCB1c2UgdGhlIHNhbWUgU0RLIGFzIG90aGVyIHByb2plY3RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI3MTgKKyAgICAgICAgcmRhcjovL3By b2JsZW0vMjM1NjY4NTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBndGVzdCBjb25maWd1cmF0aW9uIGF0dGVtcHRlZCB0byB1c2UgVVNFX0lOVEVSTkFM X1NESyB3aXRob3V0IGV2ZXIgZGVmaW5pbmcgaXQuCisKKyAgICAgICAgKiBndGVzdC94Y29kZS9D b25maWcvRGVidWdQcm9qZWN0LnhjY29uZmlnOgorICAgICAgICAqIGd0ZXN0L3hjb2RlL0NvbmZp Zy9HZW5lcmFsLnhjY29uZmlnOgorICAgICAgICAqIGd0ZXN0L3hjb2RlL0NvbmZpZy9SZWxlYXNl UHJvamVjdC54Y2NvbmZpZzoKKwogMjAxNi0wMS0wMiAgVGluZy1XZWkgTGFuICA8bGFudHc0NEBn bWFpbC5jb20+CiAKICAgICAgICAgUmVtb3ZlIHVzYWdlIG9mIGVudmlyb24gaW4gZ3Rlc3QKSW5k ZXg6IFNvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlL0NvbmZpZy9EZWJ1Z1Byb2plY3QueGNj b25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmln L0RlYnVnUHJvamVjdC54Y2NvbmZpZwkocmV2aXNpb24gMTk0NTYxKQorKysgU291cmNlL1RoaXJk UGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0RlYnVnUHJvamVjdC54Y2NvbmZpZwkod29ya2luZyBj b3B5KQpAQCAtMzMsMyArMzMsOCBAQCBPVEhFUl9DRkxBR1MgPSAkKE9USEVSX0NGTEFHUykgLURE RUJVRz0xCiBXRUJDT1JFX1BSSVZBVEVfSEVBREVSU19ESVIgPSAkKEJVSUxUX1BST0RVQ1RTX0RJ UikvV2ViQ29yZS5mcmFtZXdvcmsvUHJpdmF0ZUhlYWRlcnM7CiAKIE9OTFlfQUNUSVZFX0FSQ0gg PSBZRVMKKworU0RLUk9PVFtzZGs9aXBob25lKl0gPSAkKFNES1JPT1QpOworU0RLUk9PVCA9ICQo U0RLUk9PVF8kKFBMQVRGT1JNX05BTUUpXyQoVVNFX0lOVEVSTkFMX1NESykpOworU0RLUk9PVF9t YWNvc3hfID0gbWFjb3N4OworU0RLUk9PVF9tYWNvc3hfWUVTID0gbWFjb3N4LmludGVybmFsOwpJ bmRleDogU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0dlbmVyYWwueGNjb25m aWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0dl bmVyYWwueGNjb25maWcJKHJldmlzaW9uIDE5NDU2MSkKKysrIFNvdXJjZS9UaGlyZFBhcnR5L2d0 ZXN0L3hjb2RlL0NvbmZpZy9HZW5lcmFsLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC03LDYg KzcsMTMgQEAKIC8vICBodHRwOi8vY29kZS5nb29nbGUuY29tL3AvZ29vZ2xlLXRvb2xib3gtZm9y LW1hYy8KIC8vCiAKKyNpbmNsdWRlICIuLi8uLi8uLi8uLi8uLi8uLi9JbnRlcm5hbC9Db25maWd1 cmF0aW9ucy9IYXZlSW50ZXJuYWxTREsueGNjb25maWciCisKK1VTRV9JTlRFUk5BTF9TREsgPSAk KFVTRV9JTlRFUk5BTF9TREtfJChDT05GSUdVUkFUSU9OKSk7CitVU0VfSU5URVJOQUxfU0RLX1By b2R1Y3Rpb24gPSBZRVM7CitVU0VfSU5URVJOQUxfU0RLX0RlYnVnID0gJChIQVZFX0lOVEVSTkFM X1NESyk7CitVU0VfSU5URVJOQUxfU0RLX1JlbGVhc2UgPSAkKEhBVkVfSU5URVJOQUxfU0RLKTsK KwogR0NDX1ZFUlNJT04gPSBjb20uYXBwbGUuY29tcGlsZXJzLmxsdm0uY2xhbmcuMV8wOwogCiBB UkNIUyA9ICQoQVJDSFNfU1RBTkRBUkRfMzJfNjRfQklUKTsKQEAgLTY1LDkgKzcyLDQgQEAgT1RI RVJfQ0ZMQUdTID0gJChBU0FOX09USEVSX0NGTEFHUyk7CiBPVEhFUl9DUExVU1BMVVNGTEFHUyA9 ICQoQVNBTl9PVEhFUl9DUExVU1BMVVNGTEFHUyk7CiBPVEhFUl9MREZMQUdTID0gJChBU0FOX09U SEVSX0xERkxBR1MpOwogCi1TREtST09UW3Nkaz1pcGhvbmUqXSA9ICQoU0RLUk9PVCk7Ci1TREtS T09UID0gJChTREtST09UXyQoUExBVEZPUk1fTkFNRSlfJChVU0VfSU5URVJOQUxfU0RLKSk7Ci1T REtST09UX21hY29zeF8gPSBtYWNvc3g7Ci1TREtST09UX21hY29zeF9ZRVMgPSBtYWNvc3guaW50 ZXJuYWw7Ci0KIFNVUFBPUlRFRF9QTEFURk9STVMgPSBpcGhvbmVvcyBpcGhvbmVzaW11bGF0b3Ig bWFjb3N4IHR2b3MgdHZzaW11bGF0b3Igd2F0Y2hvcyB3YXRjaHNpbXVsYXRvcjsKSW5kZXg6IFNv dXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlL0NvbmZpZy9SZWxlYXNlUHJvamVjdC54Y2NvbmZp Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94Y29kZS9Db25maWcvUmVs ZWFzZVByb2plY3QueGNjb25maWcJKHJldmlzaW9uIDE5NDU2MSkKKysrIFNvdXJjZS9UaGlyZFBh cnR5L2d0ZXN0L3hjb2RlL0NvbmZpZy9SZWxlYXNlUHJvamVjdC54Y2NvbmZpZwkod29ya2luZyBj b3B5KQpAQCAtMzUsMyArMzUsOCBAQCBTVFJJUF9TVFlMRSA9IGFsbAogV0VCQ09SRV9QUklWQVRF X0hFQURFUlNfRElSID0gJChCVUlMVF9QUk9EVUNUU19ESVIpL1dlYkNvcmUuZnJhbWV3b3JrL1By aXZhdGVIZWFkZXJzOwogCiBPTkxZX0FDVElWRV9BUkNIID0gWUVTCisKK1NES1JPT1Rbc2RrPWlw aG9uZSpdID0gJChTREtST09UKTsKK1NES1JPT1QgPSAkKFNES1JPT1RfJChQTEFURk9STV9OQU1F KV8kKFVTRV9JTlRFUk5BTF9TREspKTsKK1NES1JPT1RfbWFjb3N4XyA9IG1hY29zeDsKK1NES1JP T1RfbWFjb3N4X1lFUyA9IG1hY29zeC5pbnRlcm5hbDsK