152715 2016-01-04 15:24:46 -0800 TextBreakIterator uses an internal implementation detail of NSLocale 2016-01-13 22:22:59 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mmaxfield mmaxfield commit-queue darin webkit-bug-importer oldest_to_newest 1152543 0 mmaxfield 2016-01-04 15:24:46 -0800 TextBreakIterator uses an internal implementation detail of NSLocale 1152544 1 268241 mmaxfield 2016-01-04 15:25:37 -0800 Created attachment 268241 Patch 1152545 2 268242 mmaxfield 2016-01-04 15:26:10 -0800 Created attachment 268242 Patch 1152547 3 mmaxfield 2016-01-04 15:26:39 -0800 <rdar://problem/23775121> 1152571 4 268242 commit-queue 2016-01-04 16:42:59 -0800 Comment on attachment 268242 Patch Clearing flags on attachment: 268242 Committed r194566: <http://trac.webkit.org/changeset/194566> 1152572 5 commit-queue 2016-01-04 16:43:03 -0800 All reviewed patches have been landed. Closing bug. 1155082 6 268242 darin 2016-01-13 08:53:58 -0800 Comment on attachment 268242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268242&action=review > Source/WebCore/platform/text/mac/TextBreakIteratorInternalICUMac.mm:41 > + NSArray *languagesArray = [NSLocale preferredLanguages]; To be consistent with the usage in the rest of this file it would be better to call CFLocaleCopyPreferredLanguages rather than [NSLocale preferredLanguages]. There is a change in behavior here: the NSLocale/CFLocale functions create a new array with the result of CFLocaleCreateCanonicalLanguageIdentifierFromString on each item in the array. That means that: 1) The code in this function that checks if the item from the array is an NSString is no longer needed since the NSLocale/CFLocale function guarantees it will return an array of strings, with no objects of other types. 2) The code below in two different functions that calls canonicalLanguageIdentifier on the result of this function is no longer needed; the result of this function is already guaranteed to be a canonical language identifier. I suggest moving the call to CFLocaleCreateCanonicalLanguageIdentifierFromString into the textBreakLocalePreference function and removing the canonicalLanguageIdentifier function entirely. 1155287 7 268242 mmaxfield 2016-01-13 16:30:30 -0800 Comment on attachment 268242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268242&action=review >> Source/WebCore/platform/text/mac/TextBreakIteratorInternalICUMac.mm:41 >> + NSArray *languagesArray = [NSLocale preferredLanguages]; > > To be consistent with the usage in the rest of this file it would be better to call CFLocaleCopyPreferredLanguages rather than [NSLocale preferredLanguages]. > > There is a change in behavior here: the NSLocale/CFLocale functions create a new array with the result of CFLocaleCreateCanonicalLanguageIdentifierFromString on each item in the array. That means that: > > 1) The code in this function that checks if the item from the array is an NSString is no longer needed since the NSLocale/CFLocale function guarantees it will return an array of strings, with no objects of other types. > 2) The code below in two different functions that calls canonicalLanguageIdentifier on the result of this function is no longer needed; the result of this function is already guaranteed to be a canonical language identifier. I suggest moving the call to CFLocaleCreateCanonicalLanguageIdentifierFromString into the textBreakLocalePreference function and removing the canonicalLanguageIdentifier function entirely. http://trac.webkit.org/changeset/195001 1155371 8 268242 mmaxfield 2016-01-13 22:22:59 -0800 Comment on attachment 268242 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268242&action=review >>> Source/WebCore/platform/text/mac/TextBreakIteratorInternalICUMac.mm:41 >>> + NSArray *languagesArray = [NSLocale preferredLanguages]; >> >> To be consistent with the usage in the rest of this file it would be better to call CFLocaleCopyPreferredLanguages rather than [NSLocale preferredLanguages]. >> >> There is a change in behavior here: the NSLocale/CFLocale functions create a new array with the result of CFLocaleCreateCanonicalLanguageIdentifierFromString on each item in the array. That means that: >> >> 1) The code in this function that checks if the item from the array is an NSString is no longer needed since the NSLocale/CFLocale function guarantees it will return an array of strings, with no objects of other types. >> 2) The code below in two different functions that calls canonicalLanguageIdentifier on the result of this function is no longer needed; the result of this function is already guaranteed to be a canonical language identifier. I suggest moving the call to CFLocaleCreateCanonicalLanguageIdentifierFromString into the textBreakLocalePreference function and removing the canonicalLanguageIdentifier function entirely. > > http://trac.webkit.org/changeset/195001 http://trac.webkit.org/changeset/195006 268241 2016-01-04 15:25:37 -0800 2016-01-04 15:26:08 -0800 Patch bug-152715-20160104152504.patch text/plain 1710 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljNTlkOGUxNmEyYjUy NTg3NzE0MzBiOTZjYzBiOTU0M2U0ZmE5My4uODAzMTI3YjVmYmU0YTlmYTMzZTM3YzJjOTVjYmVj MGY3NGQzMTRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2LTAxLTA0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVGV4dEJyZWFr SXRlcmF0b3IgdXNlcyBhbiBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbiBkZXRhaWwgb2YgTlNMb2Nh bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjcx NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc3Rl YWQgb2YgZGlyZWN0bHkgcXVlcnlpbmcgQXBwbGVMYW5ndWFnZXMsIHdlIHNob3VsZCB1c2UgW05T TG9jYWxlIHByZWZlcnJlZExhbmd1YWdlc10uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1 c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vdGV4 dC9tYWMvVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVU1hYy5tbToKKyAgICAgICAgKFdlYkNv cmU6OnRvcExhbmd1YWdlUHJlZmVyZW5jZSk6CisKKzIwMTYtMDEtMDQgIE15bGVzIEMuIE1heGZp ZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KKwogICAgICAgICBQb3N0LWNvbW1pdCB1cGRhdGUg Zm9yIHIxOTM0ODQuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTE4ODQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9t YWMvVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVU1hYy5tbSBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3RleHQvbWFjL1RleHRCcmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VNYWMubW0KaW5kZXgg NTkwMWQ4MzcwMTI0NjY5Y2RmZjYxN2FhYzUxMmZmMzU4NjI0NmFlNi4uMWRlMzgyMTM4Y2VmNzRi ZGQ0NTMwMjdmNDQxOGI2ZGVmZTg0MGExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vdGV4dC9tYWMvVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVU1hYy5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9UZXh0QnJlYWtJdGVyYXRvckludGVybmFs SUNVTWFjLm1tCkBAIC0zOCw3ICszOCw3IEBAIHN0YXRpYyBpbmxpbmUgUmV0YWluUHRyPENGU3Ry aW5nUmVmPiB0ZXh0QnJlYWtMb2NhbGVQcmVmZXJlbmNlKCkKIAogc3RhdGljIFJldGFpblB0cjxD RlN0cmluZ1JlZj4gdG9wTGFuZ3VhZ2VQcmVmZXJlbmNlKCkKIHsKLSAgICBOU0FycmF5ICpsYW5n dWFnZXNBcnJheSA9IFtbTlNVc2VyRGVmYXVsdHMgc3RhbmRhcmRVc2VyRGVmYXVsdHNdIGFycmF5 Rm9yS2V5OkAiQXBwbGVMYW5ndWFnZXMiXTsKKyAgICBOU0FycmF5ICpsYW5ndWFnZXNBcnJheSA9 IFtOU0xvY2FsZSBwcmVmZXJyZWRMYW5ndWFnZXNdOwogICAgIGlmICghbGFuZ3VhZ2VzQXJyYXkp CiAgICAgICAgIHJldHVybiAwOwogICAgIGlmIChbbGFuZ3VhZ2VzQXJyYXkgY291bnRdIDwgMSkK 268242 2016-01-04 15:26:10 -0800 2016-01-04 16:42:59 -0800 Patch bug-152715-20160104152536.patch text/plain 1745 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODljNTlkOGUxNmEyYjUy NTg3NzE0MzBiOTZjYzBiOTU0M2U0ZmE5My4uODliMzliMzBlMDI2NWYwNjA2YzZjNWM1ZWI2Mjgx MzQyMTQ0MzZmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE2LTAxLTA0ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKKyAgICAgICAgVGV4dEJyZWFr SXRlcmF0b3IgdXNlcyBhbiBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbiBkZXRhaWwgb2YgTlNMb2Nh bGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1Mjcx NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjM3NzUxMjE+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiBkaXJlY3RseSBxdWVyeWlu ZyBBcHBsZUxhbmd1YWdlcywgd2Ugc2hvdWxkIHVzZSBbTlNMb2NhbGUgcHJlZmVycmVkTGFuZ3Vh Z2VzXS4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlv ciBjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L21hYy9UZXh0QnJlYWtJdGVyYXRv ckludGVybmFsSUNVTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6dG9wTGFuZ3VhZ2VQcmVmZXJl bmNlKToKKworMjAxNi0wMS0wNCAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUu Y29tPgorCiAgICAgICAgIFBvc3QtY29tbWl0IHVwZGF0ZSBmb3IgcjE5MzQ4NC4KICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MTg4NAogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9UZXh0QnJlYWtJdGVyYXRvcklu dGVybmFsSUNVTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9tYWMvVGV4dEJy ZWFrSXRlcmF0b3JJbnRlcm5hbElDVU1hYy5tbQppbmRleCA1OTAxZDgzNzAxMjQ2NjljZGZmNjE3 YWFjNTEyZmYzNTg2MjQ2YWU2Li4xZGUzODIxMzhjZWY3NGJkZDQ1MzAyN2Y0NDE4YjZkZWZlODQw YTFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L21hYy9UZXh0QnJl YWtJdGVyYXRvckludGVybmFsSUNVTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3RleHQvbWFjL1RleHRCcmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VNYWMubW0KQEAgLTM4LDcgKzM4 LDcgQEAgc3RhdGljIGlubGluZSBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHRleHRCcmVha0xvY2Fs ZVByZWZlcmVuY2UoKQogCiBzdGF0aWMgUmV0YWluUHRyPENGU3RyaW5nUmVmPiB0b3BMYW5ndWFn ZVByZWZlcmVuY2UoKQogewotICAgIE5TQXJyYXkgKmxhbmd1YWdlc0FycmF5ID0gW1tOU1VzZXJE ZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYXJyYXlGb3JLZXk6QCJBcHBsZUxhbmd1YWdl cyJdOworICAgIE5TQXJyYXkgKmxhbmd1YWdlc0FycmF5ID0gW05TTG9jYWxlIHByZWZlcnJlZExh bmd1YWdlc107CiAgICAgaWYgKCFsYW5ndWFnZXNBcnJheSkKICAgICAgICAgcmV0dXJuIDA7CiAg ICAgaWYgKFtsYW5ndWFnZXNBcnJheSBjb3VudF0gPCAxKQo=