152713 2016-01-04 13:36:36 -0800 FTL B3 should do BitAnd binary snippets 2016-01-04 15:01:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 152668 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1152497 0 fpizlo 2016-01-04 13:36:36 -0800 Patch forthcoming. 1152502 1 268230 fpizlo 2016-01-04 13:51:07 -0800 Created attachment 268230 the patch 1152503 2 commit-queue 2016-01-04 13:54:01 -0800 Attachment 268230 did not pass style-queue: ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7485: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7497: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1152504 3 268230 mark.lam 2016-01-04 13:58:18 -0800 Comment on attachment 268230 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=268230&action=review r=me > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > + template<typename BinaryArithOpGenerator> Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match the function name? 1152505 4 fpizlo 2016-01-04 13:58:40 -0800 (In reply to comment #3) > Comment on attachment 268230 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268230&action=review > > r=me > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:7462 > > + template<typename BinaryArithOpGenerator> > > Perhaps rename "BinaryArithOpGenerator" to "BinaryBitOpGenerator" to match > the function name? Good idea, will do. 1152527 5 fpizlo 2016-01-04 15:01:09 -0800 Landed in http://trac.webkit.org/changeset/194556 268230 2016-01-04 13:51:07 -0800 2016-01-04 13:58:18 -0800 the patch blah.patch text/plain 6097 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NTU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE2LTAxLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEIzIHNob3VsZCBkbyBCaXRBbmQgYmluYXJ5IHNuaXBwZXRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI3MTMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXR0aW5nIHJlYWR5IHRvIGZpbmlzaCB1 cCB0aGUgYmluYXJ5IGJpdG9wIHNuaXBwZXRzLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZH VG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjpjb21w aWxlQml0QW5kKToKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZNOjplbWl0 QmluYXJ5U25pcHBldCk6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvTExWTTo6 ZW1pdEJpbmFyeUJpdE9wU25pcHBldCk6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRG R1RvTExWTTo6YWxsb2NhdGVDZWxsKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3Mvb2JqZWN0LWJp dC1hbmQuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKHRoaW5ncy52YWx1ZU9m KToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvdW50eXBlZC1iaXQtYW5kLmpzOiBBZGRlZC4KKyAg ICAgICAgKGZvbyk6CisgICAgICAgICh2YWx1ZU9mKToKKwogMjAxNi0wMS0wNCAgRmlsaXAgUGl6 bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTCBCMyBzaG91bGQgZG8gYWxsIG9m IHRoZSBub24tYml0b3AgYmluYXJ5IHNuaXBwZXRzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTk0NTU0KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTUyLDYgKzUyLDcgQEAKICNpbmNsdWRlICJGVExUaHVua3MuaCIKICNpbmNsdWRl ICJGVExXZWlnaHRlZFRhcmdldC5oIgogI2luY2x1ZGUgIkpJVEFkZEdlbmVyYXRvci5oIgorI2lu Y2x1ZGUgIkpJVEJpdEFuZEdlbmVyYXRvci5oIgogI2luY2x1ZGUgIkpJVERpdkdlbmVyYXRvci5o IgogI2luY2x1ZGUgIkpJVE11bEdlbmVyYXRvci5oIgogI2luY2x1ZGUgIkpJVFN1YkdlbmVyYXRv ci5oIgpAQCAtMjI4OSw4ICsyMjkwLDEyIEBAIHByaXZhdGU6CiAgICAgCiAgICAgdm9pZCBjb21w aWxlQml0QW5kKCkKICAgICB7Ci0gICAgICAgIGlmIChtX25vZGUtPmNoaWxkMSgpLnVzZUtpbmQo KSA9PSBVbnR5cGVkVXNlIHx8IG1fbm9kZS0+Y2hpbGQyKCkudXNlS2luZCgpID09IFVudHlwZWRV c2UpIHsKKyAgICAgICAgaWYgKG1fbm9kZS0+aXNCaW5hcnlVc2VLaW5kKFVudHlwZWRVc2UpKSB7 CisjaWYgRlRMX1VTRVNfQjMKKyAgICAgICAgICAgIGVtaXRCaW5hcnlCaXRPcFNuaXBwZXQ8SklU Qml0QW5kR2VuZXJhdG9yPihvcGVyYXRpb25WYWx1ZUJpdEFuZCk7CisjZWxzZSAvLyBGVExfVVNF U19CMwogICAgICAgICAgICAgY29tcGlsZVVudHlwZWRCaW5hcnlPcDxCaXRBbmREZXNjcmlwdG9y PigpOworI2VuZGlmIC8vIEZUTF9VU0VTX0IzCiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAg IH0KICAgICAgICAgc2V0SW50MzIobV9vdXQuYml0QW5kKGxvd0ludDMyKG1fbm9kZS0+Y2hpbGQx KCkpLCBsb3dJbnQzMihtX25vZGUtPmNoaWxkMigpKSkpOwpAQCAtNzQ1Myw2ICs3NDU4LDU5IEBA IHByaXZhdGU6CiAKICAgICAgICAgc2V0SlNWYWx1ZShwYXRjaHBvaW50KTsKICAgICB9CisKKyAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBCaW5hcnlBcml0aE9wR2VuZXJhdG9yPgorICAgIHZvaWQgZW1p dEJpbmFyeUJpdE9wU25pcHBldChKX0pJVE9wZXJhdGlvbl9FSkogc2xvd1BhdGhGdW5jdGlvbikK KyAgICB7CisgICAgICAgIE5vZGUqIG5vZGUgPSBtX25vZGU7CisgICAgICAgIAorICAgICAgICAv LyBGSVhNRTogTWFrZSB0aGlzIGRvIGV4Y2VwdGlvbnMuCisgICAgICAgIC8vIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTE2ODYKKyAgICAgICAgICAgIAorICAgICAg ICBMVmFsdWUgbGVmdCA9IGxvd0pTVmFsdWUobm9kZS0+Y2hpbGQxKCkpOworICAgICAgICBMVmFs dWUgcmlnaHQgPSBsb3dKU1ZhbHVlKG5vZGUtPmNoaWxkMigpKTsKKworICAgICAgICBTbmlwcGV0 T3BlcmFuZCBsZWZ0T3BlcmFuZChtX3N0YXRlLmZvck5vZGUobm9kZS0+Y2hpbGQxKCkpLnJlc3Vs dFR5cGUoKSk7CisgICAgICAgIFNuaXBwZXRPcGVyYW5kIHJpZ2h0T3BlcmFuZChtX3N0YXRlLmZv ck5vZGUobm9kZS0+Y2hpbGQyKCkpLnJlc3VsdFR5cGUoKSk7CisgICAgICAgICAgICAKKyAgICAg ICAgUGF0Y2hwb2ludFZhbHVlKiBwYXRjaHBvaW50ID0gbV9vdXQucGF0Y2hwb2ludChJbnQ2NCk7 CisgICAgICAgIHBhdGNocG9pbnQtPmFwcGVuZChsZWZ0LCBWYWx1ZVJlcDo6U29tZVJlZ2lzdGVy KTsKKyAgICAgICAgcGF0Y2hwb2ludC0+YXBwZW5kKHJpZ2h0LCBWYWx1ZVJlcDo6U29tZVJlZ2lz dGVyKTsKKyAgICAgICAgcGF0Y2hwb2ludC0+YXBwZW5kKG1fdGFnTWFzaywgVmFsdWVSZXA6OnJl ZyhHUFJJbmZvOjp0YWdNYXNrUmVnaXN0ZXIpKTsKKyAgICAgICAgcGF0Y2hwb2ludC0+YXBwZW5k KG1fdGFnVHlwZU51bWJlciwgVmFsdWVSZXA6OnJlZyhHUFJJbmZvOjp0YWdUeXBlTnVtYmVyUmVn aXN0ZXIpKTsKKyAgICAgICAgcGF0Y2hwb2ludC0+bnVtR1BTY3JhdGNoUmVnaXN0ZXJzID0gMTsK KyAgICAgICAgcGF0Y2hwb2ludC0+Y2xvYmJlcihSZWdpc3RlclNldDo6bWFjcm9TY3JhdGNoUmVn aXN0ZXJzKCkpOworICAgICAgICBTdGF0ZSogc3RhdGUgPSAmbV9mdGxTdGF0ZTsKKyAgICAgICAg cGF0Y2hwb2ludC0+c2V0R2VuZXJhdG9yKAorICAgICAgICAgICAgWz1dIChDQ2FsbEhlbHBlcnMm IGppdCwgY29uc3QgU3RhY2ttYXBHZW5lcmF0aW9uUGFyYW1zJiBwYXJhbXMpIHsKKyAgICAgICAg ICAgICAgICBBbGxvd01hY3JvU2NyYXRjaFJlZ2lzdGVyVXNhZ2UgYWxsb3dTY3JhdGNoKGppdCk7 CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAgICAgICAgIGF1dG8gZ2VuZXJhdG9yID0g Qm94PEJpbmFyeUFyaXRoT3BHZW5lcmF0b3I+OjpjcmVhdGUoCisgICAgICAgICAgICAgICAgICAg IGxlZnRPcGVyYW5kLCByaWdodE9wZXJhbmQsIEpTVmFsdWVSZWdzKHBhcmFtc1swXS5ncHIoKSks CisgICAgICAgICAgICAgICAgICAgIEpTVmFsdWVSZWdzKHBhcmFtc1sxXS5ncHIoKSksIEpTVmFs dWVSZWdzKHBhcmFtc1syXS5ncHIoKSksIHBhcmFtcy5ncFNjcmF0Y2goMCkpOworCisgICAgICAg ICAgICAgICAgZ2VuZXJhdG9yLT5nZW5lcmF0ZUZhc3RQYXRoKGppdCk7CisgICAgICAgICAgICAg ICAgZ2VuZXJhdG9yLT5lbmRKdW1wTGlzdCgpLmxpbmsoJmppdCk7CisgICAgICAgICAgICAgICAg Q0NhbGxIZWxwZXJzOjpMYWJlbCBkb25lID0gaml0LmxhYmVsKCk7CisKKyAgICAgICAgICAgICAg ICBwYXJhbXMuYWRkTGF0ZVBhdGgoCisgICAgICAgICAgICAgICAgICAgIFs9XSAoQ0NhbGxIZWxw ZXJzJiBqaXQpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIEFsbG93TWFjcm9TY3JhdGNoUmVn aXN0ZXJVc2FnZSBhbGxvd1NjcmF0Y2goaml0KTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgZG8gc29tZXRo aW5nLgorICAgICAgICAgICAgICAgICAgICAgICAgQ0NhbGxIZWxwZXJzOjpKdW1wTGlzdCBleGNl cHRpb25zOworCisgICAgICAgICAgICAgICAgICAgICAgICBnZW5lcmF0b3ItPnNsb3dQYXRoSnVt cExpc3QoKS5saW5rKCZqaXQpOworICAgICAgICAgICAgICAgICAgICAgICAgY2FsbE9wZXJhdGlv bigKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAqc3RhdGUsIHBhcmFtcy51bmF2YWlsYWJs ZVJlZ2lzdGVycygpLCBqaXQsIG5vZGUtPm9yaWdpbi5zZW1hbnRpYywKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAmZXhjZXB0aW9ucywgc2xvd1BhdGhGdW5jdGlvbiwgcGFyYW1zWzBdLmdw cigpLCBwYXJhbXNbMV0uZ3ByKCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgcGFyYW1z WzJdLmdwcigpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGppdC5qdW1wKCkubGlua1RvKGRv bmUsICZqaXQpOworICAgICAgICAgICAgICAgICAgICB9KTsKKyAgICAgICAgICAgIH0pOworCisg ICAgICAgIHNldEpTVmFsdWUocGF0Y2hwb2ludCk7CisgICAgfQogI2VuZGlmIC8vIEZUTF9VU0VT X0IzCiAKICAgICBMVmFsdWUgYWxsb2NhdGVDZWxsKExWYWx1ZSBhbGxvY2F0b3IsIExCYXNpY0Js b2NrIHNsb3dQYXRoKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9v YmplY3QtYml0LWFuZC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVz dHMvc3RyZXNzL29iamVjdC1iaXQtYW5kLmpzCShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vYmplY3QtYml0LWFuZC5qcwkod29ya2luZyBjb3B5KQpA QCAtMCwwICsxLDE2IEBACitmdW5jdGlvbiBmb28oYSwgYikgeworICAgIHJldHVybiBhICYgYjsK K30KKworbm9JbmxpbmUoZm9vKTsKKwordmFyIHRoaW5ncyA9IFt7dmFsdWVPZjogZnVuY3Rpb24o KSB7IHJldHVybiA2OyB9fV07Cit2YXIgcmVzdWx0cyA9IFsyXTsKKworZm9yICh2YXIgaSA9IDA7 IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28odGhpbmdzW2kgJSB0aGlu Z3MubGVuZ3RoXSwgMTApOworICAgIHZhciBleHBlY3RlZCA9IHJlc3VsdHNbaSAlIHJlc3VsdHMu bGVuZ3RoXTsKKyAgICBpZiAocmVzdWx0ICE9IGV4cGVjdGVkKQorICAgICAgICB0aHJvdyAiRXJy b3I6IGJhZCByZXN1bHQgZm9yIGkgPSAiICsgaSArICI6ICIgKyByZXN1bHQ7Cit9CisKSW5kZXg6 IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvdW50eXBlZC1iaXQtYW5kLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvdW50eXBlZC1i aXQtYW5kLmpzCShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0 cmVzcy91bnR5cGVkLWJpdC1hbmQuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxNiBAQAor ZnVuY3Rpb24gZm9vKGEsIGIpIHsKKyAgICByZXR1cm4gYSAmIGI7Cit9CisKK25vSW5saW5lKGZv byk7CisKK3ZhciB0aGluZ3MgPSBbMSwgMi41LCAiMyIsIHt2YWx1ZU9mOiBmdW5jdGlvbigpIHsg cmV0dXJuIDQ7IH19XTsKK3ZhciByZXN1bHRzID0gWzAsIDIsIDIsIDBdOworCitmb3IgKHZhciBp ID0gMDsgaSA8IDEwMDAwMDsgKytpKSB7CisgICAgdmFyIHJlc3VsdCA9IGZvbyh0aGluZ3NbaSAl IHRoaW5ncy5sZW5ndGhdLCAyKTsKKyAgICB2YXIgZXhwZWN0ZWQgPSByZXN1bHRzW2kgJSByZXN1 bHRzLmxlbmd0aF07CisgICAgaWYgKHJlc3VsdCAhPSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cg IkVycm9yOiBiYWQgcmVzdWx0IGZvciBpID0gIiArIGkgKyAiOiAiICsgcmVzdWx0OworfQorCg==