152712 2016-01-04 13:26:46 -0800 Hardware keyboard key-commands stop responding when viewing PDFs 2016-01-04 14:42:51 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton adele enrica mitz simon.fraser oldest_to_newest 1152484 0 thorton 2016-01-04 13:26:46 -0800 Hardware keyboard key-commands stop responding when viewing PDFs 1152485 1 268229 thorton 2016-01-04 13:27:00 -0800 Created attachment 268229 Patch 1152491 2 268229 mitz 2016-01-04 13:30:39 -0800 Comment on attachment 268229 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268229&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:793 > + return [[self _currentContentView] becomeFirstResponder] || [super becomeFirstResponder]; Can’t use a dot here? 1152515 3 thorton 2016-01-04 14:42:51 -0800 http://trac.webkit.org/changeset/194557 268229 2016-01-04 13:27:00 -0800 2016-01-04 13:30:39 -0800 Patch bug-152712-20160104132737.patch text/plain 3064 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZThlZDYxNTIwNDkwZmI0 NjRiYmE1NGVkZjliNzY1ZDM4OTBiZjNhMC4uNWRhYWM4NzNiNGViY2E2OTQyYmJiNTNjMTFhYjYw ZGMyOGRkZjQ0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE2LTAxLTA0ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIEhhcmR3YXJlIGtl eWJvYXJkIGtleS1jb21tYW5kcyBzdG9wIHJlc3BvbmRpbmcgd2hlbiB2aWV3aW5nIFBERnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjcxMgorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjMwMTQ0NTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTWFpbnRhaW4gZmlyc3QgcmVzcG9uZGVyIHN0YXR1cyB0 aHJvdWdoIGFueSBjb250ZW50IHZpZXcgc3dhcHBpbmcsIGJ5CisgICAgICAgIG1ha2luZyBXS1dl YlZpZXcgYmVjb21lIGZpcnN0IHJlc3BvbmRlciBpZiBuZWVkZWQsIGFuZCBwdXNoaW5nIGZpcnN0 CisgICAgICAgIHJlc3BvbmRlciBzdGF0dXMgZG93biB0byB0aGUgc3dhcHBlZC1pbiBjb250ZW50 IHZpZXcgaWYgcG9zc2libGUuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbToKKyAgICAgICAgKC1bV0tXZWJWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyXSk6Cisg ICAgICAgIE1ha2UgdGhlIGN1cnJlbnQgY29udGVudCB2aWV3IGZpcnN0IHJlc3BvbmRlciBpbnN0 ZWFkIG9mIHRoZSBXS0NvbnRlbnRWaWV3LAorICAgICAgICBpbiBjYXNlIHdlIGhhdmUgYSBjdXN0 b20gY29udGVudCB2aWV3IGluc3RhbGxlZC4KKworICAgICAgICAoLVtXS1dlYlZpZXcgY2FuQmVj b21lRmlyc3RSZXNwb25kZXJdKToKKyAgICAgICAgV0tXZWJWaWV3IGNhbiBhbHdheXMgYmVjb21l IGZpcnN0IHJlc3BvbmRlciwgZXZlbiBpZiBub25lIG9mIGl0cyBjaGlsZHJlbiBjYW4uCisgICAg ICAgIFRoaXMgbWFrZXMgaXQgc28gdGhhdCBpZiBhIGN1c3RvbSBjb250ZW50IHZpZXcgY2FuJ3Qg YmVjb21lIGZpcnN0IHJlc3BvbmRlciwKKyAgICAgICAgV0tXZWJWaWV3IHdpbGwgdGFrZSB0aGUg cmVzcG9uc2liaWxpdHkuCisKKyAgICAgICAgKC1bV0tXZWJWaWV3IF9zZXRIYXNDdXN0b21Db250 ZW50Vmlldzpsb2FkZWRNSU1FVHlwZTpdKToKKyAgICAgICAgUmV0dXJuIHRoZSByZXNwb25zaWJp bGl0eSBvZiBiZWluZyBmaXJzdCByZXNwb25kZXIgdG8gdGhlIG5ld2x5LWluc3RhbGxlZAorICAg ICAgICBjb250ZW50IHZpZXcgaWYgV0tXZWJWaWV3IGlzIGN1cnJlbnRseSB0aGUgZmlyc3QgcmVz cG9uZGVyIChlaXRoZXIgYmVjYXVzZQorICAgICAgICBvZiB0YWIgc3dpdGNoaW5nIG9yIGJlY2F1 c2UgdGhlIHByZXZpb3VzIGNvbnRlbnQgdmlldyBkaWQgbm90IHN1cHBvcnQKKyAgICAgICAgYmVp bmcgZmlyc3QgcmVzcG9uZGVyKSwgaWYgaXQgc3VwcG9ydHMgYmVpbmcgZmlyc3QgcmVzcG9uZGVy LgorCiAyMDE2LTAxLTA0ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUHJvZ3Jlc3MgdG93YXJkcyBpbXBsZW1lbnRpbmcgZG93bmxvYWRzIHdp dGggTmV0d29ya1Nlc3Npb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2Nv YS9XS1dlYlZpZXcubW0KaW5kZXggNjI3ZWEyNjhkZjg0YWJkNmJmNDNjM2I0NmRmY2E2MzQxNWEy OWEwZS4uMTkwZDRjODIyOTA4ODU2YWY0NjBhNDkyN2FmNzRhNzRlYTBiZGNiZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KKysrIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KQEAgLTc5MCw3 ICs3OTAsMTIgQEAgc3RhdGljIFdLRXJyb3JDb2RlIGNhbGxiYWNrRXJyb3JDb2RlKFdlYktpdDo6 Q2FsbGJhY2tCYXNlOjpFcnJvciBlcnJvcikKIAogLSAoQk9PTCliZWNvbWVGaXJzdFJlc3BvbmRl cgogewotICAgIHJldHVybiBbX2NvbnRlbnRWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyXSB8fCBb c3VwZXIgYmVjb21lRmlyc3RSZXNwb25kZXJdOworICAgIHJldHVybiBbW3NlbGYgX2N1cnJlbnRD b250ZW50Vmlld10gYmVjb21lRmlyc3RSZXNwb25kZXJdIHx8IFtzdXBlciBiZWNvbWVGaXJzdFJl c3BvbmRlcl07Cit9CisKKy0gKEJPT0wpY2FuQmVjb21lRmlyc3RSZXNwb25kZXIKK3sKKyAgICBy ZXR1cm4gWUVTOwogfQogCiBzdGF0aWMgaW5saW5lIENHRmxvYXQgZmxvb3JUb0RldmljZVBpeGVs KENHRmxvYXQgaW5wdXQsIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yKQpAQCAtODU4LDYgKzg2Myw5 IEBAIHN0YXRpYyBDR1NpemUgcm91bmRTY3JvbGxWaWV3Q29udGVudFNpemUoY29uc3QgV2ViS2l0 OjpXZWJQYWdlUHJveHkmIHBhZ2UsIENHU2l6CiAgICAgICAgIFtfY3VzdG9tQ29udGVudEZpeGVk T3ZlcmxheVZpZXcgc2V0RnJhbWU6c2VsZi5ib3VuZHNdOwogICAgICAgICBbc2VsZiBhZGRTdWJ2 aWV3Ol9jdXN0b21Db250ZW50Rml4ZWRPdmVybGF5Vmlldy5nZXQoKV07CiAgICAgfQorCisgICAg aWYgKHNlbGYuaXNGaXJzdFJlc3BvbmRlciAmJiBzZWxmLl9jdXJyZW50Q29udGVudFZpZXcuY2Fu QmVjb21lRmlyc3RSZXNwb25kZXIpCisgICAgICAgIFtzZWxmLl9jdXJyZW50Q29udGVudFZpZXcg YmVjb21lRmlyc3RSZXNwb25kZXJdOwogfQogCiAtICh2b2lkKV9kaWRGaW5pc2hMb2FkaW5nRGF0 YUZvckN1c3RvbUNvbnRlbnRQcm92aWRlcldpdGhTdWdnZXN0ZWRGaWxlbmFtZTooY29uc3QgU3Ry aW5nJilzdWdnZXN0ZWRGaWxlbmFtZSBkYXRhOihOU0RhdGEgKilkYXRhCg==