152709 2016-01-04 12:55:16 -0800 FTL B3 should do all of the non-bitop binary snippets 2016-01-04 13:34:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 152668 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1152466 0 fpizlo 2016-01-04 12:55:16 -0800 Patch forthcoming. 1152473 1 268226 fpizlo 2016-01-04 13:07:46 -0800 Created attachment 268226 the patch 1152474 2 268226 mark.lam 2016-01-04 13:12:28 -0800 Comment on attachment 268226 the patch I think these tests are already covered by the op_mul.js, op_div.js, op_add.js stress tests. If there are missing operand value cases, you can just add the values to those tests. 1152493 3 mark.lam 2016-01-04 13:31:19 -0800 (In reply to comment #2) > Comment on attachment 268226 [details] > the patch > > I think these tests are already covered by the op_mul.js, op_div.js, > op_add.js stress tests. If there are missing operand value cases, you can > just add the values to those tests. Talked to Fil offline. He pointed out that these tests run for 100000 iterations and are targetted towards the FTL, whereas the pre-existing tests only iterate up to 10000. Rather than making the comprehensive tests wait for 100000 iterations, I'm ok with having these additional small test subsets just for the ftl. 1152494 4 fpizlo 2016-01-04 13:34:11 -0800 Landed in http://trac.webkit.org/changeset/194553 268226 2016-01-04 13:07:46 -0800 2016-01-04 13:12:28 -0800 the patch blah.patch text/plain 6821 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NTQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM0IEBA CisyMDE2LTAxLTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIEIzIHNob3VsZCBkbyBhbGwgb2YgdGhlIG5vbi1iaXRvcCBiaW5hcnkgc25pcHBldHMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjcwOQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZnRsL0ZUTExv d2VyREZHVG9MTFZNLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpERkc6Okxvd2VyREZHVG9MTFZN Ojpjb21waWxlVmFsdWVBZGQpOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xM Vk06OmNvbXBpbGVTdHJDYXQpOgorICAgICAgICAoSlNDOjpGVEw6OkRGRzo6TG93ZXJERkdUb0xM Vk06OmNvbXBpbGVBcml0aE11bCk6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1Rv TExWTTo6Y29tcGlsZUFyaXRoRGl2KToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3Mvb2JqZWN0LWFk ZC5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorICAgICAgICAodGhpbmdzLnZhbHVlT2YpOgor ICAgICAgICAqIHRlc3RzL3N0cmVzcy9vYmplY3QtZGl2LmpzOiBBZGRlZC4KKyAgICAgICAgKGZv byk6CisgICAgICAgICh0aGluZ3MudmFsdWVPZik6CisgICAgICAgICogdGVzdHMvc3RyZXNzL29i amVjdC1tdWwuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKHRoaW5ncy52YWx1 ZU9mKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvdW50eXBlZC1hZGQuanM6IEFkZGVkLgorICAg ICAgICAoZm9vKToKKyAgICAgICAgKHZhbHVlT2YpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy91 bnR5cGVkLWRpdi5qczogQWRkZWQuCisgICAgICAgIChmb28pOgorICAgICAgICAodmFsdWVPZik6 CisgICAgICAgICogdGVzdHMvc3RyZXNzL3VudHlwZWQtbXVsLmpzOiBBZGRlZC4KKyAgICAgICAg KGZvbyk6CisgICAgICAgICh2YWx1ZU9mKToKKwogMjAxNi0wMS0wNCAgRmlsaXAgUGl6bG8gIDxm cGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZUTCBCMyBzaG91bGQgZG8gdGhlIEFyaXRoU3Vi IGJpbmFyeSBzbmlwcGV0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2Vy REZHVG9MTFZNLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TExvd2VyREZHVG9MTFZNLmNwcAkocmV2aXNpb24gMTk0NTQ4KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2Z0bC9GVExMb3dlckRGR1RvTExWTS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxLDYg KzUxLDkgQEAKICNpbmNsdWRlICJGVExPdXRwdXQuaCIKICNpbmNsdWRlICJGVExUaHVua3MuaCIK ICNpbmNsdWRlICJGVExXZWlnaHRlZFRhcmdldC5oIgorI2luY2x1ZGUgIkpJVEFkZEdlbmVyYXRv ci5oIgorI2luY2x1ZGUgIkpJVERpdkdlbmVyYXRvci5oIgorI2luY2x1ZGUgIkpJVE11bEdlbmVy YXRvci5oIgogI2luY2x1ZGUgIkpJVFN1YkdlbmVyYXRvci5oIgogI2luY2x1ZGUgIkpTQXJyb3dG dW5jdGlvbi5oIgogI2luY2x1ZGUgIkpTQ0lubGluZXMuaCIKQEAgLTE1OTYsNyArMTU5OSwxMSBA QCBwcml2YXRlOgogICAgIAogICAgIHZvaWQgY29tcGlsZVZhbHVlQWRkKCkKICAgICB7CisjaWYg RlRMX1VTRVNfQjMKKyAgICAgICAgZW1pdEJpbmFyeVNuaXBwZXQ8SklUQWRkR2VuZXJhdG9yPihv cGVyYXRpb25WYWx1ZUFkZCk7CisjZWxzZSAvLyBGVExfVVNFU19CMwogICAgICAgICBjb21waWxl VW50eXBlZEJpbmFyeU9wPFZhbHVlQWRkRGVzY3JpcHRvcj4oKTsKKyNlbmRpZiAvLyBGVExfVVNF U19CMwogICAgIH0KICAgICAKICAgICB2b2lkIGNvbXBpbGVTdHJDYXQoKQpAQCAtMTg0NSw3ICsx ODUyLDExIEBAIHByaXZhdGU6CiAgICAgICAgIH0KIAogICAgICAgICBjYXNlIFVudHlwZWRVc2U6 IHsKKyNpZiBGVExfVVNFU19CMworICAgICAgICAgICAgZW1pdEJpbmFyeVNuaXBwZXQ8SklUTXVs R2VuZXJhdG9yPihvcGVyYXRpb25WYWx1ZU11bCk7CisjZWxzZSAvLyBGVExfVVNFU19CMwogICAg ICAgICAgICAgY29tcGlsZVVudHlwZWRCaW5hcnlPcDxBcml0aE11bERlc2NyaXB0b3I+KCk7Cisj ZW5kaWYgLy8gRlRMX1VTRVNfQjMKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAKQEAg LTE5MTQsNyArMTkyNSwxMSBAQCBwcml2YXRlOgogICAgICAgICB9CiAKICAgICAgICAgY2FzZSBV bnR5cGVkVXNlOiB7CisjaWYgRlRMX1VTRVNfQjMKKyAgICAgICAgICAgIGVtaXRCaW5hcnlTbmlw cGV0PEpJVERpdkdlbmVyYXRvciwgTmVlZFNjcmF0Y2hGUFI+KG9wZXJhdGlvblZhbHVlRGl2KTsK KyNlbHNlIC8vIEZUTF9VU0VTX0IzCiAgICAgICAgICAgICBjb21waWxlVW50eXBlZEJpbmFyeU9w PEFyaXRoRGl2RGVzY3JpcHRvciwgSGFzQ29uc3RJbnQzMk9wZXJhbmRPcHRpbWl6YXRpb24sIEhh c0NvbnN0RG91YmxlT3BlcmFuZE9wdGltaXphdGlvbj4oKTsKKyNlbmRpZiAvLyBGVExfVVNFU19C MwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3Rlc3RzL3N0cmVzcy9vYmplY3QtYWRkLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0LWFkZC5qcwkocmV2aXNpb24gMCkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0LWFkZC5qcwkod29ya2lu ZyBjb3B5KQpAQCAtMCwwICsxLDE2IEBACitmdW5jdGlvbiBmb28oYSwgYikgeworICAgIHJldHVy biBhICsgYjsKK30KKworbm9JbmxpbmUoZm9vKTsKKwordmFyIHRoaW5ncyA9IFt7dmFsdWVPZjog ZnVuY3Rpb24oKSB7IHJldHVybiA0OyB9fV07Cit2YXIgcmVzdWx0cyA9IFs1XTsKKworZm9yICh2 YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28odGhpbmdz W2kgJSB0aGluZ3MubGVuZ3RoXSwgMSk7CisgICAgdmFyIGV4cGVjdGVkID0gcmVzdWx0c1tpICUg cmVzdWx0cy5sZW5ndGhdOworICAgIGlmIChyZXN1bHQgIT0gZXhwZWN0ZWQpCisgICAgICAgIHRo cm93ICJFcnJvcjogYmFkIHJlc3VsdCBmb3IgaSA9ICIgKyBpICsgIjogIiArIHJlc3VsdDsKK30K KwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9vYmplY3QtZGl2Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0 LWRpdi5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJl c3Mvb2JqZWN0LWRpdi5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE2IEBACitmdW5jdGlv biBmb28oYSwgYikgeworICAgIHJldHVybiBhIC8gYjsKK30KKworbm9JbmxpbmUoZm9vKTsKKwor dmFyIHRoaW5ncyA9IFt7dmFsdWVPZjogZnVuY3Rpb24oKSB7IHJldHVybiA0OyB9fV07Cit2YXIg cmVzdWx0cyA9IFsyXTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7ICsraSkgeworICAg IHZhciByZXN1bHQgPSBmb28odGhpbmdzW2kgJSB0aGluZ3MubGVuZ3RoXSwgMik7CisgICAgdmFy IGV4cGVjdGVkID0gcmVzdWx0c1tpICUgcmVzdWx0cy5sZW5ndGhdOworICAgIGlmIChyZXN1bHQg IT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3VsdCBmb3IgaSA9ICIg KyBpICsgIjogIiArIHJlc3VsdDsKK30KKwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rl c3RzL3N0cmVzcy9vYmplY3QtbXVsLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0LW11bC5qcwkocmV2aXNpb24gMCkKKysrIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3Mvb2JqZWN0LW11bC5qcwkod29ya2luZyBjb3B5KQpA QCAtMCwwICsxLDE2IEBACitmdW5jdGlvbiBmb28oYSwgYikgeworICAgIHJldHVybiBhICogYjsK K30KKworbm9JbmxpbmUoZm9vKTsKKwordmFyIHRoaW5ncyA9IFt7dmFsdWVPZjogZnVuY3Rpb24o KSB7IHJldHVybiA0OyB9fV07Cit2YXIgcmVzdWx0cyA9IFs4XTsKKworZm9yICh2YXIgaSA9IDA7 IGkgPCAxMDAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28odGhpbmdzW2kgJSB0aGlu Z3MubGVuZ3RoXSwgMik7CisgICAgdmFyIGV4cGVjdGVkID0gcmVzdWx0c1tpICUgcmVzdWx0cy5s ZW5ndGhdOworICAgIGlmIChyZXN1bHQgIT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93ICJFcnJv cjogYmFkIHJlc3VsdCBmb3IgaSA9ICIgKyBpICsgIjogIiArIHJlc3VsdDsKK30KKwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy91bnR5cGVkLWFkZC5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3VudHlwZWQtYWRkLmpz CShyZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy91bnR5 cGVkLWFkZC5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE2IEBACitmdW5jdGlvbiBmb28o YSwgYikgeworICAgIHJldHVybiBhICsgYjsKK30KKworbm9JbmxpbmUoZm9vKTsKKwordmFyIHRo aW5ncyA9IFsxLCAyLjUsICIzIiwge3ZhbHVlT2Y6IGZ1bmN0aW9uKCkgeyByZXR1cm4gNDsgfX1d OwordmFyIHJlc3VsdHMgPSBbMiwgMy41LCAiMzEiLCA1XTsKKworZm9yICh2YXIgaSA9IDA7IGkg PCAxMDAwMDA7ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28odGhpbmdzW2kgJSB0aGluZ3Mu bGVuZ3RoXSwgMSk7CisgICAgdmFyIGV4cGVjdGVkID0gcmVzdWx0c1tpICUgcmVzdWx0cy5sZW5n dGhdOworICAgIGlmIChyZXN1bHQgIT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93ICJFcnJvcjog YmFkIHJlc3VsdCBmb3IgaSA9ICIgKyBpICsgIjogIiArIHJlc3VsdDsKK30KKwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy91bnR5cGVkLWRpdi5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3VudHlwZWQtZGl2LmpzCShy ZXZpc2lvbiAwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy91bnR5cGVk LWRpdi5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE2IEBACitmdW5jdGlvbiBmb28oYSwg YikgeworICAgIHJldHVybiBhIC8gYjsKK30KKworbm9JbmxpbmUoZm9vKTsKKwordmFyIHRoaW5n cyA9IFsxLCAyLjUsICIzIiwge3ZhbHVlT2Y6IGZ1bmN0aW9uKCkgeyByZXR1cm4gNDsgfX1dOwor dmFyIHJlc3VsdHMgPSBbMC41LCAxLjI1LCAxLjUsIDJdOworCitmb3IgKHZhciBpID0gMDsgaSA8 IDEwMDAwMDsgKytpKSB7CisgICAgdmFyIHJlc3VsdCA9IGZvbyh0aGluZ3NbaSAlIHRoaW5ncy5s ZW5ndGhdLCAyKTsKKyAgICB2YXIgZXhwZWN0ZWQgPSByZXN1bHRzW2kgJSByZXN1bHRzLmxlbmd0 aF07CisgICAgaWYgKHJlc3VsdCAhPSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cgIkVycm9yOiBi YWQgcmVzdWx0IGZvciBpID0gIiArIGkgKyAiOiAiICsgcmVzdWx0OworfQorCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3VudHlwZWQtbXVsLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvdW50eXBlZC1tdWwuanMJKHJl dmlzaW9uIDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL3VudHlwZWQt bXVsLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTYgQEAKK2Z1bmN0aW9uIGZvbyhhLCBi KSB7CisgICAgcmV0dXJuIGEgKiBiOworfQorCitub0lubGluZShmb28pOworCit2YXIgdGhpbmdz ID0gWzEsIDIuNSwgIjMiLCB7dmFsdWVPZjogZnVuY3Rpb24oKSB7IHJldHVybiA0OyB9fV07Cit2 YXIgcmVzdWx0cyA9IFsyLCA1LCA2LCA4XTsKKworZm9yICh2YXIgaSA9IDA7IGkgPCAxMDAwMDA7 ICsraSkgeworICAgIHZhciByZXN1bHQgPSBmb28odGhpbmdzW2kgJSB0aGluZ3MubGVuZ3RoXSwg Mik7CisgICAgdmFyIGV4cGVjdGVkID0gcmVzdWx0c1tpICUgcmVzdWx0cy5sZW5ndGhdOworICAg IGlmIChyZXN1bHQgIT0gZXhwZWN0ZWQpCisgICAgICAgIHRocm93ICJFcnJvcjogYmFkIHJlc3Vs dCBmb3IgaSA9ICIgKyBpICsgIjogIiArIHJlc3VsdDsKK30KKwo=