152694 2016-01-04 09:58:52 -0800 [WinCairo] Download should use header values from provided request object. 2016-01-05 03:43:33 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham oldest_to_newest 1152356 0 peavo 2016-01-04 09:58:52 -0800 We currently ignore the header values in the request object, but we shouldn't do that. 1152359 1 268201 peavo 2016-01-04 10:03:10 -0800 Created attachment 268201 Patch 1152367 2 268201 achristensen 2016-01-04 10:11:02 -0800 Comment on attachment 268201 Patch It would be better to just iterate the existing headers, not all possible headers. What if there is an unrecognized header? 1152404 3 peavo 2016-01-04 11:18:55 -0800 (In reply to comment #2) > Comment on attachment 268201 [details] > Patch > > It would be better to just iterate the existing headers, not all possible > headers. What if there is an unrecognized header? Thanks for looking into this :) As far as I can see, the IWebURLRequest interface does not support iterating over existing headers, but maybe I've missed something? It is possible to get all headers as an IPropertyBag object, but this type only seems to support reading known header names. 1152425 4 268201 achristensen 2016-01-04 11:43:48 -0800 Comment on attachment 268201 Patch I think this is a bad approach. I think this should do something more like WebDownload::initWithRequest in WebDownloadCFNet.cpp instead 1152432 5 peavo 2016-01-04 11:55:44 -0800 (In reply to comment #4) > Comment on attachment 268201 [details] > Patch > > I think this is a bad approach. I think this should do something more like > WebDownload::initWithRequest in WebDownloadCFNet.cpp instead Thanks, looks good, I'll update the patch :) 1152460 6 268222 peavo 2016-01-04 12:51:52 -0800 Created attachment 268222 Patch 1152475 7 268222 achristensen 2016-01-04 13:17:58 -0800 Comment on attachment 268222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268222&action=review r=me > Source/WebKit/win/WebDownloadCurl.cpp:105 > + init(nullptr, resourceRequest, ResourceResponse(), delegate); this ResourceResponse() might cause some problems. 1152478 8 peavo 2016-01-04 13:23:14 -0800 (In reply to comment #7) > Comment on attachment 268222 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268222&action=review > > r=me > > > Source/WebKit/win/WebDownloadCurl.cpp:105 > > + init(nullptr, resourceRequest, ResourceResponse(), delegate); > > this ResourceResponse() might cause some problems. Thanks for reviewing :) I don't think the ResourceResponse object is used, is that what you mean? 1152483 9 achristensen 2016-01-04 13:25:01 -0800 We might run into some code somewhere where we want to use the ResourceResponse object and it's not a meaningful object. If we run into this, we'll fix it in the future. 1152488 10 peavo 2016-01-04 13:27:48 -0800 (In reply to comment #9) > We might run into some code somewhere where we want to use the > ResourceResponse object and it's not a meaningful object. If we run into > this, we'll fix it in the future. Sounds good. 1152695 11 peavo 2016-01-05 03:43:33 -0800 Committed r194581: <http://trac.webkit.org/changeset/194581> 268201 2016-01-04 10:03:10 -0800 2016-01-04 12:51:43 -0800 Patch bug-152694-20160104190253.patch text/plain 2136 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDUzNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTA0 ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fp cm9dIERvd25sb2FkIHNob3VsZCB1c2UgaGVhZGVyIHZhbHVlcyBmcm9tIHByb3ZpZGVkIHJlcXVl c3Qgb2JqZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUyNjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29weSBoZWFkZXIgdmFsdWVzIGZyb20gcmVxdWVzdCBvYmplY3QgcGFyYW1ldGVyLgorCisg ICAgICAgICogV2ViRG93bmxvYWRDdXJsLmNwcDoKKyAgICAgICAgKFdlYkRvd25sb2FkOjppbml0 V2l0aFJlcXVlc3QpOgorCiAyMDE1LTEyLTMxICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXBsYWNlIFdURjo6bW92ZSB3aXRoIFdURk1vdmUKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC93aW4vV2ViRG93bmxvYWRDdXJsLmNwcAkocmV2aXNpb24gMTk0NTM0KQorKysgU291cmNl L1dlYktpdC93aW4vV2ViRG93bmxvYWRDdXJsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMsNiAr NDMsNyBAQAogI2luY2x1ZGUgPHN5cy90eXBlcy5oPgogCiAjaW5jbHVkZSA8V2ViQ29yZS9CU3Ry aW5nLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9IVFRQSGVhZGVyTmFtZXMuaD4KICNpbmNsdWRlIDxX ZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUVycm9y Lmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZUhhbmRsZS5oPgpAQCAtODMsMTIgKzg0LDI5 IEBAIEhSRVNVTFQgV2ViRG93bmxvYWQ6OmluaXRXaXRoUmVxdWVzdCgKICAgICAgICAgLyogW2lu XSAqLyBJV2ViVVJMUmVxdWVzdCogcmVxdWVzdCwgCiAgICAgICAgIC8qIFtpbl0gKi8gSVdlYkRv d25sb2FkRGVsZWdhdGUqIGRlbGVnYXRlKQogeworICAgIGlmICghcmVxdWVzdCkKKyAgICAgICAg cmV0dXJuIEVfUE9JTlRFUjsKKwogICAgIEJTdHJpbmcgdXJsOwogCiAgICAgaWYgKCFTVUNDRUVE RUQocmVxdWVzdC0+VVJMKCZ1cmwpKSkKICAgICAgICAgcmV0dXJuIEVfRkFJTDsKIAotICAgIGlu aXQoVVJMKFBhcnNlZFVSTFN0cmluZywgU3RyaW5nKHVybCkpLCBkZWxlZ2F0ZSk7CisgICAgUmVz b3VyY2VSZXF1ZXN0IHJlc291cmNlUmVxdWVzdDsKKyAgICByZXNvdXJjZVJlcXVlc3Quc2V0VVJM KFVSTChQYXJzZWRVUkxTdHJpbmcsIFN0cmluZyh1cmwpKSk7CisKKyAgICBmb3IgKGludCBpID0g MDsgaSA8IG51bUhUVFBIZWFkZXJOYW1lczsgaSsrKSB7CisgICAgICAgIFN0cmluZ1ZpZXcgbmFt ZSA9IGh0dHBIZWFkZXJOYW1lU3RyaW5nKHN0YXRpY19jYXN0PEhUVFBIZWFkZXJOYW1lPihpKSk7 CisgICAgICAgIEJTdHJpbmcgdmFsdWU7CisgICAgICAgIGlmIChGQUlMRUQocmVxdWVzdC0+dmFs dWVGb3JIVFRQSGVhZGVyRmllbGQoQlN0cmluZyhuYW1lLnRvU3RyaW5nKCkpLCAmdmFsdWUpKSkK KyAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAgICBTdHJpbmcgaGVhZGVyVmFsdWUgPSBzdGF0 aWNfY2FzdDxCU1RSPih2YWx1ZSk7CisgICAgICAgIGlmIChoZWFkZXJWYWx1ZS5pc0VtcHR5KCkp CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgcmVzb3VyY2VSZXF1ZXN0LnNldEhUVFBI ZWFkZXJGaWVsZChuYW1lLnRvU3RyaW5nKCksIGhlYWRlclZhbHVlKTsKKyAgICB9CisKKyAgICBp bml0KG51bGxwdHIsIHJlc291cmNlUmVxdWVzdCwgUmVzb3VyY2VSZXNwb25zZSgpLCBkZWxlZ2F0 ZSk7CiAKICAgICByZXR1cm4gU19PSzsKIH0K 268222 2016-01-04 12:51:52 -0800 2016-01-04 13:17:58 -0800 Patch bug-152694-20160104215134.patch text/plain 1803 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDUzNCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTA0 ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luQ2Fp cm9dIERvd25sb2FkIHNob3VsZCB1c2UgaGVhZGVyIHZhbHVlcyBmcm9tIHByb3ZpZGVkIHJlcXVl c3Qgb2JqZWN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUyNjk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQ29weSBoZWFkZXIgdmFsdWVzIGZyb20gcmVxdWVzdCBvYmplY3QgcGFyYW1ldGVyLgorCisg ICAgICAgICogV2ViRG93bmxvYWRDdXJsLmNwcDoKKyAgICAgICAgKFdlYkRvd25sb2FkOjppbml0 V2l0aFJlcXVlc3QpOgorCiAyMDE1LTEyLTMxICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXBsYWNlIFdURjo6bW92ZSB3aXRoIFdURk1vdmUKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvd2luL1dlYkRvd25sb2FkQ3VybC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC93aW4vV2ViRG93bmxvYWRDdXJsLmNwcAkocmV2aXNpb24gMTk0NTM0KQorKysgU291cmNl L1dlYktpdC93aW4vV2ViRG93bmxvYWRDdXJsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODMsMTIg KzgzLDI2IEBAIEhSRVNVTFQgV2ViRG93bmxvYWQ6OmluaXRXaXRoUmVxdWVzdCgKICAgICAgICAg LyogW2luXSAqLyBJV2ViVVJMUmVxdWVzdCogcmVxdWVzdCwgCiAgICAgICAgIC8qIFtpbl0gKi8g SVdlYkRvd25sb2FkRGVsZWdhdGUqIGRlbGVnYXRlKQogeworICAgIGlmICghcmVxdWVzdCkKKyAg ICAgICAgcmV0dXJuIEVfUE9JTlRFUjsKKworICAgIENPTVB0cjxXZWJNdXRhYmxlVVJMUmVxdWVz dD4gd2ViUmVxdWVzdDsKKyAgICBpZiAoRkFJTEVEKHJlcXVlc3QtPlF1ZXJ5SW50ZXJmYWNlKCZ3 ZWJSZXF1ZXN0KSkpCisgICAgICAgIHJldHVybiBFX0ZBSUw7CisKICAgICBCU3RyaW5nIHVybDsK IAogICAgIGlmICghU1VDQ0VFREVEKHJlcXVlc3QtPlVSTCgmdXJsKSkpCiAgICAgICAgIHJldHVy biBFX0ZBSUw7CiAKLSAgICBpbml0KFVSTChQYXJzZWRVUkxTdHJpbmcsIFN0cmluZyh1cmwpKSwg ZGVsZWdhdGUpOworICAgIFJlc291cmNlUmVxdWVzdCByZXNvdXJjZVJlcXVlc3Q7CisgICAgcmVz b3VyY2VSZXF1ZXN0LnNldFVSTChVUkwoUGFyc2VkVVJMU3RyaW5nLCBTdHJpbmcodXJsKSkpOwor CisgICAgY29uc3QgSFRUUEhlYWRlck1hcCYgaGVhZGVyTWFwID0gd2ViUmVxdWVzdC0+aHR0cEhl YWRlckZpZWxkcygpOworICAgIGZvciAoSFRUUEhlYWRlck1hcDo6Y29uc3RfaXRlcmF0b3IgaXQg PSBoZWFkZXJNYXAuYmVnaW4oKTsgaXQgIT0gaGVhZGVyTWFwLmVuZCgpOyArK2l0KQorICAgICAg ICByZXNvdXJjZVJlcXVlc3Quc2V0SFRUUEhlYWRlckZpZWxkKGl0LT5rZXksIGl0LT52YWx1ZSk7 CisKKyAgICBpbml0KG51bGxwdHIsIHJlc291cmNlUmVxdWVzdCwgUmVzb3VyY2VSZXNwb25zZSgp LCBkZWxlZ2F0ZSk7CiAKICAgICByZXR1cm4gU19PSzsKIH0K