152693 2016-01-04 09:50:46 -0800 [mips] Lower immediates of logical operations. 2016-01-19 09:03:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue guijemont jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1152353 0 annulen 2016-01-04 09:50:46 -0800 On MIPS immediate operand of andi is required to be 16-bit non-negative number. 1152358 1 268200 annulen 2016-01-04 10:01:00 -0800 Created attachment 268200 Lower immediates of andi and andp 1152709 2 268200 jbriance 2016-01-05 07:03:45 -0800 Comment on attachment 268200 Lower immediates of andi and andp View in context: https://bugs.webkit.org/attachment.cgi?id=268200&action=review LGTM > Source/JavaScriptCore/offlineasm/mips.rb:525 > + when "andi", "andp" Please add other logical operations having this limitation (ori, orp, xori and xorp) 1153425 3 268455 annulen 2016-01-07 09:25:52 -0800 Created attachment 268455 Patch 1153427 4 jbriance 2016-01-07 09:32:50 -0800 Great, thanks 1153554 5 annulen 2016-01-07 13:35:53 -0800 Michael, could you take a look at this? 1153575 6 268455 msaboff 2016-01-07 14:09:35 -0800 Comment on attachment 268455 Patch r=me 1153585 7 268455 commit-queue 2016-01-07 14:13:56 -0800 Comment on attachment 268455 Patch Clearing flags on attachment: 268455 Committed r194725: <http://trac.webkit.org/changeset/194725> 1153586 8 commit-queue 2016-01-07 14:13:59 -0800 All reviewed patches have been landed. Closing bug. 1155723 9 jbriance 2016-01-15 00:51:25 -0800 *** Bug 150376 has been marked as a duplicate of this bug. *** 1156504 10 guijemont 2016-01-18 18:35:30 -0800 (In reply to comment #3) > Created attachment 268455 [details] > Patch Sorry, I'm a bit late here ;). I understood that the andi, ori and xori instructions interpret the 16 bit immediate as unsigned, so I understand that we could use the instruction for the range 0x0..0xffff, and not only for 0x0..0x7fff. Or did I miss something? 1156573 11 jbriance 2016-01-19 02:02:13 -0800 (In reply to comment #10) > Sorry, I'm a bit late here ;). I understood that the andi, ori and xori > instructions interpret the 16 bit immediate as unsigned, so I understand > that we could use the instruction for the range 0x0..0xffff, and not only > for 0x0..0x7fff. Or did I miss something? You're right. However if this case happens (immediate value in 0x7fff..0xffff), we'll also have to update the mipsOperand method of Immediate class to accept this range. 1156576 12 annulen 2016-01-19 02:16:46 -0800 Guillaume: you ar right, thanks for the gotcha. Julien: Immediate.mipsOperand allows -0x7fff <= value <= 0xffff, so it is already accepted. 1156579 13 annulen 2016-01-19 02:30:15 -0800 Reopening to attach new patch. 1156580 14 269263 annulen 2016-01-19 02:30:18 -0800 Created attachment 269263 Patch 1156583 15 jbriance 2016-01-19 02:47:58 -0800 (In reply to comment #12) > Julien: Immediate.mipsOperand allows -0x7fff <= value <= 0xffff, so it is > already accepted. Indeed, I read too quickly :) 1156606 16 269263 msaboff 2016-01-19 08:12:40 -0800 Comment on attachment 269263 Patch r=me 1156609 17 269263 commit-queue 2016-01-19 09:03:25 -0800 Comment on attachment 269263 Patch Clearing flags on attachment: 269263 Committed r195290: <http://trac.webkit.org/changeset/195290> 1156610 18 commit-queue 2016-01-19 09:03:28 -0800 All reviewed patches have been landed. Closing bug. 268200 2016-01-04 10:01:00 -0800 2016-01-07 09:25:52 -0800 Lower immediates of andi and andp 0001-mips-Lower-immediates-of-andi-and-andp.patch text/plain 1729 annulen RnJvbSA1NzFiZGUyYTRkZWE0YmE0ZWE1YTA3YmQyZGNkNWE2YmE5NDE2ZGIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIFRva2FyZXYgPGFubnVsZW5AeWFuZGV4LnJ1 PgpEYXRlOiBNb24sIDQgSmFuIDIwMTYgMTg6NDQ6NTggKzAzMDAKU3ViamVjdDogW1BBVENIIDEv MV0gW21pcHNdIExvd2VyIGltbWVkaWF0ZXMgb2YgYW5kaSBhbmQgYW5kcC4KCk9uIE1JUFMgaW1t ZWRpYXRlIG9wZXJhbmQgb2YgYW5kaSBpcyByZXF1aXJlZCB0byBiZSAxNi1iaXQKbm9uLW5lZ2F0 aXZlIG51bWJlci4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nICAgICAgICAg IHwgMTIgKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBz LnJiIHwgIDIgKysKIDIgZmlsZXMgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCmluZGV4IGMzMDFkZmMuLjFhMmQxZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTA0ICBLb25zdGFudGluIFRva2FyZXYgIDxh bm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBbbWlwc10gTG93ZXIgaW1tZWRpYXRlcyBvZiBh bmRpIGFuZCBhbmRwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUyNjkzCisKKyAgICAgICAgT24gTUlQUyBpbW1lZGlhdGUgb3BlcmFuZCBvZiBhbmRp IGlzIHJlcXVpcmVkIHRvIGJlIDE2LWJpdAorICAgICAgICBub24tbmVnYXRpdmUgbnVtYmVyLgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2ZmbGlu ZWFzbS9taXBzLnJiOgorCiAyMDE2LTAxLTA0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdl YmtpdC5vcmc+CiAKICAgICAgICAgSlNDIGdlbmVyYXRvciBzY3JpcHRzIHNob3VsZG4ndCBoYXZl IHZlcmJvc2Ugb3V0cHV0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGlu ZWFzbS9taXBzLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgpp bmRleCAzMDUyZGNhLi4wY2Y2ZDZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv b2ZmbGluZWFzbS9taXBzLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt L21pcHMucmIKQEAgLTUyMiw2ICs1MjIsOCBAQCBkZWYgbWlwc0xvd2VyTWlzcGxhY2VkSW1tZWRp YXRlcyhsaXN0KQogICAgICAgICAgICAgICAgIGVuZAogICAgICAgICAgICAgd2hlbiAvXihhZGRp fHN1YmkpLwogICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwgbm9kZS5yaXNjTG93ZXJNYWxmb3Jt ZWRJbW1lZGlhdGVzUmVjdXJzZShuZXdMaXN0LCAtMHg3ZmZmLi4weDdmZmYpCisgICAgICAgICAg ICB3aGVuICJhbmRpIiwgImFuZHAiCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBub2RlLnJp c2NMb3dlck1hbGZvcm1lZEltbWVkaWF0ZXNSZWN1cnNlKG5ld0xpc3QsIDAuLjB4N2ZmZikKICAg ICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUKICAgICAgICAg ICAgIGVuZAotLSAKMS45LjEKCg== 268455 2016-01-07 09:25:52 -0800 2016-01-07 14:13:56 -0800 Patch 0001-mips-Lower-immediates-of-logical-operations.patch text/plain 1878 annulen RnJvbSA0NjNiMWUyMDQyYWM2NjhiNWMwMTkzNjU5YmNlOTc2MzA2NDM1NjkxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLb25zdGFudGluIFRva2FyZXYgPGFubnVsZW5AeWFuZGV4LnJ1 PgpEYXRlOiBNb24sIDQgSmFuIDIwMTYgMTg6NDQ6NTggKzAzMDAKU3ViamVjdDogW1BBVENIIDEv MV0gW21pcHNdIExvd2VyIGltbWVkaWF0ZXMgb2YgbG9naWNhbCBvcGVyYXRpb25zLgoKT24gTUlQ UyBpbW1lZGlhdGUgb3BlcmFuZHMgb2YgYW5kaSwgb3JpLCBhbmQgeG9yaSBhcmUgcmVxdWlyZWQK dG8gYmUgMTYtYml0IG5vbi1uZWdhdGl2ZSBudW1iZXJzLgoKQ2hhbmdlLUlkOiBJODU5MDdmYmQ2 YzUzODdlM2JiZDA3OWFlYjJiOThiZDUzNTVmYzJjYQotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL21pcHMucmIgfCAgMiArKwogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKaW5kZXggMDA4M2Y3Ny4uNjJkNGEzMiAx MDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDEtMDQgIEtv bnN0YW50aW4gVG9rYXJldiAgPGFubnVsZW5AeWFuZGV4LnJ1PgorCisgICAgICAgIFttaXBzXSBM b3dlciBpbW1lZGlhdGVzIG9mIGxvZ2ljYWwgb3BlcmF0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjY5MworCisgICAgICAgIE9uIE1JUFMg aW1tZWRpYXRlIG9wZXJhbmRzIG9mIGFuZGksIG9yaSwgYW5kIHhvcmkgYXJlIHJlcXVpcmVkIHRv IGJlIDE2LWJpdAorICAgICAgICBub24tbmVnYXRpdmUgbnVtYmVycy4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoK KwogMjAxNi0wMS0wNiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBB ZGQgYSBXZWJLaXQgU1BJIGZvciByZWdpc3RlcmluZyBhbiBhdXRvbWF0aW9uIGNvbnRyb2xsZXIg d2l0aCBSZW1vdGVJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9v ZmZsaW5lYXNtL21pcHMucmIgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBz LnJiCmluZGV4IDMwNTJkY2EuLjExNDMxN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxp bmVhc20vbWlwcy5yYgpAQCAtNTIyLDYgKzUyMiw4IEBAIGRlZiBtaXBzTG93ZXJNaXNwbGFjZWRJ bW1lZGlhdGVzKGxpc3QpCiAgICAgICAgICAgICAgICAgZW5kCiAgICAgICAgICAgICB3aGVuIC9e KGFkZGl8c3ViaSkvCiAgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBub2RlLnJpc2NMb3dlck1h bGZvcm1lZEltbWVkaWF0ZXNSZWN1cnNlKG5ld0xpc3QsIC0weDdmZmYuLjB4N2ZmZikKKyAgICAg ICAgICAgIHdoZW4gImFuZGkiLCAiYW5kcCIsICJvcmkiLCAib3JwIiwgInhvcmkiLCAieG9ycCIK KyAgICAgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUucmlzY0xvd2VyTWFsZm9ybWVkSW1tZWRp YXRlc1JlY3Vyc2UobmV3TGlzdCwgMC4uMHg3ZmZmKQogICAgICAgICAgICAgZWxzZQogICAgICAg ICAgICAgICAgIG5ld0xpc3QgPDwgbm9kZQogICAgICAgICAgICAgZW5kCi0tIAoxLjkuMQoK 269263 2016-01-19 02:30:18 -0800 2016-01-19 09:03:25 -0800 Patch bug-152693-20160119132949.patch text/plain 1472 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MjY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NTk5YWQ5ZWNiZWVmZDdjYmU5NTdjMmM1NmQ3NjhkNTEwM2NkNzcwLi45MGFmMTBlOGJjZjhlZDE0 ODg5NjZkZjc3NWE5Yzk3MTI3NWFlMWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNi0wMS0xOSAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5k ZXgucnU+CisKKyAgICAgICAgW21pcHNdIExvZ2ljYWwgaW5zdHJ1Y3Rpb25zIGFsbG93IGltbWVk aWF0ZXMgaW4gcmFuZ2UgMC4uMHhmZmZmLCBub3QgMHg3ZmZmCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2OTMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5yYjoKKwogMjAx Ni0wMS0xOCAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBhc3Nl cnRpb25zIGluIEJ5dGVjb2RlVXNlRGVmLmggYWJvdXQgb3Bjb2RlIGxlbmd0aCBhcmUgb2ZmIGJ5 IG9uZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5y YiBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKaW5kZXggNDU1MzMy YmY5ZDIzOGI4ZWE2YmVmNDU0Y2EzMDljODJlY2M4NjJkMS4uMzdhYTgwNGVjYzBjYjE1MzUwNGNl NDRhMjcyNGFmMTc5ZWM5MWY3YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL29m ZmxpbmVhc20vbWlwcy5yYgorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9t aXBzLnJiCkBAIC01MjUsNyArNTI1LDcgQEAgZGVmIG1pcHNMb3dlck1pc3BsYWNlZEltbWVkaWF0 ZXMobGlzdCkKICAgICAgICAgICAgIHdoZW4gL14oYWRkaXxzdWJpKS8KICAgICAgICAgICAgICAg ICBuZXdMaXN0IDw8IG5vZGUucmlzY0xvd2VyTWFsZm9ybWVkSW1tZWRpYXRlc1JlY3Vyc2UobmV3 TGlzdCwgLTB4N2ZmZi4uMHg3ZmZmKQogICAgICAgICAgICAgd2hlbiAiYW5kaSIsICJhbmRwIiwg Im9yaSIsICJvcnAiLCAieG9yaSIsICJ4b3JwIgotICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwg bm9kZS5yaXNjTG93ZXJNYWxmb3JtZWRJbW1lZGlhdGVzUmVjdXJzZShuZXdMaXN0LCAwLi4weDdm ZmYpCisgICAgICAgICAgICAgICAgbmV3TGlzdCA8PCBub2RlLnJpc2NMb3dlck1hbGZvcm1lZElt bWVkaWF0ZXNSZWN1cnNlKG5ld0xpc3QsIDAuLjB4ZmZmZikKICAgICAgICAgICAgIGVsc2UKICAg ICAgICAgICAgICAgICBuZXdMaXN0IDw8IG5vZGUKICAgICAgICAgICAgIGVuZAo=