152677 2016-01-03 16:51:17 -0800 [GTK] Fix -Wpessimizing-move warnings after switch to WTFMove 2016-01-03 21:20:43 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro aestes bugs-noreply commit-queue mcatanzaro oldest_to_newest 1152188 0 mcatanzaro 2016-01-03 16:51:17 -0800 Now that we have switched from WTF::move to the macro WTFMove, we've triggered some good clang warnings that our use of WTF::move was hiding. [1015/3230] Building CXX object Source...r/platform/glib/KeyedDecoderGlib.cpp.o ../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(dictionary); ^ ../../Source/WebCore/platform/glib/KeyedDecoderGlib.cpp:61:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(dictionary); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ 1 warning generated. [1038/3230] Building CXX object Source...atform/graphics/egl/GLContextEGL.cpp.o ../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(context); ^ ../../Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:212:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(context); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ 1 warning generated. [1046/3230] Building CXX object Source...atform/graphics/glx/GLContextGLX.cpp.o ../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] return std::move<WTF::CheckMoveParameter>(context); ^ ../../Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:139:12: note: remove std::move call here return std::move<WTF::CheckMoveParameter>(context); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~ 1 warning generated. 1152190 1 268159 mcatanzaro 2016-01-03 16:57:37 -0800 Created attachment 268159 Patch 1152240 2 268159 commit-queue 2016-01-03 21:20:39 -0800 Comment on attachment 268159 Patch Clearing flags on attachment: 268159 Committed r194527: <http://trac.webkit.org/changeset/194527> 1152241 3 commit-queue 2016-01-03 21:20:43 -0800 All reviewed patches have been landed. Closing bug. 268159 2016-01-03 16:57:37 -0800 2016-01-03 21:20:39 -0800 Patch bug-152677-20160103185703.patch text/plain 2898 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjE3MGE2MGEyMTcxZGJk YmFjMGY3OTgwYTI1NWEzODhiZjY2MmJkZC4uZDZiNDdmNjc1M2UyMTZkODg0YmFkN2RlMzBjMjYw MWYyNjc0MmM5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAxLTAzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBG aXggLVdwZXNzaW1pemluZy1tb3ZlIHdhcm5pbmdzIGFmdGVyIHN3aXRjaCB0byBXVEZNb3ZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2NzcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3Jt L2dsaWIvS2V5ZWREZWNvZGVyR2xpYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLZXllZERlY29k ZXJHbGliOjpkaWN0aW9uYXJ5RnJvbUdWYXJpYW50KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdMQ29udGV4dEVH TDo6Y3JlYXRlQ29udGV4dCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29u dGV4dEdMWC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHTENvbnRleHRHTFg6OmNyZWF0ZUNvbnRl eHQpOgorCiAyMDE2LTAxLTAzICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNvbT4KIAogICAg ICAgICBXZWJLaXQgZmFpbHMgdG8gYnVpbGQgd2l0aCBtdXNsIGxpYmMgbGlicmFyeQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ2xpYi9LZXllZERlY29kZXJHbGliLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dsaWIvS2V5ZWREZWNvZGVyR2xpYi5jcHAKaW5kZXgg NWJhMTc0OWE1NDU1Mzc3ODkzNTQyY2M5ZWEzMDczNGZjNGE4NGMyMS4uNTUxMDkwZTAyMDE4Yjhm MjljMDcyOWU1OTNjNTM4ODg5MjUyMzc0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ2xpYi9LZXllZERlY29kZXJHbGliLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9nbGliL0tleWVkRGVjb2RlckdsaWIuY3BwCkBAIC01OCw3ICs1OCw3IEBAIEhhc2hNYXA8 U3RyaW5nLCBHUmVmUHRyPEdWYXJpYW50Pj4gS2V5ZWREZWNvZGVyR2xpYjo6ZGljdGlvbmFyeUZy b21HVmFyaWFudChHVmFyCiAgICAgR1ZhcmlhbnQqIHZhbHVlOwogICAgIHdoaWxlIChnX3Zhcmlh bnRfaXRlcl9sb29wKCZpdGVyLCAieyZzdn0iLCAma2V5LCAmdmFsdWUpKQogICAgICAgICBkaWN0 aW9uYXJ5LnNldChTdHJpbmc6OmZyb21VVEY4KGtleSksIHZhbHVlKTsKLSAgICByZXR1cm4gV1RG TW92ZShkaWN0aW9uYXJ5KTsKKyAgICByZXR1cm4gZGljdGlvbmFyeTsKIH0KIAogYm9vbCBLZXll ZERlY29kZXJHbGliOjpkZWNvZGVCeXRlcyhjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgdWludDhf dComIGJ5dGVzLCBzaXplX3QmIHNpemUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwCmluZGV4IDQ0ODYxMzI3YzNlMTYwNGEw OTQwM2MxMTkxZWU2NTc4OGFlMDRmMTYuLmEyYmM3NWJlNmEzNTU1ZDc0MGFhOTUxZTRhNzY1YmQy YWZkYTQ3NDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Vn bC9HTENvbnRleHRFR0wuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2VnbC9HTENvbnRleHRFR0wuY3BwCkBAIC0yMDksNyArMjA5LDcgQEAgc3RkOjp1bmlxdWVfcHRy PEdMQ29udGV4dEVHTD4gR0xDb250ZXh0RUdMOjpjcmVhdGVDb250ZXh0KEVHTE5hdGl2ZVdpbmRv d1R5cGUgd2kKICAgICBpZiAoIWNvbnRleHQpCiAgICAgICAgIGNvbnRleHQgPSBjcmVhdGVQYnVm ZmVyQ29udGV4dChlZ2xTaGFyaW5nQ29udGV4dCk7CiAKLSAgICByZXR1cm4gV1RGTW92ZShjb250 ZXh0KTsKKyAgICByZXR1cm4gY29udGV4dDsKIH0KIAogR0xDb250ZXh0RUdMOjpHTENvbnRleHRF R0woRUdMQ29udGV4dCBjb250ZXh0LCBFR0xTdXJmYWNlIHN1cmZhY2UsIEVHTFN1cmZhY2VUeXBl IHR5cGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nbHgv R0xDb250ZXh0R0xYLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dseC9H TENvbnRleHRHTFguY3BwCmluZGV4IDc2Yzc4YWJkNmRkNzBmMjgzNWJlMDdiNDIyYmUwZjg5ZDgz NjQxMGUuLjE0YmI1MzljYWUxYWQ2NWU0NDNlZWJjNzk2ZTc2OTFjNmNhMWMwNmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFgu Y3BwCkBAIC0xMzYsNyArMTM2LDcgQEAgc3RkOjp1bmlxdWVfcHRyPEdMQ29udGV4dEdMWD4gR0xD b250ZXh0R0xYOjpjcmVhdGVDb250ZXh0KFhJRCB3aW5kb3csIEdMQ29udGV4dCoKICAgICBpZiAo IWNvbnRleHQpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCi0gICAgcmV0dXJuIFdURk1vdmUo Y29udGV4dCk7CisgICAgcmV0dXJuIGNvbnRleHQ7CiB9CiAKIEdMQ29udGV4dEdMWDo6R0xDb250 ZXh0R0xYKFhVbmlxdWVHTFhDb250ZXh0JiYgY29udGV4dCwgWElEIHdpbmRvdykK