152654 2016-01-02 14:58:35 -0800 Build fails for aarch64/linux on when building with clang 2016-01-03 12:09:14 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 raj.khem webkit-unassigned commit-queue dbates fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1152030 0 raj.khem 2016-01-02 14:58:35 -0800 On OpenEmbedded when building webkitgtk using clang for aarch64/linux target build fails with Source/JavaScriptCore/assembler/ARM64Assembler.h:2857:33: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'void *' __builtin___clear_cache(reinterpret_cast<void*>(begin), reinterpret_cast<void*>(end)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. 1152032 1 268114 raj.khem 2016-01-02 15:06:02 -0800 Created attachment 268114 Fix aarch64/linux build with clang 1152033 2 268114 msaboff 2016-01-02 15:19:36 -0800 Comment on attachment 268114 Fix aarch64/linux build with clang r=me 1152042 3 268114 commit-queue 2016-01-02 16:04:43 -0800 Comment on attachment 268114 Fix aarch64/linux build with clang Clearing flags on attachment: 268114 Committed r194505: <http://trac.webkit.org/changeset/194505> 1152043 4 commit-queue 2016-01-02 16:04:46 -0800 All reviewed patches have been landed. Closing bug. 1152066 5 dbates 2016-01-02 21:30:51 -0800 (In reply to comment #3) > Comment on attachment 268114 [details] > Fix aarch64/linux build with clang > > Clearing flags on attachment: 268114 > > Committed r194505: <http://trac.webkit.org/changeset/194505> The ChangeLog entry for this change neither lists the name of the reviewer (Michael Saboff) nor conforms to format of a ChangeLog entry described in <https://webkit.org/contributing-code/#changelog-files>. Even though this a build fix (which could be landed by a committer/reviewer "Unreviewed") it was formally reviewed and landed. Therefore its ChangeLog should reflect the reviewer. 1152126 6 268142 raj.khem 2016-01-03 10:45:58 -0800 Created attachment 268142 patch to fix clang/aarch64/Linux Addressed review comments. 1152144 7 fpizlo 2016-01-03 12:08:51 -0800 Fixed the ChangeLog in http://trac.webkit.org/changeset/194517 1152145 8 268142 fpizlo 2016-01-03 12:09:14 -0800 Comment on attachment 268142 patch to fix clang/aarch64/Linux Obsolete patch. 268114 2016-01-02 15:06:02 -0800 2016-01-03 10:45:58 -0800 Fix aarch64/linux build with clang 0001-JavaScriptCore-Fix-aarch64-linux-build-with-clang.patch text/plain 2046 raj.khem RnJvbSA5NDJhNjQ5NTdhNGMyNjgzOGVkYTgzZjhjZDI5NmY5YzdmMTJkY2Y3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgpEYXRlOiBT YXQsIDIgSmFuIDIwMTYgMjM6MDM6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIXSBKYXZhU2NyaXB0 Q29yZTogRml4IGFhcmNoNjQvbGludXggYnVpbGQgd2l0aCBjbGFuZwoKQ2xhbmcncyBidWlsdGlu IGZvciBjbGVhcl9jYWNoZSBhY2NlcHRzIGNoYXIqIGFuZCBlcnJvcnMgb3V0CndoZW4gdXNpbmcg dm9pZCosIHVzaW5nIGNoYXIqIHdvcmsgb24gYm90aCBnY2MgYW5kIGNsYW5nCnNpbmNlIGNoYXIq IGlzIGF1dG8tY29udmVydGVkIHRvIHZvaWQqIGluIGdjYyBjYXNlLgoKU2lnbmVkLW9mZi1ieTog S2hlbSBSYWogPHJhai5raGVtQGdtYWlsLmNvbT4KLS0tCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysrKysrKwogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oIHwgIDIgKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hh bmdlTG9nCmluZGV4IDJhY2VhZGEuLjA4OTJjZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpA QCAtMSw1ICsxLDE5IEBACiAyMDE2LTAxLTAyICBLaGVtIFJhaiAgPHJhai5raGVtQGdtYWlsLmNv bT4KIAorICAgICAgICBDbGFuZydzIGJ1aWx0aW4gZm9yIGNsZWFyX2NhY2hlIGFjY2VwdHMgY2hh ciogYW5kIGVycm9ycyBvdXQKKyAgICAgICAgd2hlbiB1c2luZyB2b2lkKiwgdXNpbmcgY2hhciog d29yayBvbiBib3RoIGdjYyBhbmQgY2xhbmcKKyAgICAgICAgc2luY2UgY2hhciogaXMgYXV0by1j b252ZXJ0ZWQgdG8gdm9pZCogaW4gZ2NjIGNhc2UuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjY1NAorCisgICAgICAgVW5yZXZpZXdlZAorCisg ICAgICAgKiBhc3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaDoKKyAgICAgICAobGludXhQYWdlRmx1 c2gpOiBDb252ZXJ0IGFyZ3VtZW50cyB0byBfX2J1aWx0aW5fX19jbGVhcl9jYWNoZSgpCisgICAg ICAgdG8gY2hhciouCisKKzIwMTYtMDEtMDIgIEtoZW0gUmFqICA8cmFqLmtoZW1AZ21haWwuY29t PgorCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2 MjUKICAgICAgICAgcXVhbGlmeSBpc25hbigpIGNhbGxzIHdpdGggc3RkIG5hbWVzcGFjZS4KIApk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxl ci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oCmlu ZGV4IDU1NGJhOTcuLjA4MGU3NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvQVJNNjRBc3NlbWJsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmgKQEAgLTI4OTksNyArMjg5OSw3IEBAIHB1YmxpYzoKICNp ZiBPUyhMSU5VWCkgJiYgQ09NUElMRVIoR0NDX09SX0NMQU5HKQogICAgIHN0YXRpYyBpbmxpbmUg dm9pZCBsaW51eFBhZ2VGbHVzaCh1aW50cHRyX3QgYmVnaW4sIHVpbnRwdHJfdCBlbmQpCiAgICAg ewotICAgICAgICBfX2J1aWx0aW5fX19jbGVhcl9jYWNoZShyZWludGVycHJldF9jYXN0PHZvaWQq PihiZWdpbiksIHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGVuZCkpOworICAgICAgICBfX2J1aWx0 aW5fX19jbGVhcl9jYWNoZShyZWludGVycHJldF9jYXN0PGNoYXIqPihiZWdpbiksIHJlaW50ZXJw cmV0X2Nhc3Q8Y2hhcio+KGVuZCkpOwogICAgIH0KICNlbmRpZgogCi0tIAoyLjYuNAoK 268142 2016-01-03 10:45:58 -0800 2016-01-03 12:09:14 -0800 patch to fix clang/aarch64/Linux 0002-JavaScriptCore-Fix-aarch64-linux-build-with-clang.patch text/plain 2139 raj.khem RnJvbSA1NDk4ZmUxNDdjMzhhOTZmM2E3NjE3NTJhOTRiNmYyNmY4ZmIzMmU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLaGVtIFJhaiA8cmFqLmtoZW1AZ21haWwuY29tPgpEYXRlOiBT YXQsIDIgSmFuIDIwMTYgMjM6MDM6MjMgKzAwMDAKU3ViamVjdDogW1BBVENIIDIvMl0gSmF2YVNj cmlwdENvcmU6IEZpeCBhYXJjaDY0L2xpbnV4IGJ1aWxkIHdpdGggY2xhbmcKCkNsYW5nJ3MgYnVp bHRpbiBmb3IgY2xlYXJfY2FjaGUgYWNjZXB0cyBjaGFyKiBhbmQgZXJyb3JzIG91dAp3aGVuIHVz aW5nIHZvaWQqLCB1c2luZyBjaGFyKiB3b3JrIG9uIGJvdGggZ2NjIGFuZCBjbGFuZwpzaW5jZSBj aGFyKiBpcyBhdXRvLWNvbnZlcnRlZCB0byB2b2lkKiBpbiBnY2MgY2FzZS4KClNpZ25lZC1vZmYt Ynk6IEtoZW0gUmFqIDxyYWoua2hlbUBnbWFpbC5jb20+Ci0tLQogU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysrCiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVyLmggfCAgMiArLQogMiBm aWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKaW5kZXggYzAzMThkMi4uYTU0NGU4MSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTYtMDEtMDIgIEtoZW0gUmFqICA8cmFqLmtoZW1AZ21h aWwuY29tPgogCisgICAgICAgIEJ1aWxkIGZhaWxzIGZvciBhYXJjaDY0L2xpbnV4IG9uIHdoZW4g YnVpbGRpbmcgd2l0aCBjbGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNjU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWljaGFlbCBTYWJvZmYu CisKKyAgICAgICAgQ2xhbmcncyBidWlsdGluIGZvciBjbGVhcl9jYWNoZSBhY2NlcHRzIGNoYXIq IGFuZCBlcnJvcnMgb3V0CisgICAgICAgIHdoZW4gdXNpbmcgdm9pZCosIHVzaW5nIGNoYXIqIHdv cmsgb24gYm90aCBnY2MgYW5kIGNsYW5nCisgICAgICAgIHNpbmNlIGNoYXIqIGlzIGF1dG8tY29u dmVydGVkIHRvIHZvaWQqIGluIGdjYyBjYXNlLgorCisgICAgICAgKiBhc3NlbWJsZXIvQVJNNjRB c3NlbWJsZXIuaDoKKyAgICAgICAobGludXhQYWdlRmx1c2gpOiBDb252ZXJ0IGFyZ3VtZW50cyB0 byBfX2J1aWx0aW5fX19jbGVhcl9jYWNoZSgpCisgICAgICAgdG8gY2hhciouCisKKzIwMTYtMDEt MDIgIEtoZW0gUmFqICA8cmFqLmtoZW1AZ21haWwuY29tPgorCiAgICAgICAgIFdlYktpdCBmYWls cyB0byBidWlsZCB3aXRoIG11c2wgbGliYyBsaWJyYXJ5CiAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2MjUKIApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2Fzc2VtYmxlci9BUk02NEFzc2VtYmxlci5oCmluZGV4IDU1NGJhOTcuLjA4MGU3NjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNNjRBc3NlbWJs ZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTTY0QXNzZW1ibGVy LmgKQEAgLTI4OTksNyArMjg5OSw3IEBAIHB1YmxpYzoKICNpZiBPUyhMSU5VWCkgJiYgQ09NUElM RVIoR0NDX09SX0NMQU5HKQogICAgIHN0YXRpYyBpbmxpbmUgdm9pZCBsaW51eFBhZ2VGbHVzaCh1 aW50cHRyX3QgYmVnaW4sIHVpbnRwdHJfdCBlbmQpCiAgICAgewotICAgICAgICBfX2J1aWx0aW5f X19jbGVhcl9jYWNoZShyZWludGVycHJldF9jYXN0PHZvaWQqPihiZWdpbiksIHJlaW50ZXJwcmV0 X2Nhc3Q8dm9pZCo+KGVuZCkpOworICAgICAgICBfX2J1aWx0aW5fX19jbGVhcl9jYWNoZShyZWlu dGVycHJldF9jYXN0PGNoYXIqPihiZWdpbiksIHJlaW50ZXJwcmV0X2Nhc3Q8Y2hhcio+KGVuZCkp OwogICAgIH0KICNlbmRpZgogCi0tIAoyLjYuNAoK