152615 2015-12-31 09:36:38 -0800 [GTK][CMake] Do not override default values of build options with the default value 2015-12-31 10:51:06 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC All RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue mcatanzaro mrobinson oldest_to_newest 1151719 0 mcatanzaro 2015-12-31 09:36:38 -0800 Override the default value of build options only when the default value for the GTK+ port is actually different than the default value in WebKitFeatures.cmake. This way we don't accidentally override changes to default values in WebKitFeatures.cmake. We should use the values in WebKitFeatures.cmake except when we make an active choice to do otherwise. 1151720 1 268042 mcatanzaro 2015-12-31 09:37:59 -0800 Created attachment 268042 Patch 1151738 2 268042 commit-queue 2015-12-31 10:51:03 -0800 Comment on attachment 268042 Patch Clearing flags on attachment: 268042 Committed r194458: <http://trac.webkit.org/changeset/194458> 1151739 3 commit-queue 2015-12-31 10:51:06 -0800 All reviewed patches have been landed. Closing bug. 268042 2015-12-31 09:37:59 -0800 2015-12-31 10:51:03 -0800 Patch bug-152615-20151231113724.patch text/plain 5267 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGVlNDEx NWFlNmM1MmQyYTQwNGY1NWI1NmQzNmM2NjVmZjljOTg3NjkuLmUwM2I0YmRkZWY5YzA5MzYyZDM4 YzY3MTljYmY2ZDIwMmJkZjRjMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzcsNTcgKzEz NywyOSBAQCBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShVU0VfU1lTVEVNX01BTExP QyBQVUJMSUMgT0ZGKQogCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf M0RfVFJBTlNGT1JNUyBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX0FDQ0VTU0lCSUxJVFkgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9BTExJTk9ORV9CVUlMRCBQUklWQVRFIE9GRikKLVdFQktJVF9P UFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BVFRBQ0hNRU5UX0VMRU1FTlQgUFJJVkFU RSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQkFUVEVSWV9T VEFUVVMgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFC TEVfQ0FOVkFTX1BBVEggUFJJVkFURSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQ1NTM19URVhUIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX0NTU19ERVZJQ0VfQURBUFRBVElPTiBQUklWQVRFIE9GRikKLVdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DU1NfR1JJRF9MQVlPVVQgUFJJ VkFURSBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1NTX0lN QUdFX1NFVCBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX0NTU19SRUdJT05TIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQ1NTX1NFTEVDVE9SU19MRVZFTDQgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9DVVJSRU5UU1JDIFBSSVZBVEUgT04pCi1XRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ1VTVE9NX1NDSEVNRV9IQU5ETEVS IFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RB VEFCQVNFX1BST0NFU1MgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9EQVRBTElTVF9FTEVNRU5UIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0RPV05MT0FEX0FUVFJJQlVURSBQUklWQVRFIE9GRikK LVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9FTkNSWVBURURfTUVESUEg UFJJVkFURSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRU5D UllQVEVEX01FRElBX1YyIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX0ZJTFRFUlNfTEVWRUxfMiBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9GVFBESVIgUFJJVkFURSBPRkYpCiBXRUJLSVRfT1BU SU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRlVMTFNDUkVFTl9BUEkgUFJJVkFURSBPTikK LVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9HQU1FUEFEIFBSSVZBVEUg T0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0dBTUVQQURfREVQ UkVDQVRFRCBQUklWQVRFIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9JTkRFWEVEX0RBVEFCQVNFIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRf UE9SVF9WQUxVRShFTkFCTEVfSU5ERVhFRF9EQVRBQkFTRV9JTl9XT1JLRVJTIFBSSVZBVEUgT0ZG KQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0lOUFVUX1RZUEVfQ09M T1IgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9M RUdBQ1lfV0VCX0FVRElPIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX0xJTktfUFJFRkVUQ0ggUFJJVkFURSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTUVESUFfQ0FQVFVSRSBQUklWQVRFIE9GRikKIFdFQktJ VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NRURJQV9DT05UUk9MU19TQ1JJUFQg UFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NSFRN TCBQUklWQVRFIE9OKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05B VklHQVRPUl9DT05URU5UX1VUSUxTIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX05BVklHQVRPUl9IV0NPTkNVUlJFTkNZIFBSSVZBVEUgT04pCi1X RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQ SSBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05P VElGSUNBVElPTlMgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVF KEVOQUJMRV9QVUJMSUNfU1VGRklYX0xJU1QgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9RVU9UQSBQUklWQVRFIE9GRikKLVdFQktJVF9PUFRJT05f REVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9SRVNPTFVUSU9OX01FRElBX1FVRVJZIFBSSVZBVEUg T0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1JFUVVFU1RfQU5J TUFUSU9OX0ZSQU1FIFBSSVZBVEUgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfU0VDQ09NUF9GSUxURVJTIFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NNT09USF9TQ1JPTExJTkcgUFJJVkFURSBPTikKLVdFQktJ VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJUTEVfQ1JZUFRPIFBSSVZBVEUg T0ZGKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1RFTVBMQVRFX0VM RU1FTlQgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9VU0VSU0VMRUNUX0FMTCBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRf VkFMVUUoRU5BQkxFX1VTRVJfTUVTU0FHRV9IQU5ETEVSUyBQUklWQVRFIE9OKQotV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJQlJBVElPTiBQUklWQVRFIE9GRikKIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9WSURFT19UUkFDSyBQUklWQVRF IE9OKQotV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1ZJRVdfTU9ERV9D U1NfTUVESUEgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9XRUJfVElNSU5HIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfV0VCR0wgUFJJVkFURSBPTikKLVdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9USFJFQURFRF9DT01QT1NJVE9SIFBSSVZBVEUgT0ZGKQotV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NIQURPV19ET00gUFJJVkFURSBPRkYpCiAK ICMgRmluYWxpemUgdGhlIHZhbHVlIGZvciBhbGwgb3B0aW9ucy4gRG8gbm90IGF0dGVtcHQgdG8g dXNlIGFuIG9wdGlvbiBiZWZvcmUKICMgdGhpcyBwb2ludCwgYW5kIGRvIG5vdCBhdHRlbXB0IHRv IGNoYW5nZSBhbnkgb3B0aW9uIGFmdGVyIHRoaXMgcG9pbnQuCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggNjExMzk3YzVlOTdkMThiN2M1YjNlMTEwY2I0OTI1NWE3NTlm YjNjZC4uZjgxYWQ0ZTE1MDRhMzkyMmM5ZmJkZTg2NDQ0ODAxNTc5MzI0OWY1YiAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE1LTEyLTMx ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBb R1RLXVtDTWFrZV0gRG8gbm90IG92ZXJyaWRlIGRlZmF1bHQgdmFsdWVzIG9mIGJ1aWxkIG9wdGlv bnMgd2l0aCB0aGUgZGVmYXVsdCB2YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNjE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgT3ZlcnJpZGUgdGhlIGRlZmF1bHQgdmFsdWUgb2YgYnVpbGQgb3B0 aW9ucyBvbmx5IHdoZW4gdGhlIGRlZmF1bHQgdmFsdWUgZm9yIHRoZSBHVEsrIHBvcnQKKyAgICAg ICAgaXMgYWN0dWFsbHkgZGlmZmVyZW50IHRoYW4gdGhlIGRlZmF1bHQgdmFsdWUgaW4gV2ViS2l0 RmVhdHVyZXMuY21ha2UuIFRoaXMgd2F5IHdlIGRvbid0CisgICAgICAgIGFjY2lkZW50YWxseSBv dmVycmlkZSBjaGFuZ2VzIHRvIGRlZmF1bHQgdmFsdWVzIGluIFdlYktpdEZlYXR1cmVzLmNtYWtl LiBXZSBzaG91bGQgdXNlIHRoZQorICAgICAgICB2YWx1ZXMgaW4gV2ViS2l0RmVhdHVyZXMuY21h a2UgZXhjZXB0IHdoZW4gd2UgbWFrZSBhbiBhY3RpdmUgY2hvaWNlIHRvIGRvIG90aGVyd2lzZS4K KworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCisyMDE1LTEyLTMx ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKwogICAgICAgICBb Q01ha2VdIEFkZCBlcnJvciBjaGVja2luZyB0byBjYXRjaCBvcHRpb24gbWFuaXB1bGF0aW9uIGFm dGVyIFdFQktJVF9PUFRJT05fRU5ECiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTI2MTEKIAo=