152611 2015-12-31 07:43:33 -0800 [CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END 2015-12-31 09:12:27 -0800 1 1 1 Unclassified WebKit WebKit Misc. Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro achristensen mcatanzaro mrobinson oldest_to_newest 1151699 0 mcatanzaro 2015-12-31 07:43:33 -0800 If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but not to the DOM bindings generator, for example). If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are called after WEBKIT_OPTION_END, they don't do anything. Add error checking to catch these bugs. 1151700 1 268034 mcatanzaro 2015-12-31 07:52:05 -0800 Created attachment 268034 Patch 1151716 2 mcatanzaro 2015-12-31 09:12:27 -0800 Committed r194454: <http://trac.webkit.org/changeset/194454> 268034 2015-12-31 07:52:05 -0800 2015-12-31 08:36:17 -0800 Patch bug-152611-20151231095130.patch text/plain 3338 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0RmVhdHVyZXMuY21ha2UgYi9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21ha2UKaW5k ZXggYWVjMWY1ODM5YzY3YzU1NWIxYzY1NzFhNWJhNjU2MTYxNjE1NjM1ZC4uN2JlNWMzYTY0Yzll M2YxZDc3ZmFmNWVmMDYxNjJhYTgzMjA1YjhkNyAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZQpAQCAtMyw3ICszLDE0IEBAIHNldChfV0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TICIiKQogc2V0 KFBVQkxJQyBZRVMpCiBzZXQoUFJJVkFURSBOTykKIAorbWFjcm8oX0VOU1VSRV9PUFRJT05fTU9E SUZJQ0FUSU9OX0lTX0FMTE9XRUQpCisgICAgaWYgKE5PVCBfU0VUVElOR19XRUJLSVRfT1BUSU9O UykKKyAgICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiT3B0aW9ucyBtdXN0IGJlIHNldCBiZXR3 ZWVuIFdFQktJVF9PUFRJT05fQkVHSU4gYW5kIFdFQktJVF9PUFRJT05fRU5EIikKKyAgICBlbmRp ZiAoKQorZW5kbWFjcm8oKQorCiBtYWNybyhXRUJLSVRfT1BUSU9OX0RFRklORSBfbmFtZSBfZGVz Y3JpcHRpb24gX3B1YmxpYyBfaW5pdGlhbF92YWx1ZSkKKyAgICBfRU5TVVJFX09QVElPTl9NT0RJ RklDQVRJT05fSVNfQUxMT1dFRCgpCiAgICAgc2V0KF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNf REVTQ1JJUFRJT05fJHtfbmFtZX0gJHtfZGVzY3JpcHRpb259KQogICAgIHNldChfV0VCS0lUX0FW QUlMQUJMRV9PUFRJT05TX0lTX1BVQkxJQ18ke19uYW1lfSAke19wdWJsaWN9KQogICAgIHNldChf V0VCS0lUX0FWQUlMQUJMRV9PUFRJT05TX0lOSVRJQUxfVkFMVUVfJHtfbmFtZX0gJHtfaW5pdGlh bF92YWx1ZX0pCkBAIC0xNCwxOSArMjEsMjQgQEAgbWFjcm8oV0VCS0lUX09QVElPTl9ERUZJTkUg X25hbWUgX2Rlc2NyaXB0aW9uIF9wdWJsaWMgX2luaXRpYWxfdmFsdWUpCiBlbmRtYWNybygpCiAK IG1hY3JvKFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFIF9uYW1lIF9wdWJsaWMgX3Zh bHVlKQorICAgIF9FTlNVUkVfT1BUSU9OX01PRElGSUNBVElPTl9JU19BTExPV0VEKCkKICAgICBz ZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JU19QVUJMSUNfJHtfbmFtZX0gJHtfcHVibGlj fSkKICAgICBzZXQoX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OU19JTklUSUFMX1ZBTFVFXyR7X25h bWV9ICR7X3ZhbHVlfSkKIGVuZG1hY3JvKCkKIAogbWFjcm8oV0VCS0lUX09QVElPTl9DT05GTElD VCBfbmFtZSBfY29uZmxpY3QpCisgICAgX0VOU1VSRV9PUFRJT05fTU9ESUZJQ0FUSU9OX0lTX0FM TE9XRUQoKQogICAgIGxpc3QoQVBQRU5EIF9XRUJLSVRfQVZBSUxBQkxFX09QVElPTlNfJHtfbmFt ZX1fQ09ORkxJQ1RTICR7X2NvbmZsaWN0fSkKIGVuZG1hY3JvKCkKIAogbWFjcm8oV0VCS0lUX09Q VElPTl9ERVBFTkQgX25hbWUgX2RlcGVuZCkKKyAgICBfRU5TVVJFX09QVElPTl9NT0RJRklDQVRJ T05fSVNfQUxMT1dFRCgpCiAgICAgbGlzdChBUFBFTkQgX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9O U18ke19uYW1lfV9ERVBFTkRFTkNJRVMgJHtfZGVwZW5kfSkKIGVuZG1hY3JvKCkKIAogbWFjcm8o V0VCS0lUX09QVElPTl9CRUdJTikKKyAgICBzZXQoX1NFVFRJTkdfV0VCS0lUX09QVElPTlMgVFJV RSkKKwogICAgIFdFQktJVF9PUFRJT05fREVGSU5FKEVOQUJMRV8zRF9UUkFOU0ZPUk1TICJUb2dn bGUgM0QgdHJhbnNmb3JtcyBzdXBwb3J0IiBQUklWQVRFIE9GRikKICAgICBXRUJLSVRfT1BUSU9O X0RFRklORShFTkFCTEVfQUNDRUxFUkFURURfMkRfQ0FOVkFTICJUb2dnbGUgYWNjZWxlcmF0ZWQg MkQgY2FudmFzIHN1cHBvcnQiIFBSSVZBVEUgT0ZGKQogICAgIFdFQktJVF9PUFRJT05fREVGSU5F KEVOQUJMRV9BQ0NFTEVSQVRFRF9PVkVSRkxPV19TQ1JPTExJTkcgIlRvZ2dsZSBhY2NlbGVyYXRl ZCBzY3JvbGxpbmcgc3VwcG9ydCIgUFJJVkFURSBPRkYpCkBAIC0yMjQsNiArMjM2LDggQEAgbWFj cm8oX1dFQktJVF9PUFRJT05fRU5GT1JDRV9BTExfQ09ORkxJQ1RTKQogZW5kbWFjcm8oKQogCiBt YWNybyhXRUJLSVRfT1BUSU9OX0VORCkKKyAgICBzZXQoX1NFVFRJTkdfV0VCS0lUX09QVElPTlMg RkFMU0UpCisKICAgICBsaXN0KFNPUlQgX1dFQktJVF9BVkFJTEFCTEVfT1BUSU9OUykKICAgICBz ZXQoX01BWF9GRUFUVVJFX0xFTkdUSCAwKQogICAgIGZvcmVhY2ggKF9uYW1lICR7X1dFQktJVF9B VkFJTEFCTEVfT1BUSU9OU30pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5k ZXggZGU3N2E0YjAxNWU1MGRiNjIwZTg5NjZlYjk1ZTNlZjg1ZGViNjhlMi4uZDE0MzlkMGM4ZDUw YTlkYmIwNjQwOWI1OTcyZTYxMDRlNDc3YTExYSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBi L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE1LTEyLTMxICBNaWNoYWVsIENhdGFuemFy byAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIEFkZCBlcnJvciBj aGVja2luZyB0byBjYXRjaCBvcHRpb24gbWFuaXB1bGF0aW9uIGFmdGVyIFdFQktJVF9PUFRJT05f RU5ECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2 MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiBX RUJLSVRfT1BUSU9OX0RFRklORSBpcyBjYWxsZWQgYWZ0ZXIgV0VCS0lUX09QVElPTl9FTkQsIHRo ZSBvcHRpb24gbmV2ZXIgbWFrZXMgaXRzIHdheQorICAgICAgICBpbnRvIEZFQVRVUkVfREVGSU5F UyBhbmQgc28gd2lsbCBiZSBpbmNvbnNpc3RlbnRseSBzZXQgKGF2YWlsYWJsZSB0byBtb3N0IG9m IHRoZSBidWlsZCwgYnV0CisgICAgICAgIG5vdCB0byB0aGUgRE9NIGJpbmRpbmdzIGdlbmVyYXRv ciwgZm9yIGV4YW1wbGUpLgorCisgICAgICAgIElmIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFLCBXRUJLSVRfT1BUSU9OX0NPTkZMSUNULCBvciBXRUJLSVRfT1BUSU9OX0RFUEVORCBh cmUKKyAgICAgICAgY2FsbGVkIGFmdGVyIFdFQktJVF9PUFRJT05fRU5ELCB0aGV5IGRvbid0IGRv IGFueXRoaW5nLgorCisgICAgICAgIEFkZCBlcnJvciBjaGVja2luZyB0byBjYXRjaCB0aGVzZSBi dWdzLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlOgorCiAy MDE1LTEyLTMwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXVtNYWNdIERpc2FibGUgZ3RrLWRvYwo=