152607 2015-12-30 22:26:50 -0800 Change ScrollView::scrollTo() to take a ScrollPosition 2015-12-31 10:51:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser bdakin simon.fraser thorton zalan oldest_to_newest 1151675 0 simon.fraser 2015-12-30 22:26:50 -0800 Change ScrollView::scrollTo() to take a ScrollPosition 1151676 1 268029 simon.fraser 2015-12-30 22:28:03 -0800 Created attachment 268029 Patch 1151741 2 simon.fraser 2015-12-31 10:51:19 -0800 https://trac.webkit.org/changeset/194457 268029 2015-12-30 22:28:03 -0800 2015-12-31 10:51:27 -0800 Patch bug-152607-20151230222729.patch text/plain 6508 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0NDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGE2MDM1N2VkNmU1YTRl M2QxNGViMzE4NWVkNmI2NGE4MzYyMzEwYS4uZmY4YjJlNGM1YWQ2YWMwOTg1YjAwNWE2NWM2ODY3 N2ExODY4NWM5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE1LTEyLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIENoYW5nZSBTY3Jv bGxWaWV3OjpzY3JvbGxUbygpIHRvIHRha2UgYSBTY3JvbGxQb3NpdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNjA3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBpdCBtb3JlIGV4cGxpY2l0 IHRoYXQgU2Nyb2xsVmlldzo6c2Nyb2xsVG8oKSB0YWtlcyBhIFNjcm9sbFBvc2l0aW9uLCBhbmQK KyAgICAgICAgY2hhbmdlIHRoZSBuYW1lIGFuZCB0eXBlIG9mIHRoZSBtX3Njcm9sbE9mZnNldCBt ZW1iZXIgdmFyaWFibGUuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAg IChXZWJDb3JlOjpGcmFtZVZpZXc6OnNjcm9sbFRvKToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1l Vmlldzo6d2hlZWxFdmVudCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAg KiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6 OnVub2JzY3VyZWRDb250ZW50UmVjdEludGVybmFsKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bFZpZXc6OnNldFNjcm9sbE9mZnNldCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxWaWV3Ojpz Y3JvbGxUbyk6CisgICAgICAgICogcGxhdGZvcm0vU2Nyb2xsVmlldy5oOgorCisyMDE1LTEyLTMw ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBl eHBsaWNpdCBjb252ZXJzaW9ucyBiZXR3ZWVuIHNjcm9sbE9mZnNldCBhbmQgc2Nyb2xsUG9zdGlv biwgYW5kIHVzZSB0aGVtIGluIGEgZmV3IHBsYWNlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTk0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRnJhbWVWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAppbmRleCA4OWUxMzBjYTkwMzQyY2QzNjRhMTk4MzM0YjZjOWEwMGY4NzkxMmZjLi5iY2VmNjc0 MDlmZjNhNTc3ZjgyMTBmMDBjYzVjYmRkNjhmYWE0NGE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZp ZXcuY3BwCkBAIC0zNDc0LDEwICszNDc0LDEwIEBAIGJvb2wgRnJhbWVWaWV3Ojpmb3JjZVVwZGF0 ZVNjcm9sbGJhcnNPbk1haW5UaHJlYWRGb3JQZXJmb3JtYW5jZVRlc3RpbmcoKSBjb25zdAogICAg IHJldHVybiBwYWdlICYmIHBhZ2UtPnNldHRpbmdzKCkuZm9yY2VVcGRhdGVTY3JvbGxiYXJzT25N YWluVGhyZWFkRm9yUGVyZm9ybWFuY2VUZXN0aW5nKCk7CiB9CiAKLXZvaWQgRnJhbWVWaWV3Ojpz Y3JvbGxUbyhjb25zdCBJbnRTaXplJiBuZXdPZmZzZXQpCit2b2lkIEZyYW1lVmlldzo6c2Nyb2xs VG8oY29uc3QgU2Nyb2xsUG9zaXRpb24mIG5ld1Bvc2l0aW9uKQogewogICAgIEludFBvaW50IG9s ZFBvc2l0aW9uID0gc2Nyb2xsUG9zaXRpb24oKTsKLSAgICBTY3JvbGxWaWV3OjpzY3JvbGxUbyhu ZXdPZmZzZXQpOworICAgIFNjcm9sbFZpZXc6OnNjcm9sbFRvKG5ld1Bvc2l0aW9uKTsKICAgICBp ZiAob2xkUG9zaXRpb24gIT0gc2Nyb2xsUG9zaXRpb24oKSkKICAgICAgICAgc2Nyb2xsUG9zaXRp b25DaGFuZ2VkKG9sZFBvc2l0aW9uLCBzY3JvbGxQb3NpdGlvbigpKTsKICAgICBkaWRDaGFuZ2VT Y3JvbGxPZmZzZXQoKTsKQEAgLTQ1ODYsNyArNDU4Niw3IEBAIGJvb2wgRnJhbWVWaWV3Ojp3aGVl bEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxFdmVudCkKICAgICAgICAgU2Ny b2xsUG9zaXRpb24gb2xkUG9zaXRpb24gPSBzY3JvbGxQb3NpdGlvbigpOwogICAgICAgICBTY3Jv bGxQb3NpdGlvbiBuZXdQb3NpdGlvbiA9IG9sZFBvc2l0aW9uIC0gSW50U2l6ZSh3aGVlbEV2ZW50 LmRlbHRhWCgpLCB3aGVlbEV2ZW50LmRlbHRhWSgpKTsKICAgICAgICAgaWYgKG9sZFBvc2l0aW9u ICE9IG5ld1Bvc2l0aW9uKSB7Ci0gICAgICAgICAgICBTY3JvbGxWaWV3OjpzY3JvbGxUbyh0b0lu dFNpemUobmV3UG9zaXRpb24pKTsKKyAgICAgICAgICAgIFNjcm9sbFZpZXc6OnNjcm9sbFRvKG5l d1Bvc2l0aW9uKTsKICAgICAgICAgICAgIHNjcm9sbFBvc2l0aW9uQ2hhbmdlZChvbGRQb3NpdGlv biwgc2Nyb2xsUG9zaXRpb24oKSk7CiAgICAgICAgICAgICBkaWRDaGFuZ2VTY3JvbGxPZmZzZXQo KTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu aCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKaW5kZXggYTA1NmYyYzI4ZjYxNDQz ODgzOGUzOTdkNzU2ODUxNzM4OWVkZjhhZi4uYjQxYTViZGNkMDc2MGJmYzQyOTA5ZGExNmVjMDU3 YjE5YWMwNDZhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCkBAIC02MjQsNyArNjI0LDcgQEAg cHJpdmF0ZToKIAogICAgIC8vIFNjcm9sbGFibGVBcmVhIGludGVyZmFjZQogICAgIHZpcnR1YWwg dm9pZCBpbnZhbGlkYXRlU2Nyb2xsYmFyUmVjdChTY3JvbGxiYXIqLCBjb25zdCBJbnRSZWN0Jikg b3ZlcnJpZGU7Ci0gICAgdmlydHVhbCB2b2lkIHNjcm9sbFRvKGNvbnN0IEludFNpemUmKSBvdmVy cmlkZTsKKyAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsVG8oY29uc3QgU2Nyb2xsUG9zaXRpb24mKSBv dmVycmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0VmlzaWJsZVNjcm9sbGVyVGh1bWJSZWN0KGNv bnN0IEludFJlY3QmKSBvdmVycmlkZTsKICAgICB2aXJ0dWFsIFNjcm9sbGFibGVBcmVhKiBlbmNs b3NpbmdTY3JvbGxhYmxlQXJlYSgpIGNvbnN0IG92ZXJyaWRlOwogICAgIHZpcnR1YWwgSW50UmVj dCBzY3JvbGxhYmxlQXJlYUJvdW5kaW5nQm94KGJvb2wqID0gbnVsbHB0cikgY29uc3Qgb3ZlcnJp ZGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IDk3NjJiMDBlNjQ5 YzY4YmYxMWU4NTcyZTIyMTk1NzA1YmQ3ZTIzNjkuLjI2NGE1Y2E1NTAwYTIzOTVmMjZiYTI4OTVi NjBkMTkwNDczYmQ0ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9s bFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBA IC0yNjQsNyArMjY0LDcgQEAgSW50UmVjdCBTY3JvbGxWaWV3Ojp1bm9ic2N1cmVkQ29udGVudFJl Y3RJbnRlcm5hbChWaXNpYmxlQ29udGVudFJlY3RJbmNsdWRlc1Njcm8KIHsKICAgICBGbG9hdFNp emUgdmlzaWJsZUNvbnRlbnRTaXplID0gdW5zY2FsZWRVbm9ic2N1cmVkVmlzaWJsZUNvbnRlbnRT aXplKHNjcm9sbGJhckluY2x1c2lvbik7CiAgICAgdmlzaWJsZUNvbnRlbnRTaXplLnNjYWxlKDEg LyB2aXNpYmxlQ29udGVudFNjYWxlRmFjdG9yKCkpOwotICAgIHJldHVybiBJbnRSZWN0KEludFBv aW50KG1fc2Nyb2xsT2Zmc2V0KSwgZXhwYW5kZWRJbnRTaXplKHZpc2libGVDb250ZW50U2l6ZSkp OworICAgIHJldHVybiBJbnRSZWN0KG1fc2Nyb2xsUG9zaXRpb24sIGV4cGFuZGVkSW50U2l6ZSh2 aXNpYmxlQ29udGVudFNpemUpKTsKIH0KIAogSW50U2l6ZSBTY3JvbGxWaWV3Ojp1bnNjYWxlZFZp c2libGVDb250ZW50U2l6ZUluY2x1ZGluZ09ic2N1cmVkQXJlYShWaXNpYmxlQ29udGVudFJlY3RJ bmNsdWRlc1Njcm9sbGJhcnMgc2Nyb2xsYmFySW5jbHVzaW9uKSBjb25zdApAQCAtNDQxLDggKzQ0 MSw3IEBAIHZvaWQgU2Nyb2xsVmlldzo6c2V0U2Nyb2xsT2Zmc2V0KGNvbnN0IEludFBvaW50JiBv ZmZzZXQpCiAgICAgaWYgKGNvbnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlKCkpCiAgICAg ICAgIGNvbnN0cmFpbmVkT2Zmc2V0ID0gY29uc3RyYWluZWRPZmZzZXQuY29uc3RyYWluZWRCZXR3 ZWVuKEludFBvaW50KCksIG1heGltdW1TY3JvbGxPZmZzZXQoKSk7CiAKLSAgICBTY3JvbGxQb3Np dGlvbiBuZXdQb3NpdGlvbiA9IHNjcm9sbFBvc2l0aW9uRnJvbU9mZnNldChjb25zdHJhaW5lZE9m ZnNldCk7Ci0gICAgc2Nyb2xsVG8odG9JbnRTaXplKG5ld1Bvc2l0aW9uKSk7CisgICAgc2Nyb2xs VG8oc2Nyb2xsUG9zaXRpb25Gcm9tT2Zmc2V0KGNvbnN0cmFpbmVkT2Zmc2V0KSk7CiB9CiAKIHZv aWQgU2Nyb2xsVmlldzo6c2Nyb2xsUG9zaXRpb25DaGFuZ2VkVmlhUGxhdGZvcm1XaWRnZXQoY29u c3QgSW50UG9pbnQmIG9sZFBvc2l0aW9uLCBjb25zdCBJbnRQb2ludCYgbmV3UG9zaXRpb24pCkBA IC00NzYsMTkgKzQ3NSwyMCBAQCB2b2lkIFNjcm9sbFZpZXc6OmhhbmRsZURlZmVycmVkU2Nyb2xs VXBkYXRlQWZ0ZXJDb250ZW50U2l6ZUNoYW5nZSgpCiAgICAgbV9kZWZlcnJlZFNjcm9sbFBvc2l0 aW9ucyA9IG51bGxwdHI7CiB9CiAKLXZvaWQgU2Nyb2xsVmlldzo6c2Nyb2xsVG8oY29uc3QgSW50 U2l6ZSYgbmV3T2Zmc2V0KQordm9pZCBTY3JvbGxWaWV3OjpzY3JvbGxUbyhjb25zdCBTY3JvbGxQ b3NpdGlvbiYgbmV3UG9zaXRpb24pCiB7Ci0gICAgSW50U2l6ZSBzY3JvbGxEZWx0YSA9IG5ld09m ZnNldCAtIG1fc2Nyb2xsT2Zmc2V0OworICAgIEludFNpemUgc2Nyb2xsRGVsdGEgPSBuZXdQb3Np dGlvbiAtIG1fc2Nyb2xsUG9zaXRpb247CiAgICAgaWYgKHNjcm9sbERlbHRhLmlzWmVybygpKQog ICAgICAgICByZXR1cm47Ci0gICAgbV9zY3JvbGxPZmZzZXQgPSBuZXdPZmZzZXQ7CisKKyAgICBt X3Njcm9sbFBvc2l0aW9uID0gbmV3UG9zaXRpb247CiAKICAgICBpZiAoc2Nyb2xsYmFyc1N1cHBy ZXNzZWQoKSkKICAgICAgICAgcmV0dXJuOwogCiAjaWYgVVNFKENPT1JESU5BVEVEX0dSQVBISUNT KQogICAgIGlmIChkZWxlZ2F0ZXNTY3JvbGxpbmcoKSkgewotICAgICAgICByZXF1ZXN0U2Nyb2xs UG9zaXRpb25VcGRhdGUoSW50UG9pbnQobmV3T2Zmc2V0KSk7CisgICAgICAgIHJlcXVlc3RTY3Jv bGxQb3NpdGlvblVwZGF0ZShuZXdQb3NpdGlvbik7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAj ZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuaAppbmRleCA4YzcwZjVmZGZhMDE0 MjI0OWM4NzRjODM3MzIyMGFkZGZlZjJjZGZmLi5jMGUzOGViMDljNGVhNDFmY2M0YmZjYmZjZTIy ZTBlOGY3ZjEyNjdmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxW aWV3LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5oCkBAIC03NCw3 ICs3NCw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5UGFnZVRoYXRDb250ZW50 QXJlYVdpbGxQYWludCgpIGNvbnN0OwogCiAgICAgLy8gTk9URTogVGhpcyBzaG91bGQgb25seSBi ZSBjYWxsZWQgYnkgdGhlIG92ZXJyaWRlbiBzZXRTY3JvbGxPZmZzZXQgZnJvbSBTY3JvbGxhYmxl QXJlYS4KLSAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsVG8oY29uc3QgSW50U2l6ZSYgbmV3T2Zmc2V0 KTsKKyAgICB2aXJ0dWFsIHZvaWQgc2Nyb2xsVG8oY29uc3QgU2Nyb2xsUG9zaXRpb24mKTsKIAog ICAgIC8vIFRoZSB3aW5kb3cgdGhhdHMgaG9zdHMgdGhlIFNjcm9sbFZpZXcuIFRoZSBTY3JvbGxW aWV3IHdpbGwgY29tbXVuaWNhdGUgc2Nyb2xscyBhbmQgcmVwYWludHMgdG8gdGhlCiAgICAgLy8g aG9zdCB3aW5kb3cgaW4gdGhlIHdpbmRvdydzIGNvb3JkaW5hdGUgc3BhY2UuCkBAIC00NTAsNyAr NDUwLDcgQEAgcHJpdmF0ZToKICNlbHNlCiAgICAgSW50UmVjdCBtX2ZpeGVkVmlzaWJsZUNvbnRl bnRSZWN0OwogI2VuZGlmCi0gICAgSW50U2l6ZSBtX3Njcm9sbE9mZnNldDsgLy8gRklYTUU6IFdv dWxkIHJhdGhlciBzdG9yZSB0aGlzIGFzIGEgcG9zaXRpb24sIGJ1dCB3ZSB3aWxsIHdhaXQgdG8g bWFrZSB0aGlzIGNoYW5nZSB1bnRpbCBtb3JlIGNvZGUgaXMgc2hhcmVkLgorICAgIFNjcm9sbFBv c2l0aW9uIG1fc2Nyb2xsUG9zaXRpb247CiAgICAgSW50UG9pbnQgbV9jYWNoZWRTY3JvbGxQb3Np dGlvbjsKICAgICBJbnRTaXplIG1fZml4ZWRMYXlvdXRTaXplOwogICAgIEludFNpemUgbV9jb250 ZW50c1NpemU7Cg==