152559 2015-12-25 10:51:44 -0800 ASSERT(m_nsResponse) in ResourceResponse::platformCertificateInfo() when running tests in iOS simulator 2015-12-25 12:47:14 -0800 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap adele aestes beidson commit-queue ddkilzer koivisto mitz oldest_to_newest 1151336 0 ap 2015-12-25 10:51:44 -0800 I get this assertion every time when running tests in debug mode. It's a regression, as I've been able to run tests in debug mode a few months ago. $ run-webkit-tests --ios-simulator js/intl-collator.html --no-retry --no-timeout #1 0x0000000110eb3455 in WebCore::ResourceResponse::platformCertificateInfo() const at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/cocoa/ResourceResponseCocoa.mm:70 #2 0x0000000112461cb4 in WebCore::ResourceResponseBase::includeCertificateInfo() const at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/ResourceResponseBase.cpp:181 #3 0x00000001098c6962 in WebKit::NetworkLoad::sharedDidReceiveResponse(WebCore::ResourceResponse const&) at /Volumes/Data/Safari/OpenSource/Source/WebKit2/NetworkProcess/NetworkLoad.cpp:141 #4 0x00000001098c6b6d in WebKit::NetworkLoad::didReceiveResponseAsync(WebCore::ResourceHandle*, WebCore::ResourceResponse const&) at /Volumes/Data/Safari/OpenSource/Source/WebKit2/NetworkProcess/NetworkLoad.cpp:232 #5 0x00000001124510e5 in ::___ZN7WebCore55ResourceHandleCFURLConnectionDelegateWithOperationQueue18didReceiveResponseEP16_CFURLConnectionP14_CFURLResponse_block_invoke() at /Volumes/Data/Safari/OpenSource/Source/WebCore/platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:162 1151337 1 ap 2015-12-25 10:54:25 -0800 When this happens, m_nsResponse is null, but m_cfResponse is not null. I'm beginning to suspect http://trac.webkit.org/r194378 1151338 2 267921 ap 2015-12-25 11:05:40 -0800 Created attachment 267921 proposed fix Yes, definitely that. I just made sure that this test runs, and didn't audit the rest of the patch. It's probably worth another look. 1151339 3 267921 commit-queue 2015-12-25 12:47:10 -0800 Comment on attachment 267921 proposed fix Clearing flags on attachment: 267921 Committed r194420: <http://trac.webkit.org/changeset/194420> 1151340 4 commit-queue 2015-12-25 12:47:14 -0800 All reviewed patches have been landed. Closing bug. 267921 2015-12-25 11:05:40 -0800 2015-12-25 12:47:10 -0800 proposed fix NSvsCF.txt text/plain 1602 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NDQxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE1LTEyLTI1ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVChtX25zUmVzcG9u c2UpIGluIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvKCkgd2hlbiBy dW5uaW5nIHRlc3RzIGluIGlPUyBzaW11bGF0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjU1OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIHJlZ3Jlc3Npb24gZnJvbSByMTk0Mzc4LgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW06 CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNlcnRpZmljYXRl SW5mbyk6CisKIDIwMTUtMTItMjUgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBSZXNvdXJjZUVycm9yIHNob3VsZCBzdG9yZSBmYWlsaW5nVVJMIGFzIFVSTCBp bnN0ZWFkIG9mIFN0cmluZyB0byBhdm9pZCByZXBhcnNpbmcgYW5kIHRvIGFkZHJlc3MgRklYTUUg Y29tbWVudHMgaW4gUmVzb3VyY2VFcnJvckNGLmNwcCBhbmQgUmVzb3VyY2VFcnJvck1hYy5tbQpJ bmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jb2NvYS9SZXNvdXJjZVJlc3Bv bnNlQ29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9jb2NvYS9SZXNvdXJjZVJlc3BvbnNlQ29jb2EubW0JKHJldmlzaW9uIDE5NDQxOCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvUmVzb3VyY2VSZXNwb25zZUNvY29h Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw4ICs2NywxNCBAQCB2b2lkIFJlc291cmNlUmVzcG9u c2U6OmluaXROU1VSTFJlc3BvbnNlCiAKIENlcnRpZmljYXRlSW5mbyBSZXNvdXJjZVJlc3BvbnNl OjpwbGF0Zm9ybUNlcnRpZmljYXRlSW5mbygpIGNvbnN0CiB7CisjaWYgVVNFKENGTkVUV09SSykK KyAgICBBU1NFUlQobV9jZlJlc3BvbnNlKTsKKyAgICBDRlVSTFJlc3BvbnNlUmVmIGNmUmVzcG9u c2UgPSBtX2NmUmVzcG9uc2UuZ2V0KCk7CisjZWxzZQogICAgIEFTU0VSVChtX25zUmVzcG9uc2Up OwotICAgIGF1dG8gY2ZSZXNwb25zZSA9IFttX25zUmVzcG9uc2UgX0NGVVJMUmVzcG9uc2VdOwor ICAgIENGVVJMUmVzcG9uc2VSZWYgY2ZSZXNwb25zZSA9IFttX25zUmVzcG9uc2UgX0NGVVJMUmVz cG9uc2VdOworI2VuZGlmCisKICAgICBpZiAoIWNmUmVzcG9uc2UpCiAgICAgICAgIHJldHVybiB7 IH07CiAK