152555 2015-12-24 22:59:15 -0800 Rename NodeMayOverflowInXXX to NodeMayOverflowInt32InXXX. 2015-12-26 22:27:30 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren keith_miller msaboff saam oldest_to_newest 1151313 0 mark.lam 2015-12-24 22:59:15 -0800 That's because the NodeMayOverflowInBaseline and NodeMayOverflowInDFG flags only indicates potential overflowing of Int32 values. We'll be adding overflow profiling for Int52 values later, and we should disambiguate between the 2 types. 1151314 1 267912 mark.lam 2015-12-24 23:09:08 -0800 Created attachment 267912 proposed patch. 1151400 2 267912 commit-queue 2015-12-26 22:27:27 -0800 Comment on attachment 267912 proposed patch. Clearing flags on attachment: 267912 Committed r194423: <http://trac.webkit.org/changeset/194423> 1151401 3 commit-queue 2015-12-26 22:27:30 -0800 All reviewed patches have been landed. Closing bug. 267912 2015-12-24 23:09:08 -0800 2015-12-26 22:27:27 -0800 proposed patch. bug-152555.patch text/plain 7474 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk0NDE3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBA CisyMDE1LTEyLTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgTm9kZU1heU92ZXJmbG93SW5YWFggdG8gTm9kZU1heU92ZXJmbG93SW50MzJJblhYWC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjU1NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoYXQncyBi ZWNhdXNlIHRoZSBOb2RlTWF5T3ZlcmZsb3dJbkJhc2VsaW5lIGFuZCBOb2RlTWF5T3ZlcmZsb3dJ bkRGRyBmbGFncyBvbmx5CisgICAgICAgIGluZGljYXRlcyBwb3RlbnRpYWwgb3ZlcmZsb3dpbmcg b2YgSW50MzIgdmFsdWVzLiAgV2UnbGwgYmUgYWRkaW5nIG92ZXJmbG93CisgICAgICAgIHByb2Zp bGluZyBmb3IgSW50NTIgdmFsdWVzIGxhdGVyLCBhbmQgd2Ugc2hvdWxkIGRpc2FtYmlndWF0ZSBi ZXR3ZWVuIHRoZSAyIHR5cGVzLgorCisgICAgICAgIFRoaXMgaXMgcHVyZWx5IGEgcmVuYW1pbmcg cGF0Y2guICBUaGVyZSBhcmUgbm8gc2VtYW50aWMgY2hhbmdlcy4KKworICAgICAgICAqIGRmZy9E RkdCeXRlQ29kZVBhcnNlci5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Qnl0ZUNvZGVQYXJzZXI6 Om1ha2VTYWZlKToKKyAgICAgICAgKEpTQzo6REZHOjpCeXRlQ29kZVBhcnNlcjo6bWFrZURpdlNh ZmUpOgorICAgICAgICAoSlNDOjpERkc6OkJ5dGVDb2RlUGFyc2VyOjpoYW5kbGVJbnRyaW5zaWND YWxsKToKKyAgICAgICAgKiBkZmcvREZHTm9kZUZsYWdzLmNwcDoKKyAgICAgICAgKEpTQzo6REZH OjpkdW1wTm9kZUZsYWdzKToKKyAgICAgICAgKiBkZmcvREZHTm9kZUZsYWdzLmg6CisgICAgICAg IChKU0M6OkRGRzo6bm9kZU1heU92ZXJmbG93SW50MzIpOgorICAgICAgICAoSlNDOjpERkc6Om5v ZGVDYW5TcGVjdWxhdGVJbnQzMik6CisgICAgICAgIChKU0M6OkRGRzo6bm9kZU1heU92ZXJmbG93 KTogRGVsZXRlZC4KKwogMjAxNS0xMi0yMyAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5j b20+CiAKICAgICAgICAganNjIENMSSB0b29sIGNyYXNoZXMgb24gRU9GLgpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdCeXRlQ29kZVBhcnNlci5jcHAJKHJldmlzaW9u IDE5NDQxNSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQnl0ZUNvZGVQYXJzZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC04ODIsNyArODgyLDcgQEAgcHJpdmF0ZToKICAgICBOb2Rl KiBtYWtlU2FmZShOb2RlKiBub2RlKQogICAgIHsKICAgICAgICAgaWYgKG1faW5saW5lU3RhY2tU b3AtPm1fZXhpdFByb2ZpbGUuaGFzRXhpdFNpdGUobV9jdXJyZW50SW5kZXgsIE92ZXJmbG93KSkK LSAgICAgICAgICAgIG5vZGUtPm1lcmdlRmxhZ3MoTm9kZU1heU92ZXJmbG93SW5ERkcpOworICAg ICAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5T3ZlcmZsb3dJbnQzMkluREZHKTsKICAg ICAgICAgaWYgKG1faW5saW5lU3RhY2tUb3AtPm1fZXhpdFByb2ZpbGUuaGFzRXhpdFNpdGUobV9j dXJyZW50SW5kZXgsIE5lZ2F0aXZlWmVybykpCiAgICAgICAgICAgICBub2RlLT5tZXJnZUZsYWdz KE5vZGVNYXlOZWdaZXJvSW5ERkcpOwogICAgICAgICAKQEAgLTg5OCwxNCArODk4LDE0IEBAIHBy aXZhdGU6CiAgICAgICAgIGNhc2UgQXJpdGhTdWI6CiAgICAgICAgIGNhc2UgVmFsdWVBZGQ6CiAg ICAgICAgIGNhc2UgQXJpdGhNb2Q6IC8vIGZvciBBcml0aE1vZCAiTWF5T3ZlcmZsb3ciIG1lYW5z IHdlIHRyaWVkIHRvIGRpdmlkZSBieSB6ZXJvLCBvciB3ZSBzYXcgZG91YmxlLgotICAgICAgICAg ICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5T3ZlcmZsb3dJbkJhc2VsaW5lKTsKKyAgICAgICAg ICAgIG5vZGUtPm1lcmdlRmxhZ3MoTm9kZU1heU92ZXJmbG93SW50MzJJbkJhc2VsaW5lKTsKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgCiAgICAgICAgIGNhc2UgQXJpdGhOZWdhdGU6 CiAgICAgICAgICAgICAvLyBDdXJyZW50bHkgd2UgY2FuJ3QgdGVsbCB0aGUgZGlmZmVyZW5jZSBi ZXR3ZWVuIGEgbmVnYXRpb24gb3ZlcmZsb3dpbmcKICAgICAgICAgICAgIC8vIChpLmUuIC0oMSA8 PCAzMSkpIG9yIGdlbmVyYXRpbmcgbmVnYXRpdmUgemVybyAoaS5lLiAtMCkuIElmIGl0IHRvb2sg c2xvdwogICAgICAgICAgICAgLy8gcGF0aCB0aGVuIHdlIGFzc3VtZSB0aGF0IGl0IGRpZCBib3Ro IG9mIHRob3NlIHRoaW5ncy4KLSAgICAgICAgICAgIG5vZGUtPm1lcmdlRmxhZ3MoTm9kZU1heU92 ZXJmbG93SW5CYXNlbGluZSk7CisgICAgICAgICAgICBub2RlLT5tZXJnZUZsYWdzKE5vZGVNYXlP dmVyZmxvd0ludDMySW5CYXNlbGluZSk7CiAgICAgICAgICAgICBub2RlLT5tZXJnZUZsYWdzKE5v ZGVNYXlOZWdaZXJvSW5CYXNlbGluZSk7CiAgICAgICAgICAgICBicmVhazsKIApAQCAtOTE1LDcg KzkxNSw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTMyNDcwCiAgICAgICAgICAgICBpZiAobV9pbmxpbmVTdGFja1Rv cC0+bV9wcm9maWxlZEJsb2NrLT5saWtlbHlUb1Rha2VEZWVwZXN0U2xvd0Nhc2UobV9jdXJyZW50 SW5kZXgpCiAgICAgICAgICAgICAgICAgfHwgbV9pbmxpbmVTdGFja1RvcC0+bV9leGl0UHJvZmls ZS5oYXNFeGl0U2l0ZShtX2N1cnJlbnRJbmRleCwgT3ZlcmZsb3cpKQotICAgICAgICAgICAgICAg IG5vZGUtPm1lcmdlRmxhZ3MoTm9kZU1heU92ZXJmbG93SW5CYXNlbGluZSB8IE5vZGVNYXlOZWda ZXJvSW5CYXNlbGluZSk7CisgICAgICAgICAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5 T3ZlcmZsb3dJbnQzMkluQmFzZWxpbmUgfCBOb2RlTWF5TmVnWmVyb0luQmFzZWxpbmUpOwogICAg ICAgICAgICAgZWxzZSBpZiAobV9pbmxpbmVTdGFja1RvcC0+bV9wcm9maWxlZEJsb2NrLT5saWtl bHlUb1Rha2VTbG93Q2FzZShtX2N1cnJlbnRJbmRleCkKICAgICAgICAgICAgICAgICB8fCBtX2lu bGluZVN0YWNrVG9wLT5tX2V4aXRQcm9maWxlLmhhc0V4aXRTaXRlKG1fY3VycmVudEluZGV4LCBO ZWdhdGl2ZVplcm8pKQogICAgICAgICAgICAgICAgIG5vZGUtPm1lcmdlRmxhZ3MoTm9kZU1heU5l Z1plcm9JbkJhc2VsaW5lKTsKQEAgLTkzNCw3ICs5MzQsNyBAQCBwcml2YXRlOgogICAgICAgICBB U1NFUlQobm9kZS0+b3AoKSA9PSBBcml0aERpdik7CiAgICAgICAgIAogICAgICAgICBpZiAobV9p bmxpbmVTdGFja1RvcC0+bV9leGl0UHJvZmlsZS5oYXNFeGl0U2l0ZShtX2N1cnJlbnRJbmRleCwg T3ZlcmZsb3cpKQotICAgICAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5T3ZlcmZsb3dJ bkRGRyk7CisgICAgICAgICAgICBub2RlLT5tZXJnZUZsYWdzKE5vZGVNYXlPdmVyZmxvd0ludDMy SW5ERkcpOwogICAgICAgICBpZiAobV9pbmxpbmVTdGFja1RvcC0+bV9leGl0UHJvZmlsZS5oYXNF eGl0U2l0ZShtX2N1cnJlbnRJbmRleCwgTmVnYXRpdmVaZXJvKSkKICAgICAgICAgICAgIG5vZGUt Pm1lcmdlRmxhZ3MoTm9kZU1heU5lZ1plcm9JbkRGRyk7CiAgICAgICAgIApAQCAtOTQ4LDcgKzk0 OCw3IEBAIHByaXZhdGU6CiAgICAgICAgICAgICByZXR1cm4gbm9kZTsKICAgICAgICAgCiAgICAg ICAgIC8vIEZJWE1FOiBJdCBtaWdodCBiZSBwb3NzaWJsZSB0byBtYWtlIHRoaXMgbW9yZSBncmFu dWxhci4KLSAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5T3ZlcmZsb3dJbkJhc2VsaW5l IHwgTm9kZU1heU5lZ1plcm9JbkJhc2VsaW5lKTsKKyAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhO b2RlTWF5T3ZlcmZsb3dJbnQzMkluQmFzZWxpbmUgfCBOb2RlTWF5TmVnWmVyb0luQmFzZWxpbmUp OwogICAgICAgICAKICAgICAgICAgcmV0dXJuIG5vZGU7CiAgICAgfQpAQCAtMjAxMCw3ICsyMDEw LDcgQEAgYm9vbCBCeXRlQ29kZVBhcnNlcjo6aGFuZGxlSW50cmluc2ljQ2FsbAogICAgICAgICBp bnNlcnRDaGVja3MoKTsKICAgICAgICAgTm9kZSogbm9kZSA9IGFkZFRvR3JhcGgoQXJpdGhBYnMs IGdldCh2aXJ0dWFsUmVnaXN0ZXJGb3JBcmd1bWVudCgxLCByZWdpc3Rlck9mZnNldCkpKTsKICAg ICAgICAgaWYgKG1faW5saW5lU3RhY2tUb3AtPm1fZXhpdFByb2ZpbGUuaGFzRXhpdFNpdGUobV9j dXJyZW50SW5kZXgsIE92ZXJmbG93KSkKLSAgICAgICAgICAgIG5vZGUtPm1lcmdlRmxhZ3MoTm9k ZU1heU92ZXJmbG93SW5ERkcpOworICAgICAgICAgICAgbm9kZS0+bWVyZ2VGbGFncyhOb2RlTWF5 T3ZlcmZsb3dJbnQzMkluREZHKTsKICAgICAgICAgc2V0KFZpcnR1YWxSZWdpc3RlcihyZXN1bHRP cGVyYW5kKSwgbm9kZSk7CiAgICAgICAgIHJldHVybiB0cnVlOwogICAgIH0KSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZUZsYWdzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGVGbGFncy5jcHAJKHJldmlzaW9uIDE5NDQxNSkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZUZsYWdzLmNwcAkod29ya2luZyBj b3B5KQpAQCAtODQsMTMgKzg0LDEzIEBAIHZvaWQgZHVtcE5vZGVGbGFncyhQcmludFN0cmVhbSYg YWN0dWFsT3UKICAgICAgICAgaWYgKGZsYWdzICYgTm9kZUJ5dGVjb2RlVXNlc0FzT3RoZXIpCiAg ICAgICAgICAgICBvdXQucHJpbnQoY29tbWEsICJVc2VBc090aGVyIik7CiAgICAgfQotICAgIAot ICAgIGlmIChmbGFncyAmIE5vZGVNYXlPdmVyZmxvd0luQmFzZWxpbmUpCi0gICAgICAgIG91dC5w cmludChjb21tYSwgIk1heU92ZXJmbG93SW5CYXNlbGluZSIpOwotICAgIAotICAgIGlmIChmbGFn cyAmIE5vZGVNYXlPdmVyZmxvd0luREZHKQotICAgICAgICBvdXQucHJpbnQoY29tbWEsICJNYXlP dmVyZmxvd0luREZHIik7Ci0gICAgCisKKyAgICBpZiAoZmxhZ3MgJiBOb2RlTWF5T3ZlcmZsb3dJ bnQzMkluQmFzZWxpbmUpCisgICAgICAgIG91dC5wcmludChjb21tYSwgIk1heU92ZXJmbG93SW50 MzJJbkJhc2VsaW5lIik7CisKKyAgICBpZiAoZmxhZ3MgJiBOb2RlTWF5T3ZlcmZsb3dJbnQzMklu REZHKQorICAgICAgICBvdXQucHJpbnQoY29tbWEsICJNYXlPdmVyZmxvd0ludDMySW5ERkciKTsK KwogICAgIGlmIChmbGFncyAmIE5vZGVNYXlOZWdaZXJvSW5CYXNlbGluZSkKICAgICAgICAgb3V0 LnByaW50KGNvbW1hLCAiTWF5TmVnWmVyb0luQmFzZWxpbmUiKTsKICAgICAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9kZUZsYWdzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlRmxhZ3MuaAkocmV2aXNpb24gMTk0NDE1KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlRmxhZ3MuaAkod29ya2luZyBjb3B5KQpA QCAtNDksOCArNDksOCBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIERGRyB7CiAvLyAweDAw MjAgYW5kIDB4MDA0MCBhcmUgZnJlZS4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg CiAjZGVmaW5lIE5vZGVCZWhhdmlvck1hc2sgICAgICAgICAgICAgICAgIDB4MDc4MAotI2RlZmlu ZSBOb2RlTWF5T3ZlcmZsb3dJbkJhc2VsaW5lICAgICAgICAweDAwODAKLSNkZWZpbmUgTm9kZU1h eU92ZXJmbG93SW5ERkcgICAgICAgICAgICAgMHgwMTAwCisjZGVmaW5lIE5vZGVNYXlPdmVyZmxv d0ludDMySW5CYXNlbGluZSAgIDB4MDA4MAorI2RlZmluZSBOb2RlTWF5T3ZlcmZsb3dJbnQzMklu REZHICAgICAgICAweDAxMDAKICNkZWZpbmUgTm9kZU1heU5lZ1plcm9JbkJhc2VsaW5lICAgICAg ICAgMHgwMjAwCiAjZGVmaW5lIE5vZGVNYXlOZWdaZXJvSW5ERkcgICAgICAgICAgICAgIDB4MDQw MAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKQEAgLTk0LDE4ICs5NCwxOCBAQCBl bnVtIFJhcmVDYXNlUHJvZmlsaW5nU291cmNlIHsKICAgICBBbGxSYXJlQ2FzZXMKIH07CiAKLXN0 YXRpYyBpbmxpbmUgYm9vbCBub2RlTWF5T3ZlcmZsb3coTm9kZUZsYWdzIGZsYWdzLCBSYXJlQ2Fz ZVByb2ZpbGluZ1NvdXJjZSBzb3VyY2UpCitzdGF0aWMgaW5saW5lIGJvb2wgbm9kZU1heU92ZXJm bG93SW50MzIoTm9kZUZsYWdzIGZsYWdzLCBSYXJlQ2FzZVByb2ZpbGluZ1NvdXJjZSBzb3VyY2Up CiB7CiAgICAgTm9kZUZsYWdzIG1hc2sgPSAwOwogICAgIHN3aXRjaCAoc291cmNlKSB7CiAgICAg Y2FzZSBCYXNlbGluZVJhcmVDYXNlOgotICAgICAgICBtYXNrID0gTm9kZU1heU92ZXJmbG93SW5C YXNlbGluZTsKKyAgICAgICAgbWFzayA9IE5vZGVNYXlPdmVyZmxvd0ludDMySW5CYXNlbGluZTsK ICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBERkdSYXJlQ2FzZToKLSAgICAgICAgbWFzayA9IE5v ZGVNYXlPdmVyZmxvd0luREZHOworICAgICAgICBtYXNrID0gTm9kZU1heU92ZXJmbG93SW50MzJJ bkRGRzsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBBbGxSYXJlQ2FzZXM6Ci0gICAgICAgIG1h c2sgPSBOb2RlTWF5T3ZlcmZsb3dJbkJhc2VsaW5lIHwgTm9kZU1heU92ZXJmbG93SW5ERkc7Cisg ICAgICAgIG1hc2sgPSBOb2RlTWF5T3ZlcmZsb3dJbnQzMkluQmFzZWxpbmUgfCBOb2RlTWF5T3Zl cmZsb3dJbnQzMkluREZHOwogICAgICAgICBicmVhazsKICAgICB9CiAgICAgcmV0dXJuICEhKGZs YWdzICYgbWFzayk7CkBAIC0xMzAsNyArMTMwLDcgQEAgc3RhdGljIGlubGluZSBib29sIG5vZGVN YXlOZWdaZXJvKE5vZGVGbAogCiBzdGF0aWMgaW5saW5lIGJvb2wgbm9kZUNhblNwZWN1bGF0ZUlu dDMyKE5vZGVGbGFncyBmbGFncywgUmFyZUNhc2VQcm9maWxpbmdTb3VyY2Ugc291cmNlKQogewot ICAgIGlmIChub2RlTWF5T3ZlcmZsb3coZmxhZ3MsIHNvdXJjZSkpCisgICAgaWYgKG5vZGVNYXlP dmVyZmxvd0ludDMyKGZsYWdzLCBzb3VyY2UpKQogICAgICAgICByZXR1cm4gIWJ5dGVjb2RlVXNl c0FzTnVtYmVyKGZsYWdzKTsKICAgICAKICAgICBpZiAobm9kZU1heU5lZ1plcm8oZmxhZ3MsIHNv dXJjZSkpCg==