152532 2015-12-23 11:15:55 -0800 [GTK] WebFrameProxy::certificateInfo() may return nullptr 2015-12-23 12:51:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 142375 P2 Normal --- 1 ysuzuki ysuzuki berto calvaris cgarcia clopez commit-queue gustavo mcatanzaro mrobinson ossy oldest_to_newest 1151101 0 ysuzuki 2015-12-23 11:15:55 -0800 [GTK] WebFrameProxy::certificateInfo() may return nullptr 1151106 1 267847 ysuzuki 2015-12-23 11:25:22 -0800 Created attachment 267847 Patch 1151108 2 commit-queue 2015-12-23 11:26:51 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1151125 3 267847 mcatanzaro 2015-12-23 12:48:49 -0800 Comment on attachment 267847 Patch Thanks for your contribution. It's a developer error to call this function when certificateInfo() is null. You're right that we should return FALSE instead of crash, but it would be better to do so with g_return_val_if_fail so that we get a runtime critical. This is already fixed appropriately in bug #142375, so I am going to dup this there. But that bug is blocked on bug #150927. It would be great if another Apple reviewer could look at the patch in bug #150927, since this is a very serious issue for us. 1151128 4 mcatanzaro 2015-12-23 12:49:10 -0800 *** This bug has been marked as a duplicate of bug 142375 *** 1151132 5 mcatanzaro 2015-12-23 12:51:27 -0800 P.S. In the future, please use the WebKit Gtk component for bugs like this, otherwise only some of us get CCed, and not until you upload your patch. 267847 2015-12-23 11:25:22 -0800 2015-12-23 12:48:49 -0800 Patch bug-152532-20151224042445.patch text/plain 1729 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Mzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDQzOWIwMmVjZTg2ZDcz ZjZiYzkxYTExM2U4M2IzZWM1ODYxZWVlYy4uYmQ2ZTc5OWEzNzg0NThmNDk0NGU3YzVjYWZhN2Nm NGE5ZjFkNjE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEyLTIzICBZdXN1 a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAgIFtHVEtdIFdlYkZy YW1lUHJveHk6OmNlcnRpZmljYXRlSW5mbygpIG1heSByZXR1cm4gbnVsbHB0cgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTMyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgV2ViRnJhbWVQcm94 eTo6bV9jZXJ0aWZpY2F0ZUluZm8gaXMgZmlsbGVkIHdoZW4gY2FsbGluZyBkaWRDb21taXRMb2Fk LAorICAgICAgICBXZWJGcmFtZVByb3h5OjpjZXJ0aWZpY2F0ZUluZm8oKSBtYXkgcmV0dXJuIG51 bGxwdHIgdW50aWwgaXQgaXMgZmlsbGVkLgorICAgICAgICBJIGVuY291bnRlcmVkIHRoaXMgU0VH ViBvbiB0aGUgTWlkb3JpIGJyb3dzZXIuCisKKyAgICAgICAgVGhpcyBjYXNlIGlzIGhhbmRsZWQg aW4gQ29jb2EgQVBJcyBsaWtlIFdLV2ViVmlldzo6Y2VydGlmaWNhdGVDaGFpbi4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Via2l0 X3dlYl92aWV3X2dldF90bHNfaW5mbyk6CisKIDIwMTUtMTItMjIgIEh1bnNlb3AgSmVvbmcgIDxo czg1Lmplb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIGV3a19hcHBsaWNhdGlvbl9j YWNoZV9tYW5hZ2VyIHRlc3QgZmFpbGVkIGFmdGVyIHIxOTM4MTIKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggNmIyNWM3Yjhj NmRlMWI2ZTlhZjRhYWNjMmI4ZDRhMDljOTMzNjllOS4uZWE4MmIxNzkzMDFjNzk4MWVhNjFmYTYz NjgwYTIwMmU4ZjAwMTQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKQEAgLTM0NjgsNiArMzQ2OCw5IEBAIGdib29sZWFuIHdl YmtpdF93ZWJfdmlld19nZXRfdGxzX2luZm8oV2ViS2l0V2ViVmlldyogd2ViVmlldywgR1Rsc0Nl cnRpZmljYXRlKioKICAgICBpZiAoIW1haW5GcmFtZSkKICAgICAgICAgcmV0dXJuIEZBTFNFOwog CisgICAgaWYgKCFtYWluRnJhbWUtPmNlcnRpZmljYXRlSW5mbygpKQorICAgICAgICByZXR1cm4g RkFMU0U7CisKICAgICBjb25zdCBXZWJDb3JlOjpDZXJ0aWZpY2F0ZUluZm8mIGNlcnRpZmljYXRl SW5mbyA9IG1haW5GcmFtZS0+Y2VydGlmaWNhdGVJbmZvKCktPmNlcnRpZmljYXRlSW5mbygpOwog ICAgIGlmIChjZXJ0aWZpY2F0ZSkKICAgICAgICAgKmNlcnRpZmljYXRlID0gY2VydGlmaWNhdGVJ bmZvLmNlcnRpZmljYXRlKCk7Cg==