152515 2015-12-22 14:55:36 -0800 Minor cleanup in RenderBox::canBeProgramaticallyScrolled() 2016-01-04 11:03:31 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1150976 0 simon.fraser 2015-12-22 14:55:36 -0800 Minor cleanup in RenderBox::canBeProgramaticallyScrolled() 1150977 1 267807 simon.fraser 2015-12-22 14:57:33 -0800 Created attachment 267807 Patch 1151242 2 simon.fraser 2015-12-23 20:55:32 -0800 https://trac.webkit.org/changeset/194404 1152392 3 267807 sabouhallawa 2016-01-04 11:03:31 -0800 Comment on attachment 267807 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267807&action=review > Source/WebCore/rendering/RenderBox.h:476 > + Just for consistency and since we have scrollsOverflow(), should not we have the functions: bool hasOverflow() const { return hasHorizontalOverflow() || hasVerticalOverflow(); } bool hasScrollableOverflow() const { return hasScrollableOverflowX() || hasScrollableOverflowY(); } 267807 2015-12-22 14:57:33 -0800 2015-12-22 15:07:55 -0800 Patch bug-152515-20151222145656.patch text/plain 7089 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0MzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2MxMTA5OWVmN2RhOWY4 ODIxMTUzMzc2YWFhNTdjYjE0NDEzMDlmMy4uMWU4ZjMyOWExNzFiMjU2ZjA3ZGVkNWZlZDQzMGVi OTk0YzkzODEyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE1LTEyLTIyICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1pbm9yIGNsZWFu dXAgaW4gUmVuZGVyQm94OjpjYW5CZVByb2dyYW1hdGljYWxseVNjcm9sbGVkKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjUxNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgUmVtb3ZlIHRo ZSBzY3JvbGxzT3ZlcmZsb3coKSBjaGVjayBpbiBSZW5kZXJCb3g6OmNhbkJlUHJvZ3JhbWF0aWNh bGx5U2Nyb2xsZWQoKSwKKyAgICAgICAgc2luY2UgaWYgaGFzU2Nyb2xsYWJsZU92ZXJmbG93IGlz IHRydWUsIHNjcm9sbHNPdmVyZmxvdygpIG11c3QgYWxzbyBiZSB0cnVlLgorICAgICAgICAKKyAg ICAgICAgRmFjdG9yIGNsaWVudFdpZHRoL0hlaWdodCB2cy4gc2Nyb2xsV2lkdGgvSGVpZ2h0IGNo ZWNrcyBpbnRvIHNlcGFyYXRlIGZ1bmN0aW9ucywKKyAgICAgICAgYW5kIGNhbGwgdGhlbSBmcm9t IHR3byBwbGFjZXMuCisgICAgICAgIAorICAgICAgICBBZGRlZCBhIHRlc3Qgd2hpY2ggaXMgbm90 IGFmZmVjdGVkIGJ5IHRoaXMgcGFydGljdWxhciBjaGFuZ2UsIGJ1dCB3aWxsIHZlcmlmeQorICAg ICAgICB0aGF0IGEgbGF0ZXIgY2hhbmdlIGRvZXNuJ3QgYnJlYWsgYW55dGhpbmcuCisKKyAgICAg ICAgVGVzdDogZmFzdC9vdmVyZmxvdy9vdmVyZmxvdy1oaWRkZW4tc2Nyb2xsLWludG8tdmlldy5o dG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveDo6Y2FuQmVTY3JvbGxlZEFuZEhhc1Njcm9sbGFibGVBcmVhKToKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y2FuQmVQcm9ncmFtYXRpY2FsbHlTY3JvbGxlZCk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy Qm94OjpoYXNIb3Jpem9udGFsT3ZlcmZsb3cpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94 OjpoYXNWZXJ0aWNhbE92ZXJmbG93KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6aGFz U2Nyb2xsYWJsZU92ZXJmbG93WCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6Omhhc1Nj cm9sbGFibGVPdmVyZmxvd1kpOgorCiAyMDE1LTEyLTIyICBCcmVudCBGdWxnaGFtICA8YmZ1bGdo YW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFsbG93IEphdmFTY3JpcHQgdG8gaXRlcmF0ZSBvdmVy IHBsdWdpbnMgZm9yIGxvY2FsIFNlY3VyaXR5T3JpZ2lucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcAppbmRleCA5ODIxYmUzOTQxNWIzZDhkODY2MDc5MGFjYjNiODkyODgzNmY1 ZDAxLi41ODRmNTFhMGExNjAyOWQ1MjY3OTU5ZjY1MDBjY2JmODgyNjAzZDk0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtODY3LDcgKzg2Nyw3IEBAIGJvb2wgUmVu ZGVyQm94Ojpsb2dpY2FsU2Nyb2xsKFNjcm9sbExvZ2ljYWxEaXJlY3Rpb24gZGlyZWN0aW9uLCBT Y3JvbGxHcmFudWxhcml0CiAKIGJvb2wgUmVuZGVyQm94OjpjYW5CZVNjcm9sbGVkQW5kSGFzU2Ny b2xsYWJsZUFyZWEoKSBjb25zdAogewotICAgIHJldHVybiBjYW5CZVByb2dyYW1hdGljYWxseVNj cm9sbGVkKCkgJiYgKHNjcm9sbEhlaWdodCgpICE9IHJvdW5kVG9JbnQoY2xpZW50SGVpZ2h0KCkp IHx8IHNjcm9sbFdpZHRoKCkgIT0gcm91bmRUb0ludChjbGllbnRXaWR0aCgpKSk7CisgICAgcmV0 dXJuIGNhbkJlUHJvZ3JhbWF0aWNhbGx5U2Nyb2xsZWQoKSAmJiAoaGFzSG9yaXpvbnRhbE92ZXJm bG93KCkgfHwgaGFzVmVydGljYWxPdmVyZmxvdygpKTsKIH0KIAogYm9vbCBSZW5kZXJCb3g6Omlz U2Nyb2xsYWJsZU9yUnViYmVyYmFuZGFibGVCb3goKSBjb25zdApAQCAtODgzLDggKzg4Myw3IEBA IGJvb2wgUmVuZGVyQm94OjpjYW5CZVByb2dyYW1hdGljYWxseVNjcm9sbGVkKCkgY29uc3QKICAg ICBpZiAoIWhhc092ZXJmbG93Q2xpcCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBi b29sIGhhc1Njcm9sbGFibGVPdmVyZmxvdyA9IGhhc1Njcm9sbGFibGVPdmVyZmxvd1goKSB8fCBo YXNTY3JvbGxhYmxlT3ZlcmZsb3dZKCk7Ci0gICAgaWYgKHNjcm9sbHNPdmVyZmxvdygpICYmIGhh c1Njcm9sbGFibGVPdmVyZmxvdykKKyAgICBpZiAoaGFzU2Nyb2xsYWJsZU92ZXJmbG93WCgpIHx8 IGhhc1Njcm9sbGFibGVPdmVyZmxvd1koKSkKICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBy ZXR1cm4gZWxlbWVudCgpICYmIGVsZW1lbnQoKS0+aGFzRWRpdGFibGVTdHlsZSgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckJveC5oCmluZGV4IDAyN2YyMmZlOWRiYTMxYmQ1OTllNjU0Yjdi YTE3MjM4MmIzNzMyMDguLmJhMjhkODc1ZmVkMDcyN2NhZTBlMTU1ZmFmZGU1ODlmOTg3ODc5M2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKQEAgLTQ2OSwxMSArNDY5LDE2IEBA IHB1YmxpYzoKIAogICAgIGJvb2wgaGFzVmVydGljYWxTY3JvbGxiYXJXaXRoQXV0b0JlaGF2aW9y KCkgY29uc3Q7CiAgICAgYm9vbCBoYXNIb3Jpem9udGFsU2Nyb2xsYmFyV2l0aEF1dG9CZWhhdmlv cigpIGNvbnN0OworCiAgICAgYm9vbCBzY3JvbGxzT3ZlcmZsb3coKSBjb25zdCB7IHJldHVybiBz Y3JvbGxzT3ZlcmZsb3dYKCkgfHwgc2Nyb2xsc092ZXJmbG93WSgpOyB9CiAgICAgYm9vbCBzY3Jv bGxzT3ZlcmZsb3dYKCkgY29uc3QgeyByZXR1cm4gaGFzT3ZlcmZsb3dDbGlwKCkgJiYgKHN0eWxl KCkub3ZlcmZsb3dYKCkgPT0gT1NDUk9MTCB8fCBoYXNIb3Jpem9udGFsU2Nyb2xsYmFyV2l0aEF1 dG9CZWhhdmlvcigpKTsgfQogICAgIGJvb2wgc2Nyb2xsc092ZXJmbG93WSgpIGNvbnN0IHsgcmV0 dXJuIGhhc092ZXJmbG93Q2xpcCgpICYmIChzdHlsZSgpLm92ZXJmbG93WSgpID09IE9TQ1JPTEwg fHwgaGFzVmVydGljYWxTY3JvbGxiYXJXaXRoQXV0b0JlaGF2aW9yKCkpOyB9Ci0gICAgYm9vbCBo YXNTY3JvbGxhYmxlT3ZlcmZsb3dYKCkgY29uc3QgeyByZXR1cm4gc2Nyb2xsc092ZXJmbG93WCgp ICYmIHNjcm9sbFdpZHRoKCkgIT0gcm91bmRUb0ludChjbGllbnRXaWR0aCgpKTsgfQotICAgIGJv b2wgaGFzU2Nyb2xsYWJsZU92ZXJmbG93WSgpIGNvbnN0IHsgcmV0dXJuIHNjcm9sbHNPdmVyZmxv d1koKSAmJiBzY3JvbGxIZWlnaHQoKSAhPSByb3VuZFRvSW50KGNsaWVudEhlaWdodCgpKTsgfQor CisgICAgYm9vbCBoYXNIb3Jpem9udGFsT3ZlcmZsb3coKSBjb25zdCB7IHJldHVybiBzY3JvbGxX aWR0aCgpICE9IHJvdW5kVG9JbnQoY2xpZW50V2lkdGgoKSk7IH0KKyAgICBib29sIGhhc1ZlcnRp Y2FsT3ZlcmZsb3coKSBjb25zdCB7IHJldHVybiBzY3JvbGxIZWlnaHQoKSAhPSByb3VuZFRvSW50 KGNsaWVudEhlaWdodCgpKTsgfQorCisgICAgYm9vbCBoYXNTY3JvbGxhYmxlT3ZlcmZsb3dYKCkg Y29uc3QgeyByZXR1cm4gc2Nyb2xsc092ZXJmbG93WCgpICYmIGhhc0hvcml6b250YWxPdmVyZmxv dygpOyB9CisgICAgYm9vbCBoYXNTY3JvbGxhYmxlT3ZlcmZsb3dZKCkgY29uc3QgeyByZXR1cm4g c2Nyb2xsc092ZXJmbG93WSgpICYmIGhhc1ZlcnRpY2FsT3ZlcmZsb3coKTsgfQogCiAgICAgYm9v bCB1c2VzQ29tcG9zaXRlZFNjcm9sbGluZygpIGNvbnN0OwogICAgIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDMzZWE0YWQx ZmUzMzUxZWQyMDFlZTVjMzU2OGZlYTUwMjI5NTZlNDcuLmI3MzM1Yjc4ZWEzOWViNmM2N2VkZTll ZDBkMzkyM2JjOWVkYTRkOTcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNS0xMi0yMiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBNaW5vciBjbGVh bnVwIGluIFJlbmRlckJveDo6Y2FuQmVQcm9ncmFtYXRpY2FsbHlTY3JvbGxlZCgpCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI1MTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRlc3QgdGhh dCBwcm9ncmFtbWF0aWMgc2Nyb2xsaW5nIHdvcmtzIGluc2lkZSBvdmVyZmxvdzpoaWRkZW4uCisK KyAgICAgICAgKiBmYXN0L292ZXJmbG93L292ZXJmbG93LWhpZGRlbi1zY3JvbGwtaW50by12aWV3 LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ct aGlkZGVuLXNjcm9sbC1pbnRvLXZpZXcuaHRtbDogQWRkZWQuCisKIDIwMTUtMTItMjIgIFhhYmll ciBSb2RyaWd1ZXogQ2FsdmFyICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KIAogICAgICAgICBbU3Ry ZWFtcyBBUEldIEZpeCBjb3NtZXRpYyB0aGluZ3MgYWZ0ZXIgaW1wb3J0aW5nIHNwZWMgdGVzdHMK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGlkZGVuLXNj cm9sbC1pbnRvLXZpZXctZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cv b3ZlcmZsb3ctaGlkZGVuLXNjcm9sbC1pbnRvLXZpZXctZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4xODM2ZDlmYjUwOTNlZDZlNDk4ZjVlMjc5MTY2YThjYTZlNDU2NDA0Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9vdmVyZmxvdy9vdmVyZmxvdy1oaWRkZW4tc2Nyb2xsLWlu dG8tdmlldy1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1sPgor Cis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRsZT5UZXN0cyB0aGF0IHNjcm9sbEludG9WaWV3KCkg d29ya3MgaW5zaWRlIG92ZXJmbG93OmhpZGRlbjwvdGl0bGU+CisgICAgPHN0eWxlPgorICAgICAg ICAuY29udGFpbmVyIHsKKyAgICAgICAgICAgIGhlaWdodDogMjAwcHg7CisgICAgICAgICAgICB3 aWR0aDogMjAwcHg7CisgICAgICAgICAgICBib3JkZXI6IDFweCBzb2xpZCBibGFjazsKKyAgICAg ICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJlZDsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAg ICAgI2JveCB7CisgICAgICAgICAgICBoZWlnaHQ6IDIwMHB4OworICAgICAgICAgICAgd2lkdGg6 IDIwMHB4OworICAgICAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgIH0K KyAgICA8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgor ICAgIDxkaXYgaWQ9ImJveCI+PC9kaXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGlkZGVuLXNjcm9sbC1p bnRvLXZpZXcuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGlkZGVu LXNjcm9sbC1pbnRvLXZpZXcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5jZjgyYjNjOWFmNDE0YTVmYjA3MjRm MjYxNzhkM2I1ZGNjYjJmODNiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9v dmVyZmxvdy9vdmVyZmxvdy1oaWRkZW4tc2Nyb2xsLWludG8tdmlldy5odG1sCkBAIC0wLDAgKzEs MzYgQEAKKzwhRE9DVFlQRSBodG1sPgorCis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRsZT5UZXN0 cyB0aGF0IHNjcm9sbEludG9WaWV3KCkgd29ya3MgaW5zaWRlIG92ZXJmbG93OmhpZGRlbjwvdGl0 bGU+CisgICAgPHN0eWxlPgorICAgICAgICAuY29udGFpbmVyIHsKKyAgICAgICAgICAgIGhlaWdo dDogMjAwcHg7CisgICAgICAgICAgICB3aWR0aDogMjAwcHg7CisgICAgICAgICAgICBvdmVyZmxv dzogaGlkZGVuOworICAgICAgICAgICAgYm9yZGVyOiAxcHggc29saWQgYmxhY2s7CisgICAgICAg ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAg ICNib3ggeworICAgICAgICAgICAgbWFyZ2luLXRvcDogNTAwcHg7CisgICAgICAgICAgICBoZWln aHQ6IDIwMHB4OworICAgICAgICAgICAgd2lkdGg6IDIwMHB4OworICAgICAgICAgICAgYmFja2dy b3VuZC1jb2xvcjogZ3JlZW47CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+ CisgICAgICAgIGZ1bmN0aW9uIGRvVGVzdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIHZhciBi b3ggPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYm94Jyk7CisgICAgICAgICAgICBib3guc2Ny b2xsSW50b1ZpZXcoKTsKKyAgICAgICAgfQorICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5l cignbG9hZCcsIGRvVGVzdCwgZmFsc2UpOworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgaWQ9ImJveCI+PC9kaXY+Cis8L2Rp dj4KKzwvYm9keT4KKzwvaHRtbD4K