15251 2007-09-21 11:31:23 -0700 REGRESSION: <input type=range> doesn't respond to form.reset() or setting input.value 2007-09-22 21:13:26 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) All All RESOLVED FIXED InRadar, Regression P2 Normal --- 1 aroben aroben adele oldest_to_newest 194 0 aroben 2007-09-21 11:31:23 -0700 Setting input.value for <input type=range> does not update the position of the slider thumb. 195 1 aroben 2007-09-21 11:33:51 -0700 Hm, I can't reproduce this in a smaller testcase. Maybe it's a bug with the page I was working on... 196 2 aroben 2007-09-21 11:39:58 -0700 Turns out I was wrong. This works! \o/ 197 3 aroben 2007-09-21 11:58:51 -0700 Ok, so this bug does happen, but only if you've dragged the thumb once. Attaching a testcase. 192 4 16341 aroben 2007-09-21 12:00:51 -0700 Created attachment 16341 testcase 193 5 16342 aroben 2007-09-21 12:07:28 -0700 Created attachment 16342 potential fix So this patch seems to fix the bug, though I'd like Adele's opinion on whether this is the right way to go about it. 191 6 aroben 2007-09-21 12:28:12 -0700 Adele said she didn't think the approach in my first patch was right, so I debugged a bit more, and I think I have found the real cause. It looks as though the thumb's position will only get updated if HTMLInputElement::setChanged() is called at some point. When setting the value through JS, this happens in HTMLInputElement::parseMappedAttribute: } else if (attr->name() == valueAttr) { // We only need to setChanged if the form is looking at the default value right now. if (m_value.isNull()) setChanged(); setValueMatchesRenderer(false); Note the check for if (m_value.isNull()). Normally, modifications to m_value only happen if HTMLInputElement::storesValueSeparateFromAttribute() returns true (which it does not for <input type=range>). So for an <input type=range>, we would expect m_value.isNull() to always be true, and therefore setChanged() to always be called when input.value is modified. However, there is one place where m_value is set without first checking storesValueSeparateFromAttribute(): HTMLInputElement::setValueFromRenderer(). This method gets called from RenderSlider::setValueForPosition(), which is called when you drag the thumb. This sets m_value, so setChanged() is never subsequently called when input.value is set from JS. It seems like RenderSlider really wants to set the value attribute directly, not HTMLInputElement::m_value. 190 7 hyatt 2007-09-21 13:30:34 -0700 "It seems like RenderSlider really wants to set the value attribute directly, not HTMLInputElement::m_value." I don't think so... you need to be able to reset a slider back to its default value. The value attribute represents the default value that you will reset to (as well as the initial value). If the user drags the slider thumb, then this should not change the default value. It is just changing the current value. If the user then resets the form, the slider should revert back to its default value. 186 8 hyatt 2007-09-21 13:33:26 -0700 The patch in this bug is absolutely correct, although you'll need to make sure Safari RSS doesn't break. 180 9 hyatt 2007-09-21 14:19:45 -0700 This is a regression from Safari 2. 182 10 hyatt 2007-09-21 14:23:14 -0700 <rdar://problem/5498169> 130 11 aroben 2007-09-22 18:14:44 -0700 Looks like resetting via form.reset() is also broken. 128 12 aroben 2007-09-22 21:13:26 -0700 Fixed in r25701 16341 2007-09-21 12:00:51 -0700 2007-09-21 12:00:51 -0700 testcase slider.html text/html 543 aroben PGEgaHJlZj0iaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTEiPkJ1 ZyAxNTI1MTogU2V0dGluZyBpbnB1dC52YWx1ZSBmb3IgJmx0O2lucHV0IHR5cGU9cmFuZ2UmZ3Q7 IGRvZXMgbm90IHVwZGF0ZSB0aGUgcG9zaXRpb24gb2YgdGhlIHNsaWRlciB0aHVtYiBpZiB0aGUg dGh1bWIgaGFzIGJlZW4gZHJhZ2dlZCBvbmNlPC9hPgoKPHA+VG8gcmVwcm9kdWNlLCBjbGljayB0 aGUgYnV0dG9uLCB0aGVuIGRyYWcgdGhlIHRodW1iLCB0aGVuIGNsaWNrIHRoZSBidXR0b24gYWdh aW4uIEFueSBjbGlja3Mgb2YgdGhlIGJ1dHRvbiBhZnRlciBkcmFnZ2luZyB0aGUgdGh1bWIgd2ls bCBoYXZlIG5vIGVmZmVjdCBvbiB0aGUgcG9zaXRpb24gb2YgdGhlIHRodW1iLjwvcD4KCjxpbnB1 dCBpZD0ic2xpZGVyIiB0eXBlPSJyYW5nZSIgbWluPSIwIiBtYXg9IjEwMCI+Cgo8YnV0dG9uIG9u Y2xpY2s9ImRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzbGlkZXInKS52YWx1ZSA9IDEwIj5DbGlj ayB0byBzZXQgdmFsdWUgdG8gMTA8L2J1dHRvbj4K 16342 2007-09-21 12:07:28 -0700 2007-09-21 12:07:28 -0700 potential fix slider.patch text/plain 592 aroben ZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUv aHRtbC9IVE1MSW5wdXRFbGVtZW50LmNwcAppbmRleCAyZWViZTYwLi4xY2U4YjRmIDEwMDY0NAot LS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9odG1s L0hUTUxJbnB1dEVsZW1lbnQuY3BwCkBAIC0xMDAwLDEzICsxMDAwLDEzIEBAIGJvb2wgSFRNTElu cHV0RWxlbWVudDo6c3RvcmVzVmFsdWVTZXBhcmF0ZUZyb21BdHRyaWJ1dGUoKSBjb25zdAogICAg ICAgICBjYXNlIEhJRERFTjoKICAgICAgICAgY2FzZSBJTUFHRToKICAgICAgICAgY2FzZSBSQURJ TzoKLSAgICAgICAgY2FzZSBSQU5HRToKICAgICAgICAgY2FzZSBSRVNFVDoKICAgICAgICAgY2Fz ZSBTVUJNSVQ6CiAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIGNhc2UgRklMRToK ICAgICAgICAgY2FzZSBJU0lOREVYOgogICAgICAgICBjYXNlIFBBU1NXT1JEOgorICAgICAgICBj YXNlIFJBTkdFOgogICAgICAgICBjYXNlIFNFQVJDSDoKICAgICAgICAgY2FzZSBURVhUOgogICAg ICAgICAgICAgcmV0dXJuIHRydWU7Cg==