152507 2015-12-22 12:20:56 -0800 Botwatcher's dashboard should show an 'X' when the build is broken 2016-01-20 11:31:17 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dburkart dburkart dburkart lforschler webkit-bug-importer oldest_to_newest 1150933 0 dburkart 2015-12-22 12:20:56 -0800 Currently, the botwatcher's dashboard only turns red (and still shows the issue count) when the build fails. We should differentiate this failure case further from simply finding issues by displaying an 'X' instead of an issue count. 1150934 1 dburkart 2015-12-22 12:21:12 -0800 rdar://problem/23731424 1150935 2 267794 dburkart 2015-12-22 12:24:10 -0800 Created attachment 267794 patch This fixes it so that we pass "null" to StatusLineView (in which case, an 'X' is displayed) if the build is broken. 1150981 3 267794 ddkilzer 2015-12-22 15:25:24 -0800 Comment on attachment 267794 patch r=me 1156991 4 dburkart 2016-01-20 11:31:17 -0800 Committed r195359. 267794 2015-12-22 12:24:10 -0800 2015-12-22 15:25:24 -0800 patch bug_152507.patch text/plain 2429 dburkart ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90U3RhdGljQW5hbHl6ZXJR dWV1ZVZpZXcuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFN0YXRpY0FuYWx5emVy UXVldWVWaWV3LmpzCmluZGV4IDkzNmNiMDAuLjYzNGZjYWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hi b2FyZC9TY3JpcHRzL0J1aWxkYm90U3RhdGljQW5hbHl6ZXJRdWV1ZVZpZXcuanMKKysrIGIvVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv ZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RTdGF0aWNBbmFseXplclF1ZXVlVmlldy5qcwpAQCAt NjEsNiArNjEsNyBAQCBCdWlsZGJvdFN0YXRpY0FuYWx5emVyUXVldWVWaWV3LnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICB2YXIgdGV4dDsKIAogICAgICAgICAgICAgICAgIHZhciBmYWls ZWRTdGVwID0gbmV3IEJ1aWxkYm90VGVzdFJlc3VsdHMoaXRlcmF0aW9uLl9maXJzdEZhaWxlZFN0 ZXApOworICAgICAgICAgICAgICAgIHZhciBpc3N1ZUNvdW50ID0gZmFpbGVkU3RlcC5pc3N1ZUNv dW50OwogCiAgICAgICAgICAgICAgICAgaWYgKGl0ZXJhdGlvbi5zdWNjZXNzZnVsKSB7CiAgICAg ICAgICAgICAgICAgICAgIHN0YXR1c0xpbmVWaWV3Q29sb3IgPSBTdGF0dXNMaW5lVmlldy5TdGF0 dXMuR29vZDsKQEAgLTczLDkgKzc0LDEwIEBAIEJ1aWxkYm90U3RhdGljQW5hbHl6ZXJRdWV1ZVZp ZXcucHJvdG90eXBlID0gewogICAgICAgICAgICAgICAgICAgICB1cmwgPSBpdGVyYXRpb24ucXVl dWUuYnVpbGRib3QuYnVpbGRQYWdlVVJMRm9ySXRlcmF0aW9uKGl0ZXJhdGlvbik7CiAgICAgICAg ICAgICAgICAgICAgIHN0YXR1c0xpbmVWaWV3Q29sb3IgPSBTdGF0dXNMaW5lVmlldy5TdGF0dXMu QmFkOwogICAgICAgICAgICAgICAgICAgICB0ZXh0ID0gImJ1aWxkIGZhaWxlZCI7CisgICAgICAg ICAgICAgICAgICAgIGlzc3VlQ291bnQgPSBudWxsOwogICAgICAgICAgICAgICAgIH0KIAotICAg ICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXcobWVzc2FnZUVsZW1l bnQsIHN0YXR1c0xpbmVWaWV3Q29sb3IsICh0ZXh0KSA/IHRleHQgOiAiZm91bmQgIiArIGZhaWxl ZFN0ZXAuaXNzdWVDb3VudCArICIgaXNzdWVzIiwgZmFpbGVkU3RlcC5pc3N1ZUNvdW50LCB1cmwp OworICAgICAgICAgICAgICAgIHZhciBzdGF0dXMgPSBuZXcgU3RhdHVzTGluZVZpZXcobWVzc2Fn ZUVsZW1lbnQsIHN0YXR1c0xpbmVWaWV3Q29sb3IsICh0ZXh0KSA/IHRleHQgOiAiZm91bmQgIiAr IGZhaWxlZFN0ZXAuaXNzdWVDb3VudCArICIgaXNzdWVzIiwgaXNzdWVDb3VudCwgdXJsKTsKIAog ICAgICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZChzdGF0dXMuZWxlbWVudCk7 CiAgICAgICAgICAgICAgICAgYXBwZW5kZWRTdGF0dXMgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGNlNWExOWIuLjU1MDgzNDcgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNS0xMi0yMiAgRGFuYSBCdXJrYXJ0ICA8ZGJ1cmthcnRAYXBwbGUuY29tPgor CisgICAgICAgIEJvdHdhdGNoZXIncyBkYXNoYm9hcmQgc2hvdWxkIHNob3cgYW4gJ1gnIHdoZW4g dGhlIGJ1aWxkIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9w dWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFN0YXRpY0FuYWx5emVyUXVldWVW aWV3LmpzOgorICAgICAgICAoQnVpbGRib3RTdGF0aWNBbmFseXplclF1ZXVlVmlldy5wcm90b3R5 cGUuYXBwZW5kU3RhdGljQW5hbHl6ZXJRdWV1ZVN0YXR1cyk6CisgICAgICAgIChCdWlsZGJvdFN0 YXRpY0FuYWx5emVyUXVldWVWaWV3LnByb3RvdHlwZS51cGRhdGUpOgorCiAyMDE1LTEyLTIyICBD aHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgW1dLMl0gTG9v cGluZyBpbiB0ZXN0Y2FzZTogZmFzdC9kb20vV2luZG93L3Byb3BlcnR5LWFjY2Vzcy1vbi1jYWNo ZWQtd2luZG93LWFmdGVyLWZyYW1lLXJlbW92ZWQuaHRtbAo=