152505 2015-12-22 08:57:15 -0800 [Streams API] In RS during enqueuing error should be reported only if readable 2015-12-23 10:14:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 calvaris calvaris benjamin commit-queue youennf oldest_to_newest 1150895 0 calvaris 2015-12-22 08:57:15 -0800 [Streams API] In RS during enqueuing error should be reported only if readable 1150896 1 267787 calvaris 2015-12-22 08:59:42 -0800 Created attachment 267787 Patch 1150897 2 youennf 2015-12-22 09:10:24 -0800 Looks ok. I wonder why the patch does not contain any test modification. What about the tests added in https://github.com/whatwg/streams/commit/2e7f87e45806d58114592c923aed299798d10161? 1150904 3 calvaris 2015-12-22 09:39:45 -0800 (In reply to comment #2) > Looks ok. > I wonder why the patch does not contain any test modification. > What about the tests added in > https://github.com/whatwg/streams/commit/ > 2e7f87e45806d58114592c923aed299798d10161? You're right, I saw them at that moment and I forget about them later. 1151058 4 267836 calvaris 2015-12-23 05:17:14 -0800 Created attachment 267836 Patch Added tests 1151062 5 267836 youennf 2015-12-23 06:22:20 -0800 Comment on attachment 267836 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=267836&action=review > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:46 > +}, 'Readable stream: strategy.size errors the stream and then throws'); Are we not already passing this test without ReadableStreamInternals.js tests? > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:71 > + assert_equals(error.name, 'RangeError', 'enqueue should throw a RangeError'); Are we not passing this test without the patch? The checks of this test may not be sufficient enough. It seems to me we should check that rs.getReader().closed be equal to theError. 1151069 6 calvaris 2015-12-23 07:05:55 -0800 (In reply to comment #5) > > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:46 > > +}, 'Readable stream: strategy.size errors the stream and then throws'); > > Are we not already passing this test without ReadableStreamInternals.js > tests? > > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:71 > > + assert_equals(error.name, 'RangeError', 'enqueue should throw a RangeError'); Both fail in debug because of the assert, but not in release. 1151073 7 267836 youennf 2015-12-23 07:47:39 -0800 Comment on attachment 267836 Patch r=me. It would be good to improve the second test: making it a promise test, expecting the error to be theError and not a RangeError, either here or as a pull request to whatwg streams github. 1151087 8 calvaris 2015-12-23 09:27:57 -0800 (In reply to comment #7) > Comment on attachment 267836 [details] > Patch > > r=me. Landing. > It would be good to improve the second test: making it a promise test, > expecting the error to be theError and not a RangeError, either here or as a > pull request to whatwg streams github. I'll do it GitHub. 1151091 9 calvaris 2015-12-23 10:07:56 -0800 (In reply to comment #8) > > It would be good to improve the second test: making it a promise test, > > expecting the error to be theError and not a RangeError, either here or as a > > pull request to whatwg streams github. > > I'll do it GitHub. https://github.com/whatwg/streams/pull/420 1151094 10 267836 commit-queue 2015-12-23 10:14:22 -0800 Comment on attachment 267836 Patch Clearing flags on attachment: 267836 Committed r194391: <http://trac.webkit.org/changeset/194391> 1151095 11 commit-queue 2015-12-23 10:14:26 -0800 All reviewed patches have been landed. Closing bug. 267787 2015-12-22 08:59:42 -0800 2015-12-23 05:17:10 -0800 Patch bug-152505-20151222175904.patch text/plain 1672 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0MzYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGRlOGJhODlhYjM5ZDA3 MGNhNjA2ZmYyMThmYjBiMmI3NGE2YzA2Zi4uMWIzN2RkODU5YTYxZWUyM2IxZWNiNjQ2YWQ1Yjcw M2E2ZjY2YTJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTIyICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0 cmVhbXMgQVBJXSBJbiBSUyBkdXJpbmcgZW5xdWV1aW5nIGVycm9yIHNob3VsZCBiZSByZXBvcnRl ZCBvbmx5IGlmIHJlYWRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTI1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGNvbW1pdCBmaXhlcyBsYXN0IHNwZWMgY2hhbmdlIGRvbmUgaW4KKyAg ICAgICAgaHR0cHM6Ly9naXRodWIuY29tL3doYXR3Zy9zdHJlYW1zL2NvbW1pdC80YmE4NjFlNmY2 MGMyNDgwNjA4MTE4MzBlMTEyNzFjODRiNDM5Y2MzLgorCisgICAgICAgIEN1cnJlbnQgdGVzdHMg Y292ZXIgdGhpcy4KKworICAgICAgICAqIE1vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUlu dGVybmFscy5qczoKKyAgICAgICAgKGVucXVldWVJblJlYWRhYmxlU3RyZWFtKTogQ2FsbCBAZXJy b3JSZWFkYWJsZVN0cmVhbSBvbmx5IGlmIHN0YXRlIGlzIHJlYWRhYmxlLgorCiAyMDE1LTEyLTIy ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXSBFdmVyeXRoaW5nIGJyb2tlbiBpbiBHVEsrIDMuMTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcyBiL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcwppbmRl eCBmYjM1ZGJiZmY0OGJkMTQyNWQwYzk1NTUxNmRlM2UwZGJiZjAwMTgzLi5lNjg2NzZkYWM3OWUz YjQwMjljMTUxNTQ1MGEyMWNjZTFmZjRlOWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanMKKysrIGIvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzCkBAIC0zMjgs NyArMzI4LDggQEAgZnVuY3Rpb24gZW5xdWV1ZUluUmVhZGFibGVTdHJlYW0oc3RyZWFtLCBjaHVu aykKICAgICAgICAgQGVucXVldWVWYWx1ZVdpdGhTaXplKHN0cmVhbS5AcXVldWUsIGNodW5rLCBz aXplKTsKICAgICB9CiAgICAgY2F0Y2goZXJyb3IpIHsKLSAgICAgICAgQGVycm9yUmVhZGFibGVT dHJlYW0oc3RyZWFtLCBlcnJvcik7CisgICAgICAgIGlmIChzdHJlYW0uQHN0YXRlID09PSBAc3Ry ZWFtUmVhZGFibGUpCisgICAgICAgICAgICBAZXJyb3JSZWFkYWJsZVN0cmVhbShzdHJlYW0sIGVy cm9yKTsKICAgICAgICAgdGhyb3cgZXJyb3I7CiAgICAgfQogICAgIEByZXF1ZXN0UmVhZGFibGVT dHJlYW1QdWxsKHN0cmVhbSk7Cg== 267836 2015-12-23 05:17:14 -0800 2015-12-23 10:14:22 -0800 Patch bug-152505-20151223141637.patch text/plain 7115 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0Mzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzI5NDUxYTgwZTY4Mjcw Y2EwMWY4ZjFiZjYxY2UyOTc4ZTA1OWM4Yy4uYjJkN2U2M2ExNWNmMjIxYmM4YjZiMjM3N2YzMzJl ZGJjMDNjNjVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEyLTIzICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1N0 cmVhbXMgQVBJXSBJbiBSUyBkdXJpbmcgZW5xdWV1aW5nIGVycm9yIHNob3VsZCBiZSByZXBvcnRl ZCBvbmx5IGlmIHJlYWRhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTI1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGlzIGNvbW1pdCBmaXhlcyBsYXN0IHNwZWMgY2hhbmdlIGRvbmUgaW4KKyAg ICAgICAgaHR0cHM6Ly9naXRodWIuY29tL3doYXR3Zy9zdHJlYW1zL2NvbW1pdC80YmE4NjFlNmY2 MGMyNDgwNjA4MTE4MzBlMTEyNzFjODRiNDM5Y2MzLgorCisgICAgICAgIFRlc3Q6IGltcG9ydGVk L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvcmVhZGFibGUtc3RyZWFtcy9iYWQt c3RyYXRlZ2llcy5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJl YW1JbnRlcm5hbHMuanM6CisgICAgICAgIChlbnF1ZXVlSW5SZWFkYWJsZVN0cmVhbSk6IENhbGwg QGVycm9yUmVhZGFibGVTdHJlYW0gb25seSBpZiBzdGF0ZSBpcyByZWFkYWJsZS4KKwogMjAxNS0x Mi0yMyAgQ2hyaXMgQWxqb3VkaSA8Y2hyaXNAY2hyaXNtYXRpYy5pbz4gYW5kIEFsZXggQ2hyaXN0 ZW5zZW4gPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIENvbnRlbnQgYmxvY2tl cnMgc2hvdWxkIGJlIGFibGUgdG8gcHJvbW90ZSBodHRwIHRvIGh0dHBzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMuanMg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3N0cmVhbXMvUmVhZGFibGVTdHJlYW1JbnRlcm5hbHMu anMKaW5kZXggZmIzNWRiYmZmNDhiZDE0MjVkMGM5NTU1MTZkZTNlMGRiYmYwMDE4My4uZTY4Njc2 ZGFjNzllM2I0MDI5YzE1MTU0NTBhMjFjY2UxZmY0ZTlkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvTW9kdWxlcy9zdHJlYW1zL1JlYWRhYmxlU3RyZWFtSW50ZXJuYWxzLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvc3RyZWFtcy9SZWFkYWJsZVN0cmVhbUludGVybmFscy5qcwpA QCAtMzI4LDcgKzMyOCw4IEBAIGZ1bmN0aW9uIGVucXVldWVJblJlYWRhYmxlU3RyZWFtKHN0cmVh bSwgY2h1bmspCiAgICAgICAgIEBlbnF1ZXVlVmFsdWVXaXRoU2l6ZShzdHJlYW0uQHF1ZXVlLCBj aHVuaywgc2l6ZSk7CiAgICAgfQogICAgIGNhdGNoKGVycm9yKSB7Ci0gICAgICAgIEBlcnJvclJl YWRhYmxlU3RyZWFtKHN0cmVhbSwgZXJyb3IpOworICAgICAgICBpZiAoc3RyZWFtLkBzdGF0ZSA9 PT0gQHN0cmVhbVJlYWRhYmxlKQorICAgICAgICAgICAgQGVycm9yUmVhZGFibGVTdHJlYW0oc3Ry ZWFtLCBlcnJvcik7CiAgICAgICAgIHRocm93IGVycm9yOwogICAgIH0KICAgICBAcmVxdWVzdFJl YWRhYmxlU3RyZWFtUHVsbChzdHJlYW0pOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5k ZXggNTRlNDFjYTM0OTQwYWYxNzBmODcyODFjZGE3YjM0NmU5ZDA2YzYxMi4uNjlhNzk3MzZmZWQ0 MmQ5Y2IzMGE3M2IzZWYyZGY3NTcwYTE2NzRjMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTUtMTItMjMgIFhhYmllciBSb2RyaWd1ZXogQ2FsdmFy ICA8Y2FsdmFyaXNAaWdhbGlhLmNvbT4KKworICAgICAgICBbU3RyZWFtcyBBUEldIEluIFJTIGR1 cmluZyBlbnF1ZXVpbmcgZXJyb3Igc2hvdWxkIGJlIHJlcG9ydGVkIG9ubHkgaWYgcmVhZGFibGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjUwNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQg aW1wb3J0ZWQgc3BlYyB0ZXN0cy4KKworICAgICAgICAqIHdlYi1wbGF0Zm9ybS10ZXN0cy9zdHJl YW1zLWFwaS9SRUFETUUudHh0OiBVcGRhdGVkIHNwZWMgdmVyc2lvbi4KKyAgICAgICAgKiB3ZWIt cGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvcmVhZGFibGUtc3RyZWFtcy9iYWQtc3RyYXRlZ2ll cy1leHBlY3RlZC50eHQ6IEV4cGVjdGF0aW9ucy4KKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVz dHMvc3RyZWFtcy1hcGkvcmVhZGFibGUtc3RyZWFtcy9iYWQtc3RyYXRlZ2llcy5qczogQWRkZWQg dHdvIG5ldyB0ZXN0cy4KKwogMjAxNS0xMi0yMSAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxj YWx2YXJpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9zdHJlYW1zLWFwaS9yZWFkYWJsZS1zdHJlYW1zL2NhbmNlbC5o dG1sIGhhcyBhIGZsYWt5IHRlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvUkVBRE1FLnR4dCBiL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvUkVBRE1FLnR4dApp bmRleCAyZjdmNjA3YzY1ZTdlMjUyNjgxYWNiNGI2MDA4NmI3YzIxMjY2MzEzLi44MTk1MTc3ZjZl NDdkMmU2MjAwYzRlNDI0MzY1YjNmZmMyYWNjZTI3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3N0cmVhbXMtYXBpL1JFQURNRS50eHQKKysr IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zdHJlYW1zLWFw aS9SRUFETUUudHh0CkBAIC0zLDQgKzMsNCBAQCBUaGlzIGRpcmVjdG9yeSBpcyBpbXBvcnRlZCBm cm9tIHRoZSB0aGUgU3RyZWFtcyBBUEkgcmVwb3NpdG9yeS4KIFRoZXJlIGlzIGEgcGxhbiB0byBt b3ZlIHRoZXNlIHRlc3RzIHRvIHdlYi1wbGF0Zm9ybS10ZXN0cyByZXBvc2l0b3J5IHNvIGZyb20g dGhhdCBtb21lbnQgb24gdGhpcyBpbXBvcnRhdGlvbiB3aWxsIGJlCiBhdXRvbWF0aWMuCiAKLUN1 cnJlbnQgdmVyc2lvbjogaHR0cHM6Ly9naXRodWIuY29tL3doYXR3Zy9zdHJlYW1zL3RyZWUvZjdj YjBlYWMwM2U2YTZkMDQ1ZDZlOGMwOWRmMWY5ZjhhMjY0ZmRlZi9yZWZlcmVuY2UtaW1wbGVtZW50 YXRpb24vd2ViLXBsYXRmb3JtLXRlc3RzLgorQ3VycmVudCB2ZXJzaW9uOiBodHRwczovL2dpdGh1 Yi5jb20vd2hhdHdnL3N0cmVhbXMvdHJlZS8yZTdmODdlNDU4MDZkNTgxMTQ1OTJjOTIzYWVkMjk5 Nzk4ZDEwMTYxL3JlZmVyZW5jZS1pbXBsZW1lbnRhdGlvbi93ZWItcGxhdGZvcm0tdGVzdHMuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3N0 cmVhbXMtYXBpL3JlYWRhYmxlLXN0cmVhbXMvYmFkLXN0cmF0ZWdpZXMtZXhwZWN0ZWQudHh0IGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zdHJlYW1zLWFwaS9y ZWFkYWJsZS1zdHJlYW1zL2JhZC1zdHJhdGVnaWVzLWV4cGVjdGVkLnR4dAppbmRleCA4YzlkMjdj NTAxZjI0MDNhMjE4NjQwNTUyZTlmNmVmOGE4YzRlMTk2Li5mMjY2M2Y0MTM0YzBlYmQ0OGIzNDI5 YzQwYjkyYmM0M2JhMWQ5MjY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL3N0cmVhbXMtYXBpL3JlYWRhYmxlLXN0cmVhbXMvYmFkLXN0cmF0 ZWdpZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvcmVhZGFibGUtc3RyZWFtcy9iYWQtc3RyYXRlZ2llcy1l eHBlY3RlZC50eHQKQEAgLTEsNSArMSw3IEBACiAKIFBBU1MgUmVhZGFibGUgc3RyZWFtOiB0aHJv d2luZyBzdHJhdGVneS5zaXplIGdldHRlciAKK1BBU1MgUmVhZGFibGUgc3RyZWFtOiBzdHJhdGVn eS5zaXplIGVycm9ycyB0aGUgc3RyZWFtIGFuZCB0aGVuIHRocm93cyAKK1BBU1MgUmVhZGFibGUg c3RyZWFtOiBzdHJhdGVneS5zaXplIGVycm9ycyB0aGUgc3RyZWFtIGFuZCB0aGVuIHJldHVybnMg SW5maW5pdHkgCiBQQVNTIFJlYWRhYmxlIHN0cmVhbTogdGhyb3dpbmcgc3RyYXRlZ3kuc2l6ZSBt ZXRob2QgCiBQQVNTIFJlYWRhYmxlIHN0cmVhbTogdGhyb3dpbmcgc3RyYXRlZ3kuaGlnaFdhdGVy TWFyayBnZXR0ZXIgCiBQQVNTIFJlYWRhYmxlIHN0cmVhbTogaW52YWxpZCBzdHJhdGVneS5oaWdo V2F0ZXJNYXJrIApAQCAtMTAsNiArMTIsOCBAQCBGQUlMIFJlYWRhYmxlIHN0cmVhbTogdGhyb3dp bmcgc3RyYXRlZ3kuc2l6ZSBnZXR0ZXIgYXNzZXJ0X3Rocm93czogY29uc3RydWN0aW9uCiAgICAg bmV3IFJlYWRhYmxlU3RyZWFtKHt9LCB7CiAgICAgICBnZXQgc2l6ZSgpIHsKICAuLi4iIHRocmV3 IG9iamVjdCAiUmVmZXJlbmNlRXJyb3I6IENhbid0IGZpbmQgdmFyaWFibGU6IFJlYWRhYmxlU3Ry ZWFtIiAoIlJlZmVyZW5jZUVycm9yIikgZXhwZWN0ZWQgb2JqZWN0ICJFcnJvcjogYSB1bmlxdWUg c3RyaW5nIiAoIkVycm9yIikKK0ZBSUwgUmVhZGFibGUgc3RyZWFtOiBzdHJhdGVneS5zaXplIGVy cm9ycyB0aGUgc3RyZWFtIGFuZCB0aGVuIHRocm93cyBDYW4ndCBmaW5kIHZhcmlhYmxlOiBSZWFk YWJsZVN0cmVhbQorRkFJTCBSZWFkYWJsZSBzdHJlYW06IHN0cmF0ZWd5LnNpemUgZXJyb3JzIHRo ZSBzdHJlYW0gYW5kIHRoZW4gcmV0dXJucyBJbmZpbml0eSBDYW4ndCBmaW5kIHZhcmlhYmxlOiBS ZWFkYWJsZVN0cmVhbQogRkFJTCBSZWFkYWJsZSBzdHJlYW06IHRocm93aW5nIHN0cmF0ZWd5LnNp emUgbWV0aG9kIENhbid0IGZpbmQgdmFyaWFibGU6IFJlYWRhYmxlU3RyZWFtCiBGQUlMIFJlYWRh YmxlIHN0cmVhbTogdGhyb3dpbmcgc3RyYXRlZ3kuaGlnaFdhdGVyTWFyayBnZXR0ZXIgYXNzZXJ0 X3Rocm93czogY29uc3RydWN0aW9uIHNob3VsZCByZS10aHJvdyB0aGUgZXJyb3IgZnVuY3Rpb24g IigpID0+IHsKICAgICBuZXcgUmVhZGFibGVTdHJlYW0oe30sIHsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvcmVhZGFi bGUtc3RyZWFtcy9iYWQtc3RyYXRlZ2llcy5qcyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvc3RyZWFtcy1hcGkvcmVhZGFibGUtc3RyZWFtcy9iYWQtc3RyYXRl Z2llcy5qcwppbmRleCA3ZDA4NWM3NmEyOWZhYTZkMGUyNWVlMzBkYzk5NGIwYmQ3MmRlNGIyLi41 Y2VjYjhmYjJiYjMyZjIxYjVmYTdiMGVkYzdiMzlmN2I3NzdiMjE3IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3N0cmVhbXMtYXBpL3JlYWRh YmxlLXN0cmVhbXMvYmFkLXN0cmF0ZWdpZXMuanMKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQv dzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9zdHJlYW1zLWFwaS9yZWFkYWJsZS1zdHJlYW1zL2JhZC1z dHJhdGVnaWVzLmpzCkBAIC0xOSw2ICsxOSw2MCBAQCB0ZXN0KCgpID0+IHsKIAogfSwgJ1JlYWRh YmxlIHN0cmVhbTogdGhyb3dpbmcgc3RyYXRlZ3kuc2l6ZSBnZXR0ZXInKTsKIAordGVzdCgoKSA9 PiB7CisKKyAgY29uc3QgdGhlRXJyb3IgPSBuZXcgRXJyb3IoJ2EgdW5pcXVlIHN0cmluZycpOwor CisgIGxldCBjb250cm9sbGVyOworICBjb25zdCBycyA9IG5ldyBSZWFkYWJsZVN0cmVhbSgKKyAg ICB7CisgICAgICBzdGFydChjKSB7CisgICAgICAgIGNvbnRyb2xsZXIgPSBjOworICAgICAgfQor ICAgIH0sCisgICAgeworICAgICAgc2l6ZSgpIHsKKyAgICAgICAgY29udHJvbGxlci5lcnJvcih0 aGVFcnJvcik7CisgICAgICAgIHRocm93IHRoZUVycm9yOworICAgICAgfSwKKyAgICAgIGhpZ2hX YXRlck1hcms6IDUKKyAgICB9CisgICk7CisKKyAgYXNzZXJ0X3Rocm93cyh0aGVFcnJvciwgKCkg PT4geworICAgIGNvbnRyb2xsZXIuZW5xdWV1ZSgnYScpOworICB9LCAnZW5xdWV1ZSBzaG91bGQg cmUtdGhyb3cgdGhlIGVycm9yJyk7CisKK30sICdSZWFkYWJsZSBzdHJlYW06IHN0cmF0ZWd5LnNp emUgZXJyb3JzIHRoZSBzdHJlYW0gYW5kIHRoZW4gdGhyb3dzJyk7CisKK3Rlc3QoKCkgPT4gewor CisgIGNvbnN0IHRoZUVycm9yID0gbmV3IEVycm9yKCdhIHVuaXF1ZSBzdHJpbmcnKTsKKworICBs ZXQgY29udHJvbGxlcjsKKyAgY29uc3QgcnMgPSBuZXcgUmVhZGFibGVTdHJlYW0oCisgICAgewor ICAgICAgc3RhcnQoYykgeworICAgICAgICBjb250cm9sbGVyID0gYzsKKyAgICAgIH0KKyAgICB9 LAorICAgIHsKKyAgICAgIHNpemUoKSB7CisgICAgICAgIGNvbnRyb2xsZXIuZXJyb3IodGhlRXJy b3IpOworICAgICAgICByZXR1cm4gSW5maW5pdHk7CisgICAgICB9LAorICAgICAgaGlnaFdhdGVy TWFyazogNQorICAgIH0KKyAgKTsKKworICB0cnkgeworICAgIGNvbnRyb2xsZXIuZW5xdWV1ZSgn YScpOworICB9IGNhdGNoIChlcnJvcikgeworICAgIGFzc2VydF9lcXVhbHMoZXJyb3IubmFtZSwg J1JhbmdlRXJyb3InLCAnZW5xdWV1ZSBzaG91bGQgdGhyb3cgYSBSYW5nZUVycm9yJyk7CisgIH0K KworfSwgJ1JlYWRhYmxlIHN0cmVhbTogc3RyYXRlZ3kuc2l6ZSBlcnJvcnMgdGhlIHN0cmVhbSBh bmQgdGhlbiByZXR1cm5zIEluZmluaXR5Jyk7CisKIHByb21pc2VfdGVzdCgoKSA9PiB7CiAKICAg Y29uc3QgdGhlRXJyb3IgPSBuZXcgRXJyb3IoJ2EgdW5pcXVlIHN0cmluZycpOwo=