152500 2015-12-22 04:35:36 -0800 [GTK] media controls is always displayed when video has a text track 2016-01-23 14:51:56 -0800 1 1 1 Unclassified WebKit Media WebKit Local Build Other Linux RESOLVED FIXED P2 Normal --- 1 wonchul.lee webkit-unassigned bugs-noreply commit-queue mcatanzaro oldest_to_newest 1150869 0 wonchul.lee 2015-12-22 04:35:36 -0800 The media controls show up even the video does not have 'controls' attribute. Chrome and old (2.4.5) Webkit does not display media controls with it. test sample : http://www.kaizou.org/demos/video-text-track-demo/ 1155416 1 268953 wonchul.lee 2016-01-14 04:14:50 -0800 Created attachment 268953 Patch 1156396 2 268953 mcatanzaro 2016-01-18 06:46:05 -0800 Comment on attachment 268953 Patch Thanks for this patch. The code changes look sane, but I think this needs to be committed with a layout test, unless there's some reason it would be hard to test. 1156530 3 269254 wonchul.lee 2016-01-18 19:59:53 -0800 Created attachment 269254 Patch 1156531 4 wonchul.lee 2016-01-18 20:03:21 -0800 @Michael, thanks for reviewing it, I updated some layout test what checked media controls not displaying on video with text track without 'controls' attribute by default and showing media controls on fullscreen regardless of 'controls' attribute. 1158042 5 269254 mcatanzaro 2016-01-23 07:39:27 -0800 Comment on attachment 269254 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269254&action=review Thanks Wonchul. Let's just rephrase the English text a bit: > LayoutTests/media/video-controls-no-display-with-text-track-expected.txt:1 > +Tests that not showing video controls with text track without controls attribute by default and displaying it when request fullscreen How about: "Tests that video controls are not shown for videos with a text track when the controls attribute is not present, except when fullscreen." 1158043 6 269671 wonchul.lee 2016-01-23 08:21:38 -0800 Created attachment 269671 Patch 1158044 7 wonchul.lee 2016-01-23 08:23:16 -0800 Thanks, I rephrased it as you mentioned. 1158066 8 269671 commit-queue 2016-01-23 14:51:51 -0800 Comment on attachment 269671 Patch Clearing flags on attachment: 269671 Committed r195511: <http://trac.webkit.org/changeset/195511> 1158067 9 commit-queue 2016-01-23 14:51:56 -0800 All reviewed patches have been landed. Closing bug. 268953 2016-01-14 04:14:50 -0800 2016-01-18 19:59:47 -0800 Patch bug-152500-20160114211420.patch text/plain 2612 wonchul.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjk3ZTZhYmM4NGU3N2Y3 YmVjYTY5NDFjZDMwYjcyNTEzNzAyMjBkYS4uMTZmNTc1MDMyMGU3ODUxMzBkN2M0NzhiYzBhOTA3 ZDQ3YTgwNjNmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTE0ICBXb25j aHVsIExlZSAgPHdvbmNodWwubGVlQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBbR1RLXSBG aXggbWVkaWEgY29udHJvbHMgZGlzcGxheWluZyB3aXRob3V0IGNvbnRyb2xzIGF0dHJpYnV0ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTAwCisK KyAgICAgICAgTWVkaWEgY29udHJvbHMgaXMgbm90IGRpc3BsYXllZCBieSBkZWZhdWx0IHdoZW4g dGhlIHZpZGVvIGVsZW1lbnQKKyAgICAgICAgaGFzIHRleHQgdHJhY2sgcmVnYXJkbGVzcyBvZiBj b250cm9scyBhdHRyaWJ1dGUuIEluIGFkZGl0aW9uLCBtZWRpYQorICAgICAgICBjb250cm9scyBj YW4gYmUgdG9nZ2xlZCBtdWx0aXBsZSB0aW1lcy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRy b2xzR3RrLmpzOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuc2hvdWxkSGF2ZUNv bnRyb2xzKToKKyAgICAgICAgKENvbnRyb2xsZXJHdGsucHJvdG90eXBlLnJlY29ubmVjdENvbnRy b2xzKToKKyAgICAgICAgKENvbnRyb2xsZXJHdGsucHJvdG90eXBlLnJlbW92ZUNvbnRyb2xzKToK KyAgICAgICAgKENvbnRyb2xsZXJHdGsucHJvdG90eXBlLmNvbmZpZ3VyZUNvbnRyb2xzKTogRGVs ZXRlZC4KKwogMjAxNi0wMS0xMSAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgQ1NTVmFsdWVQb29sIHNob3VsZCB1c2Ugbm9uZnJhZ21lbnRlZCBzdG9yYWdlIGZv ciBldGVybmFsIGNhY2hlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKaW5kZXggMTI4ZmY3ODM2MTk3YjkxN2Rk Nzc5ZDg2M2MwZmFjMzRlMmQ1MzM5Ny4uYmNhNzc3NmM4MTE3ZWYxZTExZTJkMmIwY2IyMDdkYTM3 MTBmODA1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xz L21lZGlhQ29udHJvbHNHdGsuanMKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNv bnRyb2xzL21lZGlhQ29udHJvbHNHdGsuanMKQEAgLTU0LDE4ICs1NCwxOSBAQCBDb250cm9sbGVy R3RrLnByb3RvdHlwZSA9IHsKICAgICAgICAgdGhpcy5jb250cm9scy5lbmNsb3N1cmUuYXBwZW5k Q2hpbGQodGhpcy5jb250cm9scy5wYW5lbCk7CiAgICAgfSwKIAotICAgIGNvbmZpZ3VyZUNvbnRy b2xzOiBmdW5jdGlvbigpIHsKLSAgICAgICAgaWYgKHRoaXMuY29udHJvbHMuY29uZmlndXJlZCkK LSAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICB0aGlzLmNvbmZpZ3VyZUlubGluZUNvbnRy b2xzKCk7Ci0gICAgICAgIHRoaXMuY29udHJvbHMuY29uZmlndXJlZCA9IHRydWU7Ci0gICAgICAg IHRoaXMuYWRkQ29udHJvbHMoKTsKKyAgICBzaG91bGRIYXZlQ29udHJvbHM6IGZ1bmN0aW9uKCkK KyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLnZpZGVvLmNvbnRyb2xzIHx8IHRoaXMuaXNGdWxs U2NyZWVuKCk7CiAgICAgfSwKIAogICAgIHJlY29ubmVjdENvbnRyb2xzOiBmdW5jdGlvbigpCiAg ICAgewotICAgICAgICB0aGlzLmNvbmZpZ3VyZUNvbnRyb2xzKCk7CisgICAgICAgIENvbnRyb2xs ZXIucHJvdG90eXBlLmRpc2Nvbm5lY3RDb250cm9scy5hcHBseSh0aGlzLCBhcmd1bWVudHMpOwor CisgICAgICAgIHRoaXMuY29uZmlndXJlSW5saW5lQ29udHJvbHMoKTsKKworICAgICAgICBpZiAo dGhpcy5zaG91bGRIYXZlQ29udHJvbHMoKSkKKyAgICAgICAgICAgIHRoaXMuYWRkQ29udHJvbHMo KTsKICAgICB9LAogCiAgICAgc2V0U3RhdHVzSGlkZGVuOiBmdW5jdGlvbihoaWRkZW4pCkBAIC0x MzMsNiArMTM0LDEzIEBAIENvbnRyb2xsZXJHdGsucHJvdG90eXBlID0gewogICAgICAgICByZXR1 cm4gdHJ1ZTsKICAgICB9LAogCisgICAgcmVtb3ZlQ29udHJvbHM6IGZ1bmN0aW9uKCkKKyAgICB7 CisgICAgICAgIGlmICh0aGlzLmNvbnRyb2xzLmVuY2xvc3VyZS5wYXJlbnROb2RlKQorICAgICAg ICAgICAgdGhpcy5jb250cm9scy5lbmNsb3N1cmUucGFyZW50Tm9kZS5yZW1vdmVDaGlsZCh0aGlz LmNvbnRyb2xzLmVuY2xvc3VyZSk7CisgICAgICAgIHRoaXMuZGVzdHJveUNhcHRpb25NZW51KCk7 CisgICAgfSwKKwogICAgIGFkZENvbnRyb2xzOiBmdW5jdGlvbigpCiAgICAgewogICAgICAgICB0 aGlzLmJhc2UuYXBwZW5kQ2hpbGQodGhpcy5jb250cm9scy5lbmNsb3N1cmUpOwo= 269254 2016-01-18 19:59:53 -0800 2016-01-23 08:21:30 -0800 Patch bug-152500-20160119125924.patch text/plain 6429 wonchul.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNkYWEzODQzMWRkYmI3 ZDhmNGRjZjU1YThlYmU5Nzg0ZmRiMzBmYy4uODJhMjMwNjc1ZDFlNGQxM2NlMTg4NmI4MTE2MDZi N2VmZTI3ZmI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAxLTE4ICBXb25j aHVsIExlZSAgPHdvbmNodWwubGVlQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBbR1RLXSBG aXggbWVkaWEgY29udHJvbHMgZGlzcGxheWluZyB3aXRob3V0IGNvbnRyb2xzIGF0dHJpYnV0ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTAwCisK KyAgICAgICAgTWVkaWEgY29udHJvbHMgaXMgbm90IGRpc3BsYXllZCB3aXRob3V0IGNvbnRyb2xz IGF0dHJpYnV0ZSBieSBkZWZhdWx0CisgICAgICAgIHdoZW4gdGhlIHZpZGVvIGVsZW1lbnQgaGFz IHRleHQgdHJhY2suIEl0J2xsIGJlIGRpc3BsYXllZCBvbiBmdWxsc2NyZWVuCisgICAgICAgIHJl Z2FyZGxlc3Mgb2YgY29udHJvbHMgYXR0cmlidXRlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNHdGsuanM6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3RvdHlwZS5zaG91bGRIYXZl Q29udHJvbHMpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUucmVjb25uZWN0Q29u dHJvbHMpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUucmVtb3ZlQ29udHJvbHMp OgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuY29uZmlndXJlQ29udHJvbHMpOiBE ZWxldGVkLgogMjAxNi0wMS0xOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TIFNpbXVsYXRvciBXSzFdIEFTU0VSVCBsb2FkaW5nIEJsaW5rIGxh eW91dCB0ZXN0IGltcG9ydGVkL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFt cy9zdHJlYW0tYXBpL21lZGlhc3RyZWFtL21lZGlhc3RyZWFtLWlkbC5odG1sCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5q cyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3Rr LmpzCmluZGV4IDEyOGZmNzgzNjE5N2I5MTdkZDc3OWQ4NjNjMGZhYzM0ZTJkNTMzOTcuLmJjYTc3 NzZjODExN2VmMWUxMWUyZDJiMGNiMjA3ZGEzNzEwZjgwNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzCkBA IC01NCwxOCArNTQsMTkgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRo aXMuY29udHJvbHMuZW5jbG9zdXJlLmFwcGVuZENoaWxkKHRoaXMuY29udHJvbHMucGFuZWwpOwog ICAgIH0sCiAKLSAgICBjb25maWd1cmVDb250cm9sczogZnVuY3Rpb24oKSB7Ci0gICAgICAgIGlm ICh0aGlzLmNvbnRyb2xzLmNvbmZpZ3VyZWQpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAg ICAgdGhpcy5jb25maWd1cmVJbmxpbmVDb250cm9scygpOwotICAgICAgICB0aGlzLmNvbnRyb2xz LmNvbmZpZ3VyZWQgPSB0cnVlOwotICAgICAgICB0aGlzLmFkZENvbnRyb2xzKCk7CisgICAgc2hv dWxkSGF2ZUNvbnRyb2xzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy52 aWRlby5jb250cm9scyB8fCB0aGlzLmlzRnVsbFNjcmVlbigpOwogICAgIH0sCiAKICAgICByZWNv bm5lY3RDb250cm9sczogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhpcy5jb25maWd1cmVD b250cm9scygpOworICAgICAgICBDb250cm9sbGVyLnByb3RvdHlwZS5kaXNjb25uZWN0Q29udHJv bHMuYXBwbHkodGhpcywgYXJndW1lbnRzKTsKKworICAgICAgICB0aGlzLmNvbmZpZ3VyZUlubGlu ZUNvbnRyb2xzKCk7CisKKyAgICAgICAgaWYgKHRoaXMuc2hvdWxkSGF2ZUNvbnRyb2xzKCkpCisg ICAgICAgICAgICB0aGlzLmFkZENvbnRyb2xzKCk7CiAgICAgfSwKIAogICAgIHNldFN0YXR1c0hp ZGRlbjogZnVuY3Rpb24oaGlkZGVuKQpAQCAtMTMzLDYgKzEzNCwxMyBAQCBDb250cm9sbGVyR3Rr LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAorICAgIHJlbW92 ZUNvbnRyb2xzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAodGhpcy5jb250cm9scy5l bmNsb3N1cmUucGFyZW50Tm9kZSkKKyAgICAgICAgICAgIHRoaXMuY29udHJvbHMuZW5jbG9zdXJl LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQodGhpcy5jb250cm9scy5lbmNsb3N1cmUpOworICAgICAg ICB0aGlzLmRlc3Ryb3lDYXB0aW9uTWVudSgpOworICAgIH0sCisKICAgICBhZGRDb250cm9sczog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5iYXNlLmFwcGVuZENoaWxkKHRoaXMuY29u dHJvbHMuZW5jbG9zdXJlKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1ZGFjZjI5ZjU3MTc5ZTA5MTE4ZTZmYThlZWU4NTk3 MzYwMDI5MWViLi5hNzE2NzljMDU1MjFlMGM5OWU1ZTE4N2IzZjk3M2I1Yzk4YjYyMDgyIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMDEtMTggIFdvbmNodWwgTGVlICA8d29uY2h1bC5sZWVA Y29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIEZpeCBtZWRpYSBjb250cm9scyBkaXNw bGF5aW5nIHdpdGhvdXQgY29udHJvbHMgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI1MDAKKworICAgICAgICBNZWRpYSBjb250cm9s cyBpcyBub3QgZGlzcGxheWVkIHdpdGhvdXQgY29udHJvbHMgYXR0cmlidXRlIGJ5IGRlZmF1bHQK KyAgICAgICAgd2hlbiB0aGUgdmlkZW8gZWxlbWVudCBoYXMgdGV4dCB0cmFjay4gSXQnbGwgYmUg ZGlzcGxheWVkIG9uIGZ1bGxzY3JlZW4KKyAgICAgICAgcmVnYXJkbGVzcyBvZiBjb250cm9scyBh dHRyaWJ1dGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBtZWRpYS92aWRlby1jb250cm9scy1uby1kaXNwbGF5LXdpdGgtdGV4dC10cmFjay1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLW5vLWRpc3Bs YXktd2l0aC10ZXh0LXRyYWNrLmh0bWw6IEFkZGVkLgorCiAyMDE2LTAxLTE4ICBOYW4gV2FuZyAg PG5fd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFtNYWNdIEltcGxlbWVudCBuZXh0L3By ZXZpb3VzIHRleHQgbWFya2VyIGZ1bmN0aW9ucyB1c2luZyBUZXh0SXRlcmF0b3IKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLW5vLWRpc3BsYXktd2l0aC10ZXh0 LXRyYWNrLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLW5v LWRpc3BsYXktd2l0aC10ZXh0LXRyYWNrLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iMzczMmUx OWQyNGRlMGU0MTFjNWY2ZmQ4ZDUxMjkwM2YzZDYyZDQ4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbHMtbm8tZGlzcGxheS13aXRoLXRleHQtdHJhY2st ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1Rlc3RzIHRoYXQgbm90IHNob3dpbmcgdmlk ZW8gY29udHJvbHMgd2l0aCB0ZXh0IHRyYWNrIHdpdGhvdXQgY29udHJvbHMgYXR0cmlidXRlIGJ5 IGRlZmF1bHQgYW5kIGRpc3BsYXlpbmcgaXQgd2hlbiByZXF1ZXN0IGZ1bGxzY3JlZW4KKworRVZF TlQoY2FucGxheSkKKworKiogVmlkZW8gY29udHJvbHMgc2hvdWxkIG5vdCBiZSBzaG93biAqKgor RVhQRUNURUQgKHBhbmVsID09ICdudWxsJykgT0sKK0VWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFu Z2UpCisKKyoqIFZpZGVvIGNvbnRyb2xzIHNob3VsZCBiZSBzaG93biBvbiBmdWxsc2NyZWVuICoq CitFWFBFQ1RFRCAocGFuZWwuc3R5bGVbJ2Rpc3BsYXknXSAhPSAnbm9uZScpIE9LCitFTkQgT0Yg VEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9scy1uby1k aXNwbGF5LXdpdGgtdGV4dC10cmFjay5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29u dHJvbHMtbm8tZGlzcGxheS13aXRoLXRleHQtdHJhY2suaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4xMzE5M2Fi MjBhNWJkNTdhNTIxOWQwMjRiMDJiZWU0M2MxNmZmNzBjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbHMtbm8tZGlzcGxheS13aXRoLXRleHQtdHJhY2su aHRtbApAQCAtMCwwICsxLDQ3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cisg ICAgPHRpdGxlPlZpZGVvIGNvbnRyb2xzIG5vIGRpc3BsYXkgd2l0aCB0ZXh0IHRyYWNrIFRlc3Q8 L3RpdGxlPgorICAgIDxzY3JpcHQgc3JjPXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgPHNj cmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz1tZWRpYS1j b250cm9scy5qcz48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0uLi9mdWxsc2NyZWVuL2Z1bGwt c2NyZWVuLXRlc3QuanM+PC9zY3JpcHQ+CisgICAgPHNjcmlwdD4KKyAgICAgICAgdmFyIHBhbmVs OworCisgICAgICAgIHZhciBzdGFydFRlc3QgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGZp bmRNZWRpYUVsZW1lbnQoKTsKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCh2aWRlbywgJ2NhbnBs YXknLCBvbmNhbnBsYXkpOworICAgICAgICAgICAgdmlkZW8uc3JjID0gZmluZE1lZGlhRmlsZSgn dmlkZW8nLCAnY29udGVudC90ZXN0Jyk7CisgICAgICAgIH07CisKKyAgICAgICAgdmFyIG9uY2Fu cGxheSA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAgcGFuZWwgPSBtZWRpYUNvbnRyb2xzRWxl bWVudChpbnRlcm5hbHMuc2hhZG93Um9vdCh2aWRlbykuZmlyc3RDaGlsZCwgIi13ZWJraXQtbWVk aWEtY29udHJvbHMtcGFuZWwiKTsKKworICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAg ICAgICAgICAgIGNvbnNvbGVXcml0ZSgiKiogVmlkZW8gY29udHJvbHMgc2hvdWxkIG5vdCBiZSBz aG93biAqKiIpOworICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJwYW5lbCIsIG51bGwsICI9PSIp OworCisgICAgICAgICAgICB3YWl0Rm9yRXZlbnQodmlkZW8sICd3ZWJraXRmdWxsc2NyZWVuY2hh bmdlJywgb25mdWxsc2NyZWVuY2hhbmdlKTsKKyAgICAgICAgICAgIHJ1bldpdGhLZXlEb3duKGZ1 bmN0aW9uKCl7IHZpZGVvLndlYmtpdFJlcXVlc3RGdWxsc2NyZWVuKCk7IH0pCisgICAgICAgIH07 CisKKyAgICAgICAgdmFyIG9uZnVsbHNjcmVlbmNoYW5nZSA9IGZ1bmN0aW9uKCkgeworICAgICAg ICAgICAgcGFuZWwgPSBtZWRpYUNvbnRyb2xzRWxlbWVudChpbnRlcm5hbHMuc2hhZG93Um9vdCh2 aWRlbykuZmlyc3RDaGlsZCwgIi13ZWJraXQtbWVkaWEtY29udHJvbHMtcGFuZWwiKTsKKworICAg ICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiKiog VmlkZW8gY29udHJvbHMgc2hvdWxkIGJlIHNob3duIG9uIGZ1bGxzY3JlZW4gKioiKTsKKworICAg ICAgICAgICAgdGVzdEV4cGVjdGVkKCJwYW5lbC5zdHlsZVsnZGlzcGxheSddIiwgJ25vbmUnLCAi IT0iKTsKKyAgICAgICAgICAgIGVuZFRlc3QoKTsKKyAgICAgICAgfTsKKyAgICA8L3NjcmlwdD4K KzwvaGVhZD4KKzxib2R5IG9ubG9hZD0ic3RhcnRUZXN0KCkiPgorICAgIFRlc3RzIHRoYXQgbm90 IHNob3dpbmcgdmlkZW8gY29udHJvbHMgd2l0aCB0ZXh0IHRyYWNrIHdpdGhvdXQgY29udHJvbHMg YXR0cmlidXRlIGJ5IGRlZmF1bHQgYW5kIGRpc3BsYXlpbmcgaXQgd2hlbiByZXF1ZXN0IGZ1bGxz Y3JlZW48YnI+CisgICAgPHZpZGVvPgorICAgICAgICA8dHJhY2s+CisgICAgPC92aWRlbz4KKwor PC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 269671 2016-01-23 08:21:38 -0800 2016-01-23 14:51:51 -0800 Patch bug-152500-20160124012110.patch text/plain 6405 wonchul.lee U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MjQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjNkYWEzODQzMWRkYmI3 ZDhmNGRjZjU1YThlYmU5Nzg0ZmRiMzBmYy4uODJhMjMwNjc1ZDFlNGQxM2NlMTg4NmI4MTE2MDZi N2VmZTI3ZmI0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAxLTE4ICBXb25j aHVsIExlZSAgPHdvbmNodWwubGVlQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBbR1RLXSBG aXggbWVkaWEgY29udHJvbHMgZGlzcGxheWluZyB3aXRob3V0IGNvbnRyb2xzIGF0dHJpYnV0ZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNTAwCisK KyAgICAgICAgTWVkaWEgY29udHJvbHMgaXMgbm90IGRpc3BsYXllZCB3aXRob3V0IGNvbnRyb2xz IGF0dHJpYnV0ZSBieSBkZWZhdWx0CisgICAgICAgIHdoZW4gdGhlIHZpZGVvIGVsZW1lbnQgaGFz IHRleHQgdHJhY2suIEl0J2xsIGJlIGRpc3BsYXllZCBvbiBmdWxsc2NyZWVuCisgICAgICAgIHJl Z2FyZGxlc3Mgb2YgY29udHJvbHMgYXR0cmlidXRlLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29u dHJvbHNHdGsuanM6CisgICAgICAgIChDb250cm9sbGVyR3RrLnByb3RvdHlwZS5zaG91bGRIYXZl Q29udHJvbHMpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUucmVjb25uZWN0Q29u dHJvbHMpOgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUucmVtb3ZlQ29udHJvbHMp OgorICAgICAgICAoQ29udHJvbGxlckd0ay5wcm90b3R5cGUuY29uZmlndXJlQ29udHJvbHMpOiBE ZWxldGVkLgogMjAxNi0wMS0xOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBbaU9TIFNpbXVsYXRvciBXSzFdIEFTU0VSVCBsb2FkaW5nIEJsaW5rIGxh eW91dCB0ZXN0IGltcG9ydGVkL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYWNhcHR1cmUtc3RyZWFt cy9zdHJlYW0tYXBpL21lZGlhc3RyZWFtL21lZGlhc3RyZWFtLWlkbC5odG1sCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0d0ay5q cyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3Rr LmpzCmluZGV4IDEyOGZmNzgzNjE5N2I5MTdkZDc3OWQ4NjNjMGZhYzM0ZTJkNTMzOTcuLmJjYTc3 NzZjODExN2VmMWUxMWUyZDJiMGNiMjA3ZGEzNzEwZjgwNTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzR3RrLmpzCkBA IC01NCwxOCArNTQsMTkgQEAgQ29udHJvbGxlckd0ay5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRo aXMuY29udHJvbHMuZW5jbG9zdXJlLmFwcGVuZENoaWxkKHRoaXMuY29udHJvbHMucGFuZWwpOwog ICAgIH0sCiAKLSAgICBjb25maWd1cmVDb250cm9sczogZnVuY3Rpb24oKSB7Ci0gICAgICAgIGlm ICh0aGlzLmNvbnRyb2xzLmNvbmZpZ3VyZWQpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAg ICAgdGhpcy5jb25maWd1cmVJbmxpbmVDb250cm9scygpOwotICAgICAgICB0aGlzLmNvbnRyb2xz LmNvbmZpZ3VyZWQgPSB0cnVlOwotICAgICAgICB0aGlzLmFkZENvbnRyb2xzKCk7CisgICAgc2hv dWxkSGF2ZUNvbnRyb2xzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICByZXR1cm4gdGhpcy52 aWRlby5jb250cm9scyB8fCB0aGlzLmlzRnVsbFNjcmVlbigpOwogICAgIH0sCiAKICAgICByZWNv bm5lY3RDb250cm9sczogZnVuY3Rpb24oKQogICAgIHsKLSAgICAgICAgdGhpcy5jb25maWd1cmVD b250cm9scygpOworICAgICAgICBDb250cm9sbGVyLnByb3RvdHlwZS5kaXNjb25uZWN0Q29udHJv bHMuYXBwbHkodGhpcywgYXJndW1lbnRzKTsKKworICAgICAgICB0aGlzLmNvbmZpZ3VyZUlubGlu ZUNvbnRyb2xzKCk7CisKKyAgICAgICAgaWYgKHRoaXMuc2hvdWxkSGF2ZUNvbnRyb2xzKCkpCisg ICAgICAgICAgICB0aGlzLmFkZENvbnRyb2xzKCk7CiAgICAgfSwKIAogICAgIHNldFN0YXR1c0hp ZGRlbjogZnVuY3Rpb24oaGlkZGVuKQpAQCAtMTMzLDYgKzEzNCwxMyBAQCBDb250cm9sbGVyR3Rr LnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAorICAgIHJlbW92 ZUNvbnRyb2xzOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICBpZiAodGhpcy5jb250cm9scy5l bmNsb3N1cmUucGFyZW50Tm9kZSkKKyAgICAgICAgICAgIHRoaXMuY29udHJvbHMuZW5jbG9zdXJl LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQodGhpcy5jb250cm9scy5lbmNsb3N1cmUpOworICAgICAg ICB0aGlzLmRlc3Ryb3lDYXB0aW9uTWVudSgpOworICAgIH0sCisKICAgICBhZGRDb250cm9sczog ZnVuY3Rpb24oKQogICAgIHsKICAgICAgICAgdGhpcy5iYXNlLmFwcGVuZENoaWxkKHRoaXMuY29u dHJvbHMuZW5jbG9zdXJlKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1ZGFjZjI5ZjU3MTc5ZTA5MTE4ZTZmYThlZWU4NTk3 MzYwMDI5MWViLi5hNzE2NzljMDU1MjFlMGM5OWU1ZTE4N2IzZjk3M2I1Yzk4YjYyMDgyIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTcgQEAKKzIwMTYtMDEtMTggIFdvbmNodWwgTGVlICA8d29uY2h1bC5sZWVA Y29sbGFib3JhLmNvLnVrPgorCisgICAgICAgIFtHVEtdIEZpeCBtZWRpYSBjb250cm9scyBkaXNw bGF5aW5nIHdpdGhvdXQgY29udHJvbHMgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI1MDAKKworICAgICAgICBNZWRpYSBjb250cm9s cyBpcyBub3QgZGlzcGxheWVkIHdpdGhvdXQgY29udHJvbHMgYXR0cmlidXRlIGJ5IGRlZmF1bHQK KyAgICAgICAgd2hlbiB0aGUgdmlkZW8gZWxlbWVudCBoYXMgdGV4dCB0cmFjay4gSXQnbGwgYmUg ZGlzcGxheWVkIG9uIGZ1bGxzY3JlZW4KKyAgICAgICAgcmVnYXJkbGVzcyBvZiBjb250cm9scyBh dHRyaWJ1dGUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBtZWRpYS92aWRlby1jb250cm9scy1uby1kaXNwbGF5LXdpdGgtdGV4dC10cmFjay1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIG1lZGlhL3ZpZGVvLWNvbnRyb2xzLW5vLWRpc3Bs YXktd2l0aC10ZXh0LXRyYWNrLmh0bWw6IEFkZGVkLgorCiAyMDE2LTAxLTE4ICBOYW4gV2FuZyAg PG5fd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFtNYWNdIEltcGxlbWVudCBuZXh0L3By ZXZpb3VzIHRleHQgbWFya2VyIGZ1bmN0aW9ucyB1c2luZyBUZXh0SXRlcmF0b3IKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLW5vLWRpc3BsYXktd2l0aC10ZXh0 LXRyYWNrLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLW5v LWRpc3BsYXktd2l0aC10ZXh0LXRyYWNrLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mMWYyY2Q3 Yzc4ZDNhNTcyMGVhNDVmOGRjOTIyMTYwNzBmMGI4MTdkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvdmlkZW8tY29udHJvbHMtbm8tZGlzcGxheS13aXRoLXRleHQtdHJhY2st ZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTIgQEAKK1Rlc3RzIHRoYXQgdmlkZW8gY29udHJvbHMg YXJlIG5vdCBzaG93biBmb3IgdmlkZW9zIHdpdGggYSB0ZXh0IHRyYWNrIHdoZW4gdGhlIGNvbnRy b2xzIGF0dHJpYnV0ZSBpcyBub3QgcHJlc2VudCwgZXhjZXB0IHdoZW4gZnVsbHNjcmVlbgorCitF VkVOVChjYW5wbGF5KQorCisqKiBWaWRlbyBjb250cm9scyBzaG91bGQgbm90IGJlIHNob3duICoq CitFWFBFQ1RFRCAocGFuZWwgPT0gJ251bGwnKSBPSworRVZFTlQod2Via2l0ZnVsbHNjcmVlbmNo YW5nZSkKKworKiogVmlkZW8gY29udHJvbHMgc2hvdWxkIGJlIHNob3duIG9uIGZ1bGxzY3JlZW4g KioKK0VYUEVDVEVEIChwYW5lbC5zdHlsZVsnZGlzcGxheSddICE9ICdub25lJykgT0sKK0VORCBP RiBURVNUCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLWNvbnRyb2xzLW5v LWRpc3BsYXktd2l0aC10ZXh0LXRyYWNrLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS92aWRlby1j b250cm9scy1uby1kaXNwbGF5LXdpdGgtdGV4dC10cmFjay5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmRiMzY0 MGE5M2Y5ZWQ4MzNkNGFkMDE0ZTQ1NGMxNGY3M2JiNzA1MzIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS92aWRlby1jb250cm9scy1uby1kaXNwbGF5LXdpdGgtdGV4dC10cmFj ay5odG1sCkBAIC0wLDAgKzEsNDcgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8aGVhZD4K KyAgICA8dGl0bGU+VmlkZW8gY29udHJvbHMgbm8gZGlzcGxheSB3aXRoIHRleHQgdHJhY2sgVGVz dDwvdGl0bGU+CisgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KKyAgICA8 c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPW1lZGlh LWNvbnRyb2xzLmpzPjwvc2NyaXB0PgorICAgIDxzY3JpcHQgc3JjPS4uL2Z1bGxzY3JlZW4vZnVs bC1zY3JlZW4tdGVzdC5qcz48L3NjcmlwdD4KKyAgICA8c2NyaXB0PgorICAgICAgICB2YXIgcGFu ZWw7CisKKyAgICAgICAgdmFyIHN0YXJ0VGVzdCA9IGZ1bmN0aW9uKCkgeworICAgICAgICAgICAg ZmluZE1lZGlhRWxlbWVudCgpOworICAgICAgICAgICAgd2FpdEZvckV2ZW50KHZpZGVvLCAnY2Fu cGxheScsIG9uY2FucGxheSk7CisgICAgICAgICAgICB2aWRlby5zcmMgPSBmaW5kTWVkaWFGaWxl KCd2aWRlbycsICdjb250ZW50L3Rlc3QnKTsKKyAgICAgICAgfTsKKworICAgICAgICB2YXIgb25j YW5wbGF5ID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBwYW5lbCA9IG1lZGlhQ29udHJvbHNF bGVtZW50KGludGVybmFscy5zaGFkb3dSb290KHZpZGVvKS5maXJzdENoaWxkLCAiLXdlYmtpdC1t ZWRpYS1jb250cm9scy1wYW5lbCIpOworCisgICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOwor ICAgICAgICAgICAgY29uc29sZVdyaXRlKCIqKiBWaWRlbyBjb250cm9scyBzaG91bGQgbm90IGJl IHNob3duICoqIik7CisgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInBhbmVsIiwgbnVsbCwgIj09 Iik7CisKKyAgICAgICAgICAgIHdhaXRGb3JFdmVudCh2aWRlbywgJ3dlYmtpdGZ1bGxzY3JlZW5j aGFuZ2UnLCBvbmZ1bGxzY3JlZW5jaGFuZ2UpOworICAgICAgICAgICAgcnVuV2l0aEtleURvd24o ZnVuY3Rpb24oKXsgdmlkZW8ud2Via2l0UmVxdWVzdEZ1bGxzY3JlZW4oKTsgfSkKKyAgICAgICAg fTsKKworICAgICAgICB2YXIgb25mdWxsc2NyZWVuY2hhbmdlID0gZnVuY3Rpb24oKSB7CisgICAg ICAgICAgICBwYW5lbCA9IG1lZGlhQ29udHJvbHNFbGVtZW50KGludGVybmFscy5zaGFkb3dSb290 KHZpZGVvKS5maXJzdENoaWxkLCAiLXdlYmtpdC1tZWRpYS1jb250cm9scy1wYW5lbCIpOworCisg ICAgICAgICAgICBjb25zb2xlV3JpdGUoIiIpOworICAgICAgICAgICAgY29uc29sZVdyaXRlKCIq KiBWaWRlbyBjb250cm9scyBzaG91bGQgYmUgc2hvd24gb24gZnVsbHNjcmVlbiAqKiIpOworCisg ICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoInBhbmVsLnN0eWxlWydkaXNwbGF5J10iLCAnbm9uZScs ICIhPSIpOworICAgICAgICAgICAgZW5kVGVzdCgpOworICAgICAgICB9OworICAgIDwvc2NyaXB0 PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJzdGFydFRlc3QoKSI+CisgICAgVGVzdHMgdGhhdCB2 aWRlbyBjb250cm9scyBhcmUgbm90IHNob3duIGZvciB2aWRlb3Mgd2l0aCBhIHRleHQgdHJhY2sg d2hlbiB0aGUgY29udHJvbHMgYXR0cmlidXRlIGlzIG5vdCBwcmVzZW50LCBleGNlcHQgd2hlbiBm dWxsc2NyZWVuPGJyPgorICAgIDx2aWRlbz4KKyAgICAgICAgPHRyYWNrPgorICAgIDwvdmlkZW8+ CisKKzwvYm9keT4KKzwvaHRtbD4K