152482 2015-12-21 10:49:13 -0800 [WK2] Looping in testcase: fast/dom/Window/property-access-on-cached-window-after-frame-removed.html 2015-12-22 09:38:28 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jiewen_tan cfleizach bfulgham cfleizach commit-queue jcraig jiewen_tan webkit-bug-importer oldest_to_newest 1150764 0 jiewen_tan 2015-12-21 10:49:13 -0800 WK2 will keep looping in fast/dom/Window/property-access-on-cached-window-after-frame-removed.html while WK1 won't. Investigate why it keeps looping. 1150802 1 jiewen_tan 2015-12-21 14:36:00 -0800 The looping path is: accessibilityController,rootElement,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,verticalScrollbar,endTextMarker 1150824 2 jiewen_tan 2015-12-21 17:04:33 -0800 The looping can be explained as follow: The testcase is trying to do a DFS of window object's properties. Since verticalScrollbar itself is an AcessibilityUIElement, and AcessibilityUIElement class by default has verticalScrollbar property, DFS will be stuck. Actually, the class abstract is the same for both WebkitTestRunner and DumpRenderTree for AcessibilityUIElement. The difference is how they implement it. In WebkitTestRunner: PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::verticalScrollbar() const { BEGIN_AX_OBJC_EXCEPTIONS return AccessibilityUIElement::create([m_element accessibilityAttributeValue:NSAccessibilityVerticalScrollBarAttribute]); END_AX_OBJC_EXCEPTIONS return nullptr; } PassRefPtr<AccessibilityUIElement> AccessibilityUIElement::create(PlatformUIElement uiElement) { return adoptRef(new AccessibilityUIElement(uiElement)); } Therefore, every time when the property is accessed, an new AccessibilityUIElement is created and returned. I am not sure which constructor it calls. I am assuming the follows: AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element) : m_element(element) , m_notificationHandler(0) { // FIXME: ap@webkit.org says ObjC objects need to be CFRetained/CFRelease to be GC-compliant on the mac. [m_element retain]; } In DumpRenderTree: AccessibilityUIElement AccessibilityUIElement::verticalScrollbar() const { BEGIN_AX_OBJC_EXCEPTIONS return AccessibilityUIElement([m_element accessibilityAttributeValue:NSAccessibilityVerticalScrollBarAttribute]); END_AX_OBJC_EXCEPTIONS return nullptr; } AccessibilityUIElement::AccessibilityUIElement(PlatformUIElement element) : m_element(element) , m_notificationHandler(0) { // FIXME: ap@webkit.org says ObjC objects need to be CFRetained/CFRelease to be GC-compliant on the mac. [m_element retain]; } Here, a ref will be returned directly. In fact, the DumpRenderTree will loop as well, but it stops after the second try. Therefore, I am not sure whether it is due to some reasons specific to the language itself cause the problem. I suggest to handover the bug to the accessibility guy. 1150825 3 267765 jiewen_tan 2015-12-21 17:05:51 -0800 Created attachment 267765 Test Case 1150826 4 267766 jiewen_tan 2015-12-21 17:06:10 -0800 Created attachment 267766 Test Case Resource 1150860 5 267781 cfleizach 2015-12-21 23:19:01 -0800 Created attachment 267781 patch 1150861 6 267781 jiewen_tan 2015-12-21 23:24:51 -0800 Comment on attachment 267781 patch Could you please remove the skip statement for the test case under LayoutTests/platform/mac-wk2/TestExpectations L344 as well? 1150862 7 267782 cfleizach 2015-12-21 23:30:30 -0800 Created attachment 267782 patch 1150891 8 267781 bfulgham 2015-12-22 08:49:58 -0800 Comment on attachment 267781 patch Thanks for fixing this so quickly! r=me. 1150902 9 267782 commit-queue 2015-12-22 09:38:24 -0800 Comment on attachment 267782 patch Clearing flags on attachment: 267782 Committed r194364: <http://trac.webkit.org/changeset/194364> 1150903 10 commit-queue 2015-12-22 09:38:28 -0800 All reviewed patches have been landed. Closing bug. 267765 2015-12-21 17:05:51 -0800 2015-12-21 17:05:51 -0800 Test Case property-access-on-cached-window-after-frame-removed.html text/html 944 jiewen_tan PGh0bWw+CjxoZWFkPgo8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMi Pjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3dpbmRvdy1wcm9wZXJ0eS1jb2xsZWN0 b3IuanMiPjwvc2NyaXB0Pgo8c2NyaXB0Pgp2YXIgY2hpbGRXaW5kb3c7CnZhciBwcm9wZXJ0aWVz VG9WZXJpZnkgPSBbXTsKCmZ1bmN0aW9uIGluc2VydEV4cGVjdGVkUmVzdWx0KHBhdGgsIGV4cGVj dGVkKQp7CiAgICB2YXIgcHJvcGVydHlQYXRoID0gcGF0aC5qb2luKCcuJyk7CiAgICBwcm9wZXJ0 aWVzVG9WZXJpZnkucHVzaCh7J3Byb3BlcnR5JzogImNoaWxkV2luZG93LiIgKyBwcm9wZXJ0eVBh dGgsICdleHBlY3RlZCc6IGV4cGVjdGVkfSk7Cn0KCmZ1bmN0aW9uIHJ1blRlc3QoKQp7CiAgICB2 YXIgZnJhbWUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZnJhbWUiKTsKICAgIGNoaWxkV2lu ZG93ID0gZnJhbWUuY29udGVudFdpbmRvdzsKICAgIC8vIEhhdmUgZXhwZWN0ZWQgcmVzdWx0cyBh c3N1bWUgdGhhdCB0aGUgZnJhbWUgaGFzIGJlZW4gY2xvc2VkICg9PiB3aW5kb3cuY2xvc2VkID0g dHJ1ZS4pCiAgICBjb2xsZWN0UHJvcGVydGllcyh0cnVlKTsKICAgIGZyYW1lLnBhcmVudE5vZGUu cmVtb3ZlQ2hpbGQoZnJhbWUpOwogICAgZm9yICh2YXIgaSA9IDA7IGkgPCBwcm9wZXJ0aWVzVG9W ZXJpZnkubGVuZ3RoOyArK2kpCiAgICAgICAgc2hvdWxkQmUocHJvcGVydGllc1RvVmVyaWZ5W2ld LnByb3BlcnR5LCBwcm9wZXJ0aWVzVG9WZXJpZnlbaV0uZXhwZWN0ZWQpOwogICAgZG9jdW1lbnQu d3JpdGUoIlBhc3MuIFdlYktpdCBkaWRuJ3QgY3Jhc2guIik7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4K PGJvZHk+CjxpZnJhbWUgaWQ9ImZyYW1lIiBzcmM9ImFib3V0OmJsYW5rIiBvbmxvYWQ9InJ1blRl c3QoKSI+PC9pZnJhbWU+CjwvYm9keT4KPC9odG1sPgo= 267766 2015-12-21 17:06:10 -0800 2015-12-21 17:06:10 -0800 Test Case Resource window-property-collector.js text/javascript 4352 jiewen_tan ZnVuY3Rpb24gY29sbGVjdFByb3BlcnRpZXMod2luZG93SGFzQmVlbkdDZWQpCnsKICAgIC8vIENv bGxlY3QgcHJvcGVydGllcyBvZiB0aGUgdG9wLWxldmVsIHdpbmRvdywgc2luY2UgdG91Y2hpbmcg dGhlIHByb3BlcnRpZXMKICAgIC8vIG9mIGEgRE9NV2luZG93IGFmZmVjdHMgaXRzIGludGVybmFs IEMrKyBzdGF0ZS4KICAgIGNvbGxlY3RQcm9wZXJ0aWVzSGVscGVyKHdpbmRvdywgd2luZG93SGFz QmVlbkdDZWQsIFtdKTsKCiAgICBwcm9wZXJ0aWVzVG9WZXJpZnkuc29ydChmdW5jdGlvbiAoYSwg YikKICAgIHsKICAgICAgICBpZiAoYS5wcm9wZXJ0eSA8IGIucHJvcGVydHkpCiAgICAgICAgICAg IHJldHVybiAtMQogICAgICAgIGlmIChhLnByb3BlcnR5ID4gYi5wcm9wZXJ0eSkKICAgICAgICAg ICAgcmV0dXJuIDE7CiAgICAgICAgcmV0dXJuIDA7CiAgICB9KTsKfQoKZnVuY3Rpb24gZW1pdEV4 cGVjdGVkUmVzdWx0KHBhdGgsIGV4cGVjdGVkKQp7CiAgICAvLyBTa2lwIGludGVybmFscyBwcm9w ZXJ0aWVzLCBzaW5jZSB0aGV5IGFyZW4ndCB3ZWIgYWNjZXNzaWJsZS4KICAgIGlmIChwYXRoWzBd ID09ICdpbnRlcm5hbHMnCiAgICAgICAgfHwgcGF0aFswXSA9PSAncHJvcGVydGllc1RvVmVyaWZ5 JyAvLyBTa2lwIHRoZSBsaXN0IHdlJ3JlIGJ1aWxkaW5nLi4uCiAgICAgICAgfHwgcGF0aFswXSA9 PSAnY2xpZW50SW5mb3JtYXRpb24nIC8vIEp1c3QgYW4gYWxpYXMgZm9yIG5hdmlnYXRvci4KICAg ICAgICB8fCBwYXRoWzBdID09ICd0ZXN0UnVubmVyJyAvLyBTa2lwIHRlc3RSdW5uZXIgc2luY2Ug dGhleSBhcmUgb25seSBmb3IgdGVzdGluZy4KICAgICAgICB8fCBwYXRoWzBdID09ICdsYXlvdXRU ZXN0Q29udHJvbGxlcicgLy8gSnVzdCBhbiBhbGlhcyBmb3IgdGVzdFJ1bm5lci4KICAgICAgICB8 fCBwYXRoWzBdID09ICdldmVudFNlbmRlcicpIHsgLy8gU2tpcCBldmVudFNlbmRlciBzaW5jZSB0 aGV5IGFyZSBvbmx5IGZvciB0ZXN0aW5nLgogICAgICAgIHJldHVybjsKICAgIH0KCiAgICAvLyBT a2lwIHRoZSBwcm9wZXJ0aWVzIHdoaWNoIGFyZSBoYXJkIHRvIGV4cGVjdCBhIHN0YWJsZSByZXN1 bHQuCiAgICBpZiAocGF0aFswXSA9PSAnYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXInIC8vIHdlIGNh biBoYXJkbHkgZXN0aW1hdGUgdGhlIHN0YXRlcyBvZiB0aGUgY2FjaGVkIFdlYkFYT2JqZWN0cy4K ICAgICAgICB8fCBwYXRoWzBdID09ICdsb2NhbFN0b3JhZ2UnKSB7IC8vIGxvY2FsIHN0b3JhZ2Ug aXMgbm90IHJlbGlhYmx5IGNsZWFyZWQgYmV0d2VlbiB0ZXN0cy4KICAgICAgICByZXR1cm47CiAg ICB9CgogICAgLy8gRklYTUU6IFNraXAgTWVtb3J5SW5mbyBmb3Igbm93LCBzaW5jZSBpdCdzIG5v dCBpbXBsZW1lbnRlZCBhcyBhIERPTVdpbmRvd1Byb3BlcnR5LCBhbmQgaGFzCiAgICAvLyBubyB3 YXkgb2Yga25vd2luZyB3aGVuIGl0J3MgZGV0YWNoZWQuIEV2ZW50dWFsbHkgdGhpcyBzaG91bGQg aGF2ZSB0aGUgc2FtZSBiZWhhdmlvci4KICAgIGlmIChwYXRoLmxlbmd0aCA+PSAyICYmIChwYXRo WzBdID09ICdjb25zb2xlJyB8fCBwYXRoWzBdID09ICdwZXJmb3JtYW5jZScpICYmIHBhdGhbMV0g PT0gJ21lbW9yeScpCiAgICAgICAgcmV0dXJuOwoKICAgIC8vIFNraXAgdGhpbmdzIHRoYXQgYXJl IGFzc3VtZWQgdG8gYmUgY29uc3RhbnRzLgogICAgaWYgKHBhdGhbcGF0aC5sZW5ndGggLSAxXS50 b1VwcGVyQ2FzZSgpID09IHBhdGhbcGF0aC5sZW5ndGggLSAxXSkKICAgICAgICByZXR1cm47Cgog ICAgLy8gVmFyaW91cyBzcGVjaWFsIGNhc2VzIGZvciBsZWdhY3kgcmVhc29ucy4gUGxlYXNlIGRv IG5vdCBhZGQgZW50cmllcyB0byB0aGlzIGxpc3QuCiAgICB2YXIgcHJvcGVydHlQYXRoID0gcGF0 aC5qb2luKCcuJyk7CgogICAgLy8gQ29ubmVjdGlvbiB0eXBlIGRlcGVuZHMgb24gdGhlIGhvc3Qs IHNraXAuCiAgICBpZiAocHJvcGVydHlQYXRoID09ICduYXZpZ2F0b3IuY29ubmVjdGlvbi50eXBl JykKICAgICAgcmV0dXJuOwogICAgaWYgKHByb3BlcnR5UGF0aCA9PSAnbmF2aWdhdG9yLmNvbm5l Y3Rpb24uZG93bmxpbmtNYXgnKQogICAgICByZXR1cm47CgogICAgc3dpdGNoIChwcm9wZXJ0eVBh dGgpIHsKICAgIGNhc2UgImxvY2F0aW9uLmhyZWYiOgogICAgICAgIGV4cGVjdGVkID0gIidhYm91 dDpibGFuayciOwogICAgICAgIGJyZWFrOwogICAgY2FzZSAibG9jYXRpb24ub3JpZ2luIjoKICAg ICAgICBleHBlY3RlZCA9ICInbnVsbCciOwogICAgICAgIGJyZWFrOwogICAgY2FzZSAibG9jYXRp b24ucGF0aG5hbWUiOgogICAgICAgIGV4cGVjdGVkID0gIidibGFuayciOwogICAgICAgIGJyZWFr OwogICAgY2FzZSAibG9jYXRpb24ucHJvdG9jb2wiOgogICAgICAgIGV4cGVjdGVkID0gIidhYm91 dDonIjsKICAgICAgICBicmVhazsKICAgIGNhc2UgIm5hdmlnYXRvci5hcHBDb2RlTmFtZSI6CiAg ICBjYXNlICJuYXZpZ2F0b3IuYXBwTmFtZSI6CiAgICBjYXNlICJuYXZpZ2F0b3IuaGFyZHdhcmVD b25jdXJyZW5jeSI6CiAgICBjYXNlICJuYXZpZ2F0b3IubGFuZ3VhZ2UiOgogICAgY2FzZSAibmF2 aWdhdG9yLm9uTGluZSI6CiAgICBjYXNlICJuYXZpZ2F0b3IucGxhdGZvcm0iOgogICAgY2FzZSAi bmF2aWdhdG9yLnByb2R1Y3QiOgogICAgY2FzZSAibmF2aWdhdG9yLnByb2R1Y3RTdWIiOgogICAg Y2FzZSAibmF2aWdhdG9yLnZlbmRvciI6CiAgICAgICAgZXhwZWN0ZWQgPSAid2luZG93LiIgKyBw cm9wZXJ0eVBhdGg7CiAgICAgICAgYnJlYWs7CiAgICBjYXNlICJzY3JlZW4ub3JpZW50YXRpb24i OgogICAgICAgIGV4cGVjdGVkID0gIidwb3J0cmFpdC1wcmltYXJ5JyI7CiAgICAgICAgYnJlYWs7 CiAgICBjYXNlICJoaXN0b3J5LnNjcm9sbFJlc3RvcmF0aW9uIjoKICAgICAgICBleHBlY3RlZCA9 ICInYXV0byciOwogICAgICAgIGJyZWFrOwogICAgfQoKICAgIGluc2VydEV4cGVjdGVkUmVzdWx0 KHBhdGgsIGV4cGVjdGVkKTsKfQoKZnVuY3Rpb24gY29sbGVjdFByb3BlcnRpZXNIZWxwZXIob2Jq ZWN0LCB3aW5kb3dIYXNCZWVuR0NlZCwgcGF0aCkKewogICAgaWYgKHBhdGgubGVuZ3RoID4gMjAp IHsKICAgICAgICBjb25zb2xlLmxvZyhwYXRoKTsKICAgICAgICB0aHJvdyAnRXJyb3I6IHByb2Jh Ymx5IGxvb3BpbmcnOwogICAgfQoKICAgIGZvciAodmFyIHByb3BlcnR5IGluIG9iamVjdCkgewog ICAgICAgIC8vIFNraXAgaW50ZXJuYWxzIHByb3BlcnRpZXMsIHNpbmNlIHRoZXkgYXJlbid0IHdl YiBhY2Nlc3NpYmxlLgogICAgICAgIGlmIChwcm9wZXJ0eSA9PT0gJ2ludGVybmFscycpCiAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgIHBhdGgucHVzaChwcm9wZXJ0eSk7CiAgICAgICAgdmFy IHR5cGUgPSB0eXBlb2Yob2JqZWN0W3Byb3BlcnR5XSk7CiAgICAgICAgaWYgKHR5cGUgPT0gIm9i amVjdCIpIHsKICAgICAgICAgICAgaWYgKG9iamVjdFtwcm9wZXJ0eV0gPT09IG51bGwpIHsKICAg ICAgICAgICAgICAgIGVtaXRFeHBlY3RlZFJlc3VsdChwYXRoLCAibnVsbCIpOwogICAgICAgICAg ICB9IGVsc2UgaWYgKCFvYmplY3RbcHJvcGVydHldLldpbmRvdwogICAgICAgICAgICAgICAgJiYg IShvYmplY3RbcHJvcGVydHldIGluc3RhbmNlb2YgTm9kZSkKICAgICAgICAgICAgICAgICYmICEo b2JqZWN0W3Byb3BlcnR5XSBpbnN0YW5jZW9mIE1pbWVUeXBlQXJyYXkpCiAgICAgICAgICAgICAg ICAmJiAhKG9iamVjdFtwcm9wZXJ0eV0gaW5zdGFuY2VvZiBQbHVnaW5BcnJheSkpIHsKICAgICAg ICAgICAgICAgIC8vIFNraXAgc29tZSB0cmF2ZXJzaW5nIHRocm91Z2ggdHlwZXMgdGhhdCB3aWxs IGVuZCB1cCBpbiBjeWNsZXMuLi4KICAgICAgICAgICAgICAgIGNvbGxlY3RQcm9wZXJ0aWVzSGVs cGVyKG9iamVjdFtwcm9wZXJ0eV0sIHdpbmRvd0hhc0JlZW5HQ2VkLCBwYXRoKTsKICAgICAgICAg ICAgfQogICAgICAgIH0gZWxzZSBpZiAodHlwZSA9PSAic3RyaW5nIikgewogICAgICAgICAgICBl bWl0RXhwZWN0ZWRSZXN1bHQocGF0aCwgIicnIik7CiAgICAgICAgfSBlbHNlIGlmICh0eXBlID09 ICJudW1iZXIiKSB7CiAgICAgICAgICAgIGVtaXRFeHBlY3RlZFJlc3VsdChwYXRoLCAiMCIpOwog ICAgICAgIH0gZWxzZSBpZiAodHlwZSA9PSAiYm9vbGVhbiIpIHsKICAgICAgICAgICAgZXhwZWN0 ZWQgPSAiZmFsc2UiOwogICAgICAgICAgICBpZiAocGF0aCA9PSAiY2xvc2VkIiAmJiB3aW5kb3dI YXNCZWVuR0NlZCApCiAgICAgICAgICAgICAgICBleHBlY3RlZCA9ICJ0cnVlIjsKICAgICAgICAg ICAgZW1pdEV4cGVjdGVkUmVzdWx0KHBhdGgsIGV4cGVjdGVkKTsKICAgICAgICB9CiAgICAgICAg cGF0aC5wb3AoKTsKICAgIH0KfQo= 267781 2015-12-21 23:19:01 -0800 2015-12-22 08:49:58 -0800 patch patch text/plain 3157 cfleizach SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDM2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTEyLTIxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CisKKyAgICAgICAgW1dLMl0gTG9vcGluZyBpbiB0ZXN0Y2FzZTogZmFzdC9kb20vV2luZG93 L3Byb3BlcnR5LWFjY2Vzcy1vbi1jYWNoZWQtd2luZG93LWFmdGVyLWZyYW1lLXJlbW92ZWQuaHRt bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNDgy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdmVydGlj YWwvaG9yaXpvbnRhbFNjcm9sbGJhciByZXR1cm5zIGFuIGFjY2Vzc2liaWxpdHkgZWxlbWVudC4g VGhhdCBlbGVtZW50IGNhbiBhbHNvIGJlIHF1ZXJpZWQKKyAgICAgICAgZm9yIHRoZSBzYW1lIHBy b3BlcnR5LiBPbiBXSzIsIHRoZSBlbGVtZW50IHJldHVybmVkIHdpbGwgbm90IGJlIHZhbGlkLCBi dXQgaXMgc3RpbGwgcHJlc2VudCBhbmQKKyAgICAgICAgdGhhdCBjYW4gbGVhZCB0byBsb29waW5n LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRN YWMubW06CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpob3Jpem9udGFsU2Nyb2xs YmFyKToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnZlcnRpY2FsU2Nyb2xsYmFy KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50TWFjLm1tOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50Ojpob3Jpem9udGFsU2Nyb2xsYmFyKToKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIpOgorCiAyMDE1LTEyLTIxICBIdW5zZW9wIEplb25n ICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSB0ZXN0X2V3azJfY29u dGV4dCBmYWlsZWQgYWZ0ZXIgcjE5MjgwOApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHJldmlzaW9uIDE5NDM1 NikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50TWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMjkyLDYgKzEyOTIsOSBAQAogCiBBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omhvcml6b250YWxTY3JvbGxiYXIoKSBj b25zdAogeworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAg ICAKICAgICBCRUdJTl9BWF9PQkpDX0VYQ0VQVElPTlMKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0 eVVJRWxlbWVudChbbV9lbGVtZW50IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vz c2liaWxpdHlIb3Jpem9udGFsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNf RVhDRVBUSU9OUyAgICAKQEAgLTEzMDEsNiArMTMwNCw5IEBACiAKIEFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIoKSBjb25zdAog eworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIEJF R0lOX0FYX09CSkNfRVhDRVBUSU9OUwogICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 KFttX2VsZW1lbnQgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVZl cnRpY2FsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNfRVhDRVBUSU9OUyAg ICAgICAgCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0J KHJldmlzaW9uIDE5NDM1NikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEz NTIsNiArMTM1Miw5IEBACiAKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNj ZXNzaWJpbGl0eVVJRWxlbWVudDo6aG9yaXpvbnRhbFNjcm9sbGJhcigpIGNvbnN0CiB7CisgICAg aWYgKCFtX2VsZW1lbnQpCisgICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgQkVHSU5fQVhf T0JKQ19FWENFUFRJT05TCiAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNyZWF0 ZShbbV9lbGVtZW50IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlI b3Jpem9udGFsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNfRVhDRVBUSU9O UyAgICAKQEAgLTEzNjEsNiArMTM2NCw5IEBACiAKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJ RWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIoKSBjb25z dAogeworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAK ICAgICBCRUdJTl9BWF9PQkpDX0VYQ0VQVElPTlMKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6Y3JlYXRlKFttX2VsZW1lbnQgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOk5T QWNjZXNzaWJpbGl0eVZlcnRpY2FsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09C SkNfRVhDRVBUSU9OUyAgICAgICAgCg== 267782 2015-12-21 23:30:30 -0800 2015-12-22 09:38:24 -0800 patch patch text/plain 4317 cfleizach SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDM2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTEyLTIxICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5j b20+CisKKyAgICAgICAgW1dLMl0gTG9vcGluZyBpbiB0ZXN0Y2FzZTogZmFzdC9kb20vV2luZG93 L3Byb3BlcnR5LWFjY2Vzcy1vbi1jYWNoZWQtd2luZG93LWFmdGVyLWZyYW1lLXJlbW92ZWQuaHRt bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyNDgy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdmVydGlj YWwvaG9yaXpvbnRhbFNjcm9sbGJhciByZXR1cm5zIGFuIGFjY2Vzc2liaWxpdHkgZWxlbWVudC4g VGhhdCBlbGVtZW50IGNhbiBhbHNvIGJlIHF1ZXJpZWQKKyAgICAgICAgZm9yIHRoZSBzYW1lIHBy b3BlcnR5LiBPbiBXSzIsIHRoZSBlbGVtZW50IHJldHVybmVkIHdpbGwgbm90IGJlIHZhbGlkLCBi dXQgaXMgc3RpbGwgcHJlc2VudCBhbmQKKyAgICAgICAgdGhhdCBjYW4gbGVhZCB0byBsb29waW5n LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRN YWMubW06CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50Ojpob3Jpem9udGFsU2Nyb2xs YmFyKToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnZlcnRpY2FsU2Nyb2xsYmFy KToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9BY2Nlc3Np YmlsaXR5VUlFbGVtZW50TWFjLm1tOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50Ojpob3Jpem9udGFsU2Nyb2xsYmFyKToKKyAgICAgICAgKFdUUjo6QWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIpOgorCiAyMDE1LTEyLTIxICBIdW5zZW9wIEplb25n ICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSB0ZXN0X2V3azJfY29u dGV4dCBmYWlsZWQgYWZ0ZXIgcjE5MjgwOApJbmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFj L0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHJldmlzaW9uIDE5NDM1 NikKKysrIFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50TWFj Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMjkyLDYgKzEyOTIsOSBAQAogCiBBY2Nlc3NpYmlsaXR5 VUlFbGVtZW50IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omhvcml6b250YWxTY3JvbGxiYXIoKSBj b25zdAogeworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAg ICAKICAgICBCRUdJTl9BWF9PQkpDX0VYQ0VQVElPTlMKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0 eVVJRWxlbWVudChbbV9lbGVtZW50IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vz c2liaWxpdHlIb3Jpem9udGFsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNf RVhDRVBUSU9OUyAgICAKQEAgLTEzMDEsNiArMTMwNCw5IEBACiAKIEFjY2Vzc2liaWxpdHlVSUVs ZW1lbnQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIoKSBjb25zdAog eworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIEJF R0lOX0FYX09CSkNfRVhDRVBUSU9OUwogICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 KFttX2VsZW1lbnQgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOk5TQWNjZXNzaWJpbGl0eVZl cnRpY2FsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNfRVhDRVBUSU9OUyAg ICAgICAgCkluZGV4OiBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL21hYy9B Y2Nlc3NpYmlsaXR5VUlFbGVtZW50TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0J KHJldmlzaW9uIDE5NDM1NikKKysrIFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvbWFjL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTEz NTIsNiArMTM1Miw5IEBACiAKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJRWxlbWVudD4gQWNj ZXNzaWJpbGl0eVVJRWxlbWVudDo6aG9yaXpvbnRhbFNjcm9sbGJhcigpIGNvbnN0CiB7CisgICAg aWYgKCFtX2VsZW1lbnQpCisgICAgICAgIHJldHVybiBudWxscHRyOworCiAgICAgQkVHSU5fQVhf T0JKQ19FWENFUFRJT05TCiAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNyZWF0 ZShbbV9lbGVtZW50IGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpOU0FjY2Vzc2liaWxpdHlI b3Jpem9udGFsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09CSkNfRVhDRVBUSU9O UyAgICAKQEAgLTEzNjEsNiArMTM2NCw5IEBACiAKIFBhc3NSZWZQdHI8QWNjZXNzaWJpbGl0eVVJ RWxlbWVudD4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dmVydGljYWxTY3JvbGxiYXIoKSBjb25z dAogeworICAgIGlmICghbV9lbGVtZW50KQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKyAgICAK ICAgICBCRUdJTl9BWF9PQkpDX0VYQ0VQVElPTlMKICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eVVJ RWxlbWVudDo6Y3JlYXRlKFttX2VsZW1lbnQgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOk5T QWNjZXNzaWJpbGl0eVZlcnRpY2FsU2Nyb2xsQmFyQXR0cmlidXRlXSk7CiAgICAgRU5EX0FYX09C SkNfRVhDRVBUSU9OUyAgICAgICAgCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTQzNjApCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAxNS0x Mi0yMSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIFtX SzJdIExvb3BpbmcgaW4gdGVzdGNhc2U6IGZhc3QvZG9tL1dpbmRvdy9wcm9wZXJ0eS1hY2Nlc3Mt b24tY2FjaGVkLXdpbmRvdy1hZnRlci1mcmFtZS1yZW1vdmVkLmh0bWwKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjQ4MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjLXdrMi9UZXN0 RXhwZWN0YXRpb25zOgorCiAyMDE1LTEyLTIxICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBw bGUuY29tPgogCiAgICAgICAgIFNraXBwaW5nIHVuc3VwcG9ydGVkIHRlc3Qgb24gaW9zLXNpbXVs YXRvcgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25z Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0 aW9ucwkocmV2aXNpb24gMTk0MzU2KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9U ZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0zNjQsOSArMzY0LDYgQEAKIAogWyBE ZWJ1ZyBdIGVkaXRpbmcvdW5kby9yZW1vdmUtY3NzLXByb3BlcnR5LWFuZC1yZW1vdmUtc3R5bGUu aHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKLSMgVGVzdCBmb3IgV0sxIG9ubHkKLWZhc3QvZG9tL1dp bmRvdy9wcm9wZXJ0eS1hY2Nlc3Mtb24tY2FjaGVkLXdpbmRvdy1hZnRlci1mcmFtZS1yZW1vdmVk Lmh0bWwgWyBTa2lwIF0KLQogIyMjIEVORCBPRiAoMykgVW5jbGFzc2lmaWVkIGZhaWx1cmVzCiAj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjCiAK