152470 2015-12-20 14:11:37 -0800 PyGIWarnings printed by webkit-patch 2016-09-27 00:54:53 -0700 1 1 1 Unclassified WebKit Tools / Tests Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue glenn lforschler mcatanzaro oldest_to_newest 1150668 0 mcatanzaro 2015-12-20 14:11:37 -0800 The first output printed by 'webkit-patch upload' is always these annoying warnings: /home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring/backends/Gnome.py:6: PyGIWarning: GnomeKeyring was imported without specifying a version first. Use gi.require_version('GnomeKeyring', '1.0') before import to ensure that the right version gets loaded. from gi.repository import GnomeKeyring /home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring/backends/Gnome.py:6: PyGIWarning: GnomeKeyring was imported without specifying a version first. Use gi.require_version('GnomeKeyring', '1.0') before import to ensure that the right version gets loaded. from gi.repository import GnomeKeyring 1150669 1 mcatanzaro 2015-12-20 14:28:31 -0800 I spent a small amount of time trying to find a quick fix. It's already fixed upstream, so we just have to update the keyring module to 5.7.1. So I updated the definition of _install_keyring in Tools/Scripts/webkitpy/thirdparty: def _install_keyring(self): self._install("http://pypi.python.org/packages/source/k/keyring/keyring-5.7.1.tar.gz#md5=c1e0e5f00686f0ed118573ff47dfbaf8", "keyring") But I got this error: $ rm -rf Tools/Scripts/webkitpy/thirdparty/autoinstalled $ webkit-patch upload Traceback (most recent call last): File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkit-patch", line 44, in <module> from webkitpy.tool.main import WebKitPatch File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/tool/main.py", line 37, in <module> from webkitpy.common.host import Host File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/host.py", line 37, in <module> from webkitpy.common.net import bugzilla, buildbot, web File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/__init__.py", line 4, in <module> from .bugzilla import Bugzilla File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 48, in <module> from webkitpy.common.net.credentials import Credentials File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/net/credentials.py", line 40, in <module> from webkitpy.thirdparty.autoinstalled import keyring File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 93, in find_module self._install_keyring() File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 103, in _install_keyring "keyring") File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 160, in _install installer.install(url=url, url_subpath=url_subpath, target_name=target_name) File "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 515, in install raise Exception(message) Exception: Error auto-installing the keyring package to: "/home/mcatanzaro/src/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/keyring" --> Inner message: [Errno 2] No such file or directory: '/tmp/keyring_tFSQ4h/keyring-5.7.1/keyring' Have not investigated further. The 4.0 package installs just fine. 1233517 2 289844 mcatanzaro 2016-09-26 12:34:19 -0700 Created attachment 289844 Patch 1233522 3 289844 mcatanzaro 2016-09-26 12:38:03 -0700 Comment on attachment 289844 Patch Hm, this upgrade breaks password storage. :S 1233545 4 289856 mcatanzaro 2016-09-26 13:20:43 -0700 Created attachment 289856 Patch 1233760 5 289856 commit-queue 2016-09-27 00:54:49 -0700 Comment on attachment 289856 Patch Clearing flags on attachment: 289856 Committed r206420: <http://trac.webkit.org/changeset/206420> 1233761 6 commit-queue 2016-09-27 00:54:53 -0700 All reviewed patches have been landed. Closing bug. 289844 2016-09-26 12:34:19 -0700 2016-09-26 13:20:37 -0700 Patch bug-152470-20160926213121.patch text/plain 1735 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWI3NTZhN2Y2MTZlMzQ0YjFhYmFjNjFkZmVkMmExZWI4 NmY3ZTQ0ZC4uNmUzMTJmODQyZTUyMGI1MGViZWFiM2JhMmUzZmQ4NjA0ODdkZjJhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTA5LTI2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBQeUdJV2FybmluZ3MgcHJpbnRlZCBieSB3ZWJraXQtcGF0Y2gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjQ3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBrZXlyaW5n IG1vZHVsZSB0byBsYXRlc3QgdXBzdHJlYW0gdmVyc2lvbi4gVGhpcyBidWcgd2FzIGZpeGVkIHVw c3RyZWFtIGxvbmcgYWdvLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5 L19faW5pdF9fLnB5OgorICAgICAgICAoQXV0b2luc3RhbGxJbXBvcnRIb29rLl9pbnN0YWxsX2tl eXJpbmcpOgorCiAyMDE2LTA5LTI1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBbRUZMXSBBZGp1c3QgRUZMIGluZGVudGF0aW9uIHRvIEVGTCBNaW5p QnJvd3NlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19f aW5pdF9fLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5 CmluZGV4IGFlMzVkMDNkYTcyNGExNzBlMGRmNWRmODQzMDQxMTM0ZGZhMWJmM2EuLjJkNzQ1NmYx MTQwMTMzMDI4MGVkM2M2ODczNDQwOWVlNjRhYTYzNDMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkKQEAgLTk5LDggKzk5LDggQEAgY2xhc3MgQXV0 b2luc3RhbGxJbXBvcnRIb29rKG9iamVjdCk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJtZWNoYW5pemUtMC4yLjUvbWVjaGFuaXplIikKIAogICAgIGRlZiBfaW5zdGFsbF9rZXlyaW5n KHNlbGYpOgotICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRwOi8vcHlwaS5weXRob24ub3JnL3Bh Y2thZ2VzL3NvdXJjZS9rL2tleXJpbmcva2V5cmluZy00LjAuemlwIiwKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgImtleXJpbmciKQorICAgICAgICBzZWxmLl9pbnN0YWxsKCJodHRwczov L3B5cGkucHl0aG9uLm9yZy9wYWNrYWdlcy83ZS84NC82NTgxNmMyOTM2Y2Y3MTkxYmNiNWIzZTNk YzRmYjg3ZGVmNmY4YTM4YmUyNWIzYTc4MTMxYmJiMDg1OTQva2V5cmluZy05LjMuMS50YXIuZ3oj bWQ1PTkzNGFhZDlmM2NkY2M4NjAwMjlhMDEyMmZiNWY2N2JiIiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgImtleXJpbmctOS4zLjEva2V5cmluZyIpCiAKICAgICBkZWYgX2luc3RhbGxf cGVwOChzZWxmKToKICAgICAgICAgc2VsZi5faW5zdGFsbCgiaHR0cDovL3B5cGkucHl0aG9uLm9y Zy9wYWNrYWdlcy9zb3VyY2UvcC9wZXA4L3BlcDgtMC41LjAudGFyLmd6I21kNT01MTJhODE4YWY5 OTc5MjkwY2Q2MTljY2U4ZTljMmUyYiIsCg== 289856 2016-09-26 13:20:43 -0700 2016-09-27 00:54:49 -0700 Patch bug-152470-20160926221746.patch text/plain 1983 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWI3NTZhN2Y2MTZlMzQ0YjFhYmFjNjFkZmVkMmExZWI4 NmY3ZTQ0ZC4uOTg3NmFhZGY4MTBhM2M5M2Y3OTE0ZGFmZjJmYzcxNDYxNGRhYjhmZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTA5LTI2ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBQeUdJV2FybmluZ3MgcHJpbnRlZCBieSB3ZWJraXQtcGF0Y2gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MjQ3MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSB0byBhIG5l d2VyIHZlcnNpb24gb2YgdGhlIGtleXJpbmcgbW9kdWxlLCBzaW5jZSB0aGlzIGJ1ZyBoYXMgYmVl biBmaXhlZCB1cHN0cmVhbSBmb3IKKyAgICAgICAgYSB3aGlsZS4gQnV0IGJlIGNhcmVmdWwgbm90 IHRvIHVwZGF0ZSB0byB0aGUgbGF0ZXN0IHZlcnNpb24sIHNpbmNlIGl0IGhhcyBzb21lIGNvbXBh dGliaWxpdHkKKyAgICAgICAgYnJlYWtzIGFuZCByZXF1aXJlcyB0aGUgU2VjcmV0U2VydmljZSBw eXRob24gbW9kdWxlIG9uIExpbnV4LCBidXQgSSBjb3VsZG4ndCBmaWd1cmUgb3V0IGhvdworICAg ICAgICB0byBhdXRvaW5zdGFsbCBpdCBzdWNjZXNzZnVsbHkuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHk6CisgICAgICAgIChBdXRvaW5zdGFsbElt cG9ydEhvb2suX2luc3RhbGxfa2V5cmluZyk6CisKIDIwMTYtMDktMjUgIEd5dXlvdW5nIEtpbSAg PGd5dXlvdW5nLmtpbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIEFkanVzdCBFRkwgaW5k ZW50YXRpb24gdG8gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3RoaXJkcGFydHkvX19pbml0X18ucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Ro aXJkcGFydHkvX19pbml0X18ucHkKaW5kZXggYWUzNWQwM2RhNzI0YTE3MGUwZGY1ZGY4NDMwNDEx MzRkZmExYmYzYS4uYjU4MTY4ZTUyZjU5ZjBkODNlNTNjMDAxNzZhNjIzZjYyNjMwNDVmOSAxMDA2 NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90aGlyZHBhcnR5L19faW5pdF9fLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGhpcmRwYXJ0eS9fX2luaXRfXy5weQpAQCAtOTks OCArOTksOCBAQCBjbGFzcyBBdXRvaW5zdGFsbEltcG9ydEhvb2sob2JqZWN0KToKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIm1lY2hhbml6ZS0wLjIuNS9tZWNoYW5pemUiKQogCiAgICAg ZGVmIF9pbnN0YWxsX2tleXJpbmcoc2VsZik6Ci0gICAgICAgIHNlbGYuX2luc3RhbGwoImh0dHA6 Ly9weXBpLnB5dGhvbi5vcmcvcGFja2FnZXMvc291cmNlL2sva2V5cmluZy9rZXlyaW5nLTQuMC56 aXAiLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAia2V5cmluZyIpCisgICAgICAgIHNl bGYuX2luc3RhbGwoImh0dHBzOi8vcHlwaS5weXRob24ub3JnL3BhY2thZ2VzLzdkL2E5LzhjNmJm NjA3MTA3ODFjZTEzYTk5ODdjMGRlYmRhOGFkYWIzNWViNzljNmI1NTI1ZjdmZTUyNDBiN2E4YS9r ZXlyaW5nLTcuMy4xLnRhci5neiNtZDU9OTlkZDc5M2UxMjMzOTY0ZWI4N2NmNTY0MDZlZTY2ZjYi LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAia2V5cmluZy03LjMuMS9rZXlyaW5nIikK IAogICAgIGRlZiBfaW5zdGFsbF9wZXA4KHNlbGYpOgogICAgICAgICBzZWxmLl9pbnN0YWxsKCJo dHRwOi8vcHlwaS5weXRob24ub3JnL3BhY2thZ2VzL3NvdXJjZS9wL3BlcDgvcGVwOC0wLjUuMC50 YXIuZ3ojbWQ1PTUxMmE4MThhZjk5NzkyOTBjZDYxOWNjZThlOWMyZTJiIiwK